[Lldb-commits] [lldb] 60cbbb3 - [lldb][NFC] Remove misleading class_language variable in DWARFASTParserClang

Author: Raphael Isemann Date: 2020-07-13T13:10:12+02:00 New Revision: 60cbbb306d29f882e18d6293177d694c11c67e84 URL: https://github.com/llvm/llvm-project/commit/60cbbb306d29f882e18d6293177d694c11c67e84 DIFF: https://github.com/llvm/llvm-project/commit/60cbbb306d29f882e18d6293177d694c11c67e84.dif

[Lldb-commits] [lldb] aa933d8 - [lldb][NFC] Early-exit in DWARFASTParserClang::ParseSingleMember

Author: Raphael Isemann Date: 2020-07-13T13:21:12+02:00 New Revision: aa933d82f867ab4d33eafc5ee2666dbbc61d293d URL: https://github.com/llvm/llvm-project/commit/aa933d82f867ab4d33eafc5ee2666dbbc61d293d DIFF: https://github.com/llvm/llvm-project/commit/aa933d82f867ab4d33eafc5ee2666dbbc61d293d.dif

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

labath added a comment. To use this code from Process/elf-core, we also need to move this file. `source/Plugins/Process/Utility` is the best place we got for this right now. Comment at: lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h:9-10 #ifndef lldb_LinuxP

[Lldb-commits] [lldb] f3b3689 - [lldb][NFC] Refactor instruction dumping out of DumpDataExtractor

Author: Raphael Isemann Date: 2020-07-13T15:03:40+02:00 New Revision: f3b3689c043f49ad42e9d3f5057bc8f1a9f56d09 URL: https://github.com/llvm/llvm-project/commit/f3b3689c043f49ad42e9d3f5057bc8f1a9f56d09 DIFF: https://github.com/llvm/llvm-project/commit/f3b3689c043f49ad42e9d3f5057bc8f1a9f56d09.dif

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry this is taking so long, but I think beside one minor change this only needs some testing and then it's ready. So the way I would like to see this tested would be with a p

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added a comment. I didn't notice this before, but I see now that there's more register number overlap in `lldb-arm64-register-enums.h`. Having one overlapping enum is bad enough, but two seems really too much? Can we avoid the second enum somehow, at least? Perhaps by switching `Register

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

labath added a comment. In D83302#2142155 , @aprantl wrote: > I tried to do some radar archeology for more context, but I could neither > find a radar mentioning that commit, nor a mention of a radar in that commit. Thanks for the effort. Repository:

[Lldb-commits] [PATCH] D83545: [lldb/dotest] Remove the "xunit" result formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5803765d8e0: [lldb/dotest] Remove the "xunit" result formatter (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83545/new/ https://revie

[Lldb-commits] [lldb] a580376 - [lldb/dotest] Remove the "xunit" result formatter

Author: Pavel Labath Date: 2020-07-13T16:33:38+02:00 New Revision: a5803765d8e0b62e0b48ea76bcad07a7c183618b URL: https://github.com/llvm/llvm-project/commit/a5803765d8e0b62e0b48ea76bcad07a7c183618b DIFF: https://github.com/llvm/llvm-project/commit/a5803765d8e0b62e0b48ea76bcad07a7c183618b.diff

[Lldb-commits] [lldb] 1847f4d - [lldb/Utility] Rewrite Scalar::SetValueFromCString

Author: Pavel Labath Date: 2020-07-13T16:44:42+02:00 New Revision: 1847f4dd7570f01f70646cd5067dd0c34257cd21 URL: https://github.com/llvm/llvm-project/commit/1847f4dd7570f01f70646cd5067dd0c34257cd21 DIFF: https://github.com/llvm/llvm-project/commit/1847f4dd7570f01f70646cd5067dd0c34257cd21.diff

[Lldb-commits] [lldb] 340c376 - [lldb] Fix a CMake warning typo. NFC.

Author: Martin Storsjö Date: 2020-07-13T22:48:17+03:00 New Revision: 340c376b87c72e7eb3670301e4920106615b6689 URL: https://github.com/llvm/llvm-project/commit/340c376b87c72e7eb3670301e4920106615b6689 DIFF: https://github.com/llvm/llvm-project/commit/340c376b87c72e7eb3670301e4920106615b6689.diff

[Lldb-commits] [lldb] 341ec56 - Add a decorator to skip tests when running under Rosetta

Author: Adrian Prantl Date: 2020-07-13T13:09:53-07:00 New Revision: 341ec564182161861ec4415cdee1f4f3a0527e97 URL: https://github.com/llvm/llvm-project/commit/341ec564182161861ec4415cdee1f4f3a0527e97 DIFF: https://github.com/llvm/llvm-project/commit/341ec564182161861ec4415cdee1f4f3a0527e97.diff

[Lldb-commits] [PATCH] D83600: Add a decorator to skip tests when running under Rosetta

This revision was automatically updated to reflect the committed changes. Closed by commit rG341ec5641821: Add a decorator to skip tests when running under Rosetta (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 marked an inline comment as done. gedatsu217 added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} teemperor wrote: > gedatsu217 wrote:

[Lldb-commits] [lldb] 32d35fb - [lldb] Remove unused argument (NFC)

Author: Jonas Devlieghere Date: 2020-07-13T13:44:51-07:00 New Revision: 32d35fb74b2672ddf3674188423b71837afea8c4 URL: https://github.com/llvm/llvm-project/commit/32d35fb74b2672ddf3674188423b71837afea8c4 DIFF: https://github.com/llvm/llvm-project/commit/32d35fb74b2672ddf3674188423b71837afea8c4.d

[Lldb-commits] [lldb] 77c9aaf - Retry ""[lldb-vscode] Fix TestVSCode_module""

Author: Walter Erquinigo Date: 2020-07-13T14:12:03-07:00 New Revision: 77c9aafc5d85a816c20d1f1fb176024bc0b8d0fe URL: https://github.com/llvm/llvm-project/commit/77c9aafc5d85a816c20d1f1fb176024bc0b8d0fe DIFF: https://github.com/llvm/llvm-project/commit/77c9aafc5d85a816c20d1f1fb176024bc0b8d0fe.di

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` behave correctly in synchronous mode.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a subscriber: abidh. In synchronous mode, the `process connect` command and its aliases should wait for the stop event before claiming the command is complete. Currently, the stop event is always hand

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

jingham added a comment. Couple of minor comments. Comment at: lldb/include/lldb/Target/Platform.h:855 protected: + lldb::ProcessSP DoConnectProcess(llvm::StringRef connect_url, + llvm::StringRef plugin_name, Even though this

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

JDevlieghere updated this revision to Diff 277609. JDevlieghere added a comment. Address Jim's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83728/new/ https://reviews.llvm.org/D83728 Files: lldb/include/lldb/Target/Platform.h lldb/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1834 if (error.Fail()) return nullptr; jingham wrote: > If you fail here you leave the process hijacked. That doesn't matter

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83728/new/ https://reviews.llvm.org/D83728 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. Debug Info Size is displayed with Symbol Status Message. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Please include a test case Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:351-362 + char debug_info_size[10]; + if (debug_info < 1024) { +spri

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. Hi Pavel, When I change the `stderr` argument to point to `STDOUT` inside the `Popen` function, which is inside the `lldbtest.system` function, the output actually gets mixed up. Whereas currently,, after running a couple times, the contents of stderr always gets printed

[Lldb-commits] [lldb] 869d05f - [lldb-vscode] Fix TestVSCode_module

Author: Walter Erquinigo Date: 2020-07-13T18:02:37-07:00 New Revision: 869d05fb3e449ec7ec835b8a61687f8df41b8651 URL: https://github.com/llvm/llvm-project/commit/869d05fb3e449ec7ec835b8a61687f8df41b8651 DIFF: https://github.com/llvm/llvm-project/commit/869d05fb3e449ec7ec835b8a61687f8df41b8651.di

[Lldb-commits] [lldb] 9a9ae01 - [lldb-vscode] Fix TestVSCode_setBreakpoints

Author: Walter Erquinigo Date: 2020-07-13T18:27:53-07:00 New Revision: 9a9ae01f994a92900bc703cf8a512082f49ce45d URL: https://github.com/llvm/llvm-project/commit/9a9ae01f994a92900bc703cf8a512082f49ce45d DIFF: https://github.com/llvm/llvm-project/commit/9a9ae01f994a92900bc703cf8a512082f49ce45d.di

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss updated this revision to Diff 277657. friss added a comment. Herald added a subscriber: mgorny. I went ahead and updated all unittests to use only in-memory modules. This required tweaking both ObjectFileELF and ObjectFilePECOFF a little. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss marked 2 inline comments as done. friss added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:543-544 + if (m_data.ValidOffsetForDataOfSize(offset, size)) +return DataExtractor(m_data, offset, size); + This see

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. See inlined comments. You will also need to fix the test for this since it will now fail as the "symbolStatus" now contains the size. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:342-349 +uint64_t d