kwk updated this revision to Diff 271631.
kwk added a comment.
- Remove old logic that was no longer needed since my search filter now
adaptively adds eSymbolContextCompUnit and not always returns it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7
paolosev added a comment.
> What about replacing ProcessReadMemory(addr_t addr, ...) with
> ProcessReadMemory(Address addr, ...), or even banning the use of lldb::addr_t
> on everywhere except in the bowels of Process subclasses and as an
> interchange for getting addresses as text from users
vsk added a comment.
Generally this looks really nice!
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+ ifeq "$(TRIPLE_ENV)" ""
+ CODESIGN := codesign
+ endif
If
Author: Eric Christopher
Date: 2020-06-18T12:39:03-07:00
New Revision: 50939c0a67619b77d085bfafb2cedda413d57b7a
URL:
https://github.com/llvm/llvm-project/commit/50939c0a67619b77d085bfafb2cedda413d57b7a
DIFF:
https://github.com/llvm/llvm-project/commit/50939c0a67619b77d085bfafb2cedda413d57b7a.di
dschuff created this revision.
Herald added subscribers: llvm-commits, lldb-commits, aheejin, krytarowski.
Herald added projects: LLDB, LLVM.
Emscripten has emulations for several headers found on Linux,
including spwan.h and endian.h
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.o
dschuff added a reviewer: JDevlieghere.
dschuff added a comment.
Just taking a guess on a reviewer...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82121/new/
https://reviews.llvm.org/D82121
___
lldb-c
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks plausible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82121/new/
https://reviews.llvm.org/D82121
___
aprantl updated this revision to Diff 271878.
aprantl added a comment.
Actually update the patch and not the diff from my previous patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81980/new/
https://reviews.llvm.org/D81980
Files:
lldb/packages/Python/lldbsuite/test/dotest.py
ll
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+ ifeq "$(TRIPLE_ENV)" ""
+ CODESIGN := codesign
+ endif
aprantl updated this revision to Diff 271877.
aprantl marked an inline comment as done.
aprantl added a comment.
Simplify version detection.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81980/new/
https://reviews.llvm.org/D81980
Files:
lldb/packages/Python/lldbsuite/test/make/Makefi
Author: Derek Schuff
Date: 2020-06-18T17:00:53-07:00
New Revision: c1709e5d90e613917d616a7866ee52cfac311de6
URL:
https://github.com/llvm/llvm-project/commit/c1709e5d90e613917d616a7866ee52cfac311de6
DIFF:
https://github.com/llvm/llvm-project/commit/c1709e5d90e613917d616a7866ee52cfac311de6.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc1709e5d90e6: Set appropriate host defines for building
under emscripten (authored by dschuff).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82121/new/
htt
vsk accepted this revision.
vsk added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+ ifeq "$(TRIPLE_ENV)" ""
+ CODESIGN := codesign
+
13 matches
Mail list logo