[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I noticed this issue after committing the patch that caused it. I wasn't rushing to fix it because it did not seem like a big problem. But, of course it is a big problem for reproduc

[Lldb-commits] [lldb] 834708a - [lldb][NFC] Rename ClangExpressionDeclMap::AddThisType and clarify documentation

Author: Raphael Isemann Date: 2020-06-10T12:26:47+02:00 New Revision: 834708a6a0d04935d79bfa54c7a1bf9ab7a2ba8f URL: https://github.com/llvm/llvm-project/commit/834708a6a0d04935d79bfa54c7a1bf9ab7a2ba8f DIFF: https://github.com/llvm/llvm-project/commit/834708a6a0d04935d79bfa54c7a1bf9ab7a2ba8f.dif

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269781. kwk marked an inline comment as done. kwk added a comment. - Outsource parts into SearchFilterByModulesAndSupportFiles::FunctionPasses - Tests with alternating setting target.inline-breakpoint-strategy between "always" and "headers" - Respecting target.in

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269784. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/Target/Target.

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269782. kwk added a comment. - remove commented out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269787. kwk marked an inline comment as done. kwk added a comment. - remove debug output from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lld

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath I've applied all the ideas we ping-ponged yesterday and I decided to go with alternating the `target.inline-breakpoint-strategy` from `always` (the default) to `headers`. This way you can exactly see in the test file how things are behaving. So before going into the

[Lldb-commits] [lldb] 539b47c - [lldb/Makefile.rules] Apply CFLAGS_EXTRAS after debug-info mode flags

Author: Pavel Labath Date: 2020-06-10T14:27:53+02:00 New Revision: 539b47c9d1edd3b152efc9073f6729f28cf48d9a URL: https://github.com/llvm/llvm-project/commit/539b47c9d1edd3b152efc9073f6729f28cf48d9a DIFF: https://github.com/llvm/llvm-project/commit/539b47c9d1edd3b152efc9073f6729f28cf48d9a.diff

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath created this revision. labath added reviewers: teemperor, clayborg, jingham. Herald added subscribers: aaron.ballman, aprantl. Herald added a reviewer: shafik. Herald added a reviewer: shafik. Herald added a project: LLDB. This patch adds support for evaluation of expressions referring to t

[Lldb-commits] [lldb] 040eca7 - [lldb/Utility] Remove m_ieee_quad from Scalar

Author: Pavel Labath Date: 2020-06-10T15:15:01+02:00 New Revision: 040eca77170bea12ca0614cdb256b957c3b93810 URL: https://github.com/llvm/llvm-project/commit/040eca77170bea12ca0614cdb256b957c3b93810 DIFF: https://github.com/llvm/llvm-project/commit/040eca77170bea12ca0614cdb256b957c3b93810.diff

[Lldb-commits] [lldb] bb9d93f - [lldb] Replace the LEB128 decoding logic in LLDB's DataExtractor with calls to LLVM's LEB128 implementation

Author: Raphael Isemann Date: 2020-06-10T16:35:09+02:00 New Revision: bb9d93f4d5934259fa2a55aabfda89e631e02037 URL: https://github.com/llvm/llvm-project/commit/bb9d93f4d5934259fa2a55aabfda89e631e02037 DIFF: https://github.com/llvm/llvm-project/commit/bb9d93f4d5934259fa2a55aabfda89e631e02037.dif

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk planned changes to this revision. kwk added a comment. IMPORTANT: The behavior of `target.inline-breakpoint-strategy` when set to `headers` is still subject to change! I think the setting is not respected correctly... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D81453: [lldb] Replace the LEB128 decoding logic in LLDB's DataExtractor with calls to LLVM's LEB128 implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9d93f4d593: [lldb] Replace the LEB128 decoding logic in LLDB's DataExtractor with calls to… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 42229b6 - [lldb] XFAIL TestForwardDeclaration.test_debug_names on windows

Author: Pavel Labath Date: 2020-06-10T17:09:51+02:00 New Revision: 42229b6de756d7e3843d9cdd1988a88d76970695 URL: https://github.com/llvm/llvm-project/commit/42229b6de756d7e3843d9cdd1988a88d76970695 DIFF: https://github.com/llvm/llvm-project/commit/42229b6de756d7e3843d9cdd1988a88d76970695.diff

[Lldb-commits] [PATCH] D81453: [lldb] Replace the LEB128 decoding logic in LLDB's DataExtractor with calls to LLVM's LEB128 implementation

JDevlieghere added inline comments. Comment at: lldb/source/Utility/DataExtractor.cpp:911 uint32_t DataExtractor::Skip_LEB128(offset_t *offset_ptr) const { uint32_t bytes_consumed = 0; const uint8_t *src = PeekData(*offset_ptr, 1); labath wrote: > JDevlieg

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

JDevlieghere updated this revision to Diff 269871. JDevlieghere added a comment. Implement Pavel's approach CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81516/new/ https://reviews.llvm.org/D81516 Files: lldb/packages/Python/lldbsuite/test/lldbinline.py Index: lldb/packages/Python/

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:209 test_class = type(name, (InlineTest,), dict(test=test_func, -name=name, _build_dict=build_dict)) +name=name, _

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files (WIP)

JDevlieghere updated this revision to Diff 269893. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81589/new/ https://reviews.llvm.org/D81589 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files (WIP)

JDevlieghere created this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. JDevlieghere updated this revision to Diff 269893. https://reviews.llvm.org/D81589 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Index: lldb/source/Plugins/SymbolFile

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

JDevlieghere created this revision. JDevlieghere added reviewers: friss, labath, jingham, vsk. Herald added a subscriber: abidh. The reproducer intentionally leak every object allocated during replay, which means that modules never get orphaned. If this were to happen for another reason, we migh

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 269963. fallkrum added a comment. Sorry for misunderstanding, you were right, it is possible to reproduce situation via SB API tests. Please check them out. In D80112#2080516 , @jingham wrote: > This patch has gotte

[Lldb-commits] [lldb] 661fcfc - debugserver: Enable -DLLDB_ENERGY when compiling against an internal SDK

Author: Adrian Prantl Date: 2020-06-10T14:10:27-07:00 New Revision: 661fcfcd8afa4fbf4284a1ea8c0fc948dcc8fcac URL: https://github.com/llvm/llvm-project/commit/661fcfcd8afa4fbf4284a1ea8c0fc948dcc8fcac DIFF: https://github.com/llvm/llvm-project/commit/661fcfcd8afa4fbf4284a1ea8c0fc948dcc8fcac.diff

[Lldb-commits] [PATCH] D81300: Enable -DLLDB_ENERGY when compiling against an internal SDK

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/tools/debugserver/source/CMakeLists.txt:132 +if($ENV{SDKROOT} MATCHES ".Internal.sdk$") + message(STATUS "LLDB debugserver energy support is enabled") JDevlieghere wrote:

[Lldb-commits] [PATCH] D81300: Enable -DLLDB_ENERGY when compiling against an internal SDK

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/tools/debugserver/source/CMakeLists.txt:135 + add_definitions(-DLLDB_ENERGY) + set(ENERGY_LIBRARY -lpmenergy -lpmsample) +else() JDevlieghere wrote: > Can we not use the `

[Lldb-commits] [PATCH] D81300: Enable -DLLDB_ENERGY when compiling against an internal SDK

This revision was automatically updated to reflect the committed changes. Closed by commit rG661fcfcd8afa: debugserver: Enable -DLLDB_ENERGY when compiling against an internal SDK (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 351823f - [lldb/Test] Add 'std-module' category and skip them with reproducers

Author: Jonas Devlieghere Date: 2020-06-10T14:59:05-07:00 New Revision: 351823fbf16007444fa76dc7f1434de285649ca7 URL: https://github.com/llvm/llvm-project/commit/351823fbf16007444fa76dc7f1434de285649ca7 DIFF: https://github.com/llvm/llvm-project/commit/351823fbf16007444fa76dc7f1434de285649ca7.d

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. Thanks, this is looking good. I have a bunch of nits, but nothing substantial. Comment at: lldb/source/Target/Process.cpp:3944 +bool Process::ProcessEventData::ShouldStop(Event *event_ptr, + bool *have_valid_st

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

jingham added a comment. This looks okay to me though I'm not very familiar with the llvm file system interfaces. Do we have any tests that tests that log output gets emitted to the file requested when you do "log enable -f somefile whatever"? If so and they still work, LGTM. If we don't tes

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

JDevlieghere added a comment. In D81499#2086268 , @jingham wrote: > This looks okay to me though I'm not very familiar with the llvm file system > interfaces. > > Do we have any tests that tests that log output gets emitted to the file > requested when y

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM then. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81499/new/ https://reviews.llvm.org/D81499 ___ lldb

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

vsk added inline comments. Comment at: lldb/bindings/interface/SBModule.i:347 +static uint32_t +GetNumberAllocatedModules(); Can we add a %feature("docstring", ...) blurb about this, advising script authors that it's probably not an API they're interes

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

clayborg added a comment. The overall approach is what we had talked about previously and looks good as far as I can tell. I don't do enough expression parser work to give the accept on this, but I have no problems with what I see. If any expression parser experts are not on the reviewers, plea

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

clayborg added a comment. If we run into a class in the AST importer that was forcefully completed and we can't find a better definition, what do we do? Error out? Do what we did. I would like there to be a nice log line in the "log enable lldb expr" to tell us when this happens so we can know

[Lldb-commits] [lldb] 6b2e676 - [Debugger] Use FileSystem instead of calling openFileForWrite directly.

Author: Jonas Devlieghere Date: 2020-06-10T18:13:32-07:00 New Revision: 6b2e676555c10201705a3c2e928f3d35d1fa1d4f URL: https://github.com/llvm/llvm-project/commit/6b2e676555c10201705a3c2e928f3d35d1fa1d4f DIFF: https://github.com/llvm/llvm-project/commit/6b2e676555c10201705a3c2e928f3d35d1fa1d4f.d

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

JDevlieghere updated this revision to Diff 270017. JDevlieghere added a comment. Address @vsk's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81612/new/ https://reviews.llvm.org/D81612 Files: lldb/bindings/interface/SBModule.i lldb/include/lldb/API/SBModule.h lldb/packa

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b2e676555c1: [Debugger] Use FileSystem instead of calling openFileForWrite directly. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

aprantl added a comment. It's great to see this being addressed! I have a high-level question: When completing types across lldb::Modules — in which ASTContext is the complete type created? Since a per-module TypeSystem can be shared by many debuggers, I want to make sure that types from anothe

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files (WIP)

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Yes this fixes the regression and actually speeds things up a bit. My results were a speed up of 17% to 30% versus 11.3.1 LLDB. Just one nit in the way we are getting the DW_AT_s

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace updated this revision to Diff 270038. wallace added a comment. I updated the tests and did some minor changes. @clayborg, after some testing, I noticed that this doesn't fix the problem of lldb-vscode instances not dying, however it solves the problem of long-running inferiors not dying.