[Lldb-commits] [lldb] r366292 - [Target][NFCI] Rename variable

Author: xiaobai Date: Wed Jul 17 00:03:17 2019 New Revision: 366292 URL: http://llvm.org/viewvc/llvm-project?rev=366292&view=rev Log: [Target][NFCI] Rename variable This variable doesn't have anything to do with clang. Modified: lldb/trunk/source/Target/ABI.cpp Modified: lldb/trunk/source/T

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regexp-break with options

mib created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes the regular expressions used by the CommandInterpreter to match GDB style breakpoint command to the LLDB style. The previous version passed the breakpoint options to _regex-break as

[Lldb-commits] [lldb] r366295 - [Target][NFCI] Remove commented out code

Author: xiaobai Date: Wed Jul 17 00:13:42 2019 New Revision: 366295 URL: http://llvm.org/viewvc/llvm-project?rev=366295&view=rev Log: [Target][NFCI] Remove commented out code Modified: lldb/trunk/source/Target/ThreadPlanTracer.cpp Modified: lldb/trunk/source/Target/ThreadPlanTracer.cpp URL:

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

labath added a comment. In D64769#1587992 , @kusmour wrote: > The test set the breakpoint to the return statement, even thought the > compiler flag `-O0` was set, the first hit to that bp showed that `g_common_1 > = 0` which actually should be 21. The te

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. This breaks several tests on linux: Failing Tests (20): LLDB :: Breakpoint/debug_addrx.test LLDB :: Breakpoint/debug_rnglist_basic.test LLDB :: Breakpoint/de

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

lubgr updated this revision to Diff 210278. lubgr added a comment. I updated the description of the `address` format, is it appropriate? And I can't commit that myself, so thanks in advance for doing so when it's ready. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

sgraenitz added a comment. > I'm pretty sure there's no need to have this logic living in LLDBStandalone. > We always go through LLDBConfig.cmake which has the canonical way to find the > Python libs and interpreter. LLDBStandalone is supposed to act like a polyfill for whatever LLVM would usu

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked an inline comment as done. martong added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/c/ast/TestAST.py:57 +# This expr command imports __sFILE with definition +# (FILE is a typedef to __sFILE.) +self.expect(

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 210281. martong marked 5 inline comments as done. martong added a comment. - Applied clang-format on lldb parts (this changed two lines) - Added a comment for predicate - Merged the test into TestCModules.py Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

TWeaver added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:9 +#include + Hi there, this is a little nit picky, and I'm not entirely sure If im right in saying so, but, if this is a C++

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. Currently the ClangModulesDeclVendor is spamming the expression log with the compiler flags it is using, which creates a log that looks like this: c

[Lldb-commits] [PATCH] D64824: [CMake] Move standalone check so we don't have to reconfigure LLDB

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64824/new/ https://reviews.llvm.org/D64824 ___ lldb-c

[Lldb-commits] [lldb] r366316 - [lldb][NFC] Tablegenify watchpoint commands

Author: teemperor Date: Wed Jul 17 04:48:29 2019 New Revision: 366316 URL: http://llvm.org/viewvc/llvm-project?rev=366316&view=rev Log: [lldb][NFC] Tablegenify watchpoint commands Part of the project that migrates these struct initializers to our new lldb-tablegen. Modified: lldb/trunk/sourc

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 __

[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

sgraenitz requested changes to this revision. sgraenitz added a comment. This revision now requires changes to proceed. We shouldn't do the sole change here, but instead remove all `LLDB_PATH_TO__BUILD` variables in favor of CMake standard `_DIR` variables. Summarizing a discussion on this a whi

[Lldb-commits] [PATCH] D64865: [CMake] Polish folders in generated Xcode project

sgraenitz created this revision. sgraenitz added reviewers: jingham, mib, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. Group plugins by subfolder. Move liblldb-resource-headers to `lldb misc`. Avoid install-distribution related targets in IDE-enabled builds.

[Lldb-commits] [PATCH] D64865: [CMake] Polish folders in generated Xcode project

sgraenitz added a comment. Should give this folder structure in Xcode standalone builds: F9605898: Screenshot 2019-07-17 at 15.11.54.png We try to cut the parent folder names from the leaf folders, but that gets a mess quickly as not all names are consistent w

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. Thank you guys for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

This revision was automatically updated to reflect the committed changes. Closed by commit rL366325: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. Jenkins looks okay: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31157/ .The build is red but the the previous run has the very same failing test case: expression_command/weak_symbols/TestWeakSymbols.py Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:9 +#include + TWeaver wrote: > Hi there, > > this is a little nit picky, and I'm not entirely sure If im right in saying > so,

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

davide added subscribers: jasonmolenda, compnerd. davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:212-215 + +module_name = "libsystem_malloc.dylib" +if not os_de

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:242-257 +break_results = lldbutil.run_break_set_command( +self, "b /%s/" % +self.regex) +

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:212-215 + +module_name = "libsystem_malloc.dylib" +if not os_description == "Darwin": +module_name =

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

davide added a comment. That real In D64769#1587992 , @kusmour wrote: > In D64769#1587318 , @labath wrote: > > > The change is fine, but for my own education, could you elaborate on what > > this "delayed calculat

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This looks good. If it bothers you a lot (given you're probably one of the few users), you can do this only under `verbose` (although now that's a single line is very concise). Repository:

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

shafik added a comment. Is it worth it to write a test that verifies the output? Otherwise LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64858/new/ https://reviews.llvm.org/D64858 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

davide added a comment. I don't think it's worth adding a test for the logs. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64858/new/ https://reviews.llvm.org/D64858 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] r366346 - [CMake] Move standalone check so we don't have to reconfigure LLDB

Author: jdevlieghere Date: Wed Jul 17 09:47:02 2019 New Revision: 366346 URL: http://llvm.org/viewvc/llvm-project?rev=366346&view=rev Log: [CMake] Move standalone check so we don't have to reconfigure LLDB By moving the standalone check into the main CMake file, the whole file is ignored in a reg

[Lldb-commits] [PATCH] D64824: [CMake] Move standalone check so we don't have to reconfigure LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rL366346: [CMake] Move standalone check so we don't have to reconfigure LLDB (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [lldb] r366347 - [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

Author: teemperor Date: Wed Jul 17 09:51:16 2019 New Revision: 366347 URL: http://llvm.org/viewvc/llvm-project?rev=366347&view=rev Log: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose Summary: Currently the ClangModulesDeclVendor is spamming the expression log with the co

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

This revision was automatically updated to reflect the committed changes. Closed by commit rL366347: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:185-207 + if ( + // When the previous and current states are consistent this is the first + // time we have been asked to u

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz updated this revision to Diff 210357. sgraenitz added a comment. Don't pass `ON`/`OFF` for `LLDB_SERVER_IS_DEBUGSERVER` as it becomes as #define Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64806/new/ https://reviews.llvm.org/D64806 Fil

[Lldb-commits] [lldb] r366350 - [CMake] Avoid liblldb genex when figuring out the copy destination for framework tools

Author: stefan.graenitz Date: Wed Jul 17 10:14:40 2019 New Revision: 366350 URL: http://llvm.org/viewvc/llvm-project?rev=366350&view=rev Log: [CMake] Avoid liblldb genex when figuring out the copy destination for framework tools This genex created an order-only dependency to liblldb for every fr

[Lldb-commits] [PATCH] D64536: Adding inline comments to code view type records

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, sorry this fell out of my inbox. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64536/new/ https://reviews.llvm.org/D64536 ___

[Lldb-commits] [lldb] r366352 - [Test] Add module cache for TestWeakSymbols

Author: jdevlieghere Date: Wed Jul 17 10:22:29 2019 New Revision: 366352 URL: http://llvm.org/viewvc/llvm-project?rev=366352&view=rev Log: [Test] Add module cache for TestWeakSymbols Explicitly set the module cache in the Makefile with -fmodules-cache-path. Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This seems partly wrong to me. The point is that the Target holds keeps scratch AST contexts for all the languages it supports. They are the central repository for the accumulati

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:9 +#include + davide wrote: > TWeaver wrote: > > Hi there, > > > > this is a little nit picky, and I'm not entirely sure

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

martin updated this revision to Diff 210365. martin added a reviewer: amccarth. martin added a comment. Rebased against master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62183/new/ https://reviews.llvm.org/D62183 Files: source/Plugins/Process/Windows/Common/ProcessWindows.cpp In

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

martin added a comment. In D62183#1556645 , @amccarth wrote: > zturner is not a regular here anymore. I think he pops in from time-to-time, > but I wouldn't depend on just him for a review. > > Are you still wanting to land this? If you rebase and add m

[Lldb-commits] [lldb] r366356 - [dotest] Disable color while testing.

Author: jdevlieghere Date: Wed Jul 17 10:56:57 2019 New Revision: 366356 URL: http://llvm.org/viewvc/llvm-project?rev=366356&view=rev Log: [dotest] Disable color while testing. Disable colors so we don't risk having unexpected ANSI codes in the test output. Currently, the behavior of a test can c

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

xiaobai added a comment. I think that this is a good change overall to do but the name `LLDB_USE_SYSTEM_DEBUGSERVER` is kind of a confusing to me. The name itself doesn't really convey to me that the system debugserver is going to be used for just testing. Before this change, that flag indicate

[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

xiaobai added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:45 if(CMAKE_CROSSCOMPILING) set(LLVM_NATIVE_BUILD "${LLDB_PATH_TO_LLVM_BUILD}/NATIVE") if (NOT EXISTS "${LLVM_NATIVE_BUILD}") sgraenitz wrote: > @xiaobai Can this be c

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/ https://reviews.llvm.org/D64583 ___ lldb-commi

[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

JDevlieghere updated this revision to Diff 210373. JDevlieghere added a comment. Use `LLVM_DIR` and `Clang_DIR` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64823/new/ https://reviews.llvm.org/D64823 Files: lldb/cmake/modules/LLDBStandalone.cmake Index: lldb/cmake/modules/LLDBStan

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. In D64844#1589794 , @jingham wrote: > This seems partly wrong to me. The point is that the Target holds scratch > AST contexts for all the languages it supports. They are the central > repository for the accumulation of effects

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

amccarth added a comment. This change looks fine to me, but I wish there was a reliable way to test it. Is it a true race condition (e.g., because the unpredictability of thread scheduling), or is there a way to write a test that would always fail without this fix? CHANGES SINCE LAST ACTION

Re: [Lldb-commits] [lldb] r366356 - [dotest] Disable color while testing.

I thought the color code was smart enough to figure out whether it was actually going to an actual terminal or being redirected. Is this hiding a bug in that logic? On Wed, Jul 17, 2019 at 10:56 AM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jdevlieghere >

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Jonas is right, that there is nothing wrong with this code, but that it's just redundant as we'll do all of this in LLDBConfig anyway. Removing it means adding a potential difference for

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

jingham added a comment. I think I understand your goal - a worthy one, BTW... But I think this is an unnecessary step along that path. After all, all the clients of the Target's Scratch TypeSystem for C-family languages should be able to do what they need to do with a TypeSystem, rather than

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz added a comment. That's a fair point. However, changing the name of the parameter would force us to update quite a number of bot configurations, caches and documentation. So if it's "acceptable" I would be in favor to keep `LLDB_USE_SYSTEM_DEBUGSERVER`. Also it's kind-of in line with t

[Lldb-commits] [lldb] r366362 - [CMake] Use LLVM_DIR and Clang_DIR for standalone builds.

Author: jdevlieghere Date: Wed Jul 17 12:24:15 2019 New Revision: 366362 URL: http://llvm.org/viewvc/llvm-project?rev=366362&view=rev Log: [CMake] Use LLVM_DIR and Clang_DIR for standalone builds. When doing a standalone build, without setting LLDB_PATH_TO_LLVM_BUILD or LLDB_PATH_TO_CLANG_BUILD,

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

jingham added a comment. Seems like in most places we're just pulling out basic types or their sizes, which we should certainly be able to do with a TypeSystem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 _

[Lldb-commits] [PATCH] D64823: [CMake] Use LLVM_DIR and Clang_DIR for standalone builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366362: [CMake] Use LLVM_DIR and Clang_DIR for standalone builds. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: [Lldb-commits] [lldb] r366356 - [dotest] Disable color while testing.

When you run the tests without multiprocessing, lldb's output is not redirected. So the logic correctly detects that colors are supported, leading to potential test failures under this mode. On Wed, Jul 17, 2019 at 11:42 AM Adrian McCarthy wrote: > I thought the color code was smart enough to fi

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

mib updated this revision to Diff 210393. mib added a comment. Updating D64853 : Fix CommandInterpreter for _regex-break with options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64853/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] r366363 - [CMake] Remove duplicated logic to find Python when doing a standalone build

Author: jdevlieghere Date: Wed Jul 17 12:36:20 2019 New Revision: 366363 URL: http://llvm.org/viewvc/llvm-project?rev=366363&view=rev Log: [CMake] Remove duplicated logic to find Python when doing a standalone build I'm pretty sure there's no need to have this logic living in LLDBStandalone. It d

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL366363: [CMake] Remove duplicated logic to find Python when doing a standalone build (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [lldb] r366364 - [docs] Adjust variable formatting table

Author: jdevlieghere Date: Wed Jul 17 12:49:01 2019 New Revision: 366364 URL: http://llvm.org/viewvc/llvm-project?rev=366364&view=rev Log: [docs] Adjust variable formatting table While the in-place hints on valid formats are up to date (e.g. when choosing an invalid format expr -f nonExisting --

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

This revision was automatically updated to reflect the committed changes. Closed by commit rL366364: [docs] Adjust variable formatting table (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. Yes, I agree that replacing ClangASTContext uses with TypeSystem would be the right thing to do, and it's what I plan on doing next. There are instances where you really do want a ClangASTContext (e.g. in plugins related to clang expression parsing and objc), and so hav

[Lldb-commits] [lldb] r366365 - Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

Author: shafik Date: Wed Jul 17 13:16:13 2019 New Revision: 366365 URL: http://llvm.org/viewvc/llvm-project?rev=366365&view=rev Log: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory In ClangASTContext::CreateFunctionTemplateSpecializationInfo a TemplateArgumen

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0858e2f20c8: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack… (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D64777?v

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

JDevlieghere created this revision. JDevlieghere added reviewers: sgraenitz, labath, xiaobai, amccarth, stella.stamenova, compnerd. JDevlieghere added a project: LLDB. Herald added subscribers: abidh, mgorny. CMake has a much improved way to find the Python interpreter and libraries which guaran

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

amccarth added a comment. An aside ... I'm still trying to get back to a buildable state the earlier changes, like the one that tries to enforce version consistency between the libs and the interpreter. I'm currently bisecting to figure out what I hope is the final blocker. For me, the find_

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/regex_break/TestRegexpBreakCommand.py:5 + +from __future__ import print_function + I don't think you need this. C

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

compnerd added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:292 + else() +string(STRIP ${xcode_dev_dir} xcode_dev_dir) +set(subdir "LLDB.framework/Resources/debugserver") Can you add a comment explaining that you want to strip leading wh

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm updated this revision to Diff 210413. aadsm added a comment. Address comments. In the end I used nested switches for the GetAction function. I thought about it and I guess it boils down to personal preference. It's still harder for me to read than the if version so I put some empty lines t

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

JDevlieghere added a comment. In D64881#1590204 , @amccarth wrote: > An aside ... > > I'm still trying to get back to a buildable state the earlier changes, like > the one that tries to enforce version consistency between the libs and the > interpreter.

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

stella.stamenova added a comment. Re: Windows CMake: I am not sure, I'd have to do look into it further. On a separate note: I haven't looked into it yet, but we have a setup to run the LLDB tests on Ubuntu and that started failing somewhat recently with some Swig and Python errors. For example

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm updated this revision to Diff 210422. aadsm added a comment. Missed one function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64013/new/ https://reviews.llvm.org/D64013 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Dynam

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

JDevlieghere added a comment. In D64881#1590273 , @stella.stamenova wrote: > Re: Windows CMake: I am not sure, I'd have to do look into it further. > > On a separate note: I haven't looked into it yet, but we have a setup to run > the LLDB tests on Ubunt

[Lldb-commits] [lldb] r366378 - Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str.

Author: jmolenda Date: Wed Jul 17 14:44:05 2019 New Revision: 366378 URL: http://llvm.org/viewvc/llvm-project?rev=366378&view=rev Log: Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str. If a core file has an EFI version string which includes a UUID (similar to what it returns f

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

amccarth added a comment. In D64881#1590252 , @JDevlieghere wrote: > In D64881#1590204 , @amccarth wrote: > > > An aside ... > > > > I'm still trying to get back to a buildable state the earlier changes, like > >

[Lldb-commits] [lldb] r366381 - Ah, forgot a debug line I left in the dsym-for-uuid.sh script

Author: jmolenda Date: Wed Jul 17 14:55:39 2019 New Revision: 366381 URL: http://llvm.org/viewvc/llvm-project?rev=366381&view=rev Log: Ah, forgot a debug line I left in the dsym-for-uuid.sh script to make sure it was correctly being disabled after this test case completed. Modified: lldb/tru

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

jingham added a comment. The nice thing about the way the ObjCLanguageRuntime::Get was that is was only useable where we decided it was legit to use it, in the actual ObjCLanguageRuntime plugin or its direct users. If you want to keep the convenience cast function in a header in Plugins/Expres

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

jasonmolenda added a comment. I know there are a lot of specific notes floating around right now, but two quick suggestions. I see the idiom self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) target = self.dbg.CreateTarget(exe) repeated in several places. They're doing the same thing, doi

[Lldb-commits] [lldb] r366383 - [NFC] Clarify a Cmake status message regarding Python on LLDBConfig

Author: amccarth Date: Wed Jul 17 15:36:26 2019 New Revision: 366383 URL: http://llvm.org/viewvc/llvm-project?rev=366383&view=rev Log: [NFC] Clarify a Cmake status message regarding Python on LLDBConfig Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified: lldb/trunk/cmake/modules/LL

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz updated this revision to Diff 210448. sgraenitz marked 9 inline comments as done. sgraenitz added a comment. Address Saleem's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64806/new/ https://reviews.llvm.org/D64806 Files: lldb

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

martin added a comment. In D62183#1589937 , @amccarth wrote: > This change looks fine to me, but I wish there was a reliable way to test it. > Is it a true race condition (e.g., because the unpredictability of thread > scheduling), or is there a way to

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz added a comment. Thanks for taking a look. Comment at: lldb/cmake/modules/AddLLDB.cmake:292 + else() +string(STRIP ${xcode_dev_dir} xcode_dev_dir) +set(subdir "LLDB.framework/Resources/debugserver") compnerd wrote: > Can you add a comment exp

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz added a comment. I did some more testing and from my point of view this seems to work. If it looks acceptable to you, I would like to land it tomorrow (CEST) before the 9.0 branch cut. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64806/

[Lldb-commits] [PATCH] D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. Herald added a subscriber: abidh. Herald added a project: LLDB. On the upcoming version of macOS, 10.15 or Catalina, there are userlang kernel drivers ("DriverKit" processes) and one unique thing about a DriverKit main b

[Lldb-commits] [PATCH] D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address

jingham added a comment. I wonder if we ought to allow target properties (target as an example) that are only for testing, so they don't print when you do settings list, etc. But the we could have some settings like a "target.testing.dont-read-LC_MAIN" and that would make it easy to automate y

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

jingham added a comment. This looks good in general. I also have a few nits, and you need to fix (and probably test) the behavior for files with spaces in their names. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/regex_break/T

[Lldb-commits] [PATCH] D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address

jasonmolenda added a comment. Hm, that could be really helpful! I think I'd like to do that as a separate piece of work a little bit later, but I'll look at that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64897/new/ https://reviews.llvm.org/D64897

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

mgorny added a comment. That said, I ended up having mixed feelings about this. On the plus side, it definitely forces matching Python version for me. For example, without this patch changing `PYTHON_EXECUTABLE` resulted in mismatch. If I wanted to change Python version, I had to either update

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

mgorny added a comment. In D64881#1590330 , @amccarth wrote: > Testing the matrix of 32/64, 64/32, Python 2/3, debug/release, seems like a > lot of work. I'd be pretty surprised to learn that CMake did extra, > Windows-specific work necessary to make fi

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

mgorny added a comment. Filed https://gitlab.kitware.com/cmake/cmake/issues/19492 for that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64881/new/ https://reviews.llvm.org/D64881 ___ lldb-commits mailing list lld