[Lldb-commits] [PATCH] D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks, this looks much better. In D61498#1490885 , @jankratochvil wrote: > OK, I agree; originally I did not want to touch more code than what I need

[Lldb-commits] [PATCH] D61577: [Driver] Change the way we deal with local lldbinit files.

labath added a comment. Looks good to me. The way we were working around this thing in the driver always looked like a hack to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61577/new/ https://reviews.llvm.org/D61577 _

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

labath added inline comments. Comment at: lldb/tools/driver/Options.td:94-100 def: Flag<["-"], "x">, Alias, HelpText<"Alias for --no-lldbinit">, Group; +def local_lldbinit: F<"local-lldbinit">, + HelpText<"Allow the debugger to load the local lldbinit files.">, + Grou

[Lldb-commits] [PATCH] D61481: [DWARF] Reimplement/simplify DWARFUnit::GetID

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:43 size_t GetNumCompileUnits(); DWARFUnit *GetCompileUnitAtIndex(uint32_t idx); + DWARFUnit *GetCompileUnitAtOffset(dw_offset_t cu_offset, --

[Lldb-commits] [PATCH] D61481: [DWARF] Reimplement/simplify DWARFUnit::GetID

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rLLDB360014: [DWARF] Reimplement/simplify DWARFUnit::GetID (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Chang

[Lldb-commits] [lldb] r360014 - [DWARF] Reimplement/simplify DWARFUnit::GetID

Author: labath Date: Mon May 6 00:45:28 2019 New Revision: 360014 URL: http://llvm.org/viewvc/llvm-project?rev=360014&view=rev Log: [DWARF] Reimplement/simplify DWARFUnit::GetID Summary: The implementation of GetID used a relatively complicated algorithm, which returned some kind of an offset of

[Lldb-commits] [PATCH] D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4

Chirag created this revision. Chirag added a project: LLDB. Herald added subscribers: lldb-commits, aprantl. Chirag added a reviewer: jingham. dwarf expression DW_OP_call2/DW_OP_call4 performs dwarf procedure calls during evaluation of a dwarf expression or location description. The 2-byte unsign

[Lldb-commits] [lldb] r360024 - Revert r359949 "[clang] adding explicit(bool) from c++2a"

Author: hans Date: Mon May 6 02:51:10 2019 New Revision: 360024 URL: http://llvm.org/viewvc/llvm-project?rev=360024&view=rev Log: Revert r359949 "[clang] adding explicit(bool) from c++2a" This caused Clang to start erroring on the following: struct S {   template explicit S(); }; stru

[Lldb-commits] [lldb] r360038 - Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset

Author: jankratochvil Date: Mon May 6 05:01:38 2019 New Revision: 360038 URL: http://llvm.org/viewvc/llvm-project?rev=360038&view=rev Log: Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset These two methods are very similar and various refactorizations need to modify both similar

[Lldb-commits] [PATCH] D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset

This revision was automatically updated to reflect the committed changes. Closed by commit rL360038: Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

balazske added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249 +/// it at the end of the scope. Supports being used multiple times on the +/// same Minion instance in nested scopes. +class CxxModuleScope { teemperor wrote:

[Lldb-commits] [lldb] r360041 - [lldb] [lit] Use more readable consts and arrays in register read tests

Author: mgorny Date: Mon May 6 06:06:43 2019 New Revision: 360041 URL: http://llvm.org/viewvc/llvm-project?rev=360041&view=rev Log: [lldb] [lit] Use more readable consts and arrays in register read tests Replace the constants used for r8/mm/xmm/ymm/zmm tests with something more readable to ease

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/tools/driver/Options.td:94-100 def: Flag<["-"], "x">, Alias, HelpText<"Alias for --no-lldbinit">, Group; +def local_lldbinit: F<"local-lldbinit">, + HelpText<"Allow the

[Lldb-commits] [PATCH] D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: include/lldb/Expression/DWARFExpression.h:307 const lldb::RegisterKind reg_set, const Value *ini

[Lldb-commits] [PATCH] D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4

clayborg added a comment. Need to add a test for this as well. And to cover all cases, you will need to test in a multi-compile unit example so we can ensure the relative CU offset of the call2 or call4 works in compile units that aren't the first one. Repository: rLLDB LLDB CHANGES SINCE L

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

clayborg added a comment. Just wanted to verify that we can put a: settings set target.load-cwd-lldbinit true in our ~/.lldbinit file and it will then load the local init file in the current working directory? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D61602: Handle function parameters of RunCommandInterpreter (script bridge)

lubgr created this revision. lubgr added a reviewer: jingham. lubgr added a project: LLDB. This issue goes back to this SO answer by Jim Ingham, suggesting to fix the python bindings for RunCommandInterpreter. The reference parameters aren't prope

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/TestingSupport/TestUtilities.cpp:12 #include "llvm/Support/FileSystem.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/Support/Path.h" labath wrote: > Wha

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm updated this revision to Diff 198316. aadsm added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61292/new/ https://reviews.llvm.org/D61292 Files: lldb/include/lldb/Core/AddressRange.h lldb/include/lldb/Sy

[Lldb-commits] [PATCH] D61602: Handle function parameters of RunCommandInterpreter (script bridge)

jingham added a comment. LGTM, thanks for doing this and for the test! Can I ask you to write a doc string showing how to call this and what it returns in Python. It's not entirely obvious. There are %feature("docstring" examples around in that file that you can copy from. Repository: rL

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

jingham added a comment. The www was the original version, which Jonas replaced with with the rst version. We were waiting to get rid of the www version till we were sure we could iron out all the wrinkles of generating the docs on lldb.llvm.org from the rst version. That's close, though we s

[Lldb-commits] [PATCH] D61606: Add support for importing general C++ modules into the LLDB expression evaluator

teemperor created this revision. teemperor added reviewers: aprantl, shafik. teemperor added a project: C++ modules in LLDB. Herald added subscribers: lldb-commits, jdoerfert, abidh, mgrang. Herald added a project: LLDB. This patch adds basic support for importing C++ modules in general into the

[Lldb-commits] [lldb] r360067 - Initialization: move InstructionEmulation to full initialization

Author: compnerd Date: Mon May 6 12:38:24 2019 New Revision: 360067 URL: http://llvm.org/viewvc/llvm-project?rev=360067&view=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need to use the instruction emulation. This helps reduce the size of th

[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

compnerd closed this revision. compnerd added a comment. SVN r360067 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61543/new/ https://reviews.llvm.org/D61543 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

This revision was automatically updated to reflect the committed changes. Closed by commit rL360071: Include inlined functions when figuring out a contiguous address range (authored by gclayton, committed by ). Herald added subscribers: llvm-commits, srhines. Herald added a project: LLVM. Changed

[Lldb-commits] [lldb] r360071 - Include inlined functions when figuring out a contiguous address range

Author: gclayton Date: Mon May 6 13:01:21 2019 New Revision: 360071 URL: http://llvm.org/viewvc/llvm-project?rev=360071&view=rev Log: Include inlined functions when figuring out a contiguous address range Checking this in for Antonio Afonso: This diff changes the function LineEntry::GetSameLine

[Lldb-commits] [lldb] r360072 - Revert xcode scheme changes that I didn't mean to check in.

Author: gclayton Date: Mon May 6 13:03:30 2019 New Revision: 360072 URL: http://llvm.org/viewvc/llvm-project?rev=360072&view=rev Log: Revert xcode scheme changes that I didn't mean to check in. Modified: lldb/trunk/lldb.xcodeproj/xcshareddata/xcschemes/desktop.xcscheme lldb/trunk/lldb.x

[Lldb-commits] [lldb] r360076 - Fix the cmake build by removing non-existant source file

Author: rnk Date: Mon May 6 13:36:58 2019 New Revision: 360076 URL: http://llvm.org/viewvc/llvm-project?rev=360076&view=rev Log: Fix the cmake build by removing non-existant source file Modified: lldb/trunk/unittests/Symbol/CMakeLists.txt Modified: lldb/trunk/unittests/Symbol/CMakeLists.txt

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

rnk added a comment. I think TestLineEntry.cpp didn't get added to the commit, so I removed it in r360076 to try to fix the build. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61292/new/ https://reviews.llvm.org/D61292

[Lldb-commits] [lldb] r360077 - [Driver] Change the way we deal with local lldbinit files.

Author: jdevlieghere Date: Mon May 6 13:45:31 2019 New Revision: 360077 URL: http://llvm.org/viewvc/llvm-project?rev=360077&view=rev Log: [Driver] Change the way we deal with local lldbinit files. Currently we have special handling for local lldbinit files in the driver. At the same time, we hav

[Lldb-commits] [PATCH] D61577: [Driver] Change the way we deal with local lldbinit files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360077: [Driver] Change the way we deal with local lldbinit files. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

JDevlieghere added a comment. In D61578#1492086 , @clayborg wrote: > Just wanted to verify that we can put a: > > settings set target.load-cwd-lldbinit true > > > in our ~/.lldbinit file and it will then load the local init file in the > current working

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

JDevlieghere updated this revision to Diff 198334. JDevlieghere added a comment. Make it clear that --no-lldbinit supersedes the new flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61578/new/ https://reviews.llvm.org/D61578 Files: lldb/lit/Driver/LocalLLDBInit.test lldb/tools/d

[Lldb-commits] [lldb] r360078 - [CMake] Remove inlined-functions.yaml

Author: jdevlieghere Date: Mon May 6 14:02:03 2019 New Revision: 360078 URL: http://llvm.org/viewvc/llvm-project?rev=360078&view=rev Log: [CMake] Remove inlined-functions.yaml Modified: lldb/trunk/unittests/Symbol/CMakeLists.txt Modified: lldb/trunk/unittests/Symbol/CMakeLists.txt URL: htt

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz created this revision. sgraenitz added reviewers: labath, JDevlieghere, bkoropoff, clayborg. Herald added subscribers: MaskRay, arichardson, aprantl, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. First part of a fix for JITed code debugging. This has been a re

[Lldb-commits] [lldb] r360079 - [CMake] Remove lldbPluginSymbolVendorMacOSX to fix CMake build

Author: jdevlieghere Date: Mon May 6 14:17:50 2019 New Revision: 360079 URL: http://llvm.org/viewvc/llvm-project?rev=360079&view=rev Log: [CMake] Remove lldbPluginSymbolVendorMacOSX to fix CMake build This should fix check-lldb-unit on the bots. Modified: lldb/trunk/unittests/Symbol/CMakeLi

[Lldb-commits] [lldb] r360083 - [Docs] Add remote.html redirect

Author: jdevlieghere Date: Mon May 6 14:28:01 2019 New Revision: 360083 URL: http://llvm.org/viewvc/llvm-project?rev=360083&view=rev Log: [Docs] Add remote.html redirect Add a redirect for the old remote.html page and sort the pages to make dding redirects easier in the future. Modified: ll

[Lldb-commits] [lldb] r360105 - [Breakpoint] Remove unused dependency

Author: xiaobai Date: Mon May 6 18:03:40 2019 New Revision: 360105 URL: http://llvm.org/viewvc/llvm-project?rev=360105&view=rev Log: [Breakpoint] Remove unused dependency The CPlusPlus Language plugin is unused in lldbBreakpoint. We should just remove it. A great follow up to this change would

Re: [Lldb-commits] [lldb] r360105 - [Breakpoint] Remove unused dependency

Shouldn't be hard to do. The problem this is trying to solve is that ObjC has the notion of categories which organize methods of a class in to sub-buckets. When you call a method you generally don't specify the category name, even though the actual method name contains the category. So from a