[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Herald added a project: LLVM. This definitely broke stand-alone builds: FAILED: tools/driver/Options.inc cd /var/tmp/portage/dev-util/lldb-/work/lldb-_build && /usr/lib/llvm/9/bin/llvm-tblgen -gen-opt-parser-defs -I /var/tmp/portage/dev-util/lldb-/work/l

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBStandalone.cmake:20 + # We set LLVM_MAIN_INCLUDE_DIR so that it gets included in TableGen flags. + set(LLVM_MAIN_INCLUDE_DIR "${LLVM_BUILD_MAIN_INCLUDE_DIR}" CACHE PATH "Path to LLVM's source include dir")

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: sgraenitz, xiaobai, labath, zturner. mgorny added a project: LLDB. Restore the previous behavior of using install directories for LLVM_MAIN_INCLUDE_DIR, LLVM_LIBRARY_DIR and LLVM_BINARY_DIR. The update from llvm-config to CMake has changed the

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Submitted a fix as D57995 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to ClangLex

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: JDevlieghere, labath. mgorny added a project: LLDB. Herald added subscribers: teemperor, abidh. Fixes the following build error: /usr/lib/gcc/x86_64-pc-linux-gnu/7.4.0/../../../../x86_64-pc-linux-gnu/bin/ld: tools/lldb-instr/CMakeFiles/lld

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 186111. mgorny retitled this revision from "[lldb] [lldb-instr] Add missing linkage to ClangLex" to "[lldb] [lldb-instr] Add missing linkage to clang libraries". mgorny edited the summary of this revision. mgorny added a comment. That's the complete set. CHA

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to ClangLex

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny planned changes to this revision. mgorny added a comment. Expecting more. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57999/new/ https://reviews.llvm.org/D57999 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, zturner. mgorny added a project: LLDB. Herald added subscribers: abidh, ki.stfu. Herald added a reviewer: serge-sans-paille. Skip running lldb-mi tests when Python support is disabled. This causes lldb-mi to unconditionally fail, and t

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

2019-02-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: zturner, labath. mgorny added a project: LLDB. Herald added a reviewer: serge-sans-paille. Fix the build helper to find lld-link via PATH lookup, rather than making a fragile assumption that it will be present in the 'compiler directory'. This

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

2019-02-09 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer updated this revision to Diff 186144. mortimer added a comment. Added a test to verify that the unwind state is reset after each kind of return. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57928/new/ https://reviews.llvm.org/D57928 Files: lldb/source/Plugins/UnwindAssembly