[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 184471. leonid.mashinskiy marked an inline comment as done. leonid.mashinskiy added a comment. - made changes related to review Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added inline comments. Comment at: source/Expression/DWARFExpression.cpp:3253 - return false; + return true; } zturner wrote: > Why do we change the return value here? This function had mixed return value semantics and I changed it to alway

[Lldb-commits] [PATCH] D57506: [LLDB] FreeBSD suppress compilation warning

devnexen created this revision. devnexen added a reviewer: labath. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, emaste. Repository: rLLDB LLDB https://reviews.llvm.org/D57506 Files: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index

[Lldb-commits] [PATCH] D57506: [LLDB] FreeBSD suppress compilation warning

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57506/new/ https://reviews.llvm.org/D57506 ___ lldb-c

[Lldb-commits] [lldb] r352744 - [LLDB] FreeBSD suppress compilation warning

Author: devnexen Date: Thu Jan 31 03:54:58 2019 New Revision: 352744 URL: http://llvm.org/viewvc/llvm-project?rev=352744&view=rev Log: [LLDB] FreeBSD suppress compilation warning Reviewers: labath, teemperor Reviewed By: teemperor Differential Revision: https://reviews.llvm.org/D57506 Msou

[Lldb-commits] [PATCH] D57506: [LLDB] FreeBSD suppress compilation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL352744: [LLDB] FreeBSD suppress compilation warning (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57506?vs=184480&id=

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. Thanks for review! Please, commit this for me, because I have no commit access. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 ___ lldb-c

[Lldb-commits] [lldb] r352772 - Fix use of non-existing variable in crashlog.py

Author: shafik Date: Thu Jan 31 09:33:17 2019 New Revision: 352772 URL: http://llvm.org/viewvc/llvm-project?rev=352772&view=rev Log: Fix use of non-existing variable in crashlog.py Summary: The method find_matching_slice(self) uses uuid_str on one of the paths but the variable does not exist and

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB352772: Fix use of non-existing variable in crashlog.py (authored by shafik, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57467/new/ https://reviews.

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath added a comment. BTW, it would be nice to mention somewhere how to use this tool. Do you just run it, or does it needs some special arguments, or something? Comment at: source/API/SBBlock.cpp:52-58 + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsValid); + return m_o

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/API/SBBlock.cpp:52-58 + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsValid); + return m_opaque_ptr != NULL; +} bool SBBlock::IsInlined() const { + SB_RECORD_METHOD_CONST

[Lldb-commits] [lldb] r352780 - [unittest] Fix scalar unit test.

Author: jdevlieghere Date: Thu Jan 31 10:48:17 2019 New Revision: 352780 URL: http://llvm.org/viewvc/llvm-project?rev=352780&view=rev Log: [unittest] Fix scalar unit test. The test was using ASSERT_EQ instead of ASSERT_STREQ which meant we were comparing string addresses instead of the actual str

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

labath added a comment. I was going to say that this has the potential of breaking libstdc++ formatters, but it looks like you found that out already. Since the libc++ inline namespace can really be anything, it makes sense to have the regex match that. Since libstdc++ (AFAIK) doesn't have that

Re: [Lldb-commits] [lldb] r352780 - [unittest] Fix scalar unit test.

On Thu, Jan 31, 2019 at 10:48 AM Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Thu Jan 31 10:48:17 2019 > New Revision: 352780 > > URL: http://llvm.org/viewvc/llvm-project?rev=352780&view=rev > Log: > [unittest] Fix scalar unit test. > > The test was using ASSERT_EQ in

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath added inline comments. Comment at: source/API/SBBlock.cpp:52-58 + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsValid); + return m_opaque_ptr != NULL; +} bool SBBlock::IsInlined() const { + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsInlined); + ---

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 184586. tatyana-krasnukha removed a subscriber: llvm-commits. tatyana-krasnukha added a comment. Changed configuration register handling logic: if an RSP-server doesn't provide a register, don't count this as a failure - just use default values for

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thakis added a comment. labath, was that an lg? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha updated this revision to Diff 184642. tatyana-krasnukha added a comment. Updated file headers to reflect the new license; Updated according to the last revision of D55718 . Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 184644. JDevlieghere added a comment. Add unit testing for supporting classes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: include/lldb/API/SBReproducer.h source/API/CMakeLists.txt sourc