JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52103
___
lldb-commits mailing list
lldb-commits@lists.llv
JDevlieghere updated this revision to Diff 165727.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
- Address Shafik's feedback
https://reviews.llvm.org/D51934
Files:
packages/Python/lldbsuite/test/functionalities/target_create_deps/Makefile
packages/Python/lldb
JDevlieghere added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:153
+static OptionDefinition g_dependents_options[1] = {
+{LLDB_OPT_SET_1, false, "no-dependents", 'd',
+ OptionParser::eOptionalArgument, nullptr, g_dependents_enumaration, 0,
---
Author: teemperor
Date: Mon Sep 17 05:06:07 2018
New Revision: 342385
URL: http://llvm.org/viewvc/llvm-project?rev=342385&view=rev
Log:
Add descriptions to completed expressions
Summary:
Completing inside the expression command now uses the new description API
to also provide additional informati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342385: Add descriptions to completed expressions (authored
by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52103?vs=165527&id=1
clayborg added inline comments.
Comment at: www/python-reference.html:325
+Another use of the Python API's in lldb is to create a
custom breakpoint resolver. This facility
+ was added in r51967.
+
Is that SVN r
aprantl added a comment.
It looks like it would be easy to forget to add -gdb-exit to every test.
Wouldn't it be better to have the lldb-mi automatically produce a -gdb-exit
command when it reads EOF from stdin?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52139
_
stella.stamenova accepted this revision.
stella.stamenova added a comment.
LGTM, but I'd wait till @teemperor approves as well.
https://reviews.llvm.org/D50751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: davide
Date: Mon Sep 17 11:14:38 2018
New Revision: 342404
URL: http://llvm.org/viewvc/llvm-project?rev=342404&view=rev
Log:
Revert "[IRInterpreter] Minor cleanups, add comments. NFCI."
This breaks buildbots.
Modified:
lldb/trunk/source/Expression/IRInterpreter.cpp
Modified: lldb/tr
jingham marked 3 inline comments as done.
jingham added a comment.
I used your suggestion and fixed the few other bits.
Comment at: www/python-reference.html:325
+Another use of the Python API's in lldb is to create a
custom breakpoint resolver. This facility
jingham updated this revision to Diff 165796.
jingham marked 3 inline comments as done.
jingham added a comment.
Addressed review comments from Greg.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52065
Files:
www/python-reference.html
Index: www/python-reference.html
==
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for doing all the updates. Pretty clear and concise now.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52065
___
lldb-commits ma
Author: jingham
Date: Mon Sep 17 14:55:46 2018
New Revision: 342419
URL: http://llvm.org/viewvc/llvm-project?rev=342419&view=rev
Log:
Add docs for scripted breakpoint resolvers
Differential Revision: https://reviews.llvm.org/D52065
Modified:
lldb/trunk/www/python-reference.html
Modified: ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342419: Add docs for scripted breakpoint resolvers (authored
by jingham, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52065?vs=165796&id=16
Author: shafik
Date: Mon Sep 17 15:10:44 2018
New Revision: 342421
URL: http://llvm.org/viewvc/llvm-project?rev=342421&view=rev
Log:
[DataFormatters] Add formatter for C++17 std::variant
rdar://problem/43691454
Patch by Shafik Yaghmour.
Differential Revision: https://reviews.llvm.org/D51520
Ad
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342421: [DataFormatters] Add formatter for C++17
std::variant (authored by shafik, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51520?vs=16
apolyakov added a comment.
It seems reasonable, I'll look at this.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I'm afraid this broke one of our bots. Can you please take a look and
fix or revert?
Thanks!
Testing Time: 236.25s
Failing Tests (1):
lldb-Suite ::
functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
http://green.lab.llvm.o
Author: shafik
Date: Mon Sep 17 16:15:35 2018
New Revision: 342424
URL: http://llvm.org/viewvc/llvm-project?rev=342424&view=rev
Log:
Revert "[DataFormatters] Add formatter for C++17 std::variant"
This reverts commit r342421.
Because it breaks build bot
http://green.lab.llvm.org/green/job/lldb-c
Thanks Shafik!
--
Davide
On Mon, Sep 17, 2018 at 4:16 PM Shafik Yaghmour via lldb-commits
wrote:
>
> Author: shafik
> Date: Mon Sep 17 16:15:35 2018
> New Revision: 342424
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342424&view=rev
> Log:
> Revert "[DataFormatters] Add formatter for C++17 st
20 matches
Mail list logo
