[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

labath added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { joerg wrote: > krytarowski wrote: > > brunoa

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

labath added a comment. I would prefer the unique_lock idea also. Lamdas make the code look ugly. Alternatively, we could start using thread safety annotations https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, and let clang do the checking for us. I think a number of places could benefit f

[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

labath created this revision. Herald added a subscriber: ki.stfu. It defined a couple of types (condition_t) which we don't use anymore, as we have c++11 goodies now. I remove these definitions. Also it unnecessarily included a couple of headers which weren't necessary for it's operation. I remov

Re: [Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

On 6 July 2017 at 18:40, Bruno Rosa via Phabricator wrote: > brunoalr added a comment. > > In https://reviews.llvm.org/D35065#800877, @krytarowski wrote: > >> What are the build failures? > > > > > [2397/3183] Building CXX object > tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/l

[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

krytarowski added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:18 #if defined(__linux__) || defined(__FreeBSD__) #include "Plugins/Process/elf-core/ProcessElfCore.h" #endif Is this needed here? https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

labath added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:18 #if defined(__linux__) || defined(__FreeBSD__) #include "Plugins/Process/elf-core/ProcessElfCore.h" #endif krytarowski wrote: > Is this needed here? good point.

[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

labath updated this revision to Diff 105613. labath added a comment. Remove unused include from auxvector.h https://reviews.llvm.org/D35113 Files: include/lldb/Host/MainLoop.h include/lldb/Host/PosixApi.h include/lldb/lldb-types.h source/Host/common/File.cpp source/Host/common/Socket.

[Lldb-commits] [lldb] r307390 - Add a NativeProcessProtocol Factory class

Author: labath Date: Fri Jul 7 04:02:19 2017 New Revision: 307390 URL: http://llvm.org/viewvc/llvm-project?rev=307390&view=rev Log: Add a NativeProcessProtocol Factory class Summary: This replaces the static functions used for creating NativeProcessProtocol instances with a factory pattern, and

[Lldb-commits] [lldb] r307391 - Disable TestGoASTContext

Author: labath Date: Fri Jul 7 04:02:28 2017 New Revision: 307391 URL: http://llvm.org/viewvc/llvm-project?rev=307391&view=rev Log: Disable TestGoASTContext it fails with go 1.8 and we don't seem to have a maintainer of that functionality. Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

This revision was automatically updated to reflect the committed changes. Closed by commit rL307390: Add a NativeProcessProtocol Factory class (authored by labath). Repository: rL LLVM https://reviews.llvm.org/D33778 Files: lldb/trunk/include/lldb/Host/common/NativeProcessProtocol.h lldb/

[Lldb-commits] [PATCH] D35123: Remove shared pointer from NativeProcessProtocol

labath created this revision. The usage of shared_from_this forces us to separate construction and initialization phases, because shared_from_this() is not available in the constructor (or destructor). The shared semantics are not necessary, as we always have a clear owner of the native process cl

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105638. brunoalr added a comment. Applying suggestions from review https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYL

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105639. brunoalr added a comment. Use string+5 instead of concatenation https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSI

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105640. brunoalr added a comment. Small fix https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYL

[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex

jingham added a comment. The ThreadSafety analysis stuff looks interesting, but just to be sure I understand: You said "alternatively we could..." but from what I could tell the thread safety is markup on already extant mechanisms. It didn't look like it provided any locking on it's on, it on

[Lldb-commits] [lldb] r307454 - The x86 instruction unwinder can be asked to disassemble non-instruction

Author: jmolenda Date: Fri Jul 7 17:12:15 2017 New Revision: 307454 URL: http://llvm.org/viewvc/llvm-project?rev=307454&view=rev Log: The x86 instruction unwinder can be asked to disassemble non-instruction blocks of memory, and if the final bytes of that block look like a long x86 instruction,

[Lldb-commits] [lldb] r307464 - Update message that Main Thread Checker produces.

Author: kuba.brecka Date: Fri Jul 7 22:18:19 2017 New Revision: 307464 URL: http://llvm.org/viewvc/llvm-project?rev=307464&view=rev Log: Update message that Main Thread Checker produces. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/mtc/simple/TestMTCSimple.py ll