labath updated this revision to Diff 91693.
labath added a comment.
Herald added a subscriber: ki.stfu.
I've updated the code as suggested. For the "fudge factor" I chose one, so that
this at least works in the fairly common case where you put an empty line
between two tiny functions. The "breakpo
labath created this revision.
Herald added subscribers: mgorny, srhines.
ProcFileReader is the cause of the dependency from Host to ProcessLinux
module. Since it's interface is also obsolete (ReadIntoDataBuffer is
trivially replaceable by llvm::MemoryBuffer functions and
ProcessLineByLine is trivi
Author: labath
Date: Tue Mar 14 09:58:31 2017
New Revision: 297743
URL: http://llvm.org/viewvc/llvm-project?rev=297743&view=rev
Log:
Fix flakyness in TestCompletion
One of the file name templates was occasionally generating the name
"fooa***", which conflicted with the one of the tests expectatio
zturner added a comment.
Code looks much nicer than before!
Comment at: source/Host/linux/Host.cpp:59-60
- static const char tracerpid_token[] = "TracerPid:";
- char *buf_tracerpid = strstr((char *)buf_sp->GetBytes(), tracerpid_token);
- if (buf_tracerpid) {
-// Tracer
labath added a comment.
Comment at: source/Host/linux/Host.cpp:63-70
+ Line = Line.ltrim();
+ uint32_t RGid, EGid;
+ Line.consumeInteger(10, RGid);
+ Line = Line.ltrim();
+ Line.consumeInteger(10, EGid);
+
+ ProcessInfo.SetGroupID(RGid);
-
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This seems good to me. Thanks for doing this.
I made a few inline comments, but none are serious.
Maybe I'm a little over-cautious about this sort of thing, but
GetStartLineSourceInfo will
eugene accepted this revision.
eugene added inline comments.
Comment at: source/Host/linux/Host.cpp:167
+ (llvm::Twine("/proc/") + llvm::Twine(pid) + "/exe").toVector(ProcExe);
+ llvm::SmallString<0> ExePath;
+ ExePath.assign(PATH_MAX, '\0');
std::string? Do w
Author: cbieneman
Date: Tue Mar 14 15:01:24 2017
New Revision: 297774
URL: http://llvm.org/viewvc/llvm-project?rev=297774&view=rev
Log:
[debugserver] Fixing a small logic error from r297685
I had mixed up the logic during patch review. This resolves the test failure
reading YMM registers on Darw
Author: cbieneman
Date: Tue Mar 14 15:04:46 2017
New Revision: 297776
URL: http://llvm.org/viewvc/llvm-project?rev=297776&view=rev
Log:
[CMake] Override debugserver to use the build tree on Darwin
This patch adds support to the test suite for overriding the path to
debugserver, and uses the over
Author: cbieneman
Date: Tue Mar 14 17:24:36 2017
New Revision: 297787
URL: http://llvm.org/viewvc/llvm-project?rev=297787&view=rev
Log:
[debugserver] NFC. Cleanup Get/Set Register Value/Context
This patch modifies the Get/Set Register Value/Context functions for Intel to
not duplicate code for r
amccarth closed this revision.
amccarth added a comment.
Committed in r287770.
https://reviews.llvm.org/D27010
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tstellar created this revision.
https://reviews.llvm.org/D30961
Files:
include/lldb/Utility/TaskPool.h
Index: include/lldb/Utility/TaskPool.h
===
--- include/lldb/Utility/TaskPool.h
+++ include/lldb/Utility/TaskPool.h
@@ -12,6 +1
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks great.
Comment at: tools/lldb-server/LLDBServerUtilities.cpp:59-60
if (!success) {
- fprintf(stderr, "Unable to open log file '%s' for channel \"%s\"\n",
-
13 matches
Mail list logo
