[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-25 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. Although this patch fixes the test case in question but in theory EphemeralMode watchpoint enable/disable cycles should be independent of step-over watchpoint enable disable cycle. On gdb-remote type targets we only update hardware_watch_id when a watchpoint is hit so

[Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

2016-11-25 Thread Muhammad Omair Javaid via lldb-commits
omjavaid abandoned this revision. omjavaid added a comment. There is not exact solution that satisfies all corner cases. Abandoning for now until I come up with a solution that covers us from all corners. https://reviews.llvm.org/D24610 ___ lldb-co

[Lldb-commits] [PATCH] D27115: [cleanup] Fix typos in file headers

2016-11-25 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great, thanks. Repository: rL LLVM https://reviews.llvm.org/D27115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-25 Thread Pavel Labath via lldb-commits
labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. Jim will be a better person to review this. However, this feels like a hack to me. https://reviews.llvm.org/D27124 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-11-25 Thread Pavel Labath via lldb-commits
labath added a comment. Thank you for trying this out, and getting the core file. Unfortunately, the core is somewhat bigger then I had hoped for (it contains a very large data segment). I'll try to play around with this on a freebsd vm to see if I can reduce that somehow (maybe another ulimit

[Lldb-commits] [lldb] r287916 - Merge Linux and FreeBSD arm64 register contexts

2016-11-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 25 04:28:09 2016 New Revision: 287916 URL: http://llvm.org/viewvc/llvm-project?rev=287916&view=rev Log: Merge Linux and FreeBSD arm64 register contexts Summary: This is a test-the-water change about possibilities of reducing duplication in the register context definit

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-11-25 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287916: Merge Linux and FreeBSD arm64 register contexts (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25947?vs=75718&id=79286#toc Repository: rL LLVM https://reviews.llvm.

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

2016-11-25 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: emaste, sas. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, rengolin, aemerson. These two register contexts were identical, so this shouldn't cause any regressions, but I'd appreciate it if you can check that this at

[Lldb-commits] [lldb] r287917 - Use Clang for D language support.

2016-11-25 Thread Johan Engelen via lldb-commits
Author: jengelen Date: Fri Nov 25 05:01:12 2016 New Revision: 287917 URL: http://llvm.org/viewvc/llvm-project?rev=287917&view=rev Log: Use Clang for D language support. Differential revision: https://reviews.llvm.org/D24794 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: l

[Lldb-commits] [lldb] r287920 - Introduce chrono to the Communication class

2016-11-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 25 05:58:44 2016 New Revision: 287920 URL: http://llvm.org/viewvc/llvm-project?rev=287920&view=rev Log: Introduce chrono to the Communication class This replaces the raw integer timeout parameters in the class with their chrono-based equivalents. To achieve this, I h

[Lldb-commits] [lldb] r287921 - Fix FreeBSD build error in r287920

2016-11-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 25 06:15:17 2016 New Revision: 287921 URL: http://llvm.org/viewvc/llvm-project?rev=287921&view=rev Log: Fix FreeBSD build error in r287920 The conditional expression is ambiguous there, so help it by explicitly casting. This will go away once we use chrono all the way

[Lldb-commits] [lldb] r287922 - Introduce Chrono to the Connection class. NFCI.

2016-11-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 25 06:22:32 2016 New Revision: 287922 URL: http://llvm.org/viewvc/llvm-project?rev=287922&view=rev Log: Introduce Chrono to the Connection class. NFCI. Modified: lldb/trunk/include/lldb/Core/Connection.h lldb/trunk/include/lldb/Core/ConnectionSharedMemory.h

[Lldb-commits] [lldb] r287923 - Fix darwin build broken by r287920

2016-11-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 25 06:37:49 2016 New Revision: 287923 URL: http://llvm.org/viewvc/llvm-project?rev=287923&view=rev Log: Fix darwin build broken by r287920 I accidentally used the wrong brackets when including llvm headers. Modified: lldb/trunk/include/lldb/Utility/Timeout.h Mod

[Lldb-commits] [PATCH] D24794: Use Clang for D language support until there is a proper language plugin for it.

2016-11-25 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287917: Use Clang for D language support. (authored by jengelen). Changed prior to commit: https://reviews.llvm.org/D24794?vs=72028&id=79288#toc Repository: rL LLVM https://reviews.llvm.org/D24794

[Lldb-commits] [lldb] r287927 - Fix builds Windows and OSX builds after Connection refactor in r287922

2016-11-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 25 08:43:37 2016 New Revision: 287927 URL: http://llvm.org/viewvc/llvm-project?rev=287927&view=rev Log: Fix builds Windows and OSX builds after Connection refactor in r287922 Switch various bits of platform-specific code to chrono that I did not notice when doing a li

[Lldb-commits] [PATCH] D27115: [cleanup] Fix typos in file headers

2016-11-25 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. I checked the FreeBSD parts, looks good. Thanks for doing this! Repository: rL LLVM https://reviews.llvm.org/D27115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

2016-11-25 Thread Ed Maste via Phabricator via lldb-commits
emaste added a subscriber: dmikulin. emaste added a comment. I think @dmikulin might be able to test this https://reviews.llvm.org/D27126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D27134: Remove ConnectionMachPort

2016-11-25 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, jingham. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This class is unused, and since the StringRef refactor, it does not even implement the Connection interface. https://reviews.llvm.org/D27134 Files

[Lldb-commits] [PATCH] D27136: Use Timeout<> in the Listener class

2016-11-25 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: jingham, clayborg, zturner. labath added a subscriber: lldb-commits. Communication classes use the Timeout<> class to specify the timeout. Listener class was converted to chrono some time ago, but it used a different meaning for a timeout of ze

[Lldb-commits] [lldb] r287966 - [lldb] Fix typos in file headers

2016-11-25 Thread Alexander Shaposhnikov via lldb-commits
Author: alexshap Date: Fri Nov 25 23:23:44 2016 New Revision: 287966 URL: http://llvm.org/viewvc/llvm-project?rev=287966&view=rev Log: [lldb] Fix typos in file headers This diff fixes typos in file headers (incorrect file names). Test plan: Under llvm/tools/lldb/source: find ./* -type f | grep

[Lldb-commits] [PATCH] D27115: [cleanup] Fix typos in file headers

2016-11-25 Thread Alexander Shaposhnikov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287966: [lldb] Fix typos in file headers (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D27115?vs=79259&id=79329#toc Repository: rL LLVM https://reviews.llvm.org/D27115 F