labath added a comment.
Ed, what do you think about this one? Is there anyone with a FreeBSD arm64
setup that could verify this?
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
hhellyer created this revision.
hhellyer added a subscriber: lldb-commits.
This patch changes the way ProcessElfCore.cpp handles signal information.
The patch changes ProcessElfCore.cpp to use the signal from si_signo in SIGINFO
notes in preference to the value of cursig in PRSTATUS notes. The va
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as all register contexts are the same between these targets.
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few quick changes.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:208-209
+ // Check we found a signal in a SIGINFO note.
+ for (std::v
labath added a comment.
Thank you for looking into this. This has been a long standing issue that we
haven't got time to address.
Could you also add some tests to cover the new functionality? It sounds like it
would be easy to generate tiny core files which trigger this. You can look at
tests
jingham added a comment.
Besides Greg's comments, this looks reasonable to me.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sammccall
Date: Tue Nov 15 04:58:16 2016
New Revision: 286947
URL: http://llvm.org/viewvc/llvm-project?rev=286947&view=rev
Log:
Fix uninitialized members.
Summary: Fix uninitialized members.
Reviewers: jingham
Subscribers: jingham, lldb-commits
Differential Revision: https://reviews.ll
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
Cool stuff.
Are you planning on doing a similar change for other architectures?
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
sas added a comment.
Just a couple nits inline. Also, did you run `clang-format` on your change? I
see some issues with `if`s and the associated parentheses.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:215
+ }
+ if (siginfo_signal_found == false) {
+//
Author: zturner
Date: Tue Nov 15 14:11:01 2016
New Revision: 287016
URL: http://llvm.org/viewvc/llvm-project?rev=287016&view=rev
Log:
One more fix for Printf. Apparently I fail at incremental builds.
Modified:
lldb/trunk/source/Commands/CommandObjectSyntax.cpp
Modified: lldb/trunk/source/Co
Author: zturner
Date: Tue Nov 15 14:13:14 2016
New Revision: 287017
URL: http://llvm.org/viewvc/llvm-project?rev=287017&view=rev
Log:
Make some code not manipulate the underlying string of a StreamString.
Differential Revision: https://reviews.llvm.org/D26618
Modified:
lldb/trunk/source/Plug
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287017: Make some code not manipulate the underlying string
of a StreamString. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26618?vs=77830&id=78050#toc
Repository:
rL LLV
amccarth created this revision.
amccarth added reviewers: labath, zturner.
amccarth added a subscriber: lldb-commits.
Herald added subscribers: modocache, mgorny.
With the cross-platform minidump plugin working, the Windows-specific one is no
longer needed. This eliminates the unnecessary code.
emaste added a comment.
> Ed, what do you think about this one? Is there anyone with a FreeBSD arm64
> setup that could verify this?
We have an arm64 reference machine in the FreeBSD cluster and I will test after
I return from travel later this week, although perhaps @andrew can try it
before
Author: zturner
Date: Tue Nov 15 17:36:43 2016
New Revision: 287055
URL: http://llvm.org/viewvc/llvm-project?rev=287055&view=rev
Log:
Change Property::GetName() and GetDescription() to return StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/OptionValueProperties.h
lldb/trunk/inclu
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner created this revision.
zturner added reviewers: beanz, tfiala.
zturner added a subscriber: lldb-commits.
As per the title. beanz@, could you specifically look over my usage of
`llvm::Twine`? This is the first time I've used this class, and I'm not sure
if I'm using it correctly / effic
tfiala added a comment.
I can run this through in the morning on macOS.
https://reviews.llvm.org/D26698
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I can give this one a run though on macOS in the morning.
https://reviews.llvm.org/D26721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
19 matches
Mail list logo
