Re: [Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

2016-09-02 Thread Pavel Labath via lldb-commits
Yeah, sorry about that, I wrote that message in a hurry. This was a generic issue with expressions in backticks (``) concerning the printing of pointers (or even integers, as I later found out) of different sizes. Basically a 64-bit pointer would get printed as a decimal value, but a 32-bit one in

[Lldb-commits] [lldb] r280477 - Bump up TestCallWithTimeout timeout

2016-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 2 04:25:42 2016 New Revision: 280477 URL: http://llvm.org/viewvc/llvm-project?rev=280477&view=rev Log: Bump up TestCallWithTimeout timeout Still a bit flaky on remote targets. Trying a larger bump this time. :/ Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r280476 - Make Scalar::GetValue more consistent

2016-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 2 04:25:36 2016 New Revision: 280476 URL: http://llvm.org/viewvc/llvm-project?rev=280476&view=rev Log: Make Scalar::GetValue more consistent Summary: It seems the original intention of the function was printing signed values in decimal format, and unsigned values in

Re: [Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

2016-09-02 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280476: Make Scalar::GetValue more consistent (authored by labath). Changed prior to commit: https://reviews.llvm.org/D24126?vs=69979&id=70140#toc Repository: rL LLVM https://reviews.llvm.org/D24126

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

2016-09-02 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp:146 @@ +145,3 @@ +break; +} + You have a "enumeration not handled in a switch" warning here. Could you do something about that? Repository:

[Lldb-commits] [lldb] r280478 - Revert "Make Scalar::GetValue more consistent"

2016-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 2 04:52:18 2016 New Revision: 280478 URL: http://llvm.org/viewvc/llvm-project?rev=280478&view=rev Log: Revert "Make Scalar::GetValue more consistent" This reverts commit r280476 as it breaks several tests on i386. I was fixing an 32-bit breakage, and I did not run t

[Lldb-commits] [lldb] r280480 - Reapply "Make Scalar::GetValue more consistent"

2016-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 2 05:58:52 2016 New Revision: 280480 URL: http://llvm.org/viewvc/llvm-project?rev=280480&view=rev Log: Reapply "Make Scalar::GetValue more consistent" this is a resubmission of r280476. The problem with the original commit was that it was printing out all numbers as

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

2016-09-02 Thread Dimitar Vlahovski via lldb-commits
dvlahovski added inline comments. Comment at: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp:146 @@ +145,3 @@ +break; +} + labath wrote: > You have a "enumeration not handled in a switch" warning here. Could you do > something about

[Lldb-commits] [lldb] r280490 - Fix 2 waring in the OCaml AST context

2016-09-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Sep 2 10:52:19 2016 New Revision: 280490 URL: http://llvm.org/viewvc/llvm-project?rev=280490&view=rev Log: Fix 2 waring in the OCaml AST context Modified: lldb/trunk/include/lldb/Symbol/OCamlASTContext.h lldb/trunk/source/Symbol/OCamlASTContext.cpp Modified

[Lldb-commits] [lldb] r280492 - Fix build breakage caused by r280490

2016-09-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Sep 2 10:56:33 2016 New Revision: 280492 URL: http://llvm.org/viewvc/llvm-project?rev=280492&view=rev Log: Fix build breakage caused by r280490 Modified: lldb/trunk/source/Symbol/OCamlASTContext.cpp Modified: lldb/trunk/source/Symbol/OCamlASTContext.cpp URL: h

[Lldb-commits] LLVM buildmaster will be updated and restarted tonight

2016-09-02 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r280513 - Check for null

2016-09-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 2 13:15:48 2016 New Revision: 280513 URL: http://llvm.org/viewvc/llvm-project?rev=280513&view=rev Log: Check for null Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-project/lld

[Lldb-commits] SVN mirror in the LLVM Lab is behind the master SVN

2016-09-02 Thread Galina Kistanova via lldb-commits
SVN mirror in the LLVM Lab is behind the master SVN. This affects the build bots. I'm looking in to this. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-02 Thread Ed Munoz via lldb-commits
edmunoz created this revision. edmunoz added a reviewer: ki.stfu. edmunoz added a subscriber: lldb-commits. edmunoz set the repository for this revision to rL LLVM. edmunoz added a project: LLDB. Herald added a subscriber: ki.stfu. When extracting options for long options (starting with "--"), the

Re: [Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-02 Thread Ed Munoz via lldb-commits
edmunoz added inline comments. Comment at: tools/lldb-mi/MICmdArgValOptionLong.cpp:190 @@ -189,10 +189,3 @@ { -CMIUtilString::VecString_t vecOptions; -MIuint nOptionsPresent = 0; -if ((m_eExpectingOptionType != eArgValType_StringQuoted) && (m_eExpectingOptionType !=

Re: [Lldb-commits] [PATCH] D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex

2016-09-02 Thread Michał Górny via lldb-commits
mgorny added a comment. In https://reviews.llvm.org/D23882#527682, @ki.stfu wrote: > lgtm if tests are passed I can't say tests pass for me right now, but the results (failures, errors and unexpected passes) are the same with and without the patch. https://reviews.llvm.org/D23882

[Lldb-commits] LLVM master is back to work

2016-09-02 Thread Galina Kistanova via lldb-commits
Hello everyone, The issue with the SVN mirror in the Lab has been resolved. Please let me know if anything seems wrong with the builders. Thank you for understanding. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists