labath added a comment.
I think we should make one more iteration on this, as there is still some room
for improvement.
In http://reviews.llvm.org/D19998#438756, @zturner wrote:
> Should this be disabled by default unless explicitly requested? Seems like
> "run the entire test suite N times" s
Author: labath
Date: Wed May 25 05:48:16 2016
New Revision: 270684
URL: http://llvm.org/viewvc/llvm-project?rev=270684&view=rev
Log:
Add unit tests for ModuleCache
Reviewers: ovyalov, zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D20570
Added:
lldb/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270684: Add unit tests for ModuleCache (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D20570?vs=58244&id=58400#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20570
Files:
labath added inline comments.
Comment at: unittests/Utility/ModuleCacheTest.cpp:74
@@ +73,3 @@
+{
+HostInfo::Initialize();
+ObjectFileELF::Initialize();
ovyalov wrote:
> If it's one-off initialization can we use setUpTestCase for these purposes
> (for Hos
labath updated this revision to Diff 58418.
labath added a comment.
New version, which does not rely on pretty-printers.
http://reviews.llvm.org/D20567
Files:
packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py
packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp
Index: pack
labath created this revision.
labath added reviewers: sas, tberghammer.
labath added a subscriber: lldb-commits.
This adds the ability to customize the debugserver codesign process via cmake
cache variable. The
user can set the codesign indentity (with the default being the customary
lldb_codesi
labath abandoned this revision.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53
@@ -22,2 +52,3 @@
+
NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol
&native_thread,
uint
tfiala added a comment.
@aprantl, the lldbsuite/support/gmodules.py file didn't make it into your patch
set here. (It was the top file in the -v6 diff).
I'm going to adjust per comments above. @labath, see question on
add_test_categories.
I may end up filing this as a separate review since I
aprantl abandoned this revision.
aprantl added a comment.
Todd, I'm abandoning the review. This should allow you to claim it as your own
so you can iterate quicker. Thanks!
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@l
tfiala commandeered this revision.
tfiala edited reviewers, added: aprantl; removed: tfiala.
tfiala added a comment.
Commandeering.
Thanks, Adrian!
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
tfiala added a comment.
> @aprantl, the lldbsuite/support/gmodules.py file didn't make it into your
> patch set here. (It was the top file in the -v6 diff).
Totally incorrect. The top file is the new file, but it is malformed and is
showing a diff rather than the whole file. Not sure exactly
tfiala updated this revision to Diff 58449.
tfiala added a comment.
Just updating the patch set to what I had intended to give Adrian in r6. This
does not yet contain any of the suggestions from the latest round.
http://reviews.llvm.org/D19998
Files:
packages/Python/lldbsuite/support/gmodul
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/decorators.py:527
@@ -525,3 +526,3 @@
-def skipUnlessClangModules():
+def skipUnlessClangModules(func):
"""Decorate the item to skip test unless Clang -gmodules flag is
supported."""
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D20623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tfiala added a comment.
Yep, I see how it works now.
I'll do a quick follow-up review after this to get that other issue with the
debug info multiplicator (you may have just coined a word ;-)) fixed since I'm
already in this code.
Just finishing testing it on OS X.
http://reviews.llvm.org/D1
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I also stuck a print in to verify the gmodules build was being run everywhere I
expected (i.e. for normal tests, inline tests, and the gmodules-explicit tests).
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
ll
tfiala updated this revision to Diff 58458.
tfiala added a comment.
Adjustments per review, removal of decorator, fixup of
incorrect build method call in inline tests.
http://reviews.llvm.org/D19998
Files:
packages/Python/lldbsuite/support/gmodules.py
packages/Python/lldbsuite/test/decorato
tfiala updated this revision to Diff 58459.
tfiala added a comment.
Remove the now-unneeded second check for Windows.
http://reviews.llvm.org/D19998
Files:
packages/Python/lldbsuite/support/gmodules.py
packages/Python/lldbsuite/test/decorators.py
packages/Python/lldbsuite/test/expression
tfiala added a comment.
I believe this now accounts for everything we discussed changing.
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala marked 15 inline comments as done.
tfiala added a comment.
Marked all code comments as done.
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Going to try this out on Windows and see how it goes.
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: omjavaid
Date: Wed May 25 13:48:39 2016
New Revision: 270745
URL: http://llvm.org/viewvc/llvm-project?rev=270745&view=rev
Log:
Mark some arm-linux specific xfails marking bug entries
TestCallUserAnonTypedef.py and TestIRInterpreter.py fail to limitation of JIT
expressions in handling har
tfiala added a comment.
Okay, thanks Zachary.
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hello,
Builder
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
is back to normal.
Sorry for the noise.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
A factory required a successful step of removing the llvm.obj directory,
which could be missing in some cases.
The fix is committed as r270773
Thanks
Galina
On Wed, May 25, 2016 at 12:22 PM, Sean Silva wrote:
> What was the issue?
>
> On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llv
tfiala added a comment.
Timing info for Ubuntu 15.10:
| Description | Time
(seconds)(mm:ss) |
| Ubuntu 15.10 6-core, 24 GB RAM, TOT clang, no gmodules | 377s (6:17)
|
| Ubuntu 15.10 6-core, 24 GB RAM, TOT clang, with gmodules | 517s (8:37
zturner accepted this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision is now accepted and ready to land.
No problems here, I'd wait for Pavel for additional thoughts before going in.
http://reviews.llvm.org/D19998
___
tfiala added a comment.
In http://reviews.llvm.org/D19998#439698, @zturner wrote:
> No problems here, I'd wait for Pavel for additional thoughts before going in.
Yep that's fine. I am in no hurry to get this in.
http://reviews.llvm.org/D19998
__
tfiala added a comment.
Updated timings, now with OS X:
| Configuration | Time
(seconds)(mm:ss) |
| Ubuntu 15.10 6-core, 24 GB RAM, TOT clang, no gmodules| 377 (6:17)
|
| Ubuntu 15.10 6-core, 24 GB RAM, TOT clang, with gmodules
Author: enrico
Date: Wed May 25 15:38:33 2016
New Revision: 270752
URL: http://llvm.org/viewvc/llvm-project?rev=270752&view=rev
Log:
Fix an issue where LLDB would crash if one tried to 'frame variable' an
unordered_map more than once in a stop due to the synthetic provider not
properly caching t
Author: enrico
Date: Wed May 25 16:38:32 2016
New Revision: 270770
URL: http://llvm.org/viewvc/llvm-project?rev=270770&view=rev
Log:
Add logging to ValueObjectSyntheticFilter such that one can trace through the
creation of synthetic children
Modified:
lldb/trunk/source/Core/ValueObjectSynthe
Author: omjavaid
Date: Wed May 25 17:30:05 2016
New Revision: 270780
URL: http://llvm.org/viewvc/llvm-project?rev=270780&view=rev
Log:
Mark some aarch64-linux specific xfails marking bug entries
TestBSDArchives.py and TestWatchLocation.py fail due to unicode error and bug
has already been report
Author: enrico
Date: Wed May 25 18:19:01 2016
New Revision: 270793
URL: http://llvm.org/viewvc/llvm-project?rev=270793&view=rev
Log:
It has been brought to my attention that, given two variables
T x;
U y;
doing
x = *((T*)y)
is undefined behavior, even if sizeof(T) == sizeof(U), due to pointer
Author: gclayton
Date: Wed May 25 19:08:39 2016
New Revision: 270803
URL: http://llvm.org/viewvc/llvm-project?rev=270803&view=rev
Log:
Make sure to try and take the process stop lock when calling:
uint32_t SBProcess::GetNumQueues();
SBQueue SBProcess::GetQueueAtIndex (size_t index);
Otherwise th
sas accepted this revision.
sas added a comment.
This is really useful.
http://reviews.llvm.org/D20623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Wed May 25 23:22:47 2016
New Revision: 270818
URL: http://llvm.org/viewvc/llvm-project?rev=270818&view=rev
Log:
Small further refinement to the check in ObjectFileMachO::ParseSymtab
which looks for binaries missing an LC_FUNCTION_STARTS section because
it was stripped/not em
37 matches
Mail list logo
