[Lldb-commits] Patch: Add additional nullptr check to SBValue::CreateValueFromData

2016-05-20 Thread Sebastian Theophil via lldb-commits
SBValue::CreateValueFromData didn’t check if the SBType argument was in fact a nullptr. This leads to a crash when dereferencing it of course. I followed the naming used in SBValue CreateValueFromAddress above. Regards, Sebastian -- Dr. Sebastian Theophil | stheop...@think-cell.com Senior Softw

[Lldb-commits] [lldb] r270201 - Work around android-arm NDK bug exposed by rL269992

2016-05-20 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri May 20 05:58:55 2016 New Revision: 270201 URL: http://llvm.org/viewvc/llvm-project?rev=270201&view=rev Log: Work around android-arm NDK bug exposed by rL269992 In the android-arm ndk there is a duplicated typedef in link.h and in unwind.h causing build erros. This CL

Re: [Lldb-commits] [PATCH] D19535: Fix 2 LLVM assertion caoused by an API missues in Scalar

2016-05-20 Thread Tamas Berghammer via lldb-commits
tberghammer abandoned this revision. tberghammer added a comment. Abandoning. as http://reviews.llvm.org/rL270062 fixed the same issue before I managed to add a test for this CL. http://reviews.llvm.org/D19535 ___ lldb-commits mailing list lldb-com

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, ®set, &ioVec, sizeof_native_regs_struct); +Host

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, ®set, &ioVec, sizeof_native_regs_struct); +HostInfo:

[Lldb-commits] [lldb] r270207 - [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 20 07:07:27 2016 New Revision: 270207 URL: http://llvm.org/viewvc/llvm-project?rev=270207&view=rev Log: [LLDB][MIPS] Fix floating point handling in case of thread step-out Patch by Nitesh Jain. Summary: These patch fix thread step-out for hard and soft float. Revi

[Lldb-commits] [lldb] r270208 - [LLDB][MIPS] Fix Floating point Registers Encoding

2016-05-20 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 20 07:11:52 2016 New Revision: 270208 URL: http://llvm.org/viewvc/llvm-project?rev=270208&view=rev Log: [LLDB][MIPS] Fix Floating point Registers Encoding Patch by Nitesh Jain. Summary: Currently floating point regsiters has eEncodingUint encoding. Hence register

Re: [Lldb-commits] [PATCH] D18853: [LLDB][MIPS] Fix Floating point Registers Encoding

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. Committed in revision 270208. Repository: rL LLVM http://reviews.llvm.org/D18853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. committed in revision 270207 Repository: rL LLVM http://reviews.llvm.org/D20416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, ®set, &ioVec, sizeof_native_regs_struct); +HostInfo:

[Lldb-commits] [lldb] r270214 - Revert rL270207: "[LLDB][MIPS] Fix floating point handling in case of thread step-out"

2016-05-20 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri May 20 08:07:16 2016 New Revision: 270214 URL: http://llvm.org/viewvc/llvm-project?rev=270214&view=rev Log: Revert rL270207: "[LLDB][MIPS] Fix floating point handling in case of thread step-out" The CL causes a build breakage on platforms where sizeof(double) == siz

Re: [Lldb-commits] [lldb] r270207 - [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Tamas Berghammer via lldb-commits
I had to revert this CL with rL270214 as it causes a build breakage (see http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/7282) and makes a false assumption regarding host-target compatibility. Please see my commit message in http://reviews.llvm.org/rL270214 for more de

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Muhammad Omair Javaid via lldb-commits
omjavaid accepted this revision. omjavaid added a comment. Seems to be causing no regressions on arm-linux. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-05-20 Thread Luke Drummond via lldb-commits
ldrumm added a comment. gentle ping, if @spyffe or @jingham is available to take another pass at this. http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r270254 - Adopt mmap flags that allow mmap'ed memory to be less crash prone.

2016-05-20 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri May 20 14:18:20 2016 New Revision: 270254 URL: http://llvm.org/viewvc/llvm-project?rev=270254&view=rev Log: Adopt mmap flags that allow mmap'ed memory to be less crash prone. On Darwin if a mmap file is code signed and the code signature is invalid, it used to crash. I

Re: [Lldb-commits] Patch: Add additional nullptr check to SBValue::CreateValueFromData

2016-05-20 Thread Enrico Granata via lldb-commits
> On May 20, 2016, at 2:35 AM, Sebastian Theophil via lldb-commits > wrote: > > SBValue::CreateValueFromData didn’t check if the SBType argument was in fact > a nullptr. This leads to a crash when dereferencing it of course. I followed > the naming used in SBValue CreateValueFromAddress above

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-05-20 Thread Zachary Turner via lldb-commits
zturner added a comment. I'm still getting a lot of crashes after this, but this will at least fix the compiler errors. I will try to look at the crashes on Monday. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355 @@ -358,5 +353,4 @@ { -//