[Lldb-commits] [lldb] r264030 - [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-22 Thread Mohit K. Bhakkad via lldb-commits
Author: mohit.bhakkad Date: Tue Mar 22 03:08:02 2016 New Revision: 264030 URL: http://llvm.org/viewvc/llvm-project?rev=264030&view=rev Log: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py Patch by Nitesh Jain Reviewers: clayborg, labath. Subscribers: jaydeep, bhushan, mohit.bhakkad, sagar, lldb-co

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-22 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264030: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D18082?vs=50569&id=51260#toc Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-22 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. I think this is ready to go in. You probably noticed that this took a long time to work out all the issues with. In the future if there's any way you could break things up into smaller pat

[Lldb-commits] [lldb] r264074 - Unicode support on Win32.

2016-03-22 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 22 12:58:09 2016 New Revision: 264074 URL: http://llvm.org/viewvc/llvm-project?rev=264074&view=rev Log: Unicode support on Win32. Win32 API calls that are Unicode aware require wide character strings, but LLDB uses UTF8 everywhere. This patch does conversions wherev

[Lldb-commits] Buildbot numbers for week of 3/06/2016 - 3/12/2016

2016-03-22 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the week of 3/06/2016 - 3/12/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

[Lldb-commits] Buildbot numbers for week of 3/13/2016 - 3/19/2016

2016-03-22 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 3/13/2016 - 3/19/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

[Lldb-commits] [lldb] r264087 - Changes to the Xcode project file to make LLDB build again after llvm/Support/ConvertUTF.h was brought into the driver

2016-03-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Mar 22 15:16:51 2016 New Revision: 264087 URL: http://llvm.org/viewvc/llvm-project?rev=264087&view=rev Log: Changes to the Xcode project file to make LLDB build again after llvm/Support/ConvertUTF.h was brought into the driver Modified: lldb/trunk/lldb.xcodeproj/pro

Re: [Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

2016-03-22 Thread Zachary Turner via lldb-commits
zturner abandoned this revision. zturner added a comment. Abandoning this revision and will re-open a new revision. http://reviews.llvm.org/D18194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] r264095 - Backend support for top-level Clang epxressions

2016-03-22 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Mar 22 16:05:51 2016 New Revision: 264095 URL: http://llvm.org/viewvc/llvm-project?rev=264095&view=rev Log: Backend support for top-level Clang epxressions This patch adds a new ExecutionPolicy, eExecutionPolicyTopLevel, which tells the expression parser that the expressi

[Lldb-commits] [lldb] r264096 - Fix a bug caused by my alias refactoring where, if an alias was defined in terms of another alias, trying to run the nested command would actually cause a crash in the

2016-03-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Mar 22 16:07:54 2016 New Revision: 264096 URL: http://llvm.org/viewvc/llvm-project?rev=264096&view=rev Log: Fix a bug caused by my alias refactoring where, if an alias was defined in terms of another alias, trying to run the nested command would actually cause a crash in

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-22 Thread Cameron via lldb-commits
cameron314 added a comment. Excellent, thank you! Fortunately, almost all the other changes I've made to llvm/clang/lldb locally are fairly small patches. http://reviews.llvm.org/D17107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D18377: [lldb-mi] Uncomment a line in CMakeLists.txt to make linux build happy.

2016-03-22 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added a reviewer: zturner. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D18377 Files: tools/lldb-mi/CMakeLists.txt Index: tools/lldb-mi/CMakeLists.txt === ---

[Lldb-commits] [lldb] r264104 - [lldb-mi] Uncomment a line in CMakeLists.txt to make linux build happy.

2016-03-22 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Tue Mar 22 16:37:56 2016 New Revision: 264104 URL: http://llvm.org/viewvc/llvm-project?rev=264104&view=rev Log: [lldb-mi] Uncomment a line in CMakeLists.txt to make linux build happy. Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.ll

[Lldb-commits] [PATCH] D18379: [JITLoaderGDB] Read jit entry struct manually.

2016-03-22 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added a reviewer: clayborg. sivachandra added a subscriber: lldb-commits. Though r264012 was fancy enough to make reading the jit entry struct work with templates, the packing and alignment attributes do not work on Windows. So, this change makes it p

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-22 Thread Cameron via lldb-commits
cameron314 closed this revision. cameron314 added a comment. Closing now that the patch has been committed by http://reviews.llvm.org/rL264074. (Not sure why it didn't auto-link.) http://reviews.llvm.org/D17107 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] r264108 - Make it so that a command alias can actually remove the help/long help from its parent command by setting itself to an empty help string

2016-03-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Mar 22 17:12:59 2016 New Revision: 264108 URL: http://llvm.org/viewvc/llvm-project?rev=264108&view=rev Log: Make it so that a command alias can actually remove the help/long help from its parent command by setting itself to an empty help string Modified: lldb/trunk/

[Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

2016-03-22 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. zturner added a subscriber: lldb-commits. This patch attempts to remove the coupling between `ClangASTContext` and DWARF debug information. Previously, `TypeSystem` exposed a method called `GetDWARFParser`, which means that any

[Lldb-commits] [lldb] r264113 - Reverted a change in r264074 that made lldb-mi use lldb_private APIs.

2016-03-22 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Mar 22 17:42:42 2016 New Revision: 264113 URL: http://llvm.org/viewvc/llvm-project?rev=264113&view=rev Log: Reverted a change in r264074 that made lldb-mi use lldb_private APIs. FileSystem::Fopen is a lldb_private API, but lldb-mi uses only the public API. Depending on l

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

2016-03-22 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. After our last conversation I must have missed that both Go and Java need to be able to provide custom DWARF parsing. Any language, and any TypeSystem, should be able to provide

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-03-22 Thread Cameron via lldb-commits
cameron314 added inline comments. Comment at: tools/lldb-mi/MIUtilFileStd.cpp:234-241 @@ -223,11 +233,10 @@ -FILE *pTmp = nullptr; -pTmp = ::fopen(vFileNamePath.c_str(), "wb"); +FILE *pTmp = lldb_private::FileSystem::Fopen(vFileNamePath.c_str(), "wb"); if (pTmp

Re: [Lldb-commits] [PATCH] D18379: [JITLoaderGDB] Read jit entry struct manually.

2016-03-22 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One thing to note: don't use Process::DoReadMemory(), it doesn't cache data and it will always result in a read memory packet going to GDB server if you are using lldb-server and

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

2016-03-22 Thread Zachary Turner via lldb-commits
Should we go back to my original patch then? It left the parser accessible from TypeSystem, but made it a DebugInfoParser instead of a DWARFParser. The whole idea is to remove knowledge of a specific debug info format from the generic TypeSystem, so it still seems wrong to add DWARF specific stuff

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

2016-03-22 Thread Greg Clayton via lldb-commits
clayborg added a comment. No. Keep GetDWARFParser() on TypeSystem and all that code as is. You shouldn't need to add GetPDBParser() to TypeSystem as you should get a type system for language from within your SymbolFilePDB (with a language like C or C++) and then make a PDBParser with a referenc

Re: [Lldb-commits] [PATCH] D18379: [JITLoaderGDB] Read jit entry struct manually.

2016-03-22 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 51370. sivachandra added a comment. Modify according to suggestions. http://reviews.llvm.org/D18379 Files: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp source/Plugins/JITLoader/GDB/JITLoaderGDB.h Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.h

Re: [Lldb-commits] [PATCH] D18379: [JITLoaderGDB] Read jit entry struct manually.

2016-03-22 Thread Siva Chandra via lldb-commits
sivachandra added a comment. How does this look? http://reviews.llvm.org/D18379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r264123 - Change 'apropos' such that it doesn't look into the "long help/syntax" strings for commands

2016-03-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Mar 22 20:21:55 2016 New Revision: 264123 URL: http://llvm.org/viewvc/llvm-project?rev=264123&view=rev Log: Change 'apropos' such that it doesn't look into the "long help/syntax" strings for commands This solves issues such as 'apropos foo' returning valid matches just b