labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
This revision is now accepted and ready to land.
Thanks.
If you wish, you can link it to the same bug as the arm xfail above, as that is
the same underlying issue.
Repository:
rL LLVM
http://reviews.llvm.
Author: jaydeep
Date: Fri Dec 4 03:56:36 2015
New Revision: 254710
URL: http://llvm.org/viewvc/llvm-project?rev=254710&view=rev
Log:
[LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS
SUMMARY:
Marked TestCrashDuringStep.py as XFAIL for MIPS. The test generates IO
error due to breakpoint
jaydeep closed this revision.
jaydeep added a comment.
Closed by commit http://reviews.llvm.org/rL254710
Repository:
rL LLVM
http://reviews.llvm.org/D15182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: mohit.bhakkad
Date: Fri Dec 4 03:58:07 2015
New Revision: 254711
URL: http://llvm.org/viewvc/llvm-project?rev=254711&view=rev
Log:
[LLDB][MIPS] Fix gdbremote_testcase.py
Patch by Nitesh Jain
Reviewers: clayborg, ovyalov.
Subscribers: jaydeep, bhushan, mohit.bhakkad, sagar.
Differential R
tberghammer retitled this revision from "Create new "platform process connect"
command" to "Modify "platform connect" to connect to processes as well".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41867.
http://reviews.llvm.org/D14952
Files:
docs
Author: tberghammer
Date: Fri Dec 4 07:23:35 2015
New Revision: 254715
URL: http://llvm.org/viewvc/llvm-project?rev=254715&view=rev
Log:
Improve the functionality of JSONNumber
* Add support for representing signed integers
* Add new constructors taking any signed or unsigned integer types
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254715: Improve the functionality of JSONNumber (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15187?vs=41743&id=41868#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
labath added a comment.
Just a tiny remark from my side..
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:184
@@ +183,3 @@
+std::string hostname;
+// TODO: /tmp/ should not be hardcoded. User might want to override /tmp
+// wit
tberghammer retitled this revision from "Change Platform::LoadImage to copy the
file to the remote platform" to "Add a new option to Platform::LoadImage to
install the image".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41877.
tberghammer added a c
amccarth marked 2 inline comments as done.
amccarth added a comment.
Addressed comments.
http://reviews.llvm.org/D15218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth updated this revision to Diff 41884.
amccarth added a comment.
Address comments.
Factored the decoding of the page protection bits to share that logic between
the live and mini dump debugging.
http://reviews.llvm.org/D15218
Files:
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cp
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Because of the large number of XFAILs TestThreadStates has decayed quite a bit.
This commit does
the following:
- removes the "breakpoint list" expectations. Most tests have been failing on
tfiala added a comment.
Looking at this now.
http://reviews.llvm.org/D15209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
OK. It would have been better to make a patch that fixes the specific problem
with other C variants. That's just a straight up bug, and mixing it with
comments on the two separate issues,
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So my main issue with this is the new virtual
"Platform::GetPendingGdbServerList(...)" function. Can we remove this function
and just put the functionality into Platform::Contect
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Add header doc for the new LoadImage and make Platform::LoadImage virtual in
case platforms want to override this and this is good to go.
Comment at: include/ll
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Hey Zachary,
As best as I can tell, we don't need to do anything here, at least not on OS X
El Capitan, because six is already included in the OS X Python distribution.
I was scratching my he
amccarth updated this revision to Diff 41898.
amccarth added a comment.
After discussion with Zach, we concluded that his original logic for
IsPageReadable was better.
http://reviews.llvm.org/D15218
Files:
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp
source/Plugins/Process/Windows/
Author: gclayton
Date: Fri Dec 4 12:37:48 2015
New Revision: 254743
URL: http://llvm.org/viewvc/llvm-project?rev=254743&view=rev
Log:
Fill in the generic register kind if in AugmentRegisterInfoViaABI if it is
available.
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote
Author: tfiala
Date: Fri Dec 4 12:40:34 2015
New Revision: 254744
URL: http://llvm.org/viewvc/llvm-project?rev=254744&view=rev
Log:
Fix test error in TestObjCCheckers.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-checker/TestObjCCheckers.py
Modified:
lldb/trunk/pac
Author: tfiala
Date: Fri Dec 4 12:52:02 2015
New Revision: 254746
URL: http://llvm.org/viewvc/llvm-project?rev=254746&view=rev
Log:
Marked TestModulesInlineFunctions.py XFAIL
Tracked here:
https://llvm.org/bugs/show_bug.cgi?id=25743
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/
Thanks, I'll commit this later today then.
On Fri, Dec 4, 2015 at 10:25 AM Todd Fiala wrote:
> tfiala accepted this revision.
> tfiala added a comment.
> This revision is now accepted and ready to land.
>
> Hey Zachary,
>
> As best as I can tell, we don't need to do anything here, at least not o
Author: dperchik
Date: Fri Dec 4 13:34:00 2015
New Revision: 254753
URL: http://llvm.org/viewvc/llvm-project?rev=254753&view=rev
Log:
Fix breakpoint language filtering for other C variants (like C99) and Pascal.
This patch fixes setting breakpoints on symbol for variants of C and
Pascal where th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254753: Fix breakpoint language filtering for other C
variants (like C99) and Pascal. (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D15175?vs=41713&id=41902#toc
Repository:
Author: enrico
Date: Fri Dec 4 13:40:26 2015
New Revision: 254755
URL: http://llvm.org/viewvc/llvm-project?rev=254755&view=rev
Log:
Add a benchmark that validates how much time LLDB spends trying to fully print
a fairly large std::list
This is meant to help me track optimizations to the libc++
dawn added a comment.
In http://reviews.llvm.org/D12809#301752, @sivachandra wrote:
> @dawn: Thanks for accepting the patch. I guess I still need to wait for
> sign-off/comments from a CODE_OWNER.
Yeah. Maybe add more proactive reviewers? And definitely be a squeaky wheel
about it. Keep a
Author: enrico
Date: Fri Dec 4 13:48:08 2015
New Revision: 254757
URL: http://llvm.org/viewvc/llvm-project?rev=254757&view=rev
Log:
Improve the std::list data formatter to not need to calculate indices for every
loop iteration
This saves about 5 seconds on a 1500 elements list from my local est
Author: enrico
Date: Fri Dec 4 13:50:05 2015
New Revision: 254758
URL: http://llvm.org/viewvc/llvm-project?rev=254758&view=rev
Log:
Fix an issue where all tests marked with skip_if_callable would be skipped
regardless of the actual callable
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
zturner created this revision.
zturner added reviewers: jingham, labath.
zturner added a subscriber: lldb-commits.
This test would fail before if conditional breakpoints weren't
working correctly, and the nature of the test (spinning up 10
threads, etc) opens the door to raciness.
Author: enrico
Date: Fri Dec 4 14:12:46 2015
New Revision: 254762
URL: http://llvm.org/viewvc/llvm-project?rev=254762&view=rev
Log:
Cache the incremental iterators as you traverse the list, so that you don't
have to keep recomputing them
If memory turns out to be a problem, which I don't think
jingham added a comment.
Oh, wait, in your patch, the line in the test file that sets the thread on the
supposedly thread specific breakpoint is commented out???
If I uncomment that line, then the test passes.
http://reviews.llvm.org/D15241
___
ll
Author: jingham
Date: Fri Dec 4 14:16:51 2015
New Revision: 254763
URL: http://llvm.org/viewvc/llvm-project?rev=254763&view=rev
Log:
Add documentation for SBTarget::CreateValueFromAddress.
Modified:
lldb/trunk/scripts/interface/SBTarget.i
Modified: lldb/trunk/scripts/interface/SBTarget.i
UR
zturner added a comment.
Ahh, derp. I commented that out when I was testing something locally, and
forgot to uncomment it. So yea, that should be uncommented.
I was having some trouble following the logic of the original test, so it's
possible this test misses an edge case that I haven't thou
jingham added a comment.
The logic was:
- Set a breakpoint on some loop that will get hit multiple times in some thread
worker function.
- The first time it is hit, make it specific to the thread that hit it by
setting a Thread ID on the breakpoint.
- Then add a condition to the breakpoint that
zturner added a comment.
Wouldn't the functionality that's tested by that combination of two things at
the same be equivalently tested by this test, plus a test that only tests the
behavior of conditional breakpoints?
In other words, if you had two tests, one which only tests thread specific
b
zturner added a comment.
Also the origianl test as written was either flaky or disabled on almost every
platform, so it doesn't seem like it was providing much value to anyone.
http://reviews.llvm.org/D15241
___
lldb-commits mailing list
lldb-commi
Author: kamil
Date: Fri Dec 4 15:23:24 2015
New Revision: 254768
URL: http://llvm.org/viewvc/llvm-project?rev=254768&view=rev
Log:
Fix typo in a comment
Modified:
lldb/trunk/source/Core/IOHandler.cpp
Modified: lldb/trunk/source/Core/IOHandler.cpp
URL:
http://llvm.org/viewvc/llvm-project/ll
jingham added a comment.
The test that test "Only breakpoint conditions" will always have
LLDB_INVALID_ID for the breakpoint thread ID. That means the thread test is a
no-op. So it doesn't test the case "thread passes, condition doesn't" or
"condition passes, thread doesn't". I wrote this te
jingham added a comment.
It doesn't require any thread rendezvousing or anything fancy like that.
http://reviews.llvm.org/D15241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
I don't have any examples, one of the linux guys might. But you can look at
the decorators at the top, which say this:
@skipIfFreeBSD # test frequently times out or hangs
@expectedFailureFreeBSD('llvm.org/pr18522') # hits break in another thread in
testrun
@expec
zturner added a comment.
For now I'll just make this a separate test in the same file I guess. But it's
a bummer to have a test that's broken almost everywhere. Makes me think
something is wrong with the test instead of with LLDB. I agree with you though
that it's not obvious what might be w
Author: enrico
Date: Fri Dec 4 16:16:14 2015
New Revision: 254779
URL: http://llvm.org/viewvc/llvm-project?rev=254779&view=rev
Log:
Add a similar benchmark for our std::map performance
Added:
lldb/trunk/packages/Python/lldbsuite/test/benchmarks/libcxxmap/
lldb/trunk/packages/Python/lldb
Author: amccarth
Date: Fri Dec 4 16:22:15 2015
New Revision: 254780
URL: http://llvm.org/viewvc/llvm-project?rev=254780&view=rev
Log:
Implement GetMemoryRegionInfo for mini dumps.
Differential Revision: http://reviews.llvm.org/D15218
Modified:
lldb/trunk/source/Plugins/ObjectFile/PECOFF/Win
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254780: Implement GetMemoryRegionInfo for mini dumps.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15218?vs=41898&id=41940#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: enrico
Date: Fri Dec 4 16:25:52 2015
New Revision: 254781
URL: http://llvm.org/viewvc/llvm-project?rev=254781&view=rev
Log:
Do the same iterator caching optimization for std::map
This brings the timings down for 1500 elements from 166 to 2 seconds on my
machine - if I can math correctly
jingham added a comment.
The comments in llvm.org/pr18522 seem to me to be bugs that the test is
uncovering, not bugs in the test itself. It looks like we hit a breakpoint on
thread A, and try to run the condition on thread B. In some cases, thread B
isn't really alive yet, and so the attempt
Author: enrico
Date: Fri Dec 4 16:49:27 2015
New Revision: 254787
URL: http://llvm.org/viewvc/llvm-project?rev=254787&view=rev
Log:
Reduce memory traffic in ConstString in the std::map formatter
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxMap.cpp
Modified: lldb/trunk/source
Author: jingham
Date: Fri Dec 4 16:51:19 2015
New Revision: 254790
URL: http://llvm.org/viewvc/llvm-project?rev=254790&view=rev
Log:
Make it clear how you would get the pointee out of an SBValue with
GetType().IsPointerType() returns true.
Modified:
lldb/trunk/include/lldb/API/SBValue.h
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Anyway, adding a separate test is fine with me.
http://reviews.llvm.org/D15241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
Author: zturner
Date: Fri Dec 4 16:59:14 2015
New Revision: 254791
URL: http://llvm.org/viewvc/llvm-project?rev=254791&view=rev
Log:
Python 3 - Fix script import --allow-reload.
Differential Revision: http://reviews.llvm.org/D15209
Reviewed By: Todd Fiala
Modified:
lldb/trunk/source/Plugin
Author: zturner
Date: Fri Dec 4 16:59:41 2015
New Revision: 254792
URL: http://llvm.org/viewvc/llvm-project?rev=254792&view=rev
Log:
Make TestThreadSpecificBreakpoint.py more focused.
This test would fail before if conditional breakpoints weren't
working correctly, and the nature of the test (sp
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
52 matches
Mail list logo
