Re: [PATCH 05/27] arc: TCG instruction generator and hand-definitions

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +/* + * Function to add boiler plate code for conditional execution. + * It will add tcg_gen codes only if there is a condition to + * be checked (ctx->insn.cc != 0). + * Remember to pair it with gen_cc_epilogue(ctx) macro. + */ +static void ge

Re: [PATCH 06/27] arc: semfunc.c tcg code generator.

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: From: Cupertino Miranda TCG generator scripts for semfunc.c file. Signed-off-by: Cupertino Miranda --- My only comment here is: do we really want to re-write semfunc.c, as opposed to read one input file and output another? I presume that

Re: [PATCH 06/27] arc: semfunc.c tcg code generator.

2021-04-07 Thread Peter Maydell
On Wed, 7 Apr 2021 at 18:17, Richard Henderson wrote: > > On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: > > From: Cupertino Miranda > > > > TCG generator scripts for semfunc.c file. > > > > Signed-off-by: Cupertino Miranda > I don't know ruby at all, and don't really know how to evaluate t

Re: [PATCH 07/27] arc: TCG instruction definitions

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +void arc_gen_verifyCCFlag(const DisasCtxt *ctx, TCGv ret) Why "verify"? I don't see anything that verifies here... I'll note that this can be done better, if you expose the actual comparison rather than a simple boolean. This could remov

Re: [GIT PULL] ARC fixes for 5.12-rc7

2021-04-07 Thread pr-tracker-bot
The pull request you sent on Wed, 7 Apr 2021 20:15:54 +: > git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/ > tags/arc-5.12-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/454859c552da78b0f587205d308401922b56863e Thank you! -- Deet-doot-dot, I a

Re: [PATCH 14/27] arc: Add support for ARCv2

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: diff --git a/configure b/configure index 535e6a9269..80d993fac7 100755 --- a/configure +++ b/configure @@ -680,6 +680,8 @@ elif check_define __arm__ ; then cpu="arm" elif check_define __aarch64__ ; then cpu="aarch64" +elif check_defin

Re: [PATCH 15/27] tests/tcg: ARC: Add TCG instruction definition tests

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: From: Claudiu Zissulescu The added tests verify basic instructions execution as well as more advanced features such as zero overhead loops interrupt system, memory management unit and memory protection unit. Signed-off-by: Claudiu Zissulescu

Re: [PATCH 16/27] tests/acceptance: ARC: Add linux boot testing.

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: From: Cupertino Miranda Just an acceptance test with ARC Linux booting. Signed-off-by: Cupertino Miranda --- tests/acceptance/boot_linux_console.py | 55 ++ 1 file changed, 55 insertions(+) diff --git a/tests/acc

Re: [PATCH 18/27] arcv3: Decoder code

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: From: Cupertino Miranda --- disas/arc.c| 51 +- target/arc/decoder-v3.c| 1547 target/arc/decoder-v3.h| 322 target/arc/flags-v3.def| 103 +++ target/arc/oper

Re: [PATCH 20/27] arcv3: TCG, decoder glue code and helper changes

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +uint64_t helper_carry_add_flag32(uint64_t dest, uint64_t b, uint64_t c) { +return carry_add_flag(dest, b, c, 32); +} + +target_ulong helper_overflow_add_flag32(target_ulong dest, target_ulong b, target_ulong c) { +return overflow_add_

Re: [PATCH 21/27] arcv3: TCG instruction generator changes

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +if(ctx->insn.limm & 0x8000) + ctx->insn.limm += 0x; (1) bad braces, but (2) use an unconditional cast to int32_t. Qemu forces the compiler to use standard 2's compliment arithmetic. We don't have to go

Re: [PATCH 22/27] arcv3: TCG instruction definitions

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: From: Cupertino Miranda --- target/arc/semfunc-helper.c |13 + target/arc/semfunc-helper.h |31 + target/arc/semfunc-v3.c | 14653 ++ target/arc/semfunc-v3.h |55 + 4 files changed, 147

[GIT PULL] ARC fixes for 5.12-rc7

2021-04-07 Thread Vineet Gupta
Hi Linus, Please pull a few straggler fixes for ARC for 5.12 ! Thx, -Vineet --> The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/lin

Re: [PATCH 07/27] arc: TCG instruction definitions

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +/* + * ADD + *Variables: @b, @c, @a + *Functions: getCCFlag, getFFlag, setZFlag, setNFlag, setCFlag, CarryADD, + * setVFlag, OverflowADD + * --- code --- + * { + * cc_flag = getCCFlag (); + * lb = @b; + * lc = @c; +

Re: [PATCH] arcc/kernel/process: Few mundane typo fixes

2021-04-07 Thread Vineet Gupta
On 3/22/21 5:51 AM, Bhaskar Chowdhury wrote: > s/defintion/definition/ > s/succeded/succeeded/ > s/commiting/committing/ > s/interrutps/interrupts/ > > Signed-off-by: Bhaskar Chowdhury I've squashed all your 3 patches into one (no reason to break them out) and queued for 5.13. Thx, -Vineet > -

Re: [PATCH] arc/kernel/signal.c: Fix couple of typos

2021-04-07 Thread Vineet Gupta
On 3/23/21 10:52 PM, Bhaskar Chowdhury wrote: > s/unconditonally/unconditionally/ > s/gaurantees/guarantees/ > > Signed-off-by: Bhaskar Chowdhury And this one too. Thx, -Vineet > --- > arch/arc/kernel/signal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/