Re: [PR] Introduces IndexInput#updateReadAdvice to change the readadvice while [lucene]

2024-11-10 Thread via GitHub
shatejas commented on code in PR #13985: URL: https://github.com/apache/lucene/pull/13985#discussion_r1835999756 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -123,4 +123,11 @@ public abstract void search( public KnnVectorsReader getMergeInstan

Re: [PR] Introduces IndexInput#updateReadAdvice to change the readadvice while [lucene]

2024-11-10 Thread via GitHub
shatejas commented on code in PR #13985: URL: https://github.com/apache/lucene/pull/13985#discussion_r1835999858 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java: ## @@ -113,6 +114,25 @@ public Lucene99HnswVectorsReader(SegmentReadState st

Re: [PR] Introduces IndexInput#updateReadAdvice to change the readadvice while [lucene]

2024-11-10 Thread via GitHub
shatejas commented on code in PR #13985: URL: https://github.com/apache/lucene/pull/13985#discussion_r1836000686 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java: ## @@ -327,4 +336,61 @@ static FieldEntry create(IndexInput input, FieldInfo

Re: [PR] Introduces IndexInput#updateReadAdvice to change the readadvice while [lucene]

2024-11-10 Thread via GitHub
shatejas commented on code in PR #13985: URL: https://github.com/apache/lucene/pull/13985#discussion_r1835999756 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -123,4 +123,11 @@ public abstract void search( public KnnVectorsReader getMergeInstan

Re: [PR] Introduces IndexInput#updateReadAdvice to change the readadvice while [lucene]

2024-11-10 Thread via GitHub
shatejas commented on code in PR #13985: URL: https://github.com/apache/lucene/pull/13985#discussion_r1836001654 ## lucene/test-framework/src/java/org/apache/lucene/tests/store/BaseDirectoryTestCase.java: ## @@ -1554,6 +1555,42 @@ public void testPrefetchOnSlice() throws IOExcep

Re: [PR] Add a Better Binary Quantizer format for dense vectors [lucene]

2024-11-10 Thread via GitHub
ShashwatShivam commented on PR #13651: URL: https://github.com/apache/lucene/pull/13651#issuecomment-2466635037 Hey @benwtrent, Thank you for all your help so far! I have a question about the oversampling used to increase recall. From what I understand, it scales up the top-k and fanout

Re: [PR] Allow reading binary doc values as a RandomAccessInput [lucene]

2024-11-10 Thread via GitHub
github-actions[bot] commented on PR #13948: URL: https://github.com/apache/lucene/pull/13948#issuecomment-2467011723 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi