Re: [PR] Add IntervalsSource for range and regexp queries [lucene]

2024-07-14 Thread via GitHub
mayya-sharipova commented on code in PR #13562: URL: https://github.com/apache/lucene/pull/13562#discussion_r1677132919 ## lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java: ## @@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard

Re: [PR] Add IntervalsSource for range and regexp queries [lucene]

2024-07-14 Thread via GitHub
mayya-sharipova commented on code in PR #13562: URL: https://github.com/apache/lucene/pull/13562#discussion_r1677132855 ## lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java: ## @@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard

Re: [PR] Add IntervalsSource for range and regexp queries [lucene]

2024-07-14 Thread via GitHub
mayya-sharipova commented on PR #13562: URL: https://github.com/apache/lucene/pull/13562#issuecomment-2227356227 @romseygeek @dweiss Thank you for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add IntervalsSource for range and regexp queries [lucene]

2024-07-14 Thread via GitHub
mayya-sharipova merged PR #13562: URL: https://github.com/apache/lucene/pull/13562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[PR] Add RefCountedSharedArena [lucene]

2024-07-14 Thread via GitHub
ChrisHegarty opened a new pull request, #13570: URL: https://github.com/apache/lucene/pull/13570 This commit adds a ref counted shared arena to support aggregating segment filed into a single Arena. TODO: benchmark, and add better tests. -- This is an automated message from the Apa

Re: [PR] Group memory arenas by segment to reduce costly `Arena.close()` [lucene]

2024-07-14 Thread via GitHub
ChrisHegarty commented on PR #13555: URL: https://github.com/apache/lucene/pull/13555#issuecomment-2227465099 Hi, I don't have access to commit to this branch, so (sorry) I just created an alternative PR to sketch out an idea around a simplification of ref counting the arena. See #13570

[I] TestSnapshotDeletionPolicy#testMultiThreadedSnapshotting assertion failure [lucene]

2024-07-14 Thread via GitHub
aoli-al opened a new issue, #13571: URL: https://github.com/apache/lucene/issues/13571 ### Description I saw the following assertion failure when running TestSnapshotDeletionPolicy#testMultiThreadedSnapshotting ``` Caused by: java.lang.AssertionError: seqNo=9 vs maxSeqNo=8

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-14 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1677204200 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesFormat.java: ## @@ -194,5 +194,34 @@ public DocValuesProducer fieldsProducer(SegmentReadStat

Re: [PR] gh-12627: HnswGraphBuilder connects disconnected HNSW graph components [lucene]

2024-07-14 Thread via GitHub
msokolov commented on PR #13566: URL: https://github.com/apache/lucene/pull/13566#issuecomment-2227508427 I tried implementing a "strongly-connected" version of this thing. My implementation is super slow (makes indexing take way longer) and the result in terms of search metrics was about t