[PR] Fix english grammar error in Field that stores a per-document long values for scoring #13482 [lucene]

sakshichourasia4 opened a new pull request, #13490: URL: https://github.com/apache/lucene/pull/13490 ### Description Fixing English grammar errors. Changed line: from `Field that stores a per-document long values for scoring` to `Field that stores pe

Re: [PR] Minor cleanup in some Facet tests [lucene]

slow-J commented on code in PR #13489: URL: https://github.com/apache/lucene/pull/13489#discussion_r1640936281 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetValueSource.java: ## @@ -694,7 +694,7 @@ private void checkResults( "dim" +

Re: [PR] Minor cleanup in some Facet tests [lucene]

slow-J commented on PR #13489: URL: https://github.com/apache/lucene/pull/13489#issuecomment-2169232440 > > While I am already touching these, let me know if anyone has strong opinions and I can also fix the `Statement lambda can be replaced with expression lambda` or `Redundant array creat

Re: [PR] GITHUB#13175: Stop double-checking priority queue inserts [lucene]

slow-J commented on code in PR #13488: URL: https://github.com/apache/lucene/pull/13488#discussion_r1640951451 ## lucene/CHANGES.txt: ## @@ -273,6 +273,8 @@ Optimizations * GITHUB#13431: Replace TreeMap and use compiled Patterns in Japanese UserDictionary. (Bruno Roustant)

Re: [I] English grammar error in `Field that stores a per-document long values for scoring` [lucene]

sakshichourasia4 commented on issue #13482: URL: https://github.com/apache/lucene/issues/13482#issuecomment-2169245386 @cpoerschke @wurui90 I have raised the pull request to fix this issue, please have a look. https://github.com/apache/lucene/pull/13490 -- This is an automated message

Re: [I] Change behavior for finding segmentMerges from contains to finding IDs? [lucene]

ameyakarve closed issue #13477: Change behavior for finding segmentMerges from contains to finding IDs? URL: https://github.com/apache/lucene/issues/13477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Change behavior for finding segmentMerges from contains to finding IDs? [lucene]

ameyakarve commented on issue #13477: URL: https://github.com/apache/lucene/issues/13477#issuecomment-2169555732 Closing - this is probably not needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Update int array growth calls [lucene]

stefanvodita commented on PR #12947: URL: https://github.com/apache/lucene/pull/12947#issuecomment-2170405710 Thank you for the reviews on this forgotten PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Update int array growth calls [lucene]

stefanvodita merged PR #12947: URL: https://github.com/apache/lucene/pull/12947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] TaskExecutor should not fork unnecessarily [lucene]

original-brownbear commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2170618011 Lucene util benchmark results for this by running with one less thread for this branch vs main (credit to @jpountz and @javanna for the idea) to get an idea of the impact: