Re: [PR] LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict [lucene]

2023-12-16 Thread via GitHub
mocobeta commented on PR #772: URL: https://github.com/apache/lucene/pull/772#issuecomment-1858761902 @mikemccand I tried to backport this to branch_9x and found that we should handle many conflicts in both kuromoji and nori to cherry-pick this in 9x branch. I think it can be a daunting tas

[PR] Use growNoCopy in some places [lucene]

2023-12-16 Thread via GitHub
easyice opened a new pull request, #12951: URL: https://github.com/apache/lucene/pull/12951 Found some `grow` method can be change to `growNoCopy` when reading code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Use growNoCopy in some places [lucene]

2023-12-16 Thread via GitHub
dweiss commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1428895426 ## lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java: ## @@ -60,6 +60,13 @@ public void grow(int capacity) { ref.bytes = ArrayUtil.grow(ref.bytes, c

Re: [PR] Use growNoCopy in some places [lucene]

2023-12-16 Thread via GitHub
easyice commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1428978833 ## lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java: ## @@ -60,6 +60,13 @@ public void grow(int capacity) { ref.bytes = ArrayUtil.grow(ref.bytes,

[PR] Improve Javadoc for DocValuesConsumer [lucene]

2023-12-16 Thread via GitHub
easyice opened a new pull request, #12952: URL: https://github.com/apache/lucene/pull/12952 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u