shubhamvishu commented on code in PR #12799:
URL: https://github.com/apache/lucene/pull/12799#discussion_r1396959558
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswConcurrentMergeBuilder.java:
##
@@ -77,42 +75,17 @@ public OnHeapHnswGraph build(int maxOrd) throws IOExce
shubhamvishu commented on code in PR #12799:
URL: https://github.com/apache/lucene/pull/12799#discussion_r1396959558
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswConcurrentMergeBuilder.java:
##
@@ -77,42 +75,17 @@ public OnHeapHnswGraph build(int maxOrd) throws IOExce
mikemccand commented on PR #124:
URL: https://github.com/apache/lucene/pull/124#issuecomment-1816528624
OK thank you for bringing closure @ChristophKaser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
original-brownbear opened a new pull request, #12823:
URL: https://github.com/apache/lucene/pull/12823
This can be written in a much drier way that shouldn't come at any
performance cost as far as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the me
mikemccand commented on PR #12716:
URL: https://github.com/apache/lucene/pull/12716#issuecomment-1816539511
Thanks @shubhamvishu and @dweiss and @bruno-roustant. Hashing is fun and
hard :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Shibi-bala commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816600417
@uschindler hey, thanks for the approval! Read the contributing guidelines,
but not entirely sure how to get permissions to merge this PR.
--
This is an automated message from the A
uschindler commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816614768
You can't do it.
Please add a Changes entry unter the 9.9 section, commit it to branch and I
will merge and Backport your PR.
I am just away from my computer at moment, s
cpoerschke merged PR #448:
URL: https://github.com/apache/lucene/pull/448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
cpoerschke closed issue #11277: Update OpenNLP to 1.9.4 [LUCENE-10241]
URL: https://github.com/apache/lucene/issues/11277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
cpoerschke commented on issue #11277:
URL: https://github.com/apache/lucene/issues/11277#issuecomment-1816701100
#448 is the merged `main` branch pull request and
https://github.com/apache/lucene/commit/b8094d49aaf5e5cb5182c0307e25eafa2d332dda
is the `branch_9x` commit.
Thanks @jzont
kaivalnp commented on PR #12820:
URL: https://github.com/apache/lucene/pull/12820#issuecomment-1816720340
Thanks @jpountz! I realised something from your comment:
My current implementation has a flaw, because it cannot handle the
[`OrdinalTranslatedKnnCollector`](https://github.com/ka
MarcusSorealheis commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816799469
@Shibi-bala It's here:
https://github.com/apache/lucene/blob/c228e4bb66ca73c8150d8eaebe2bb999bcc6c9b1/lucene/CHANGES.txt#L147
You need to include your user and the
Shibi-bala commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816818775
Made the changes. Thanks @uschindler @MarcusSorealheis @msfroh 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
mikemccand merged PR #12530:
URL: https://github.com/apache/lucene/pull/12530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler merged PR #12626:
URL: https://github.com/apache/lucene/pull/12626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler closed issue #12637: segmentInfos.replace() doesn't set userData
URL: https://github.com/apache/lucene/issues/12637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mikemccand commented on issue #7820:
URL: https://github.com/apache/lucene/issues/7820#issuecomment-1816857195
I merged the first step in this issue -- detecting when this unique
snowflake form of corruption strikes.
Step 2 is to enable exorcism when there is an `_X.si` file missing,
jpountz commented on PR #12782:
URL: https://github.com/apache/lucene/pull/12782#issuecomment-1817146436
Thanks @easyice. I took some time to look into the benchmark and improve a
few things, hopefully you don't mind. Here is the output of the benchmark on my
machine now:
```
Benc
jpountz commented on code in PR #12782:
URL: https://github.com/apache/lucene/pull/12782#discussion_r1391047570
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/GroupVIntWriter.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
jpountz commented on PR #12819:
URL: https://github.com/apache/lucene/pull/12819#issuecomment-1817157857
Logging doesn't sound like a good fit for this, would it be better exposed
e.g. via the profiling query?
--
This is an automated message from the Apache Git Service.
To respond to the
jpountz commented on code in PR #12816:
URL: https://github.com/apache/lucene/pull/12816#discussion_r1397929325
##
lucene/misc/src/java/org/apache/lucene/misc/search/HumanReadableQuery.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
vigyasharma commented on code in PR #12794:
URL: https://github.com/apache/lucene/pull/12794#discussion_r1397994430
##
lucene/core/src/java/org/apache/lucene/search/TopKnnCollector.java:
##
@@ -26,26 +26,71 @@
* @lucene.experimental
*/
public final class TopKnnCollector ext
vigyasharma commented on PR #12794:
URL: https://github.com/apache/lucene/pull/12794#issuecomment-1817274998
We seem to consistently see an improvement in recall between single segment,
and multi-segment runs (both seq and conc.) on baseline. Is this because with
multiple segments, we get m
vigyasharma commented on PR #12794:
URL: https://github.com/apache/lucene/pull/12794#issuecomment-1817282807
Do you have a mental model on what kind of graphs would see minimal loss of
recall between baseline and candidate? Is this change better with denser
(higher fanout) graphs? Would it
slow-J commented on code in PR #12816:
URL: https://github.com/apache/lucene/pull/12816#discussion_r1398045523
##
lucene/misc/src/test/org/apache/lucene/misc/search/TestHumanReadableQuery.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
slow-J commented on PR #12816:
URL: https://github.com/apache/lucene/pull/12816#issuecomment-1817340280
> I left minor comments but it looks good to me otherwise!
Thanks for the feedback! Done the changes.
--
This is an automated message from the Apache Git Service.
To respond to th
jpountz commented on PR #12821:
URL: https://github.com/apache/lucene/pull/12821#issuecomment-1817419020
Thanks for doing it, it looks like the PR includes unintended changes though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jpountz merged PR #12815:
URL: https://github.com/apache/lucene/pull/12815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #12816:
URL: https://github.com/apache/lucene/pull/12816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz closed issue #12487: Can/should `KnnByte/FloatVectorQuery` carry some
human-meaningful opaque `toString` fragment?
URL: https://github.com/apache/lucene/issues/12487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
30 matches
Mail list logo
