[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12548: Ability to compute vector similarity scores with DoubleValuesSource

2023-10-01 Thread via GitHub
shubhamvishu commented on code in PR #12548: URL: https://github.com/apache/lucene/pull/12548#discussion_r1342112409 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12548: Ability to compute vector similarity scores with DoubleValuesSource

2023-10-01 Thread via GitHub
shubhamvishu commented on code in PR #12548: URL: https://github.com/apache/lucene/pull/12548#discussion_r1342112773 ## lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java: ## @@ -172,6 +173,40 @@ public LongValuesSource rewrite(IndexSearcher searcher) throws

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12548: Ability to compute vector similarity scores with DoubleValuesSource

2023-10-01 Thread via GitHub
shubhamvishu commented on code in PR #12548: URL: https://github.com/apache/lucene/pull/12548#discussion_r1342112910 ## lucene/core/src/java/org/apache/lucene/search/FloatVectorSimilarityValuesSource.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12548: Ability to compute vector similarity scores with DoubleValuesSource

2023-10-01 Thread via GitHub
shubhamvishu commented on code in PR #12548: URL: https://github.com/apache/lucene/pull/12548#discussion_r1342113181 ## lucene/core/src/test/org/apache/lucene/search/TestVectorSimilarityValuesSource.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] uschindler opened a new pull request, #12612: Upgrade forbiddenapis to 3.6 and ASM for APIJAR extraction to 9.6

2023-10-01 Thread via GitHub
uschindler opened a new pull request, #12612: URL: https://github.com/apache/lucene/pull/12612 the usual maintenance. Allows us to process Java 22 APIs soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [lucene] uschindler commented on pull request #12612: Upgrade forbiddenapis to 3.6 and ASM for APIJAR extraction to 9.6

2023-10-01 Thread via GitHub
uschindler commented on PR #12612: URL: https://github.com/apache/lucene/pull/12612#issuecomment-1742097851 I regenerated the APIJAR files, it worked without problems out of box. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] uschindler merged pull request #12612: Upgrade forbiddenapis to 3.6 and ASM for APIJAR extraction to 9.6

2023-10-01 Thread via GitHub
uschindler merged PR #12612: URL: https://github.com/apache/lucene/pull/12612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] dweiss commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

2023-10-01 Thread via GitHub
dweiss commented on PR #11724: URL: https://github.com/apache/lucene/pull/11724#issuecomment-1742195597 I will take a look tomorrow - was out of office last week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] dweiss merged pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

2023-10-01 Thread via GitHub
dweiss merged PR #11724: URL: https://github.com/apache/lucene/pull/11724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] dweiss closed issue #11556: HTMLStripCharFilter fails on '>' or '<' characters in attribute values [LUCENE-10520]

2023-10-01 Thread via GitHub
dweiss closed issue #11556: HTMLStripCharFilter fails on '>' or '<' characters in attribute values [LUCENE-10520] URL: https://github.com/apache/lucene/issues/11556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL