risdenk commented on PR #12266:
URL: https://github.com/apache/lucene/pull/12266#issuecomment-1545691179
Is it possible that all the build logic can be simplified like the other
plugins and not be in `settings.gradle`? See `build.gradle` and
`gradle/validation/*.gradle` files.
--
This is
uschindler commented on PR #12286:
URL: https://github.com/apache/lucene/pull/12286#issuecomment-1545694199
> Use ArrayDeque instead of java.util.Stack (synchronized methods)?
We should but this on forbiddenapis.
--
This is an automated message from the Apache Git Service.
To respon
uschindler commented on code in PR #12286:
URL: https://github.com/apache/lucene/pull/12286#discussion_r1192326625
##
lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java:
##
@@ -39,6 +39,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
benwtrent merged PR #12197:
URL: https://github.com/apache/lucene/pull/12197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
tang-hi commented on code in PR #12286:
URL: https://github.com/apache/lucene/pull/12286#discussion_r1192435347
##
lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java:
##
@@ -1284,7 +1290,7 @@ public static int[] topoSortStates(Automaton a) {
int numStates
tang-hi commented on code in PR #12286:
URL: https://github.com/apache/lucene/pull/12286#discussion_r1192435950
##
lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java:
##
@@ -39,6 +39,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
+i
tang-hi commented on PR #12286:
URL: https://github.com/apache/lucene/pull/12286#issuecomment-1545825629
@rmuir I have added a unit test to evaluate the toposort functionality. I
developed a method that generates a random automaton, and you can include a
cycle by passing the hasCycle argume
benwtrent opened a new pull request, #12288:
URL: https://github.com/apache/lucene/pull/12288
Backport of #12160
---
### Description
Issue #11862
### Solution
`AbstractKnnVectorQuery` currently performs HNSW searches
benwtrent merged PR #12288:
URL: https://github.com/apache/lucene/pull/12288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on PR #12288:
URL: https://github.com/apache/lucene/pull/12288#issuecomment-1545889373
//cc @zhaih && @kaivalnp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
benwtrent closed issue #11862: Concurrent rewrite for KnnVectorQuery
URL: https://github.com/apache/lucene/issues/11862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
benwtrent commented on issue #11862:
URL: https://github.com/apache/lucene/issues/11862#issuecomment-1545890266
Merged and backported for a future Lucene release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
benwtrent closed issue #11838: Adding concurrency to query rewrite?
URL: https://github.com/apache/lucene/issues/11838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
benwtrent commented on issue #11838:
URL: https://github.com/apache/lucene/issues/11838#issuecomment-1545891005
Merged and backported for a future Lucene release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
benwtrent commented on PR #12235:
URL: https://github.com/apache/lucene/pull/12235#issuecomment-1546025921
@zhaih I verified your change doesn't hurt recall. Is this change good to
continue working on? I tried replicating your performance improvements, but did
not see that big of a change.
gsmiller opened a new pull request, #12289:
URL: https://github.com/apache/lucene/pull/12289
### Description
Right now, `FilterTerms#intersect` is picking up the default implementation
from `Terms`, which hides any custom implementation provided by the wrapped
`Terms` instance. This
gsmiller commented on PR #12289:
URL: https://github.com/apache/lucene/pull/12289#issuecomment-1546288958
Note that `testOverrideMethods` is failing right now. I can update this
test, but I wonder if there's a good reason we wouldn't want to make the change
proposed here? Seems like we shou
gsmiller commented on issue #12276:
URL: https://github.com/apache/lucene/issues/12276#issuecomment-1546298721
+1 to `StringsToAutomaton` language. I'd suggest keeping "Builder" in the
name.
In general, also +1 to renaming. The algorithm doesn't have to only be
applied to strings (e.
gsmiller commented on issue #11547:
URL: https://github.com/apache/lucene/issues/11547#issuecomment-1546327008
@stefanvodita it's been a while since I looked at this, and @LuXugang had
the idea originally so he's really best positioned to clarify, but since you
haven't gotten a response yet
stefanvodita commented on issue #11547:
URL: https://github.com/apache/lucene/issues/11547#issuecomment-1546370839
Thanks @gsmiller! Your explanation makes perfect sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
zhaih commented on PR #12235:
URL: https://github.com/apache/lucene/pull/12235#issuecomment-1546537128
@benwtrent I was originally waiting for
https://github.com/apache/lucene/pull/12246 to be merged first so that this PR
won't break their test, but seems that one is blocked somehow by othe
zhaih commented on PR #12257:
URL: https://github.com/apache/lucene/pull/12257#issuecomment-1546540855
> would be ok for you to try to get involved in the other contribution,
trying to align your intent with the guy in there?
I'll for sure trying to review that PR, but that one is try
kaivalnp commented on PR #12288:
URL: https://github.com/apache/lucene/pull/12288#issuecomment-1546547247
Thank you for following up on this @benwtrent! Much appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
23 matches
Mail list logo
