dweiss commented on issue #11925:
URL: https://github.com/apache/lucene/issues/11925#issuecomment-1312666964
I think you want to pass a jvm configuring flag to javac, assuming
JavaCompile is in fork mode (which is always the case in Lucene). errorprone
hacks into javac, so I think it'll wor
uschindler commented on code in PR #11923:
URL: https://github.com/apache/lucene/pull/11923#discussion_r1020891869
##
lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java:
##
@@ -414,7 +414,7 @@ private void rehash(final int newSize, boolean hashOnData) {
}
rmuir commented on code in PR #11923:
URL: https://github.com/apache/lucene/pull/11923#discussion_r1020892411
##
lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java:
##
@@ -414,7 +414,7 @@ private void rehash(final int newSize, boolean hashOnData) {
}
hashM
rmuir commented on PR #11923:
URL: https://github.com/apache/lucene/pull/11923#issuecomment-1312717162
just hash out how you want the style of the bytesrefhash code to be as we
are going back and forth here.
a little sad as i thought spotless was the end of the java style bikesheds :
uschindler commented on PR #11923:
URL: https://github.com/apache/lucene/pull/11923#issuecomment-1312717445
@rmuir just some question about cases like `merge.estimatedMergeBytes / 1024
/ 1024.` changed to `merge.estimatedMergeBytes / 1024. / 1024.`:
Were they also found by this check or d
uschindler commented on PR #11923:
URL: https://github.com/apache/lucene/pull/11923#issuecomment-1312717771
All fine! I vote: merge this ASAP :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
uschindler commented on PR #11923:
URL: https://github.com/apache/lucene/pull/11923#issuecomment-1312718213
> @rmuir just some question about cases like `merge.estimatedMergeBytes /
1024 / 1024.` changed to `merge.estimatedMergeBytes / 1024. / 1024.`: Were they
also found by this check or d
uschindler opened a new pull request, #11926:
URL: https://github.com/apache/lucene/pull/11926
This improves the test a bit, especially regarding this code (and I'm glad:
code is fine):
-
https://github.com/apache/lucene/blob/98b26e0885dcc4dc0b7a085f5d23d5099d59808a/lucene/core/src/java/
uschindler merged PR #11926:
URL: https://github.com/apache/lucene/pull/11926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
dweiss commented on issue #11925:
URL: https://github.com/apache/lucene/issues/11925#issuecomment-1312774179
I think this is what you wanted, @rmuir
https://github.com/apache/lucene/pull/11927
This tweaks jvm options of every javac task. I think the slowdown you're
observing is no
rmuir commented on PR #11927:
URL: https://github.com/apache/lucene/pull/11927#issuecomment-1312774986
I will try it out. I tried something similar to this... maybe exactly
this... but when i inspected the forked processes for error-prone with `ps`
they weren't actually getting the flags.
dweiss commented on PR #11927:
URL: https://github.com/apache/lucene/pull/11927#issuecomment-1312798750
I can see jvm flags being dumped if I add ```-XX:+PrintFlagsFinal``` to this
patch (and either force the fork mode or run with an alt. jvm, which has the
same side-effect).
--
This is
mdmarshmallow commented on issue #11868:
URL: https://github.com/apache/lucene/issues/11868#issuecomment-1312954877
Sounds good, I just started working on this and will make sure to add
`FilterIndexInput` as well.
--
This is an automated message from the Apache Git Service.
To respond to
13 matches
Mail list logo
