[GitHub] [lucene] vsop-479 commented on pull request #11888: [Fix] Binary search the entries when all suffixes have the same length in a leaf block.

2022-11-12 Thread GitBox
vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1312467537 @jpountz I moved the test case for this bug to TestLucene90PostingsFormat. Please have a check. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene] rmuir opened a new issue, #11924: gradle build uses excessive resources on multi-core machine

2022-11-12 Thread GitBox
rmuir opened a new issue, #11924: URL: https://github.com/apache/lucene/issues/11924 ### Description on e.g. an 8-core machine, gradle might spin up 4 jvms by default. but each jvm is ergonomically sized for an 8-core machine. so you get `8 * 4 = 32` "threads" or whatever it may be.

[GitHub] [lucene] rmuir commented on issue #11924: gradle build uses excessive resources on multi-core machine

2022-11-12 Thread GitBox
rmuir commented on issue #11924: URL: https://github.com/apache/lucene/issues/11924#issuecomment-1312478615 Basically this behavior grows `O(n)^2` where n is the number of cpus. The more you have, the more this is slowing you down. -- This is an automated message from the Apache Git Servi

[GitHub] [lucene] rmuir commented on issue #11924: gradle build uses excessive resources on multi-core machine

2022-11-12 Thread GitBox
rmuir commented on issue #11924: URL: https://github.com/apache/lucene/issues/11924#issuecomment-1312479438 one important thing when passing this flag, is to also configure the GC too, else you get serialgc on a 1-cpu jvm. But we should always be setting the JVM anyway (to ParallelGC) for b

[GitHub] [lucene] rmuir opened a new issue, #11925: error-prone's JVM arguments need help

2022-11-12 Thread GitBox
rmuir opened a new issue, #11925: URL: https://github.com/apache/lucene/issues/11925 ### Description error-prone runs extremely slowly because on an N-core computer, it spins up N/2 jvms, each one ergonomically sized for N as far as compiler threads etc. And it uselessly enables C2 c

[GitHub] [lucene] madrob commented on issue #11924: gradle build uses excessive resources on multi-core machine

2022-11-12 Thread GitBox
madrob commented on issue #11924: URL: https://github.com/apache/lucene/issues/11924#issuecomment-1312491533 That's a super interesting observation, do you think we should also report it to gradle? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene] dweiss commented on issue #11924: gradle build uses excessive resources on multi-core machine

2022-11-12 Thread GitBox
dweiss commented on issue #11924: URL: https://github.com/apache/lucene/issues/11924#issuecomment-1312502293 Depends what all those threads are doing... For I/O bound jobs they're idle most of the time. But I agree it's wasteful, it's fine to change the defaults. -- This is an automated m

[GitHub] [lucene] rmuir commented on issue #11925: error-prone's JVM arguments need help

2022-11-12 Thread GitBox
rmuir commented on issue #11925: URL: https://github.com/apache/lucene/issues/11925#issuecomment-1312638502 I stared at https://github.com/tbroyer/gradle-errorprone-plugin/blob/main/src/main/kotlin/net/ltgt/gradle/errorprone/ErrorPronePlugin.kt but I couldnt figure out yet how to tweak this

[GitHub] [lucene] rmuir commented on issue #11924: gradle build uses excessive resources on multi-core machine

2022-11-12 Thread GitBox
rmuir commented on issue #11924: URL: https://github.com/apache/lucene/issues/11924#issuecomment-1312640064 Yes, for background I think the flag was added with docker usages in mind: https://bugs.openjdk.org/browse/JDK-8189497 But the idea is the same here. Since we're making the buil

[GitHub] [lucene] rmuir commented on pull request #11923: enable error-prone "narrow calculation" check

2022-11-12 Thread GitBox
rmuir commented on PR #11923: URL: https://github.com/apache/lucene/pull/11923#issuecomment-1312641592 @uschindler @risdenk if you want to take another pass, it would be helpful. I don't want to introduce new risks here with this change. -- This is an automated message from the Apache Git