[GitHub] [lucene] dweiss merged pull request #11856: Fix nanos to millis conversion for tests

2022-10-29 Thread GitBox
dweiss merged PR #11856: URL: https://github.com/apache/lucene/pull/11856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] uschindler commented on pull request #11889: Allow building with java 18 now that gradle supports it

2022-10-29 Thread GitBox
uschindler commented on PR #11889: URL: https://github.com/apache/lucene/pull/11889#issuecomment-1295789651 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [lucene] rmuir commented on pull request #874: LUCENE-10471 Increse max dims for vectors to 2048

2022-10-29 Thread GitBox
rmuir commented on PR #874: URL: https://github.com/apache/lucene/pull/874#issuecomment-1295819265 i dont agree, I think the problems are flaws with the HNSW and can't be worked around. Its too slow already at 768 and in fact the current limit overpromises and underdelivers by allowing you

[GitHub] [lucene] uschindler commented on pull request #874: LUCENE-10471 Increse max dims for vectors to 2048

2022-10-29 Thread GitBox
uschindler commented on PR #874: URL: https://github.com/apache/lucene/pull/874#issuecomment-1295866157 Please don't do this. If somebody is not able to reduce the number of dimensions before indxing the stuff heshe should also not use vector search at all because it will just produce huge

[GitHub] [lucene] MarcusSorealheis commented on pull request #874: LUCENE-10471 Increse max dims for vectors to 2048

2022-10-29 Thread GitBox
MarcusSorealheis commented on PR #874: URL: https://github.com/apache/lucene/pull/874#issuecomment-1295871431 Neither of you are wrong. In this case, we have a world of people excited about a new thing, willing to take actions that go against science because vendors have told them it is rig