[GitHub] [lucene] rmuir commented on pull request #874: LUCENE-10471 Increse max dims for vectors to 2048

2022-10-21 Thread GitBox
rmuir commented on PR #874: URL: https://github.com/apache/lucene/pull/874#issuecomment-1286914129 the performance with e.g. 768 is incredibly painful. hours and hours to index just 1M documents. Already doesn't scale with the current limit! -- This is an automated message from the Apach

[GitHub] [lucene-solr] risdenk commented on pull request #1728: SOLR-14596: equals/hashCode for common SolrRequest classes

2022-10-21 Thread GitBox
risdenk commented on PR #1728: URL: https://github.com/apache/lucene-solr/pull/1728#issuecomment-1287203950 @gerlowskija is this still valid? It looks like it might be modulo some merge conflicts in main. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] risdenk commented on pull request #2206: BlobDirectoryFactory correctly deletes directories in the blob store

2022-10-21 Thread GitBox
risdenk commented on PR #2206: URL: https://github.com/apache/lucene-solr/pull/2206#issuecomment-1287219142 @bruno-roustant / @dsmiley is this still valid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] risdenk commented on pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shared file syste

2022-10-21 Thread GitBox
risdenk commented on PR #2137: URL: https://github.com/apache/lucene-solr/pull/2137#issuecomment-1287219774 This is most likely still valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene-solr] epugh commented on pull request #802: SOLR-13626: document the SystemInfoHandler

2022-10-21 Thread GitBox
epugh commented on PR #802: URL: https://github.com/apache/lucene-solr/pull/802#issuecomment-1287316769 This has been replaced by https://github.com/apache/solr/pull/1104. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene-solr] epugh closed pull request #802: SOLR-13626: document the SystemInfoHandler

2022-10-21 Thread GitBox
epugh closed pull request #802: SOLR-13626: document the SystemInfoHandler URL: https://github.com/apache/lucene-solr/pull/802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [lucene-solr] risdenk commented on a diff in pull request #116: SOLR-9775 fixed NPEs

2022-10-21 Thread GitBox
risdenk commented on code in PR #116: URL: https://github.com/apache/lucene-solr/pull/116#discussion_r1002129826 ## solr/core/src/java/org/apache/solr/search/QueryResultKey.java: ## @@ -49,12 +49,14 @@ public QueryResultKey(Query query, List filters, Sort sort, int nc_flags)

[GitHub] [lucene] mdmarshmallow opened a new issue, #11869: Add RangeOnRangeFacetCounts

2022-10-21 Thread GitBox
mdmarshmallow opened a new issue, #11869: URL: https://github.com/apache/lucene/issues/11869 ### Description We currently have `LongRangeFacetCounts` and `DoubleRangeFacetCounts`, which counts facets based on doc values points that fall into a given list of range. It would be nice to

[GitHub] [lucene] mdmarshmallow commented on issue #11869: Add RangeOnRangeFacetCounts

2022-10-21 Thread GitBox
mdmarshmallow commented on issue #11869: URL: https://github.com/apache/lucene/issues/11869#issuecomment-1287402896 I plan on working on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-solr] epugh closed pull request #116: SOLR-9775 fixed NPEs

2022-10-21 Thread GitBox
epugh closed pull request #116: SOLR-9775 fixed NPEs URL: https://github.com/apache/lucene-solr/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-solr] epugh commented on pull request #116: SOLR-9775 fixed NPEs

2022-10-21 Thread GitBox
epugh commented on PR #116: URL: https://github.com/apache/lucene-solr/pull/116#issuecomment-1287413360 See https://github.com/apache/solr/pull/1107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] gezapeti commented on pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shared file syst

2022-10-21 Thread GitBox
gezapeti commented on PR #2137: URL: https://github.com/apache/lucene-solr/pull/2137#issuecomment-1287434191 I'll create a PR for the solr repo instead of this one. Should I create a PR for Solr 8 as well? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [lucene-solr] gezapeti commented on pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shared file syst

2022-10-21 Thread GitBox
gezapeti commented on PR #2137: URL: https://github.com/apache/lucene-solr/pull/2137#issuecomment-1287484266 Ohh, Solr 8x is not maintained anymore. I've filed against main https://github.com/apache/solr/pull/1108 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] gezapeti closed pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shared file systems li

2022-10-21 Thread GitBox
gezapeti closed pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shared file systems like HDFS URL: https://github.com/apache/lucene-solr/pull/2137 -- This is an automated message from the Apache Git Se

[GitHub] [lucene] mikemccand commented on a diff in pull request #11867: Add monster test that indexes 1M vectors

2022-10-21 Thread GitBox
mikemccand commented on code in PR #11867: URL: https://github.com/apache/lucene/pull/11867#discussion_r1001623486 ## lucene/core/src/test/org/apache/lucene/document/TestManyKnnVectors.java: ## @@ -61,11 +61,13 @@ @Monster("takes ~2 hours and needs 2GB heap") public class Test

[GitHub] [lucene] mikemccand commented on pull request #11815: Support deletions in rearrange (#11814)

2022-10-21 Thread GitBox
mikemccand commented on PR #11815: URL: https://github.com/apache/lucene/pull/11815#issuecomment-1286757349 > This change is technically not backwards compatible. Not just because of changes to the rearrange API, but also because now we no longer make the deletes disappear from the rearrang

[GitHub] [lucene] mikemccand commented on pull request #11815: Support deletions in rearrange (#11814)

2022-10-21 Thread GitBox
mikemccand commented on PR #11815: URL: https://github.com/apache/lucene/pull/11815#issuecomment-1286765622 What happens if the delete selector deletes 100% of the documents in a segment? `IndexWriter` would normally drop such segments ... does it do so in this case too? Indeed, `te

[GitHub] [lucene] mikemccand commented on a diff in pull request #11815: Support deletions in rearrange (#11814)

2022-10-21 Thread GitBox
mikemccand commented on code in PR #11815: URL: https://github.com/apache/lucene/pull/11815#discussion_r1001630980 ## lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java: ## @@ -139,6 +203,47 @@ private static void addOneSegment( writer.addIndexes(readers