navneet1v commented on PR #11753:
URL: https://github.com/apache/lucene/pull/11753#issuecomment-1273640714
@nknize can I get a review on this PR, its been open for a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
gsmiller commented on code in PR #11832:
URL: https://github.com/apache/lucene/pull/11832#discussion_r991658811
##
lucene/core/src/java/org/apache/lucene/index/VectorValues.java:
##
@@ -35,6 +35,27 @@ public abstract class VectorValues extends DocIdSetIterator {
/** Sole cons
gsmiller commented on code in PR #11832:
URL: https://github.com/apache/lucene/pull/11832#discussion_r991658811
##
lucene/core/src/java/org/apache/lucene/index/VectorValues.java:
##
@@ -35,6 +35,27 @@ public abstract class VectorValues extends DocIdSetIterator {
/** Sole cons
gsmiller commented on code in PR #11832:
URL: https://github.com/apache/lucene/pull/11832#discussion_r991658811
##
lucene/core/src/java/org/apache/lucene/index/VectorValues.java:
##
@@ -35,6 +35,27 @@ public abstract class VectorValues extends DocIdSetIterator {
/** Sole cons
gsmiller commented on PR #11832:
URL: https://github.com/apache/lucene/pull/11832#issuecomment-1273864084
> but the EMPTY vectors instance also returns 0 for the dimension() method,
which is something I could see some code paths to complain about if they end up
seeing different values for t
jpountz commented on PR #11753:
URL: https://github.com/apache/lucene/pull/11753#issuecomment-1274149163
I was hoping to get @nknize 's feedback on this since he's been closer to
this work, but the API looks ok to me this way.
--
This is an automated message from the Apache Git Service.
T
