[GitHub] [lucene] jpountz commented on pull request #1068: LUCENE-10674: Update subiterators when BitSetConjDISI exhausts

2022-09-09 Thread GitBox
jpountz commented on PR #1068: URL: https://github.com/apache/lucene/pull/1068#issuecomment-1241631941 Thank you for your comments, I think I understand the bug now. I think a better description of the bug is that `BitSetConjunctionDISI#docID()` doesn't honor its contract that it must retur

[GitHub] [lucene] jpountz commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D

2022-09-09 Thread GitBox
jpountz commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1241643263 I had missed that the constructor was not publicly available. Am I guessing correctly that your goal is to create custom collectors that work with shapes? Maybe we should make the ctor t

[GitHub] [lucene] jpountz commented on pull request #11741: DRAFT: Experiment with intersecting TermInSetQuery terms up-front to better estimate cost

2022-09-09 Thread GitBox
jpountz commented on PR #11741: URL: https://github.com/apache/lucene/pull/11741#issuecomment-1241681411 > If we assume a scenario where we have a TermInSetQuery over very selective terms (low docFreqs for each), we'd want to use the index query unless there's another clause that can lead t

[GitHub] [lucene] romseygeek opened a new issue, #11759: IntervalBuilder.NO_INTERVALS returns wrong docId when unpositioned

2022-09-09 Thread GitBox
romseygeek opened a new issue, #11759: URL: https://github.com/apache/lucene/issues/11759 ### Description DocIdSetIterators should return -1 when they are unpositioned, but IntervalBuilder.NO_INTERVALS always returns NO_MORE_DOCS. This can lead to exceptions when an empty inter

[GitHub] [lucene] nknize commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D

2022-09-09 Thread GitBox
nknize commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1242048944 > Maybe we should make the ctor that takes a `BytesRef` public for such use-cases? We can either make the `LatLonShapeDocValues` and `XYShapeDocValues` ctor public, or add new fact

[GitHub] [lucene] romseygeek opened a new pull request, #11760: Fix IntervalBuilder.NO_INTERVALS docId when unpositioned

2022-09-09 Thread GitBox
romseygeek opened a new pull request, #11760: URL: https://github.com/apache/lucene/pull/11760 IntervalBuilder.NO_INTERVALS should return -1 when unpositioned, not NO_MORE_DOCS. This can trigger exceptions when an empty intervalquery is combined in a conjunction. Fixes #11759

[GitHub] [lucene] jpountz commented on pull request #11729: LUCENE-11728: Improve code clarity for OrdinalMap

2022-09-09 Thread GitBox
jpountz commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1242116139 This class is indeed a bit subtle, but most of the comments that you are suggesting seem to be paraphrasing what the code is doing and I'm not sure that they would actually help someone

[GitHub] [lucene] romseygeek merged pull request #11760: Fix IntervalBuilder.NO_INTERVALS docId when unpositioned

2022-09-09 Thread GitBox
romseygeek merged PR #11760: URL: https://github.com/apache/lucene/pull/11760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] romseygeek closed issue #11759: IntervalBuilder.NO_INTERVALS returns wrong docId when unpositioned

2022-09-09 Thread GitBox
romseygeek closed issue #11759: IntervalBuilder.NO_INTERVALS returns wrong docId when unpositioned URL: https://github.com/apache/lucene/issues/11759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] mdmarshmallow commented on pull request #11729: LUCENE-11728: Improve code clarity for OrdinalMap

2022-09-09 Thread GitBox
mdmarshmallow commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1242374535 That's fair, I think I also was getting a little too specific with the comments in some places. I'll go through and see if I can make the comments more general than they currently

[GitHub] [lucene] navneet1v commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D

2022-09-09 Thread GitBox
navneet1v commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1242385721 > > Maybe we should make the ctor that takes a `BytesRef` public for such use-cases? > > We can either make the `LatLonShapeDocValues` and `XYShapeDocValues` ctor public, or add

[GitHub] [lucene] gsmiller commented on pull request #11741: DRAFT: Experiment with intersecting TermInSetQuery terms up-front to better estimate cost

2022-09-09 Thread GitBox
gsmiller commented on PR #11741: URL: https://github.com/apache/lucene/pull/11741#issuecomment-1242553881 > I'm not sure if this is true. I've seen users run TermInSetQuerys with 10k terms or more, a typical use-case being implementing some form of join where a first query collects IDs of i

[GitHub] [lucene] mdmarshmallow opened a new issue, #11761: Expand TieredMergePolicy deletePctAllowed limits

2022-09-09 Thread GitBox
mdmarshmallow opened a new issue, #11761: URL: https://github.com/apache/lucene/issues/11761 ### Description I'm an engineer at Amazon Search and we have been experimenting with more aggressively getting rid of deleted documents. We use TieredMergePolicy and we would like to set `Tie