gf2121 commented on PR #831:
URL: https://github.com/apache/lucene/pull/831#issuecomment-1107810870
Benchmark result looks good, I'll merge.
https://home.apache.org/~mikemccand/lucenebench/2022.04.23.18.02.58.html
--
This is an automated message from the Apache Git Service.
To resp
gf2121 merged PR #831:
URL: https://github.com/apache/lucene/pull/831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527143#comment-17527143
]
ASF subversion and git services commented on LUCENE-10315:
--
Co
epugh commented on PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#issuecomment-1107839649
I was trying to figure out why I couldn't find this PR, and realized that
this is against the `lucene-solr` repo... Not the new `solr` repo. I'm
going to copy the code over and se
madrob commented on code in PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#discussion_r857126726
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2503,7 +2503,8 @@ public static int
persistConfigResourceToZooKeeper(ZkSolrResourceLoader zkLoa
epugh commented on code in PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#discussion_r857128799
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2503,7 +2503,8 @@ public static int
persistConfigResourceToZooKeeper(ZkSolrResourceLoader zkLoad
madrob commented on code in PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#discussion_r857132730
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2503,7 +2503,8 @@ public static int
persistConfigResourceToZooKeeper(ZkSolrResourceLoader zkLoa
rmuir commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1107875110
`./gradlew check` still fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gautamworah96 commented on PR #829:
URL: https://github.com/apache/lucene/pull/829#issuecomment-1108049460
I've added a new revision that adds some more functionality, caught some bad
edge cases and beasted the test for 2000 iters on a Mac. Only when I ran
`./gradlew check` finally did I re
rmuir commented on PR #829:
URL: https://github.com/apache/lucene/pull/829#issuecomment-1108062297
i think we should avoid doing case-insensitivity here. maybe for another PR?
I'd like to avoid listing tons of files as a side effect of Path resolve
operations, it is many extra i/os.
gautamworah96 commented on PR #829:
URL: https://github.com/apache/lucene/pull/829#issuecomment-1108069323
> I'd like to avoid listing tons of files as a side effect of Path resolve
operations, it is many extra i/os.
Yes I was concerned about this as well (probably need a cache here).
gautamworah96 commented on code in PR #829:
URL: https://github.com/apache/lucene/pull/829#discussion_r857252262
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterPath.java:
##
@@ -270,7 +270,7 @@ public static Path unwrap(Path path) {
return Unwrappa
gautamworah96 commented on code in PR #829:
URL: https://github.com/apache/lucene/pull/829#discussion_r857255977
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsPath.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
gautamworah96 commented on code in PR #829:
URL: https://github.com/apache/lucene/pull/829#discussion_r857259974
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsPath.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
zacharymorn opened a new pull request, #833:
URL: https://github.com/apache/lucene/pull/833
# Description / Solution
Add NN vectors support to ExitableDirectoryReader
# Tests
* Added new test
* Passed existing tests
# Checklist
Please review the following
[
https://issues.apache.org/jira/browse/LUCENE-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527308#comment-17527308
]
Zach Chen commented on LUCENE-10411:
Hi [~jpountz] , I have created a PR for this.
[
https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen reassigned LUCENE-10436:
--
Assignee: Zach Chen
> Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and
> KnnVec
[
https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen resolved LUCENE-10436.
Resolution: Done
> Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and
> KnnVectorField
18 matches
Mail list logo
