[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523347#comment-17523347 ] Michael McCandless commented on LUCENE-10482: - Thanks [~gworah] -- can we r

[GitHub] [lucene] mikemccand commented on a diff in pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

mikemccand commented on code in PR #805: URL: https://github.com/apache/lucene/pull/805#discussion_r851776382 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/ViterbiNBest.java: ## @@ -0,0 +1,1253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

mayya-sharipova commented on code in PR #792: URL: https://github.com/apache/lucene/pull/792#discussion_r851785737 ## lucene/core/src/java/org/apache/lucene/codecs/lucene92/Lucene92HnswVectorsWriter.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] mayya-sharipova commented on pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

mayya-sharipova commented on PR #792: URL: https://github.com/apache/lucene/pull/792#issuecomment-1100923586 @LuXugang as per @jtibshirani' [comment](https://github.com/apache/lucene/pull/792#pullrequestreview-940285463) , the main factor for deciding if we can use `DirectMonotonicWriter/R

[GitHub] [lucene] uschindler commented on pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

uschindler commented on PR #762: URL: https://github.com/apache/lucene/pull/762#issuecomment-1100941707 Hi, since this commit all Jenkins WIndows builds fail with this error: ``` FAILED: org.apache.lucene.facet.taxonomy.directory.TestAlwaysRefreshDirectoryTaxonomyReader.testAlw

[GitHub] [lucene] uschindler commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch deci

uschindler commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r851798738 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache So

[GitHub] [lucene] uschindler commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch deci

uschindler commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r851798902 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523439#comment-17523439 ] Uwe Schindler commented on LUCENE-10482: Hey the commit breaks all builds on Wi

[GitHub] [lucene] dweiss commented on pull request #811: Add some basic tasks to help/workflow

dweiss commented on PR #811: URL: https://github.com/apache/lucene/pull/811#issuecomment-1100945965 Please, go ahead, @mocobeta. I'm on Easter holidays and with intermittent access to the internet. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523449#comment-17523449 ] Mayya Sharipova commented on LUCENE-10518: -- [~dnhatn] Thanks for a great inves

[jira] [Comment Edited] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523449#comment-17523449 ] Mayya Sharipova edited comment on LUCENE-10518 at 4/17/22 10:17 PM: -

[jira] [Comment Edited] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523449#comment-17523449 ] Mayya Sharipova edited comment on LUCENE-10518 at 4/17/22 10:35 PM: -

[jira] [Comment Edited] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523449#comment-17523449 ] Mayya Sharipova edited comment on LUCENE-10518 at 4/17/22 10:36 PM: -

[jira] [Comment Edited] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523449#comment-17523449 ] Mayya Sharipova edited comment on LUCENE-10518 at 4/17/22 10:36 PM: -

[jira] [Comment Edited] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523449#comment-17523449 ] Mayya Sharipova edited comment on LUCENE-10518 at 4/17/22 10:37 PM: -

[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523464#comment-17523464 ] Gautam Worah commented on LUCENE-10482: --- Got it. My apologies for introducing thi

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r851814501 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 opened a new pull request, #814: LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

gautamworah96 opened a new pull request, #814: URL: https://github.com/apache/lucene/pull/814 Tests in Windows are failing because of an invalid `:` character in the directory name. Full stack trace and the comment which detected the issue: https://github.com/apache/lucene/pull/762#

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r851816491 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] mikemccand merged pull request #814: LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

mikemccand merged PR #814: URL: https://github.com/apache/lucene/pull/814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523472#comment-17523472 ] ASF subversion and git services commented on LUCENE-10482: -- Co

[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow

mocobeta commented on PR #811: URL: https://github.com/apache/lucene/pull/811#issuecomment-1101035368 Thanks and apologies for interrupting your holidays, I'll merge this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene] mocobeta merged pull request #811: Add some basic tasks to help/workflow

mocobeta merged PR #811: URL: https://github.com/apache/lucene/pull/811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] mocobeta commented on a diff in pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

mocobeta commented on code in PR #805: URL: https://github.com/apache/lucene/pull/805#discussion_r851846785 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/ViterbiNBest.java: ## @@ -0,0 +1,1253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [lucene] gautamworah96 opened a new pull request, #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

gautamworah96 opened a new pull request, #815: URL: https://github.com/apache/lucene/pull/815 Backport of this PR: https://github.com/apache/lucene/pull/814 Tests in Windows are failing because of an invalid : character in the directory name. Full stack trace and the comment wh

[GitHub] [lucene] uschindler commented on a diff in pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

uschindler commented on code in PR #815: URL: https://github.com/apache/lucene/pull/815#discussion_r851923047 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -53,15 +52,15 @@ public class TestAlwaysRefreshD