[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437808#comment-17437808 ] Lu Xugang commented on LUCENE-10120: Hi, [~gsmiller] {quote}I'm not sure we necessa

[GitHub] [lucene] LuXugang opened a new pull request #423: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread GitBox
LuXugang opened a new pull request #423: URL: https://github.com/apache/lucene/pull/423 Detailed discussion see: https://issues.apache.org/jira/browse/LUCENE-10120 and https://github.com/apache/lucene/pull/422 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] rmuir commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread GitBox
rmuir commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-958756345 Why do we need a range docidset? RoaringDocIdSet will compress dense situations too. It should be used. -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437841#comment-17437841 ] Robert Muir commented on LUCENE-10120: -- I'm concerned about having 3 implementatio

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437850#comment-17437850 ] Adrien Grand commented on LUCENE-10196: --- There's a noticeable 3-4% indexing speed

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-03 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437856#comment-17437856 ] Dawid Weiss commented on LUCENE-10196: -- Go Bruno! > Improve IntroSorter with 3-wa

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437861#comment-17437861 ] Adrien Grand commented on LUCENE-10196: --- [~broustant] Do you know if i similar im

[jira] [Commented] (LUCENE-10088) Too many open files in TestIndexWriterMergePolicy.testStressUpdateSameDocumentWithMergeOnGetReader

2021-11-03 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437862#comment-17437862 ] Dawid Weiss commented on LUCENE-10088: -- I bumped the limit on just this test class

[jira] [Created] (LUCENE-10217) BufferedUpdates is memory inefficient

2021-11-03 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10217: - Summary: BufferedUpdates is memory inefficient Key: LUCENE-10217 URL: https://issues.apache.org/jira/browse/LUCENE-10217 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-03 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437876#comment-17437876 ] Bruno Roustant commented on LUCENE-10196: - Thanks for sharing the benchmark Adr

[GitHub] [lucene] uschindler opened a new pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
uschindler opened a new pull request #425: URL: https://github.com/apache/lucene/pull/425 See https://issues.apache.org/jira/browse/LUCENE-10218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [lucene] jpountz commented on a change in pull request #420: [DRAFT] LUCENE-10122 Explore using NumericDocValue to store taxonomy parent array

2021-11-03 Thread GitBox
jpountz commented on a change in pull request #420: URL: https://github.com/apache/lucene/pull/420#discussion_r741939064 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -129,39 +124,19 @@ private void initParents(In

[GitHub] [lucene] dweiss commented on pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
dweiss commented on pull request #425: URL: https://github.com/apache/lucene/pull/425#issuecomment-959477250 I added task graph ordering that enforces the validation runs prior to compilation (if they're both scheduled to run). This is safer than just scheduling module's tests after valida

[GitHub] [lucene] uschindler merged pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
uschindler merged pull request #425: URL: https://github.com/apache/lucene/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene-solr] thelabdude opened a new pull request #2599: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude opened a new pull request #2599: URL: https://github.com/apache/lucene-solr/pull/2599 backport of https://github.com/apache/solr/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] thelabdude merged pull request #2599: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2599: URL: https://github.com/apache/lucene-solr/pull/2599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude opened a new pull request #2600: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude opened a new pull request #2600: URL: https://github.com/apache/lucene-solr/pull/2600 backport of #2599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [lucene-solr] thelabdude merged pull request #2600: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2600: URL: https://github.com/apache/lucene-solr/pull/2600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Commented] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-11-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438215#comment-17438215 ] Adrien Grand commented on LUCENE-10190: --- For the record, we just hit this failure

[GitHub] [lucene-solr] thelabdude opened a new pull request #2601: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude opened a new pull request #2601: URL: https://github.com/apache/lucene-solr/pull/2601 backport of https://github.com/apache/solr/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] thelabdude merged pull request #2601: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #2601: URL: https://github.com/apache/lucene-solr/pull/2601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude opened a new pull request #2602: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude opened a new pull request #2602: URL: https://github.com/apache/lucene-solr/pull/2602 backport of #2601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [lucene-solr] thelabdude merged pull request #2602: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #2602: URL: https://github.com/apache/lucene-solr/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] dsmiley opened a new pull request #426: Javadocs, Sorter impls:

2021-11-03 Thread GitBox
dsmiley opened a new pull request #426: URL: https://github.com/apache/lucene/pull/426 * clarify which sorts are stable/not * link from utility methods to the primary Sorter implementations for further information * describe when InPlaceMergeSorter is useful. Fix incorrect statement

[jira] [Commented] (LUCENE-9229) Lucene web site broken links

2021-11-03 Thread Kristin Heibel (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438295#comment-17438295 ] Kristin Heibel commented on LUCENE-9229: Hello, I am a newdev on this project,

[jira] [Commented] (LUCENE-10122) Explore using NumericDocValue to store taxonomy parent array

2021-11-03 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438317#comment-17438317 ] Haoyu Zhai commented on LUCENE-10122: - The luceneutil benchmark shows a mostly neut

[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2021-11-03 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438318#comment-17438318 ] Vigya Sharma commented on LUCENE-10216: --- Thanks for going through the proposal, [

[GitHub] [lucene] rmuir commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread GitBox
rmuir commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-958756345 Why do we need a range docidset? RoaringDocIdSet will compress dense situations too. It should be used. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene-solr] thelabdude merged pull request #2599: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2599: URL: https://github.com/apache/lucene-solr/pull/2599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude merged pull request #2601: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #2601: URL: https://github.com/apache/lucene-solr/pull/2601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [lucene-solr] thelabdude merged pull request #2602: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #2602: URL: https://github.com/apache/lucene-solr/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [lucene-solr] thelabdude merged pull request #2600: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2600: URL: https://github.com/apache/lucene-solr/pull/2600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [lucene] dweiss commented on pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
dweiss commented on pull request #425: URL: https://github.com/apache/lucene/pull/425#issuecomment-959477250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] jpountz commented on a change in pull request #420: [DRAFT] LUCENE-10122 Explore using NumericDocValue to store taxonomy parent array

2021-11-03 Thread GitBox
jpountz commented on a change in pull request #420: URL: https://github.com/apache/lucene/pull/420#discussion_r741939064 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -129,39 +124,19 @@ private void initParents(In

[GitHub] [lucene] uschindler merged pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
uschindler merged pull request #425: URL: https://github.com/apache/lucene/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene-solr] thelabdude merged pull request #2599: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2599: URL: https://github.com/apache/lucene-solr/pull/2599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-11-03 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r742449547 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,88 +135,168 @@ private int cacheF

[GitHub] [lucene] rmuir commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread GitBox
rmuir commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-958756345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene-solr] thelabdude merged pull request #2599: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2599: URL: https://github.com/apache/lucene-solr/pull/2599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude merged pull request #2601: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #2601: URL: https://github.com/apache/lucene-solr/pull/2601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-11-03 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r742449547 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,88 +135,168 @@ private int cacheF

[GitHub] [lucene] jpountz commented on a change in pull request #420: [DRAFT] LUCENE-10122 Explore using NumericDocValue to store taxonomy parent array

2021-11-03 Thread GitBox
jpountz commented on a change in pull request #420: URL: https://github.com/apache/lucene/pull/420#discussion_r741939064 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -129,39 +124,19 @@ private void initParents(In

[GitHub] [lucene] dweiss commented on pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
dweiss commented on pull request #425: URL: https://github.com/apache/lucene/pull/425#issuecomment-959477250 I added task graph ordering that enforces the validation runs prior to compilation (if they're both scheduled to run). This is safer than just scheduling module's tests after valida

[GitHub] [lucene-solr] thelabdude merged pull request #2600: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #2600: URL: https://github.com/apache/lucene-solr/pull/2600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude merged pull request #2602: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #2602: URL: https://github.com/apache/lucene-solr/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] uschindler merged pull request #425: LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

2021-11-03 Thread GitBox
uschindler merged pull request #425: URL: https://github.com/apache/lucene/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] LuXugang commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread GitBox
LuXugang commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-960382982 > RoaringDocIdSet will compress dense situations too. It should be used. As @jpountz said in [LUCENE-10120](https://issues.apache.org/jira/browse/LUCENE-10120), LRUQueryCac

[GitHub] [lucene] LuXugang edited a comment on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread GitBox
LuXugang edited a comment on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-960382982 > RoaringDocIdSet will compress dense situations too. It should be used. As @jpountz said in [LUCENE-10120](https://issues.apache.org/jira/browse/LUCENE-10120), LRUQ

[GitHub] [lucene] zacharymorn commented on pull request #418: LUCENE-10061: [WIP] Implements basic dynamic pruning support for CombinedFieldsQuery

2021-11-03 Thread GitBox
zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-960493545 Perf tests result for commit 2ba435e5c83f870be9566 Run 1:                             TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct di