[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-29 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r697971217 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/TestUtil.java ## @@ -321,6 +326,11 @@ public static void syncConcurrentMerges(MergeSc

[GitHub] [lucene] wuda0112 commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-29 Thread GitBox
wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-907748573 > So awesome that `SimpleText` is finally getting a skipping implementation! Thank you @wuda0112! > > Have you tried stressing out the new code by running all Lucene unit-te

[jira] [Commented] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406403#comment-17406403 ] Michael McCandless commented on LUCENE-10068: - Yeah that's a good point [~r

[GitHub] [lucene] mikemccand commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-29 Thread GitBox
mikemccand commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-907786967 > > So awesome that `SimpleText` is finally getting a skipping implementation! Thank you @wuda0112! > > Have you tried stressing out the new code by running all Lucene unit-t

[GitHub] [lucene] mikemccand commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-29 Thread GitBox
mikemccand commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r698012354 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/TestUtil.java ## @@ -321,6 +326,11 @@ public static void syncConcurrentMerges(MergeSch

[GitHub] [lucene] wuda0112 commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-29 Thread GitBox
wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-907810690 > > > So awesome that `SimpleText` is finally getting a skipping implementation! Thank you @wuda0112! > > > Have you tried stressing out the new code by running all Lucene unit

[GitHub] [lucene] rmuir commented on pull request #271: LUCENE-9969:TaxoArrays, a member variable of the DirectoryTaxonomyReader class, i…

2021-08-29 Thread GitBox
rmuir commented on pull request #271: URL: https://github.com/apache/lucene/pull/271#issuecomment-907829353 could we look at storing this stuff as docvalues instead of as payloads that are read into heap memory? It is just integers or list of integers right? -- This is an automated messa

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698055359 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java ## @@ -89,6 +89,28 @@ private void crea

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698056689 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java ## @@ -366,9 +366,9 @@ public void testReaderBasic() th

[jira] [Created] (LUCENE-10077) Closing the DirTaxonomyReader while another thread access the cache can throw NPE

2021-08-29 Thread Gautam Worah (Jira)
Gautam Worah created LUCENE-10077: - Summary: Closing the DirTaxonomyReader while another thread access the cache can throw NPE Key: LUCENE-10077 URL: https://issues.apache.org/jira/browse/LUCENE-10077

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698061294 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698080163 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,142 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698080163 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,142 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698080163 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,142 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698080163 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,142 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r698080163 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,142 @@ public FacetLabe

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-29 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-907952441 > Thanks @zacharymorn -- the changes look awesome! I'm looking forward to faster `CheckIndex`! Thanks @mikemccand again for the review and approval, and I look forward to

[jira] [Commented] (LUCENE-10059) Assertion error in JapaneseTokenizer backtrace

2021-08-29 Thread Anh Dung Bui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406501#comment-17406501 ] Anh Dung Bui commented on LUCENE-10059: --- Thanks [~mikemccand], we already backpor

[jira] [Updated] (LUCENE-10059) Assertion error in JapaneseTokenizer backtrace

2021-08-29 Thread Anh Dung Bui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anh Dung Bui updated LUCENE-10059: -- Fix Version/s: main (9.0) 8.x > Assertion error in JapaneseTokenizer backt

[jira] [Resolved] (LUCENE-10059) Assertion error in JapaneseTokenizer backtrace

2021-08-29 Thread Anh Dung Bui (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anh Dung Bui resolved LUCENE-10059. --- Resolution: Fixed > Assertion error in JapaneseTokenizer backtrace > --

[jira] [Commented] (LUCENE-8723) Bad interaction bewteen WordDelimiterGraphFilter, StopFilter and FlattenGraphFilter

2021-08-29 Thread Geoffrey Lawson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406516#comment-17406516 ] Geoffrey Lawson commented on LUCENE-8723: - I believe this issue has been fixed i