[COMMITTED 070/141] gccrs: add discriminant value intrinsic

From: Philip Herron This is pretty nasty piece of rust in my opinion the return type of this intrinsic results into a lang item associated type: ::Discriminant This is a special case which needs to support mapping onto the repr type of the associated ADT that is passed in, but defaults to isz

[COMMITTED 073/141] gccrs: remove name resolution inserts from type-path

From: Philip Herron We resolve path segments and inserted their resolution into the name resolution space which was an old hack to use this as information in code-gen/check-passes in order to help things move forward but this is not nessecary gcc/rust/ChangeLog: * typecheck/rust-hir-typ

[COMMITTED 078/141] gccrs: improve error diagnostic for bad type-resolution in CallExpr

From: Philip Herron We have the type information for the resolved call lets tell the user about it in the diagnostic and apply the correct error code. Fixes Rust-GCC#2035 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): improve error diag gcc/testsu

[COMMITTED 082/141] gccrs: Add type check on if-expr

From: Benjamin Thos Check if an if-expr returns void type or a coercible type like an early return. gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Add check on if-expr. gcc/testsuite/ChangeLog: * rust/compile/implicit_returns_err3.r

[COMMITTED 001/141] gccrs: typecheck: Separate assemble_builtin_candidate in two

From: Arthur Cohen This paves the way for adding trait bounds that aren't necessarily Sized. gcc/rust/ChangeLog: * typecheck/rust-tyty-bounds.cc (TypeBoundsProbe::add_trait_bound): New function. * typecheck/rust-hir-type-bounds.h: Declare it. (TypeBoundsProbe::assemble_

[COMMITTED 034/141] gccrs: Compile unit struct with constructor

From: Pierre-Emmanuel Patry gcc/rust/ChangeLog: * backend/rust-compile-resolve-path.cc (ResolvePathRef::resolve): Do not use query system for unit struct but compile it's constructor instead. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/backend/rust-compile-resolv

[COMMITTED 035/141] gccrs: Remove some passing test from exclude file

From: Pierre-Emmanuel Patry Those tests are now passing. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove some tests. Signed-off-by: Pierre-Emmanuel Patry --- gcc/testsuite/rust/compile/nr2/exclude | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/

[COMMITTED 097/141] gccrs: Remove some member functions from SingleASTNode

From: Owen Avery gcc/rust/ChangeLog: * ast/rust-ast.h (SingleASTNode::take_trait_item): Remove. (SingleASTNode::take_impl_item): Remove. (SingleASTNode::take_trait_impl_item): Remove. * expand/rust-expand-visitor.cc (ExpandVisitor::visit): Replace

[COMMITTED 108/141] gccrs: Adjust unknown macro error message

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-early-name-resolver-2.0.cc (Early::visit): Adjust error produced when macro resolution fails. * resolve/rust-early-name-resolver.cc (EarlyNameResolver::visit): Likewise. gcc/testsuite/ChangeLog:

[COMMITTED 037/141] gccrs: lang-items: Add From::from

From: Arthur Cohen gcc/rust/ChangeLog: * util/rust-lang-item.h: Declare it. * util/rust-lang-item.cc: Use it. --- gcc/rust/util/rust-lang-item.cc | 2 ++ gcc/rust/util/rust-lang-item.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/gcc/rust/util/rust-lang-item.cc b/gcc

[COMMITTED 116/141] gccrs: Add rib kind debug representation

From: Pierre-Emmanuel Patry Rib kind had no string representation, and thus were not used in the debug string representation. gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: Output rib kind. * resolve/rust-rib.h: Add function to get string representation from a rib

[COMMITTED 080/141] gccrs: initial setup for new OpaqueType to represent Impl types

From: Philip Herron This completes the initial setup and boilerplate for the new type in the typesystem. This is not functional yet but its a big patch already. gcc/rust/ChangeLog: * backend/rust-compile-type.cc (TyTyResolveCompile::visit): new tyty::OpaqueType * backend/rust-c

[COMMITTED 076/141] gccrs: fix name resolution for generics where type param is declared later

From: Philip Herron Rust allows you to use generics within type bounds when they are declared later on. This changes the name resolution to walk the genric params in two passes to ensure the type parameters are setup before drilling down into the type parameters This issue has exposed another ty

[COMMITTED 124/141] gccrs: check for recursion trait cycle with bounds checks

From: Philip Herron We need to be careful when doing bounds check as to not create a recusive trait resolution. This patch checks for that case and fixes a bad type is equal check on ADT Types which was caught with a regression here. Fixes Rust-GCC#3126 gcc/rust/ChangeLog: * typecheck/

[COMMITTED 121/141] gccrs: Fix some small issues

From: Owen Avery gcc/rust/ChangeLog: * backend/rust-compile-intrinsic.cc (assume_handler): Fix copy/paste error. * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit): Fix spelling mistake. Signed-off-by: Owen Avery --- gcc/rust/backend/rust-comp

[COMMITTED 138/141] gccrs: Modify multiple definition error

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-ast-resolve-expr.cc (ResolveExpr::visit): Modify error message. * resolve/rust-ast-resolve-implitem.h (ResolveToplevelImplItem::visit): Likewise. (ResolveTopLevelTraitItems::visit): Likewise. (Res

[COMMITTED 140/141] gccrs: nr2.0: Fix StructExprFieldIdentifier handling

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Add visitor for StructExprFieldIdentifier. * resolve/rust-late-name-resolver-2.0.h (Late::visit): Likewise. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude:

[COMMITTED 136/141] gccrs: Prevent multiple resolution insertion

From: Owen Avery gcc/rust/ChangeLog: * expand/rust-derive-clone.cc (DeriveClone::clone_impl): Avoid using the same node id multiple times. (DeriveClone::clone_enum_identifier): Likewise. (DeriveClone::clone_enum_tuple): Likewise. * expand/rust-deri

[COMMITTED 081/141] gccrs: nr2.0: Resolve paths which start with Self

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx (ForeverStack::find_starting_point): Be more careful about applying ForeverStack::find_closest_module. (ForeverStack::resolve_segments): Allow traversal into parent nodes when not in a m

[COMMITTED 027/146] gccrs: typecheck: Remove unused parameter in TyTyCheckCallExpr

From: Arthur Cohen gcc/rust/ChangeLog: * typecheck/rust-tyty-call.h: Remove unused context member. --- gcc/rust/typecheck/rust-tyty-call.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/rust/typecheck/rust-tyty-call.h b/gcc/rust/typecheck/rust-tyty-call.h in

[COMMITTED 022/141] gccrs: hir: Adapt visitors to lang item PathInExpressions

From: Arthur Cohen gcc/rust/ChangeLog: * backend/rust-compile-resolve-path.cc (ResolvePathRef::visit): Adapt visitor to lang item HIR::PathInExpressions. * typecheck/rust-hir-type-check-path.cc (TypeCheckExpr::visit): Likewise. --- gcc/rust/backend/rust-compile-resolve

[COMMITTED 023/141] gccrs: marklive: Fix handling for lang item PathInExpressions.

From: Arthur Cohen gcc/rust/ChangeLog: * checks/lints/rust-lint-marklive.cc (MarkLive::visit): Adapt to lang items. --- gcc/rust/checks/lints/rust-lint-marklive.cc | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/gcc/rust/checks/lints/rust-lint-mark

[COMMITTED 025/141] gccrs: backend: Improve handling of lang-item PathInExpressions

From: Arthur Cohen gcc/rust/ChangeLog: * backend/rust-compile-resolve-path.cc (ResolvePathRef::visit): Call into resolve_path_like instead. (ResolvePathRef::resolve_path_like): New. (ResolvePathRef::resolve): Call into resolve_with_node_id. * backend/rust

[COMMITTED 067/141] gccrs: session manager: Call into DesugarForLoops

From: Arthur Cohen gcc/rust/ChangeLog: * rust-session-manager.cc (Session::compile_crate): Call the visitor. --- gcc/rust/rust-session-manager.cc | 4 1 file changed, 4 insertions(+) diff --git a/gcc/rust/rust-session-manager.cc b/gcc/rust/rust-session-manager.cc index 3adde297a4e

[COMMITTED 065/141] gccrs: ast: builder: Fix arguments of Builder::let

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.h: Mark all arguments as &&. * ast/rust-ast-builder.cc (Builder::let): Likewise. --- gcc/rust/ast/rust-ast-builder.cc | 4 ++-- gcc/rust/ast/rust-ast-builder.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletion

[COMMITTED 086/141] gccrs: derive(Eq): Add implementation.

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive.cc (DeriveVisitor::derive): Call into DeriveEq. * expand/rust-derive-eq.cc: New file. * expand/rust-derive-eq.h: New file. * Make-lang.in: Compile them. gcc/testsuite/ChangeLog: * rust/compile/d

[COMMITTED 141/141] gccrs: support generic super traits recursively

From: Philip Herron In order to handle generic super traits on any trait bound we need to ensure we track the TypeBoundPredicate as part of the TraitReference instead of just the raw TraitReferences because these will have any applied generics enplace. Then for any TypeBoundPredicate it takes a

[COMMITTED 084/141] gccrs: nr2.0: Fix issue with external crates

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::visit): When visiting an external crate declaration, handle failed crate name lookups. This can happen when Session::load_extern_crate fails to load a crate during the

[COMMITTED 090/141] gccrs: derive(PartialEq): Add partial implementation

From: Arthur Cohen We are still missing some deriving for enums, as part of our codegen and nameres for rebinding struct field patterns is missing. gcc/rust/ChangeLog: * expand/rust-derive-partial-eq.cc: New file. * expand/rust-derive-partial-eq.h: New file. * expand/ru

[COMMITTED 089/141] gccrs: derive(Clone): chore: Cleanup

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-clone.cc: Cleanup implementation, avoid repetitions. * expand/rust-derive-clone.h: Likewise. --- gcc/rust/expand/rust-derive-clone.cc | 34 ++-- gcc/rust/expand/rust-derive-clone.h | 8 ---

[COMMITTED 130/141] gccrs: Fix canonical path parent resolution

From: Pierre-Emmanuel Patry The algorithm was comparing using the wrong id, this lead to some mangling errors as an erroneous parent was selected. gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: Fix the id comparison. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/resolve/ru

[COMMITTED 085/141] gccrs: nr2.0: Run DefaultResolver::visit on PathInExpression

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): When visiting a PathInExpression instance, call into DefaultResolver::visit, ensuring generic arguments are visited. gcc/testsuite/ChangeLog: * rust/compile/nr2/

[COMMITTED 087/141] gccrs: ast-builder: Improve function generation.

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.cc (Builder::block): Change return type. (Builder::loop): Use new APIs. * ast/rust-ast-builder.h: Change return type of block functions. --- gcc/rust/ast/rust-ast-builder.cc | 22 +++--- gcc/ru

[COMMITTED 098/141] gccrs: ast: builder: Add new builder methods

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.cc (Builder::statementify): New. (Builder::function): Add generic params optional argument. (Builder::path_in_expression): Add opening_scope_resolution optional argument. (Builder::block): Add function

[COMMITTED 030/141] gccrs: Remove some tests from nr2 exclusion file

From: Pierre-Emmanuel Patry Those test are now passing. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove passing tests. Signed-off-by: Pierre-Emmanuel Patry --- gcc/testsuite/rust/compile/nr2/exclude | 11 --- 1 file changed, 11 deletions(-) diff --git a/gcc/tests

[COMMITTED 036/141] gccrs: add new -frust-overflow-checks flag to control overflow checks

From: Philip Herron This will be crucial for more complex gimple debugging to make it easier to follow the code vs the original rust code. gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::visit): disable overflow checks * lang.opt: new flag Signed-off-by: Phili

[COMMITTED 020/141] gccrs: ast: More visitors to allow lang item paths in expressions

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-collector.cc (TokenCollector::visit): Adapt visitor to lang item PathInExpressions. * ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): Likewise. * expand/rust-cfg-strip.cc (CfgStrip::visit): Likewise.

[COMMITTED 018/141] gccrs: mappings: Improve error message for get_lang_item_node

From: Arthur Cohen gcc/rust/ChangeLog: * util/rust-hir-map.cc (Mappings::get_lang_item_node): Better formatting when a lang item does not exist when it should. --- gcc/rust/util/rust-hir-map.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/rust/uti

[COMMITTED 015/141] gccrs: Infer crate name after file opening

From: Dylan Gardner Fixes #3129. gcc/rust/ChangeLog: * rust-session-manager.cc (Session::handle_crate_name): Remove crate name inference (Session::compile_crate): Add crate name inference and error if inferred name is empty. Remove CompileOptions::get_instance ()

[COMMITTED 016/141] gccrs: catch missing guard for optional result

From: Philip Herron When we lookup here it returns an optional which can lead to a crash because it needs a guard if it has a value. gcc/rust/ChangeLog: * backend/rust-compile-resolve-path.cc (HIRCompileBase::query_compile): add guard gcc/testsuite/ChangeLog: * rust/compile/n

[COMMITTED 009/141] gccrs: Fix rust breakage with nr2

From: Pierre-Emmanuel Patry Nr2 did not emit the correct error message for break identifier "rust". gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Add "rust" identifier detection akin to nr1. (funny_ice_finalizer): Copy ICE finalizer from nr1

[COMMITTED 049/141] gccrs: derive(Debug): Add stub implementation.

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-debug.cc: New file. * expand/rust-derive-debug.h: New file. * Make-lang.in: Compile them. * expand/rust-derive.cc (DeriveVisitor::derive): Call into DeriveDebug. gcc/testsuite/ChangeLog: * rust/

[COMMITTED 008/141] gccrs: derive(Copy): Improve bounds when deriving Copy

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-copy.cc: Always add an extra Copy bound on generic Copy impls. --- gcc/rust/expand/rust-derive-copy.cc | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gcc/rust/expand/rust-derive-copy.cc b/gcc/rus

[COMMITTED 012/141] gccrs: Check for type paths nr2.0 can't handle yet

From: Owen Avery Some of our tests only work with name resolution 2.0 because the latter misinterprets type paths. This change should cause the compiler to error out if it would otherwise misinterpret a type path. A fix for type path resolution isn't included in this comment, since doing so would

[COMMITTED 053/141] gccrs: Fix ICE when fn_once and fn_once_output lang item is not defined

From: Philip Herron We needed to check for the optional has a value here or not it leads to an ICE. gcc/rust/ChangeLog: * typecheck/rust-tyty.cc (ClosureType::setup_fn_once_output): add checks for lang items Signed-off-by: Philip Herron --- gcc/rust/typecheck/rust-tyty.cc | 22 +

[COMMITTED 056/141] gccrs: Fix crash in privay reporter for placeholder types

From: Philip Herron This guards against a crash but i think this should actually be treated as if its a generic type like below. But for now this addresses a crash which can occur. gcc/rust/ChangeLog: * checks/errors/privacy/rust-privacy-reporter.cc (PrivacyReporter::check_base_type_p

[COMMITTED 061/141] gccrs: Add test case to show issue is fixed

From: Philip Herron This was fixed as part of: "gccrs: Fix compilation of trait-items which map to impl items" Fixes Rust-GCC#3402 gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: nr2 cant handle this * rust/compile/issue-3402-1.rs: New test. * rust/compile/issue-3

[COMMITTED 110/141] gccrs: lower: Error out when lowering ErrorPropagationExpr

From: Arthur Cohen Adapt functions for lowering nodes that should never reach the lowering phase to cause an unreachable, and mark them as final so as it not possible to override them in other visitors. gcc/rust/ChangeLog: * hir/rust-ast-lower-base.cc: Adapt functions for ErrorPropaga

[COMMITTED 115/141] gccrs: nr2.0: Set the node id of the root node

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-forever-stack.h (ForeverStack::ForeverStack): Set the node id of the root node to that of the current crate. * resolve/rust-forever-stack.hxx (ForeverStack::find_starting_point): Use the node id of the ro

[COMMITTED 122/141] gccrs: remove visitor which is not needed here

From: Philip Herron Just a small refactor to remove a visitor which is not needed. gcc/rust/ChangeLog: * backend/rust-compile-resolve-path.cc (ResolvePathRef::Compile): remove visitor (ResolvePathRef::ResolvePathRef): likewise (ResolvePathRef::visit): likewise *

[COMMITTED 123/141] gccrs: track DefId on ADT Types this could be useful information

From: Philip Herron gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-item.cc (TypeCheckItem::visit): track DefId of origin * typecheck/rust-tyty.cc (BaseType::monomorphized_clone): likewise (ADTType::ADTType): likewise (ADTType::get_id): likewise (ADTT

[Bug rust/116561] [15 regression] gcc/testsuite/rust/execute/torture/iter1.rs:350:5: internal compiler error: 'verify_gimple' failed since r15-3328-g673a448aa24efedd5ac140ebf7bfe652d7a6a846

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116561 Andrew Pinski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[COMMITTED 063/141] gccrs: inline-asm: Fix some warnings

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-macro-builtins-asm.cc (strip_double_quotes): Special case empty strings ("\"\""). (parse_reg_operand): Remove use of the `struct` keyword. (parse_reg_operand_in): Likewise. (parse_reg_operand_out): Like

[COMMITTED 088/141] gccrs: ast-builder: Add new methods for creating operator expressions

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.cc (Builder::literal_bool): New method. (Builder::comparison_expr): Likewise. (Builder::boolean_operation): Likewise. * ast/rust-ast-builder.h: Declare them. --- gcc/rust/ast/rust-ast-builder.cc | 46 +

[COMMITTED 109/141] gccrs: ast: Add base for desugaring try expressions

From: Arthur Cohen gcc/rust/ChangeLog: * Make-lang.in: Compile it. * ast/rust-desugar-question-mark.cc: New file. * ast/rust-desugar-question-mark.h: New file. gcc/testsuite/ChangeLog: * rust/compile/try-expr1.rs: New test. --- gcc/rust/Make-lang.in

[COMMITTED 069/141] gccrs: Get rid of duplicate interface gccrs#3396

From: GS-GOAT <86884129+gs-g...@users.noreply.github.com> gcc/rust/ChangeLog: * typecheck/rust-autoderef.cc (insert_implicit_type): Update single-parameter call to pass explicit HirId. * typecheck/rust-hir-type-check-expr.cc: Same. * typecheck/rust-hir-type

[COMMITTED 118/141] gccrs: Add enum variant string information to definition

From: Pierre-Emmanuel Patry New enum variant status now appears in the string representation of the resolver's definition. gcc/rust/ChangeLog: * resolve/rust-rib.cc (Rib::Definition::to_string): Add enum variant status. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/resolv

[COMMITTED 071/141] gccrs: add variant_count intrinsic

From: Philip Herron Addresses Rust-GCC#3348 gcc/rust/ChangeLog: * backend/rust-compile-intrinsic.cc (variant_count_handler): new intrinsic gcc/testsuite/ChangeLog: * rust/execute/torture/enum_intrinsics2.rs: New test. Signed-off-by: Philip Herron --- gcc/rust/backend/rust-

[COMMITTED 119/141] gccrs: Remove nr2 exhaustiveness test from exclusion list

From: Pierre-Emmanuel Patry gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove test. Signed-off-by: Pierre-Emmanuel Patry --- gcc/testsuite/rust/compile/nr2/exclude | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/testsuite/rust/compile/nr2/exclude b/gcc/testsuite/rust

[COMMITTED 107/141] gccrs: nr2.0: Handle lang item type path segments

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx (ForeverStack::find_starting_point): Stop when hitting a lang item segment. (ForeverStack::resolve_segments): Resolve lang item segments. (ForeverStacl::resolve_path): Handle single segm

[COMMITTED 137/141] gccrs: nr2.0: Adjust visitors for struct expressions

From: Owen Avery gcc/rust/ChangeLog: * ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): Make sure to always visit the struct name. * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Avoid visiting the struct name twice. gcc/testsuite/ChangeLog:

[COMMITTED 024/141] gccrs: ast: Add Path::is_lang_item()

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-path.h: New function. --- gcc/rust/ast/rust-path.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/rust/ast/rust-path.h b/gcc/rust/ast/rust-path.h index 2a76acc48c3..c2537034b61 100644 --- a/gcc/rust/ast/rust-path.h +++ b/gcc/r

[COMMITTED 048/141] gccrs: derive(Clone, Copy): Cleanup using new method from DeriveVisitor

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-clone.cc: Cleanup using DeriveVisitor::setup_impl_generics. * expand/rust-derive-copy.cc: Likewise. --- gcc/rust/expand/rust-derive-clone.cc | 87 ++-- gcc/rust/expand/rust-derive-copy.cc | 87

[COMMITTED 021/141] gccrs: hir: Add LangItem paths to PathPattern class

From: Arthur Cohen gcc/rust/ChangeLog: * hir/tree/rust-hir-path.h: Adapt PathPattern to accept lang-item paths. * hir/tree/rust-hir-path.cc: Assert we are dealing with a segmented path, create lang-item constructors. * hir/tree/rust-hir.cc (PathPattern::convert_t

[COMMITTED 043/141] gccrs: lang-items: Add structural_{peq, teq}

From: Arthur Cohen These lang items are used when deriving Eq and PartialEq, and will be checked when compiling pattern matching. gcc/rust/ChangeLog: * util/rust-lang-item.cc: New items. * util/rust-lang-item.h: Likewise. gcc/testsuite/ChangeLog: * rust/compile/struct

[COMMITTED 032/141] gccrs: Make foreverstack debug string const

From: Pierre-Emmanuel Patry Those function should not change anything within the foreverstack, it can therefore be made const. gcc/rust/ChangeLog: * resolve/rust-forever-stack.h: Make debug functions const. * resolve/rust-forever-stack.hxx: Likewise. Signed-off-by: Pierre-Emman

[COMMITTED 050/141] gccrs: ast: builder: Add Return expression builder

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.h: Declare it. * ast/rust-ast-builder.cc (Builder::return_expr): Define it. --- gcc/rust/ast/rust-ast-builder.cc | 7 +++ gcc/rust/ast/rust-ast-builder.h | 4 2 files changed, 11 insertions(+) diff --git a/

[COMMITTED 112/141] gccrs: Reduce usage of rust-session-manager.h

From: Owen Avery gcc/rust/ChangeLog: * util/rust-edition.cc: New file. * util/rust-edition.h: New file. * Make-lang.in: Add rust-edition.o to the object list. * ast/rust-pattern.cc: Remove inclusion of rust-session-manager.h. * expand/rust-macro-e

[COMMITTED 062/141] gccrs: Add warning about default visitor usage

From: Pierre-Emmanuel Patry We already lost some time on this unusual pattern, a comment will hopefully prevent this from happening again. gcc/rust/ChangeLog: * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::visit): Add warning about current code. Signed-off-by: Pierre-E

[COMMITTED 039/146] gccrs: Fix FnParam pattern location ternary logic

From: Pierre-Emmanuel Patry Condition was inverted, we should retrieve the locus only if we have a pattern. gcc/rust/ChangeLog: * typecheck/rust-tyty-call.cc (TypeCheckCallExpr::visit): Do not get a reference if the pattern does not exist. (TypeCheckMethodCallExpr::check

[COMMITTED 139/141] gccrs: nr2.0: Adjust indentifier expression handling

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Make sure to return early after a resolution error, improve the resolution error message, fix a typo, handle ambiguous resolutions, and remove an old comment. gcc/testsui

[COMMITTED 133/141] gccrs: Fix modules with same name as builtins causing ICE (#3315)

From: Liam Naddell gcc/rust/ChangeLog: * resolve/rust-forever-stack.h (ForeverStack): Add a dedicated prelude node for the Language prelude * resolve/rust-forever-stack.hxx (ForeverStack): Add support code for the prelude node * resolve/rust-late-name-re

[COMMITTED 126/141] gccrs: Remove tests from exclusion list

From: Pierre-Emmanuel Patry gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove issue-1786 and issue-3033 from exclusion list. Signed-off-by: Pierre-Emmanuel Patry --- gcc/testsuite/rust/compile/nr2/exclude | 2 -- 1 file changed, 2 deletions(-) diff --git a/gcc/tests

[COMMITTED 120/141] gccrs: Add a test for enum variant name resolution

From: Pierre-Emmanuel Patry Highlight the fact that a value inside an enum definition refers to a struct outside of the enum and not to the enum variant's name directly. gcc/testsuite/ChangeLog: * rust/compile/enum_variant_name.rs: New test. Signed-off-by: Pierre-Emmanuel Patry --- g

[COMMITTED 125/141] gccrs: Move import mapping resolution to in tree visit

From: Pierre-Emmanuel Patry Import mapping was relying on resolve_path which in turn relies on the cursor function. This means the mapping resolver should be called from the correct scope instead of being called from the crate scope. gcc/rust/ChangeLog: * resolve/rust-early-name-resolve

[COMMITTED 127/141] gccrs: Remove finalize import visitor

From: Pierre-Emmanuel Patry This visitor is not used anymore. gcc/rust/ChangeLog: * resolve/rust-finalize-imports-2.0.cc (FinalizeImports::FinalizeImports): Remove constructor. (FinalizeImports::go): Remove function. (FinalizeImports::visit): Likewise. *

[COMMITTED 096/141] gccrs: Fix expansion of macros inside modules

From: Owen Avery gcc/rust/ChangeLog: * expand/rust-expand-visitor.cc (ExpandVisitor::visit): Override DefaultASTVisitor in order to expand a module's items, rather than directly visit them. * expand/rust-expand-visitor.h (ExpandVisitor::visit): Add overrid

[COMMITTED 064/141] gccrs: nr2.0: Resolve instances of TypePath more accurately

From: Owen Avery gcc/rust/ChangeLog: * util/rust-unwrap-segment.cc: New file. * util/rust-unwrap-segment.h: New file. * Make-lang.in: Add rust-unwrap-segment.o to the object list. * resolve/rust-forever-stack.hxx: Include rust-unwrap-segment.h. (ForeverSta

[COMMITTED 100/141] gccrs: derive(Hash): Add implementation.

From: Arthur Cohen gcc/rust/ChangeLog: * Make-lang.in: Compile it. * expand/rust-derive.cc (DeriveVisitor::derive): Call it. * expand/rust-derive-hash.cc: New file. * expand/rust-derive-hash.h: New file. gcc/testsuite/ChangeLog: * rust/compile/derive-has

[COMMITTED 099/141] gccrs: derive(Debug): Use builder's ptrify function instead

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-debug.cc (ptrify): Remove function. --- gcc/rust/expand/rust-derive-debug.cc | 8 1 file changed, 8 deletions(-) diff --git a/gcc/rust/expand/rust-derive-debug.cc b/gcc/rust/expand/rust-derive-debug.cc index f3754745

[COMMITTED 132/141] gccrs: nr2.0: Check compile/torture/*.rs tests

From: Owen Avery gcc/testsuite/ChangeLog: * rust/compile/nr2/compile.exp: Adjust to cover tests in the torture subdirectory. * rust/compile/nr2/exclude: Add entries. Signed-off-by: Owen Avery --- gcc/testsuite/rust/compile/nr2/compile.exp | 6 ++ gcc/testsuite/rus

[COMMITTED 129/141] gccrs: Insert crate name in canonical path

From: Pierre-Emmanuel Patry gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: Insert a new segment with the crate's name as canonical's path prefix. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/resolve/rust-forever-stack.hxx | 7 ++- 1 file changed, 6 insertions(+

[COMMITTED 135/141] gccrs: nr2.0: Fix test self-path2.rs

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-ast-resolve-path.cc (ResolvePath::resolve_path): Adjust the error message for a lower self segment in the middle of a path. * resolve/rust-ast-resolve-type.cc (ResolveRelativeTypePath::go): Likewise. gcc

[COMMITTED 013/141] gccrs: Add environment capture to NR2

From: Pierre-Emmanuel Patry The compiler was still relying on NR1 for closure captures when using nr2 even though the resolver was not used and thus it's state empty. gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Add environment collection.

[COMMITTED 002/141] gccrs: typecheck: Add basic handling for applying auto trait bounds

From: Arthur Cohen gcc/rust/ChangeLog: * hir/rust-ast-lower-item.cc (ASTLoweringItem::visit): Register auto traits in mappings. * util/rust-hir-map.cc (Mappings::insert_auto_trait): New. (Mappings::get_auto_traits): New. * util/rust-hir-map.h: Declare them.

[COMMITTED 004/141] gccrs: hir-dump: Improve handling of typepathsegments that are lang items.

From: Arthur Cohen gcc/rust/ChangeLog: * hir/rust-hir-dump.cc (Dump::do_typepathsegment): Add handling for lang items. --- gcc/rust/hir/rust-hir-dump.cc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/rust/hir/rust-hir-dump.cc b/gcc/rust/hir/rust-hir-dump.cc

[COMMITTED 005/141] gccrs: ast-builder: Add extra parameter for TypeParam builder

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.cc (Builder::new_type_param): Add optional extra trait bounds. * ast/rust-ast-builder.h: Likewise. --- gcc/rust/ast/rust-ast-builder.cc | 6 +- gcc/rust/ast/rust-ast-builder.h | 4 +++- 2 files changed, 8 insert

[COMMITTED 006/141] gccrs: derive(Clone): Add Clone bound on generated impl blocks

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-clone.cc: Add extra bound when deriving generic Clone --- gcc/rust/expand/rust-derive-clone.cc | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/gcc/rust/expand/rust-derive-clone.cc b/gcc/

[COMMITTED 014/141] gccrs: Add captures for ClosureExprInnerTyped with nr2

From: Pierre-Emmanuel Patry Captures were only processed for regular ClosureExprInner. gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Add ClosureExprInnerTyped visit implementation. (add_captures): Add a function to avoid code duplication.

[COMMITTED 011/141] gccrs: backend: Allow anything as a match scrutinee

From: Arthur Cohen gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (check_match_scrutinee): Allow anything to be used as a match scrutinee, not just ADTs. --- gcc/rust/backend/rust-compile-expr.cc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gcc/r

[COMMITTED 028/141] gccrs: Add unit struct to name namespace in old resolver

From: Pierre-Emmanuel Patry We missed the name namespace for unit struct in the old resolver. gcc/rust/ChangeLog: * resolve/rust-ast-resolve-toplevel.h: Add struct to name namespace. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/resolve/rust-ast-resolve-toplevel.h | 23 ++

[COMMITTED 059/141] gccrs: ast-builder: Add methods for QualifiedPathInExpressions

From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast-builder.cc (Builder::qualified_path_in_expression): New. (Builder::function): Change the return type. * ast/rust-ast-builder.h: Declare qualified_path_in_expression functions. * expand/rust-derive-debug.cc (De

[COMMITTED 055/141] gccrs: coercion sites allow for type inference as well.

From: Philip Herron Addresses Rust-GCC#3382 and Rust-GCC#3381 gcc/rust/ChangeLog: * typecheck/rust-type-util.cc (coercion_site): allow inference vars gcc/testsuite/ChangeLog: * rust/compile/reference1.rs: fix error message Signed-off-by: Philip Herron --- gcc/rust/typecheck

[COMMITTED 051/141] gccrs: nr2.0: Remove accidental copies of resolver

From: Owen Avery gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::generate_closure_function): Take NameResolutionContext by reference instead of by value. * backend/rust-compile-item.cc (CompileItem::visit): Likewise. * backend/rust

[COMMITTED 033/141] gccrs: Resolved item type shall be differentiated later

From: Pierre-Emmanuel Patry We need to query all namespaces and error out at a later stage if the retrieved item is wrong. gcc/rust/ChangeLog: * typecheck/rust-hir-trait-resolve.cc (TraitResolver::resolve_path_to_trait): Query all namespaces. Signed-off-by: Pierre-Emmanuel Pat

[COMMITTED 105/141] gccrs: name-resolution: early: Remove overzealous overrides

From: Arthur Cohen Some empty overrides were incorrectly being set-up instead of using the correct behavior from DefaultASTVisitor. gcc/rust/ChangeLog: * resolve/rust-early-name-resolver.cc: Remove definitions. * resolve/rust-early-name-resolver.h: Remove declarations. --- gcc

[COMMITTED 077/141] gccrs: self paths are patterns but we dont have mappings for it

From: Philip Herron With simple patterns we dont introduce any more inference varaibles as they are already declared in a specific way. This would only lead to more unconstrained inference varaibles than is required. Fixes Rust-GCC#3022 gcc/rust/ChangeLog: * hir/rust-ast-lower-base.cc

[COMMITTED 103/141] gccrs: nr2.0: Implement macro_use for modules

From: Owen Avery gcc/rust/ChangeLog: * resolve/rust-early-name-resolver-2.0.cc: Include rust-attribute-values.h. (Early::visit): If a module has a macro_use attribute, avoid pushing a new textual macro scope. gcc/testsuite/ChangeLog: * rust/compile/nr2/e

[COMMITTED 106/141] gccrs: expansion: Expand generic args in generic type path segments

From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-expand-visitor.cc (ExpandVisitor::visit): Correctly visit the generic args of a generic type path segment. gcc/testsuite/ChangeLog: * rust/compile/issue-2015.rs: New test. --- gcc/rust/expand/rust-expand-visitor.cc

[COMMITTED 044/141] gccrs: scan-deadcode: Do not warn unused fields if they start with '_'

From: Arthur Cohen gcc/rust/ChangeLog: * checks/lints/rust-lint-scan-deadcode.h: Check if the field name starts with an underscore before warning. --- gcc/rust/checks/lints/rust-lint-scan-deadcode.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/rust/

  1   2   >