Re: [RFC Patch, Aarch64] : Macros for profile code generation to enable gprof support

2013-09-28 Thread Venkataramanan Kumar
that glibc patches are upstreamed. 2013-10-28 Venkataramanan Kumar * config/aarch64/aarch64.h (MCOUNT_NAME): Define. (NO_PROFILE_COUNTERS): Likewise. (PROFILE_HOOK): Likewise. (FUNCTION_PROFILER): Likewise. * config/aarch64/aarch64.c

Re: [RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-27 Thread Venkataramanan Kumar
Hi Richard, > I don't think it's good to have long lists of targets on generic tests. > Can we factor this out into a target-supports option? I have updated the patch as per your recommendation. Please let me know if it is fine. 2013-11-26 Venkataramanan Kumar

[Ping] Re: [RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-12-01 Thread Venkataramanan Kumar
Hi Richard, Pinging for further comments. regards, Venkat. On 27 November 2013 14:24, Venkataramanan Kumar wrote: > Hi Richard, > >> I don't think it's good to have long lists of targets on generic tests. >> Can we factor this out into a target-supports option? >

[PATCH AArch64]: Add constraint letter for stack_protect_test pattern.

2014-09-04 Thread Venkataramanan Kumar
trunk? regards, Venkat. gcc/ChangeLog 2014-09-04 Venkataramanan Kumar * config/aarch64/aarch64.md (stack_protect_test_) Add register constraint for operand 0. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index b5be79c..77588b9 100644 --- a/gcc/confi

[PATCH v2 AArch64]: Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern.

2014-09-04 Thread Venkataramanan Kumar
Hi maintainers, I just added "=r" and retested it. gcc/ChangeLog 2014-09-04 Venkataramanan Kumar * config/aarch64/aarch64.md (stack_protect_test_) Add register constraint for operand 0. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md ind

Re: [PATCH v2 AArch64]: Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern.

2014-09-04 Thread Venkataramanan Kumar
Hi James, Yes we can just mark operand 3 as "&r". PFB, the updated patch. Ok for trunk? regards, Venkat. gcc/ChangeLog 2014-09-04 Venkataramanan Kumar * config/aarch64/aarch64.md (stack_protect_test_) Add register constraint for operand 0 and remove write only c

Re: [PATCH v2 AArch64]: Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern.

2014-09-08 Thread Venkataramanan Kumar
Hi Marcus, I up streamed the changes to trunk. There is no support for stack protection in FSF GCC 4.9 branch yet. So I need to back port r209712 and this change together. regards, Venkat. On 5 September 2014 21:17, Marcus Shawcroft wrote: > On 4 September 2014 19:19, Venkataramanan Ku

[RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-19 Thread Venkataramanan Kumar
Hi Maintainers, This is RFC patch that adds machine descriptions to support stack smashing protection in AArch64. I have written a very simple patch that prints "stack set" and "stack test" as template of instructions. I had 2 assumptions. 1) For "stack_protect_set" and "stack_protect_test", I

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-20 Thread Venkataramanan Kumar
Hi Joseph, On 19 November 2013 21:53, Joseph S. Myers wrote: > On Tue, 19 Nov 2013, Jakub Jelinek wrote: > >> On Tue, Nov 19, 2013 at 04:30:21PM +0530, Venkataramanan Kumar wrote: >> > This is RFC patch that adds machine descriptions to support stack >> >

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-22 Thread Venkataramanan Kumar
To make GCC for AArch64 generate TLS based stack access for glibc >= 2.19 I need to introduce a new macro TARGET_LIBC_PROVIDES_TLS_SSP and check and set it for glibc >= 2.19 in GCC configure . Any better approach to this since it is specific to Aarch64? regards, Venkat. On 20 Novembe

[RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-26 Thread Venkataramanan Kumar
guard access for aarch64. I have posted code snippet here. http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02968.html ChangeLog: 2013-11-26 Venkataramanan Kumar * configure.ac (gcc_cv_libc_provides_tls_ssp): Add test to check TLS support in target C library for Aarch64.

[RFC][ARM]: Fix reload spill failure (PR 60617)

2014-06-16 Thread Venkataramanan Kumar
Hi Maintainers, This patch fixes the PR 60617 that occurs when we turn on reload pass in thumb2 mode. It occurs for the pattern "*ior_scc_scc" that gets generated for the 3 argument of the below function call. JIT:emitStoreInt32(dst,regT0m, (op1 == dst || op2 == dst))); (snip---) (insn 634

Re: [RFC][ARM]: Fix reload spill failure (PR 60617)

2014-06-18 Thread Venkataramanan Kumar
Hi Ramana, On 18 June 2014 15:29, Ramana Radhakrishnan wrote: > On Mon, Jun 16, 2014 at 1:53 PM, Venkataramanan Kumar > wrote: >> Hi Maintainers, >> >> This patch fixes the PR 60617 that occurs when we turn on reload pass >> in thumb2 mode. >> >> It

Re: [RFC][ARM]: Fix reload spill failure (PR 60617)

2014-07-07 Thread Venkataramanan Kumar
Hi Ramana/Maxim, On 18 June 2014 16:05, Venkataramanan Kumar wrote: > Hi Ramana, > > On 18 June 2014 15:29, Ramana Radhakrishnan wrote: >> On Mon, Jun 16, 2014 at 1:53 PM, Venkataramanan Kumar >> wrote: >>> Hi Maintainers, >>> >>> This patc

Re: [RFC] Tighten memory type assumption in RTL combiner pass.

2015-01-15 Thread Venkataramanan Kumar
Hi jeff and Richard On 15 January 2015 at 03:10, Jeff Law wrote: > On 01/14/15 04:27, Venkataramanan Kumar wrote: >> >> Hi all, >> >> When trying to debug GCC combiner pass with the test case in PR63949 >> ref https://gcc.gnu.org/bugzilla/show_bug.cgi?id

[PATCH]: Conditionally include target specific files while building TSAN

2015-01-20 Thread Venkataramanan Kumar
Hi all, This patch changes make file and configure under libsanitizer, to separate out X86_64 specific file "tsan_rtl_amd64.S" from getting build for targets other than X86_64. Ok for trunk? Please review. regards, Venkat, ChangeLog 2015-01-19 Venkataram

[PING] : [RFC] Tighten memory type assumption in RTL combiner pass.

2015-01-22 Thread Venkataramanan Kumar
ping. Segher do you any comments from your side. regards, Venkat. On 14 January 2015 at 16:57, Venkataramanan Kumar wrote: > Hi all, > > When trying to debug GCC combiner pass with the test case in PR63949 > ref https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63949 I came across

[PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-22 Thread Venkataramanan Kumar
ping. Forgot to mention, GCC bootstraps and regression testing passed on x86_64. regards, Venkat. On 20 January 2015 at 18:51, Venkataramanan Kumar wrote: > Hi all, > > This patch changes make file and configure under libsanitizer, to > separate out X86_64 specific file "

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-22 Thread Venkataramanan Kumar
Thu, Jan 22, 2015 at 07:30:50PM +0530, Venkataramanan Kumar wrote: >> ping. >> >> Forgot to mention, GCC bootstraps and regression testing passed on x86_64. > > Well, without a change from upstream to guard the HACKY_CALL and actual tsan > port to non-x86_64 thi

Re: [PING] : [RFC] Tighten memory type assumption in RTL combiner pass.

2015-01-22 Thread Venkataramanan Kumar
Thank you Segher, I will send an updated patch for stage 1. regards, Venkat. On 22 January 2015 at 21:46, Segher Boessenkool wrote: > On Thu, Jan 22, 2015 at 07:29:28PM +0530, Venkataramanan Kumar wrote: >> ping. Segher do you any comments from your side. > > I agree com

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-23 Thread Venkataramanan Kumar
Jan 22, 2015 at 5:03 PM, Jakub Jelinek wrote: >> > On Thu, Jan 22, 2015 at 07:30:50PM +0530, Venkataramanan Kumar wrote: >> >> ping. >> >> >> >> Forgot to mention, GCC bootstraps and regression testing passed on x86_64. >> > >> > Well,

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-23 Thread Venkataramanan Kumar
Hi Rainer, Yes thanks I will work on fixing this. Let me know if I need to revert the patch meanwhile. regards, Venkat. On 24 January 2015 at 02:23, Rainer Orth wrote: > Hi Venkat, > >> I committed the patch with the change log corrections you said. >> >> https://gcc.gnu.org/viewcvs/gcc?view=re

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-23 Thread Venkataramanan Kumar
Biotechnology, Bielefeld University Index: libsanitizer/ChangeLog === --- libsanitizer/ChangeLog (revision 220077) +++ libsanitizer/ChangeLog (working copy) @@ -1,5 +1,10 @@ 2015-01-25 Venkataramanan Kumar + * configure.

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-24 Thread Venkataramanan Kumar
Hi Rainer, Please find the corrected patch attached. I removed some eval statements I added for debugging. regards, Venkat, On 24 January 2015 at 13:23, Venkataramanan Kumar wrote: > Hi Rainer, > > I reused libgcc's "host_address" test and the patch passed norm

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-24 Thread Venkataramanan Kumar
Hi Jakub, On 24 January 2015 at 14:40, Jakub Jelinek wrote: > On Sat, Jan 24, 2015 at 01:23:22PM +0530, Venkataramanan Kumar wrote: >> I reused libgcc's "host_address" test and the patch passed normal >> bootstrap in x86_64. >> >> Can you please chec

Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN

2015-01-24 Thread Venkataramanan Kumar
Hi Jakub, Thank you and I committed the patch https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=220083. regards, Venkat. On 24 January 2015 at 20:38, Jakub Jelinek wrote: > On Sat, Jan 24, 2015 at 08:09:24PM +0530, Venkataramanan Kumar wrote: >> Index: libsaniti

[RFC] Tighten memory type assumption in RTL combiner pass.

2015-01-14 Thread Venkataramanan Kumar
Hi all, When trying to debug GCC combiner pass with the test case in PR63949 ref https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63949 I came across this code. This code in "make_compound_operation" assumes that all PLUS and MINUS RTX are "MEM" type for scalar int modes and tries to optimize based o

[Patch, Aarch64] [RFC] : Macros for profile code generation to enable gprof support

2013-05-08 Thread Venkataramanan Kumar
2013-05-09 Venkataramanan Kumar * config/aarch64/aarch64.h (MCOUNT_NAME): Define. (NO_PROFILE_COUNTERS): Likewise. (PROFILE_HOOK): Likewise. (FUNCTION_PROFILER): Likewise. * config/aarch64/aarch64.c (aarch64_return_addr): Handle returning address fr

Re: [Patch, Aarch64] [RFC] : Macros for profile code generation to enable gprof support

2013-05-12 Thread Venkataramanan Kumar
elf targets which uses newlib. Patch1 - gcc/ChangeLog - 2013-05-12 Venkataramanan Kumar * config/aarch64/aarch64.c (aarch64_return_addr): Handle returning address from a frame. Patch2 -- 2013-05-12 Venkataramanan Kumar * config/aarch64

Re: [PATCH v2 AArch64]: Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern.

2014-09-16 Thread Venkataramanan Kumar
eded for the clobber, so that GCC will allocate a fresh register. regards, Venkat. On 17 September 2014 03:06, Andrew Pinski wrote: > On Thu, Sep 4, 2014 at 1:18 AM, James Greenhalgh > wrote: >> On Thu, Sep 04, 2014 at 08:42:31AM +0100, Venkataramanan Kumar wrote: >>>

[Patch, Aarch64]: Handle return address via. frame pointer

2013-07-28 Thread Venkataramanan Kumar
Hi Maintainers, This patch adds supports to handle return address via. frame pointer. gcc/ChangeLog - 2013-07-28 Venkataramanan Kumar * config/aarch64/aarch64.c (aarch64_return_addr): Handle returning address from a frame. Regression tested with

[Patch, Aarch64] : Macros for profile code generation to enable gprof support

2013-07-28 Thread Venkataramanan Kumar
Hi Maintainers, This patch defines some macros that are needed for profile generation support in Aarch64. I tested this patch on top of the patch http://gcc.gnu.org/ml/gcc-patches/2013-07/msg01333.html Regression tested with aarch64-none-elf with V8 foundation model after re basing to latest gcc

Re: [Patch, Aarch64]: Handle return address via. frame pointer

2013-07-29 Thread Venkataramanan Kumar
ction which uses _builtin_return_address(1), even when -fomit-frame-pointer is used. regards, venkat. On 29 July 2013 11:57, Andrew Pinski wrote: > On Sun, Jul 28, 2013 at 3:53 AM, Venkataramanan Kumar > wrote: >> Hi Maintainers, >> >> This patch adds supports to handle

[RFC Patch, Aarch64] : Macros for profile code generation to enable gprof support

2013-08-03 Thread Venkataramanan Kumar
bc as well. 2013-08-02 Venkataramanan Kumar * config/aarch64/aarch64.h (MCOUNT_NAME): Define. (NO_PROFILE_COUNTERS): Likewise. (PROFILE_HOOK): Likewise. (FUNCTION_PROFILER): Likewise. * config/aarch64/aarch64.c (aarch64_function_profiler): Remove.

Re: [RFC Patch, Aarch64] : Macros for profile code generation to enable gprof support

2013-08-09 Thread Venkataramanan Kumar
ping! On 3 August 2013 23:31, Venkataramanan Kumar wrote: > Hi Maintainers, > > This patch adds macros to support gprof in Aarch64. The difference > from the previous patch is that the compiler, while generating > "mcount" routine for an instrumented function, also passe

[RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.

2014-01-22 Thread Venkataramanan Kumar
x0, [x19] eor x0, x1, x0 cbnzx0, .L7 Please let me know if this change is fine for Aarch64. 2014-01-22 Venkataramanan Kumar * config/aarch64/aarch64.md (stack_protect_set, stack_protect_test) (stack_protect_set_, stack_protect_test_): Add machine descri

Re: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.

2014-01-26 Thread Venkataramanan Kumar
ping. On 22 January 2014 22:27, Venkataramanan Kumar wrote: > Hi Marcus, > > After we changed the frame growing direction (downwards) in Aarch64, > the back-end now generates stack smashing set and test based on > generic code available in GCC. > > But most of the ports (i3

[Ping]: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.

2014-01-30 Thread Venkataramanan Kumar
Can someone review this please. regards, Venkat. On 22 January 2014 22:27, Venkataramanan Kumar wrote: > Hi Marcus, > > After we changed the frame growing direction (downwards) in Aarch64, > the back-end now generates stack smashing set and test based on > generic code available

Re: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.

2014-02-05 Thread Venkataramanan Kumar
oes a run time test. It failed in cross compilation environment and these are compile only tests. Also I thought richard suggested me to add a new option for this. ref: http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03358.html regards, Venkat. On 4 February 2014 21:39, Marcus Shawcroft wrote: > H

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Venkataramanan Kumar
Hi Jiong, (Snip) + && (op0 == virtual_stack_vars_rtx + || op0 == frame_pointer_rtx + || op0 == arg_pointer_rtx) (Snip) The above check is means that these are the ways to access the frame. is it possible to have stack_pointer_rtx has op0? On 1 August 2014 14:01, Jiong Wang wrote: >

[PATCH 2/2, AARCH64] Test case changes: Re: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.

2014-03-19 Thread Venkataramanan Kumar
s that is a > different issue. > I used the existing dg-require-effective-target check, "stack_protector" and added it in a separate line. ChangeLog. 2014-03-19 Venkataramanan Kumar * g++.dg/fstack-protector-strong.C: Add effetive target check for stack protec

[PATCH 1/2, AARCH64]: Machine descriptions: Re: [RFC] [PATCH, AARCH64] : Using standard patterns for stack protection.

2014-03-19 Thread Venkataramanan Kumar
Hi Marcus, On 14 March 2014 19:42, Marcus Shawcroft wrote: > Hi Venkat > > On 5 February 2014 10:29, Venkataramanan Kumar > wrote: >> Hi Marcus, >> >>> + "ldr\\t%x2, %1\;str\\t%x2, %0\;mov\t%x2,0" >>> + [(set_attr "length" "1

[Patch, AArch64, AArch64-4.7] Backport Optimize cmp in some cases patch

2013-01-27 Thread Venkataramanan Kumar
Hi Maintainers, The attached patch backports the gcc trunk patch http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00143.html to "ARM/aarch64-4.7-branch" branch. ChangeLog.aarch64 2013-01-27 Venkataramanan Kumar Backport from mainline. 2013-01-04 Andrew Pinski