Re: [PATCH 0/3] picolibc: Add picolibc linking help

2022-08-25 Thread Kito Cheng via Gcc-patches
I am thinking that maybe we should add -mlibc=[newlib|newlib-nano|picolibc|unknown] option to bare-matel toolchain, one reason is having an unify interface to select libc implementation between clang/LLVM, spec file is a GCC specific stuff, that cause very bad compatibility between GCC and clang/LL

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Linux, On 8/25/22 02:52, Linus Torvalds wrote: On Wed, Aug 24, 2022 at 4:36 PM Alejandro Colomar wrote: I'm trying to be nice, and ask for review to make sure I'm not making some big mistake by accident, and I get disrespect? No thanks. You've been told multiple times that the kernel do

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 09:20 +0200, Alejandro Colomar via Gcc-patches wrote: > I don't know for sure, and I never pretended to say otherwise.  But what > IMHO the kernel could do is to make the types compatible, by typedefing > to the same fundamental types (i.e., long or long long) that user-spac

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Linus Torvalds
On Wed, Aug 24, 2022 at 11:41 PM Florian Weimer wrote: > > The justifications brought forward are just regurgitating previous > misinformation. If you do that, it's hard to take you seriously. Pot, meet kettle. > There is actually a good reason for using __u64: it's always based on > long long,

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Greg, On 8/25/22 07:57, Greg Kroah-Hartman wrote: On Thu, Aug 25, 2022 at 01:36:10AM +0200, Alejandro Colomar wrote: But from your side what do we have? Just direct NAKs without much explanation. The only one who gave some explanation was Greg, and he vaguely pointed to Linus's comments ab

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Linus Torvalds
On Thu, Aug 25, 2022 at 12:20 AM Alejandro Colomar wrote: > > This patch is not about kernel, but about the section 2 and 3 manual > pages, which are directed towards user-space readers most of the time. They are about the types to the kernel interfaces. Those types that the kernel defines and ex

[PATCH] internal-fn, tree-cfg, v2: Fix .TRAP handling and another __builtin_trap vops issue [PR106099]

2022-08-25 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 24, 2022 at 10:20:45AM +, Richard Biener wrote: > So > >combined_fn cfn = builtin_cfn_unreachable (); >gimple_build (&gsi, false, GSI_NEW_STMT, cfn, void_type_node); > > ? So what about just using existing call that creates the GIMPLE call, whether it is builtin call or i

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Xi, On 8/25/22 09:28, Xi Ruoyao wrote: On Thu, 2022-08-25 at 09:20 +0200, Alejandro Colomar via Gcc-patches wrote: I don't know for sure, and I never pretended to say otherwise.  But what IMHO the kernel could do is to make the types compatible, by typedefing to the same fundamental types (i

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
Hi Linus, (Oops, I mistyped you name in my previous reply; I'm on a roll for funny typos this week it seems) On 8/25/22 09:42, Linus Torvalds wrote: On Thu, Aug 25, 2022 at 12:20 AM Alejandro Colomar wrote: This patch is not about kernel, but about the section 2 and 3 manual pages, which a

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Alejandro Colomar via Gcc-patches
On 8/25/22 09:44, Alejandro Colomar wrote: Hi Greg, On 8/25/22 07:57, Greg Kroah-Hartman wrote: On Thu, Aug 25, 2022 at 01:36:10AM +0200, Alejandro Colomar wrote: But from your side what do we have?  Just direct NAKs without much explanation.  The only one who gave some explanation was Greg, a

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 09:48 +0200, Alejandro Colomar wrote: > Hi Xi, > > On 8/25/22 09:28, Xi Ruoyao wrote: > > On Thu, 2022-08-25 at 09:20 +0200, Alejandro Colomar via Gcc-patches > > wrote: > > > I don't know for sure, and I never pretended to say otherwise.  But what > > > IMHO the kernel could

Re: [PATCH] internal-fn, tree-cfg, v2: Fix .TRAP handling and another __builtin_trap vops issue [PR106099]

2022-08-25 Thread Richard Biener via Gcc-patches
On Thu, 25 Aug 2022, Jakub Jelinek wrote: > On Wed, Aug 24, 2022 at 10:20:45AM +, Richard Biener wrote: > > So > > > >combined_fn cfn = builtin_cfn_unreachable (); > >gimple_build (&gsi, false, GSI_NEW_STMT, cfn, void_type_node); > > > > ? > > So what about just using existing call

Re: [PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol

2022-08-25 Thread Lulu Cheng
在 2022/8/24 下午10:03, Xi Ruoyao 写道: SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))" before invoking "SYMBOL_REF_TLS_MODEL (x)", indicating that it's now possi

[PATCH] m32c-rtems: remove obsoleted port

2022-08-25 Thread Martin Liška
Remove the port that has been marked obsolete in GCC 12 change notes. Ready to be installed? Thanks, Martin contrib/ChangeLog: * config-list.mk: Remove the port. gcc/ChangeLog: * config.gcc: Remove the port. * config/m32c/rtems.h: Removed. libgcc/ChangeLog: *

[PATCH] tree-optimization/106737 - remove intermediate SSA verification in autopar

2022-08-25 Thread Richard Biener via Gcc-patches
The following removes intermediate SSA verification in autopar which isn't expected to succeed after previous changes delaying (virtual) SSA update to the end of the pass. Pushed as obvious. PR tree-optimization/106737 * tree-parloops.cc (transform_to_exit_first_loop_alt): Do not

[PATCH] c++, v2: Implement C++23 P2071R2 - Named universal character escapes [PR106648]

2022-08-25 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 24, 2022 at 04:22:17PM -0400, Jason Merrill wrote: > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > Does the copyright 2005-2022 mean that this code is partly derived from some > other? Yes, I was lazy and started by copying over makeucnid.cc which also par

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Lulu Cheng
在 2022/8/24 下午10:12, Xi Ruoyao 写道: On Wed, 2022-08-24 at 22:08 +0800, Xi Ruoyao wrote: v1 -> v2:  * Avoid introduce of SYMBOL_PCREL32, use SYMBOL_PCREL for 32-bit PC    relative.  * Rebase onto a bug fix ([1/2] in the series) to avoid merge conflict.  * Fix missed ChangeLog entries. Rese

Re: [PATCH] Teach vectorizer to deal with bitfield accesses (was: [RFC] Teach vectorizer to deal with bitfield reads)

2022-08-25 Thread Andre Vieira (lists) via Gcc-patches
On 17/08/2022 13:49, Richard Biener wrote: Yes, of course. What you need to do is subtract DECL_FIELD_BIT_OFFSET of the representative from DECL_FIELD_BIT_OFFSET of the original bitfield access - that's the offset within the representative (by construction both fields share DECL_FIELD_OFFSET).

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 16:53 +0800, Lulu Cheng wrote: > I think this should add a sentence: > > > "Currently, the identifier name can only be one of small or extreme." I'll add this line and spend some time trying to see how to reliably reproduce the ICE mentioned in 1/2 before committing. >

[PATCH] middle-end: Add MULT_EXPR recognition for cond scalar reduction

2022-08-25 Thread Kong, Lingling via Gcc-patches
Hi, The conditional mult reduction cannot be recognized with current GCC. The following loop cannot be vectorized. Now add MULT_EXPR recognition for conditional scalar reduction. float summa(int n, float *arg1, float *arg2) { int i;

[PATCH] regenerate configure files and config.h.in files

2022-08-25 Thread Martin Liška
Hi. I wrote a scipt that runs autoconf in all folders that have configure.ac file and same for autoheader (where AC_CONFIG_HEADERS is present) and this is the output. The script can be seen here: https://github.com/marxin/script-misc/blob/master/gcc-autoconf-all.py I'm going to add the script to

Re: Rust frontend patches v2

2022-08-25 Thread Philip Herron
Hi everyone I noticed a few patches still didn't make it through here with the 400kb limit. In the meantime, Mark pointed out to me that they can all be viewed over here: https://inbox.sourceware.org/gcc-patches/20220824115956.737931-9-philip.her...@embecosm.com/T/#rbff0bb3df2780fecd9ee3d2baa864d

Re: Rust frontend patches v2

2022-08-25 Thread Martin Liška
On 8/25/22 11:46, Philip Herron wrote: > The missing patches on > https://gcc.gnu.org/pipermail/gcc-patches/2022-August/thread.html#600200 > are 8, 10, 13, 29, and 22. Hmm, I think our limit is pretty low, sorry for that. Can you please paste output of du -hs 00*? What about limit increase, how

Patch ping (was Re: [PATCH] libstdc++: Clear padding bits in atomic compare_exchange)

2022-08-25 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 18, 2022 at 09:48:19PM +, Jonathan Wakely via Gcc-patches wrote: > On Tue, 2 Nov 2021 at 01:26, Thomas Rodgers wrote: > > > This should address Jonathan's feedback and adds support for atomic_ref > > > > > >This change implements P0528 which requires that padding bits not > >par

Re: Rust frontend patches v2

2022-08-25 Thread Philip Herron
Hi Martin 4.0K0001-Use-DW_ATE_UTF-for-the-Rust-char-type.patch 8.0K0002-gccrs-Add-nessecary-hooks-for-a-Rust-front-end-tests.patch 8.0K0003-gccrs-Add-Debug-info-testsuite.patch 12K 0004-gccrs-Add-link-cases-testsuite.patch 356K0005-gccrs-Add-general-compilation-test-cases.patch

Re: [PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 16:29 +0800, Lulu Cheng wrote: > > 在 2022/8/24 下午10:03, Xi Ruoyao 写道: >   > > SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS > > invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. > > > > r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))"

Re: Rust frontend patches v2

2022-08-25 Thread Mark Wielaard
Hi Martin, On Thu, 2022-08-25 at 11:52 +0200, Martin Liška wrote: > What about limit increase, how much space do we have on sourceware > infrastructure? Feel free to increase the limits, there is a couple of hundred GB free on sourceware and we can add more. The public-inbox instance at inbox.so

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 17:12 +0800, Xi Ruoyao via Gcc-patches wrote: > On Thu, 2022-08-25 at 16:53 +0800, Lulu Cheng wrote: > > I think this should add a sentence: > > > > > > "Currently, the identifier name can only be one of small or > > extreme." > > I'll add this line and spend some time

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Lulu Cheng
在 2022/8/25 下午7:41, Xi Ruoyao 写道: On Thu, 2022-08-25 at 17:12 +0800, Xi Ruoyao via Gcc-patches wrote: On Thu, 2022-08-25 at 16:53 +0800, Lulu Cheng wrote: I think this should add a sentence: "Currently, the identifier name can only be one of small or extreme." I'll add this line and

Re: [PATCH V4] rs6000: Optimize cmp on rotated 16bits constant

2022-08-25 Thread Jiufu Guo via Gcc-patches
Hi, Segher Boessenkool writes: > On Wed, Aug 24, 2022 at 03:48:49PM +0800, Jiufu Guo wrote: >> Segher Boessenkool writes: >> >> + "TARGET_POWERPC64 && !reload_completed && can_create_pseudo_p () >> > >> > reload_completed in splitters is almost always wrong. It isn't any >> > better if it is

Re: [PATCH] regenerate configure files and config.h.in files

2022-08-25 Thread Richard Sandiford via Gcc-patches
Martin Liška writes: > Hi. > > I wrote a scipt that runs autoconf in all folders that have configure.ac > file and same for autoheader (where AC_CONFIG_HEADERS is present) and > this is the output. > > The script can be seen here: > https://github.com/marxin/script-misc/blob/master/gcc-autoconf-al

Re: [PATCH] regenerate configure files and config.h.in files

2022-08-25 Thread Martin Liška
On 8/25/22 14:21, Richard Sandiford wrote: > Do you know what's going on with these ifndef guards? How were they > there before? There were there since commit 5213506e247206177045f832a0911db0118a8641 Author: Ralf Wildenhues Date: Sat Aug 22 13:22:20 2009 + Regenerate tree using Autoc

Re: [PATCH V4] rs6000: Optimize cmp on rotated 16bits constant

2022-08-25 Thread Segher Boessenkool
Hi! On Thu, Aug 25, 2022 at 08:11:31PM +0800, Jiufu Guo wrote: > Segher Boessenkool writes: > > You usually can split fine if you cannot create new pseudos, by reusing > > existing registers. > > > > FAIL will cause an ICE: the RTL instruction does match, but will fail > > when trying to generate

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jan-Benedict Glaw
On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > Remove the port that has been marked obsolete in GCC 12 change notes. > contrib/ChangeLog: > > * config-list.mk: Remove cr16. Thanks for not forgetting this part! I hope the scripts will properly pick up the cr16 removal. We'll fin

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Martin Liška
On 8/25/22 14:48, Jan-Benedict Glaw wrote: > On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: >> Remove the port that has been marked obsolete in GCC 12 change notes. > >> contrib/ChangeLog: >> >> * config-list.mk: Remove cr16. > > Thanks for not forgetting this part! I hope the scri

Re: Rust frontend patches v2

2022-08-25 Thread Frank Ch. Eigler via Gcc-patches
Hi - > 12K 0004-gccrs-Add-link-cases-testsuite.patch > 356K0005-gccrs-Add-general-compilation-test-cases.patch > 132K0006-gccrs-Add-execution-test-cases.patch > 4.0K0007-gccrs-Add-gcc-check-target-check-rust.patch > 656K0008-gccrs-Add-the-Rust-front-end-AST-data-structures.pat

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jan-Benedict Glaw
On Thu, 2022-08-25 14:50:12 +0200, Martin Liška wrote: > On 8/25/22 14:48, Jan-Benedict Glaw wrote: > > On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > >> Remove the port that has been marked obsolete in GCC 12 change notes. > > > >> contrib/ChangeLog: > >> > >>* config-list.mk: Rem

[PATCH] vect: Tighten get_related_vectype_for_scalar_type

2022-08-25 Thread Richard Sandiford via Gcc-patches
Builds of glibc with SVE enabled have been failing since V1DI was added to the aarch64 port. The problem is that BB SLP starts the (hopeless) attempt to use variable-length modes to vectorise a single-element vector, and that now gets further than it did before. Initially we tried getting a vecto

[PATCH 0/6] Optimise placement of SLP permutations

2022-08-25 Thread Richard Sandiford via Gcc-patches
This series is a follow-up from the RFC that I posted a while back about optimising the placement of SLP permutations. The main comment is in the final patch. Tested on aarch64-linux-gnu and x86_64-linux-gnu. If the series is OK, I'll test on powerpc64le-linux-gnu too before committing. Richard

[PATCH 1/6] Split code out of vectorizable_slp_permutation

2022-08-25 Thread Richard Sandiford via Gcc-patches
A later patch needs to test whether the target supports a lane_permutation_t without having to construct a full SLP node to test that. This patch splits out most of the work of vectorizable_slp_permutation into a subroutine, so that properties of the permutation can be passed explicitly without di

[PATCH 3/6] Make graphds_scc pass the node order back to callers

2022-08-25 Thread Richard Sandiford via Gcc-patches
As a side-effect, graphds_scc constructs a vector in which all nodes in an SCC are listed consecutively. This can be useful information, so that the patch adds an optional pass-back parameter for it. The interface is similar to the one for graphds_dfs. gcc/ * graphds.cc (graphds_scc): Ad

[PATCH 4/6] Rearrange unbounded_hashmap_traits

2022-08-25 Thread Richard Sandiford via Gcc-patches
int_hash combines two kinds of operation: (1) hashing and equality of integers (2) using spare integer encodings to represent empty and deleted slots (1) is really independent of (2), and could be useful in cases where no spare integer encodings are available. This patch adds a base class (int_h

[PATCH 2/6] Split code out of vect_transform_slp_perm_load

2022-08-25 Thread Richard Sandiford via Gcc-patches
Similarly to the previous vectorizable_slp_permutation patch, this one splits out the main part of vect_transform_slp_perm_load so that a later patch can test a permutation without constructing a node for it. Also fixes a lingering use of STMT_VINFO_VECTYPE. gcc/ * tree-vect-slp.cc (vect_

[PATCH 5/6] Add base hash traits for vectors

2022-08-25 Thread Richard Sandiford via Gcc-patches
This patch adds a class that provides basic hash/equal functions for vectors, based on corresponding traits for the element type. gcc/ * hash-traits.h (vec_hash_base): New class. (vec_free_hash_base): Likewise. --- gcc/hash-traits.h | 55 +++

[PATCH 6/6] Extend SLP permutation optimisations

2022-08-25 Thread Richard Sandiford via Gcc-patches
Currently SLP tries to force permute operations "down" the graph from loads in the hope of reducing the total number of permutations needed or (in the best case) removing the need for the permutations entirely. This patch tries to extend it as follows: - Allow loads to take a different permutatio

Re: [PATCH v4] c++: Implement -Wself-move warning [PR81159]

2022-08-25 Thread Jason Merrill via Gcc-patches
On 8/24/22 17:30, Marek Polacek wrote: On Tue, Aug 23, 2022 at 05:27:00PM -0400, Jason Merrill wrote: On 8/23/22 09:39, Marek Polacek wrote: + tree arg = CALL_EXPR_ARG (fn, 0); + extract_op (arg); + if (TREE_CODE (arg) == ADDR_EXPR) +arg = TREE_OPERAND (arg, 0); + tree type = TREE_TYPE

Re: [PATCH] c++, v2: Implement C++23 P2071R2 - Named universal character escapes [PR106648]

2022-08-25 Thread Jason Merrill via Gcc-patches
On 8/25/22 04:49, Jakub Jelinek wrote: On Wed, Aug 24, 2022 at 04:22:17PM -0400, Jason Merrill wrote: Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Does the copyright 2005-2022 mean that this code is partly derived from some other? Yes, I was lazy and started by copyin

Re: Rust frontend patches v2

2022-08-25 Thread Philip Herron
On Thu, 25 Aug 2022 at 13:50, Frank Ch. Eigler wrote: > > Hi - > > > > 12K 0004-gccrs-Add-link-cases-testsuite.patch > > 356K0005-gccrs-Add-general-compilation-test-cases.patch > > 132K0006-gccrs-Add-execution-test-cases.patch > > 4.0K0007-gccrs-Add-gcc-check-target-check-rust.patc

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-08-25 Thread David Edelsohn via Gcc-patches
On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: > > on 2022/8/25 11:37, HAO CHEN GUI wrote: > > Hi, > > > > On 24/8/2022 下午 1:24, Kewen.Lin wrote: > >> Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" > >> all the time, but still > >> having that has_arch_ppc64 effective

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Joseph Myers
On Thu, 25 Aug 2022, Linus Torvalds wrote: > That's a small detail that yes, we've tried to avoid the absolute > humongous mess that the C standard library has with their horrendous > 'PRId*' mess, but honestly, it's just a tiny detail. I've not yet implemented it for glibc or for GCC format chec

[Patch][1/3] libgomp: Prepare for reverse offload fn lookup

2022-08-25 Thread Tobias Burnus
Technically, this patch is stand alone, but conceptually it based on the submitted but not reviewed patch: "[Patch] OpenMP: Support reverse offload (middle end part)" https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598662.html With that patch, for reverse offloads ('omp target device(ancestor

[PATCH] Improve uninit_analysis::collect_phi_def_edges

2022-08-25 Thread Richard Biener via Gcc-patches
This avoids expanding an edge to those of a PHI def if it is not may-undefined, reducing the number of compute_control_dep_chain calls. Bootstrap and regtest in progress on x86_64-unknown-linux-gnu. * gimple-predicate-analysis.cc (uninit_analysis::collect_phi_def_edges): Only expa

[PATCH] Improve compute_control_dep_chain path finding

2022-08-25 Thread Richard Biener via Gcc-patches
This improves the compute_control_dep_chain path finding by first marking the dominating region we search and then making sure to not walk outside if it when enumerating all paths from the dominating block to the interesting PHI edge source. I have limited the DFS walk done for the marking in simi

RE: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread David Laight via Gcc-patches
From: Joseph Myers > Sent: 25 August 2022 15:39 > > On Thu, 25 Aug 2022, Linus Torvalds wrote: > > > That's a small detail that yes, we've tried to avoid the absolute > > humongous mess that the C standard library has with their horrendous > > 'PRId*' mess, but honestly, it's just a tiny detail.

[committed] libstdc++: Some minor cleanups

2022-08-25 Thread Patrick Palka via Gcc-patches
libstdc++-v3/ChangeLog: * include/std/ranges (lazy_split_view::_OuterIter::_M_current): Remove redundant comment. (lazy_split_view::_M_current): Likewise. (common_view::common_view): Remove commented out view-converting constructor as per LWG3405. (e

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-08-25 Thread Segher Boessenkool
On Wed, Aug 24, 2022 at 01:11:39PM +0800, HAO CHEN GUI wrote: > On 23/8/2022 下午 10:26, Segher Boessenkool wrote: > > On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: > >> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c > >> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/s

RE: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Joseph Myers
On Thu, 25 Aug 2022, David Laight wrote: > From: Joseph Myers > > Sent: 25 August 2022 15:39 > > > > On Thu, 25 Aug 2022, Linus Torvalds wrote: > > > > > That's a small detail that yes, we've tried to avoid the absolute > > > humongous mess that the C standard library has with their horrendous >

[Patch][2/3] GCN: libgomp+mkoffload.cc: Prepare for reverse offload fn lookup

2022-08-25 Thread Tobias Burnus
On 25.08.22 16:54, Tobias Burnus wrote: The attached patch prepare for reverse-offload device->host function-address lookup by requesting (if needed) the on-device address. This patch adds the actual implementation for GCN. A variant would be to only generate .offload_func_table inside mkoffloa

[PATCH 2/2] libstdc++: Implement LWG 3692/3702 changes to zip_/zip_transform_view

2022-08-25 Thread Patrick Palka via Gcc-patches
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? libstdc++-v3/ChangeLog: * include/std/ranges (zip_view::_Iterator::operator<): Remove. (zip_view::_Iterator::operator>): Remove. (zip_view::_Iterator::operator<=): Remove. (zip_view::_Iterator::operator>=)

[PATCH 1/2] libstdc++: Implement ranges::zip_transform_view from P2321R2

2022-08-25 Thread Patrick Palka via Gcc-patches
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? libstdc++-v3/ChangeLog: * include/std/ranges (zip_view::_Iterator): Befriend zip_transform_view. (__detail::__range_iter_cat): Define. (zip_transform_view): Define. (zip_transform_view::_Iterator):

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2022 2:38 AM, Martin Liška wrote: Remove the port that has been marked obsolete in GCC 12 change notes. Ready to be installed? Thanks, Martin ChangeLog: * config.sub: Remove cr16. contrib/ChangeLog: * config-list.mk: Remove cr16. gcc/ChangeLog: * config.g

Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming

2022-08-25 Thread Linus Torvalds
On Thu, Aug 25, 2022 at 7:38 AM Joseph Myers wrote: > > I've not yet implemented it for glibc or for GCC format checking, but C23 > adds 'wN' format length modifiers so you will be able to e.g. use "%w64d" > with printf to print an int64_t and won't need those PRI macros any more. Yeah, that's go

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Joseph Myers
On Thu, 25 Aug 2022, Martin Liška wrote: > * config.sub: Remove cr16. config.sub and config.guess are imported verbatim from config.git; any changes should go upstream first. Removal from config.sub would only be appropriate if *no* GNU package wants to support cr16 any more. -- Joseph

Re: [PATCH v2] c: Implement C23 nullptr (N3042)

2022-08-25 Thread Joseph Myers
On Wed, 24 Aug 2022, Marek Polacek via Gcc-patches wrote: > Ah, okay. I had just copied what we do in C++ in null_ptr_cst_p and the > rest of the patch worked under that assumption. I've added some tests > for this too. Except I don't really understand the _Generic comment so > I only have test

[Patch][2/3] nvptx: libgomp+mkoffload.cc: Prepare for reverse offload fn lookup

2022-08-25 Thread Tobias Burnus
On 25.08.22 16:54, Tobias Burnus wrote: The attached patch prepare for reverse-offload device->host function-address lookup by requesting (if needed) the on-device address. This patch adds the actual implementation for NVPTX. Having array[] = {fn1,fn2}; works with nvptx only since sm_35; hen

c: Support C2x empty initializer braces

2022-08-25 Thread Joseph Myers
[Middle-end maintainers / global reviewers, note that there is a gimplify.cc change to be reviewed here.] ISO C2x standardizes empty initializer braces {}. Implement this feature accordingly. The basic case was already supported and so just needed diagnostic adjustments. However, the standard

Re: [PATCH 0/3] picolibc: Add picolibc linking help

2022-08-25 Thread Keith Packard via Gcc-patches
Kito Cheng writes: > I am thinking that maybe we should add > -mlibc=[newlib|newlib-nano|picolibc|unknown] option to bare-matel > toolchain, one reason is having an unify interface to select libc > implementation between clang/LLVM, spec file is a GCC specific stuff, > that cause very bad compati

Re: c: Support C2x empty initializer braces

2022-08-25 Thread Jakub Jelinek via Gcc-patches
On Thu, Aug 25, 2022 at 05:33:02PM +, Joseph Myers wrote: > * gimplify.cc (gimplify_modify_expr): Convert initialization from > a variable-size CONSTRUCTOR to memset before call to > gimplify_modify_expr_rhs. > --- a/gcc/gimplify.cc > +++ b/gcc/gimplify.cc > @@ -6031,6 +6031,

Re: [PATCH] Implement __builtin_issignaling

2022-08-25 Thread Michael Meissner via Gcc-patches
On Mon, Aug 15, 2022 at 12:12:02PM +0200, Jakub Jelinek via Gcc-patches wrote: > Hi! > > The following patch implements a new builtin, __builtin_issignaling, > which can be used to implement the ISO/IEC TS 18661-1 issignaling > macro. I haven't looked in detail at the patch, but from the descrip

Re: [PATCH] Implement __builtin_issignaling

2022-08-25 Thread Jakub Jelinek via Gcc-patches
On Thu, Aug 25, 2022 at 03:23:12PM -0400, Michael Meissner wrote: > On Mon, Aug 15, 2022 at 12:12:02PM +0200, Jakub Jelinek via Gcc-patches wrote: > > Hi! > > > > The following patch implements a new builtin, __builtin_issignaling, > > which can be used to implement the ISO/IEC TS 18661-1 issigna

[PATCH v3] c: Implement C23 nullptr (N3042)

2022-08-25 Thread Marek Polacek via Gcc-patches
On Thu, Aug 25, 2022 at 05:28:09PM +, Joseph Myers wrote: > On Wed, 24 Aug 2022, Marek Polacek via Gcc-patches wrote: > > > Ah, okay. I had just copied what we do in C++ in null_ptr_cst_p and the > > rest of the patch worked under that assumption. I've added some tests > > for this too. Exc

[pushed] dwarf2: use DW_ATE_UTF for C++ char8_t

2022-08-25 Thread Jason Merrill via Gcc-patches
While looking at the Rust changes to dwarf2out I noticed that this was missing from the char8_t support. gcc/ChangeLog: * dwarf2out.cc (base_type_die): Also use DW_ATE_UTF for char8_t. gcc/testsuite/ChangeLog: * g++.dg/debug/dwarf2/utf-1.C: New test. --- gcc/dwarf2out.cc

[pushed] c++: block copy elision in delegating ctor

2022-08-25 Thread Jason Merrill via Gcc-patches
CWG2403 deals with the issue that copy elision is not possible when the initialized object is a potentially-overlapping subobject and the initializer is a function that returns by value. Jonathan pointed out that this also affects delegating constructors, which might be used to construct a base su

Re: c: Support C2x empty initializer braces

2022-08-25 Thread Joseph Myers
On Thu, 25 Aug 2022, Jakub Jelinek via Gcc-patches wrote: > > + && vec_safe_is_empty (CONSTRUCTOR_ELTS (*from_p))) > > Perhaps > && CONSTRUCTOR_NELTS (*from_p) == 0) > instead? > > > +{ > > +maybe_with_size_expr (from_p); > > The indentation above is 8 spaces instead of t

Re: [PATCH v3] c: Implement C23 nullptr (N3042)

2022-08-25 Thread Joseph Myers
On Thu, 25 Aug 2022, Marek Polacek via Gcc-patches wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? This version is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH v4] c++: Implement -Wself-move warning [PR81159]

2022-08-25 Thread Marek Polacek via Gcc-patches
On Thu, Aug 25, 2022 at 09:25:43AM -0400, Jason Merrill wrote: > On 8/24/22 17:30, Marek Polacek wrote: > > On Tue, Aug 23, 2022 at 05:27:00PM -0400, Jason Merrill wrote: > > > On 8/23/22 09:39, Marek Polacek wrote: > > > > + tree arg = CALL_EXPR_ARG (fn, 0); > > > > + extract_op (arg); > > > > +

Re: [PATCH v3] c: Implement C23 nullptr (N3042)

2022-08-25 Thread Marek Polacek via Gcc-patches
On Thu, Aug 25, 2022 at 09:12:07PM +, Joseph Myers wrote: > On Thu, 25 Aug 2022, Marek Polacek via Gcc-patches wrote: > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > This version is OK. Thanks a lot. I've gone ahead and updated GCC 13 changes.html: commit 54b8bcfe7c6

Re: [PATCH v4] c++: Implement -Wself-move warning [PR81159]

2022-08-25 Thread Jason Merrill via Gcc-patches
On 8/25/22 17:49, Marek Polacek wrote: On Thu, Aug 25, 2022 at 09:25:43AM -0400, Jason Merrill wrote: On 8/24/22 17:30, Marek Polacek wrote: On Tue, Aug 23, 2022 at 05:27:00PM -0400, Jason Merrill wrote: On 8/23/22 09:39, Marek Polacek wrote: + tree arg = CALL_EXPR_ARG (fn, 0); + extract_op

[PATCH] libstdc++: Add test for std::con/disjunction's base class

2022-08-25 Thread Patrick Palka via Gcc-patches
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? libstdc++-v3/ChangeLog: * testsuite/20_util/logical_traits/requirements/base_classes.cc: New test. --- .../requirements/base_classes.cc | 37 +++ 1 file changed, 37 insertions(+) create mode 100644

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-08-25 Thread HAO CHEN GUI via Gcc-patches
Hi David, On 25/8/2022 下午 10:01, David Edelsohn wrote: > On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: >> >> on 2022/8/25 11:37, HAO CHEN GUI wrote: >>> Hi, >>> >>> On 24/8/2022 下午 1:24, Kewen.Lin wrote: Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all th

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-08-25 Thread Kewen.Lin via Gcc-patches
on 2022/8/26 10:42, HAO CHEN GUI wrote: > Hi David, > > On 25/8/2022 下午 10:01, David Edelsohn wrote: >> On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: >>> >>> on 2022/8/25 11:37, HAO CHEN GUI wrote: Hi, On 24/8/2022 下午 1:24, Kewen.Lin wrote: > Could you try to test with dg-op

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Martin Liška
On 8/25/22 18:54, Joseph Myers wrote: > On Thu, 25 Aug 2022, Martin Liška wrote: > >> * config.sub: Remove cr16. > > config.sub and config.guess are imported verbatim from config.git; any > changes should go upstream first. Removal from config.sub would only be > appropriate if *no* GNU p

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Martin Liška
On 8/25/22 19:06, Andrew Pinski wrote: > You missed the following one: > gcc/testsuite/lib/target-supports.exp:if { [istarget msp430-*-*] > || [istarget cr16-*-*] } { Thanks, included and installed as r13-2209-geb6358247a9386. Martin

[PATCH][DOCS] Mention removed ports in GCC 13.

2022-08-25 Thread Martin Liška
Ready for master? Thanks, Martin --- htdocs/gcc-13/changes.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/htdocs/gcc-13/changes.html b/htdocs/gcc-13/changes.html index c58ca1d4..e3f2ee44 100644 --- a/htdocs/gcc-13/changes.html +++ b/htdocs/gcc-13/changes.html @@ -28,

[PATCH] Remove uninit_analysis::use_cannot_happen

2022-08-25 Thread Richard Biener via Gcc-patches
As written earlier uninit_analysis::use_cannot_happen is duplicate functionality implemented in a complement way, not adhering to the idea of disproving a may-uninit use and eventually (I have not yet found a testcase it helps to avoid false positives) avoiding false positives because of this or di