Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

2020-08-26 Thread Tobias Burnus
Thanks. I have now committed it as r11-2858-gd58e7173ef964ddac3ab3ad8cc97de8f9f3b32ee Tobias On 8/20/20 6:10 PM, Andre Vehreschild wrote: Hi Tobias, to me this looks OK now. Regards, Andre On Thu, 20 Aug 2020 11:51:50 +0200 Tobias Burnus wrote: Updated patch – taking Andre's suggest

[PATCH] Fortran : ICE on invalid code PR95398

2020-08-26 Thread Mark Eggleston
Please find attach a fix for PR95398.  The original patch was  by Steve Kargl. OK to commit? [PATCH] Fortran  : ICE on invalid code PR95398 The CLASS_DATA macro is used to shorten the code accessing the derived components of an expressions type specification.  If the type is not BT_CLASS the d

Re: [PATCH 1/2] IPA symver: allow multiple symvers for a definition

2020-08-26 Thread Martin Liška
On 8/25/20 8:48 PM, Jan Hubicka wrote: gcc/ChangeLog: * cgraphunit.c (process_symver_attribute): Allow multiple symver attributes for one symbol. * doc/extend.texi: Document the change. gcc/testsuite/ChangeLog: * lib/target-supports-dg.exp: Add dg-require-symve

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread Martin Liška
On 8/25/20 8:46 PM, Jan Hubicka wrote: What will happen here with protected visibility? I forgot about it. Should it be mapped also to "local"? + const char *visibility = NULL; + if (!TREE_PUBLIC (origin_decl)) +visibility = "remove"; + else if (DECL_VISIBILITY (origin_decl) == VISIBILI

[PATCH] fix testcase gcc.target/aarch64/insv_1.c

2020-08-26 Thread Qian Jianhua
There are three failures in gcc.target/aarch64/insv_1.c. FAIL: gcc.target/aarch64/insv_1.c scan-assembler bfi\tx[0-9]+, x[0-9]+, 0, 8 FAIL: gcc.target/aarch64/insv_1.c scan-assembler bfi\tx[0-9]+, x[0-9]+, 16, 5 FAIL: gcc.target/aarch64/insv_1.c scan-assembler movk\tx[0-9]+, 0x1d6b, lsl 32 This

[PATCH] lto: fix documentation about -fpie and -fpic options

2020-08-26 Thread Martin Liška
Hey. We should document how we currently merge pie and pie options as we fixed PR80838. Ready for master? Thanks, Martin gcc/ChangeLog: * doc/invoke.texi: Document how are pie and pic options merged. --- gcc/doc/invoke.texi | 17 ++--- 1 file changed, 14 insertions(+), 3 d

[committed] d: Move d_gimplify_expr and dependencies to d-gimplify.cc

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch moves D-specific tree lowering parts to its own file. Bootstrapped and regression tested on x86_64-linux-gnu/-m32/-mx32, committed to mainline. Regards Iain --- gcc/d/ChangeLog: * Make-lang.in (D_OBJS): Add d-gimplify.o. * d-lang.cc (empty_modify_p): Move to d-gi

[committed] d: Fix no NRVO when returning an array of a non-POD struct

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch fixes another NRVO bug in the D front-end where arrays of non-POD types were not being returns by reference. TREE_ADDRESSABLE was not propagated from the RECORD_TYPE to the ARRAY_TYPE, so NRVO code generation was not being triggered. Regstrapped on x86_64-linux-gnu/-m32/-mx32, com

[committed] d: Use read() to load contents of stdin into memory.

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch replaces getc() with read(), which would be an improvement over reading one character at a time. An ICE was also discovered when mixing reading from stdin with `-v', this has been fixed in upstream DMD and backported as well. Regstrapped on x86_64-linux-gnu/-m32/-mx32, committed t

[committed] d: Fix small struct literals that have non-deterministic hash values

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch addresses the same issue as the first patch for PR96153, only this time, fix it also for structs that are not returned in memory. Tests have been added that triggered an assertion on x86_64, however the original test was failing on SPARC 64-bit targets. Regstrapped on x86_64-linux

[committed] d: Move lowering of each tree node to separate functions

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch moves each lowering in d_gimplify_expr to separate functions. Bootstrapped and regression tested on x86_64-linux-gnu/-m32/-mx32, committed to mainline. Regards Iain --- gcc/d/ChangeLog: * d-gimplify.cc (d_gimplify_expr): Move lowering of each tree node to separat

[committed] d: Don't run all permutations for fail_compilation tests.

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch turns off permutations for fail_compilatation tests if the test file did not request its own options. Fail compilation tests only check for language errors from the front-end, all default option switches do nothing to alter the error. Regression tested on x86_64-linux-gnu/-m32/-mx

[committed] d: Merge upstream dmd cb4a96fae

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch merges the D front-end implementation with upstream dmd cb4a96fae. Fixes both a bug where compilation would hang, and an issue where recursive template limits are hit too early. Regstrapped on x86_64-linux-gnu/-m32/-mx32, committed to mainline, and cherry-picked to the releases/gc

[committed] d: Merge upstream dmd e49192807

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch merges the D front-end implementation with upstream dmd e49192807. 1. Removes prelude assert for constructors and destructors. To trigger these asserts one needed to construct or destruct an aggregate at the null memory location. This would crash upon any data member access, whic

[committed] d: Fix no RVO when returning struct literals initialized with constructor.

2020-08-26 Thread Iain Buclaw via Gcc-patches
Hi, This patch backports a change from upstream dmd that moves front-end NRVO checking from ReturnStatement semantic to the end of FuncDeclaration semantic. In the codegen, retStyle has been partially implemented so that only structs and static arrays return RETstack. This isn't accurate, but do

[PATCH] dwarf2out: Fix up dwarf2out_next_real_insn caching [PR96729]

2020-08-26 Thread Jakub Jelinek via Gcc-patches
Hi! The addition of NOTE_INSN_BEGIN_STMT and NOTE_INSN_INLINE_ENTRY notes reintroduced quadratic behavior into dwarf2out_var_location. This function needs to know the next real instruction to which the var location note applies, but the way final_scan_insn is called outside of final.c main loop do

Re: [PATCH] dwarf2out: Fix up dwarf2out_next_real_insn caching [PR96729]

2020-08-26 Thread Richard Biener
On Wed, 26 Aug 2020, Jakub Jelinek wrote: > Hi! > > The addition of NOTE_INSN_BEGIN_STMT and NOTE_INSN_INLINE_ENTRY notes > reintroduced quadratic behavior into dwarf2out_var_location. > This function needs to know the next real instruction to which the var > location note applies, but the way fi

Re: [PATCH] lra: Canonicalize mult to shift in address reloads

2020-08-26 Thread Richard Sandiford
Alex Coplan writes: > Hello, > > Inside a (mem) RTX, it is canonical to write multiplications by powers > of two using a (mult) [0]. For example, given the following C function: > > long f(long *p, long x) > { > return p[x]; > } > > AArch64 GCC generates the following RTL insn (in final): > >

Re: [PATCH] Implement no_stack_protect attribute.

2020-08-26 Thread Martin Liška
On 8/25/20 4:46 PM, Nick Desaulniers wrote: This would solve a common pattern in the kernel where folks are using `extern inline` with `gnu_inline` semantics or worse (empty `asm("");` statements) in certain places where it would be much more preferable to have this attribute. Thank you very muc

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread Jan Hubicka
> On 8/25/20 8:46 PM, Jan Hubicka wrote: > > What will happen here with protected visibility? > > I forgot about it. Should it be mapped also to "local"? > > + const char *visibility = NULL; > + if (!TREE_PUBLIC (origin_decl)) > +visibility = "remove"; > + else if (DECL_VISIBILITY (origin_

[PATCH PR96757] aarch64: ICE during GIMPLE pass: vect

2020-08-26 Thread duanbo (C)
Hi, This is a fix for PR96757. Before vect pass, the main statements of the test case will be optimized like: _1 = d_10(D) > 3; _2 = a_11(D) > m_12(D); _18 = _1 > _2 ? _26 : 0; At the beginning of vectorization analysis, function vect_recog_mask_conversion_pattern proce

Re: [PATCH] fix testcase gcc.target/aarch64/insv_1.c

2020-08-26 Thread Richard Sandiford
Qian Jianhua writes: > There are three failures in gcc.target/aarch64/insv_1.c. > FAIL: gcc.target/aarch64/insv_1.c scan-assembler bfi\tx[0-9]+, x[0-9]+, 0, 8 > FAIL: gcc.target/aarch64/insv_1.c scan-assembler bfi\tx[0-9]+, x[0-9]+, 16, 5 > FAIL: gcc.target/aarch64/insv_1.c scan-assembler movk\

Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions emitted at -O3

2020-08-26 Thread Richard Sandiford
xiezhiheng writes: >> -Original Message- >> From: Richard Sandiford [mailto:richard.sandif...@arm.com] >> Sent: Tuesday, August 25, 2020 7:08 PM >> To: xiezhiheng >> Cc: Richard Biener ; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> em

Re: [PATCH] RX add control register PC

2020-08-26 Thread Darius Galis
Hello, Thank you for adjusting the patch. I don't have commit privileges, so if you could please commit it, that would be great. Best regards, Darius Galis On 25-Aug-20 10:48 PM, Jeff Law wrote: On Tue, 2020-08-18 at 16:05 +0300, Darius Galis wrote: Hello, The following patch is adding the

Re: [PATCH v3] libgcc: Use `-fasynchronous-unwind-tables' for LIB2_DIVMOD_FUNCS

2020-08-26 Thread Richard Biener via Gcc-patches
On Tue, Aug 25, 2020 at 6:32 PM Maciej W. Rozycki wrote: > > Hi Kito, > > > I just found the mail thread about div mod with -fnon-call-exceptions, > > I think keeping the default LIB2_DIVMOD_EXCEPTION_FLAGS unchanged > > should be the best way to go. > > > > Non-call exceptions and libcalls > > ht

Re: [PATCH] lto: fix documentation about -fpie and -fpic options

2020-08-26 Thread Richard Biener via Gcc-patches
On Wed, Aug 26, 2020 at 10:13 AM Martin Liška wrote: > > Hey. > > We should document how we currently merge pie and pie options > as we fixed PR80838. > > Ready for master? OK. > Thanks, > Martin > > gcc/ChangeLog: > > * doc/invoke.texi: Document how are pie and pic options merged. > ---

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread Martin Liška
On 8/26/20 11:22 AM, Jan Hubicka wrote: On 8/25/20 8:46 PM, Jan Hubicka wrote: What will happen here with protected visibility? I forgot about it. Should it be mapped also to "local"? + const char *visibility = NULL; + if (!TREE_PUBLIC (origin_decl)) +visibility = "remove"; + else if (

RE: [PATCH] hppa: PR middle-end/87256: Improved hppa_rtx_costs avoids synth_mult madness.

2020-08-26 Thread Roger Sayle
Hi Dave, > This change is also fine. > > The gcc.target/hppa/shadd-2.c test now fails because there are two additional sh1add instructions. > However, the total number of instructions is the same as before. Just to be on the safe side, I took a deeper look into this. We're now generating a sli

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread Jan Hubicka
> On 8/26/20 11:22 AM, Jan Hubicka wrote: > > > On 8/25/20 8:46 PM, Jan Hubicka wrote: > > > > What will happen here with protected visibility? > > > > > > I forgot about it. Should it be mapped also to "local"? > > > > > > + const char *visibility = NULL; > > > + if (!TREE_PUBLIC (origin_decl)

Re: [PATCH v3] libgcc: Use `-fasynchronous-unwind-tables' for LIB2_DIVMOD_FUNCS

2020-08-26 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 26, 2020 at 01:08:00PM +0200, Richard Biener via Gcc-patches wrote: > You only need -fexceptions for that, then you can throw; from a signal handler > for example. If you want to be able to catch the exception somewhere up > the call chain all intermediate code needs to be compiled so

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread Martin Liška
On 8/26/20 1:27 PM, Jan Hubicka wrote: On 8/26/20 11:22 AM, Jan Hubicka wrote: On 8/25/20 8:46 PM, Jan Hubicka wrote: What will happen here with protected visibility? I forgot about it. Should it be mapped also to "local"? + const char *visibility = NULL; + if (!TREE_PUBLIC (origin_decl))

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-08-26 Thread Alexandre Oliva
On Aug 25, 2020, Jeff Law wrote: > On Tue, 2020-08-25 at 02:16 -0300, Alexandre Oliva wrote: >> On Aug 24, 2020, Richard Biener wrote: >> >> > since the option is quite elaborate on what (sub-)set of regs is >> > supposed to be cleared I'm not sure an implementation not involving >> > any targe

Re: [PATCH 1/5] Don't enable -gvariable-location-views by default for DWARF5.

2020-08-26 Thread Alexandre Oliva
Hello, Mark, On Aug 25, 2020, Mark Wielaard wrote: > On Tue, 2020-08-25 at 01:05 -0300, Alexandre Oliva wrote: >> it would seem to >> make more sense to adopt and promote the proposed extension, >> implemented in =incompat5 in GCC, but it would need some >> implementation work in consumers to at

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread H.J. Lu via Gcc-patches
On Wed, Aug 26, 2020 at 4:34 AM Martin Liška wrote: > > On 8/26/20 1:27 PM, Jan Hubicka wrote: > >> On 8/26/20 11:22 AM, Jan Hubicka wrote: > On 8/25/20 8:46 PM, Jan Hubicka wrote: > > What will happen here with protected visibility? > > I forgot about it. Should it be mapped al

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread Martin Liška
On 8/26/20 2:22 PM, H.J. Lu wrote: What is the question? What are the scenarios where the new syntax: .symver foo, foo@VERS_1, local# Change foo to a local symbol. .symver foo, foo@VERS_2, hidden # Change foo to a hidden symbol. is useful? Thanks, Martin

c++: template operator lookup caching

2020-08-26 Thread Nathan Sidwell
Jason's fix to retain operator lookups inside dependent lambda functions turns out to be needed on the modules branch for all template functions. Because the context for that lookup no longer exists in imports. There were also a couple of shortcomings, which this patch fixes. (a) we conflate '

Re: [PATCH] add move CTOR to auto_vec, use auto_vec for get_loop_exit_edges

2020-08-26 Thread Richard Biener
On Thu, 6 Aug 2020, Richard Biener wrote: > On Thu, 6 Aug 2020, Richard Biener wrote: > > > This adds a move CTOR to auto_vec and makes use of a > > auto_vec return value for get_loop_exit_edges denoting > > that lifetime management of the vector is handed to the caller. > > > > The move CTOR pr

Re: [PATCH 2/2] IPA symver: support visibility and static symbols.

2020-08-26 Thread H.J. Lu via Gcc-patches
On Wed, Aug 26, 2020 at 5:24 AM Martin Liška wrote: > > On 8/26/20 2:22 PM, H.J. Lu wrote: > > What is the question? > > What are the scenarios where the new syntax: > >.symver foo, foo@VERS_1, local# Change foo to a local symbol. foo is local to the file. Use it there is no global refer

[PATCH] tree-optimization/96783 - fix vectorization of negative step SLP

2020-08-26 Thread Richard Biener
This appropriately uses VMAT_ELEMENTWISE when the vectors cannot be filled from a single SLP group until we get more explicit support for negative stride SLP. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. Richard. 2020-08-26 Richard Biener PR tree-optimization/96783

Re: [PATCH] lra: Canonicalize mult to shift in address reloads

2020-08-26 Thread Vladimir Makarov via Gcc-patches
On 2020-08-26 5:06 a.m., Richard Sandiford wrote: Alex Coplan writes: Minor nit, should be formatted as: static rtx canonicalize_reload_addr (rtx addr) Sorry for missing this.  Alex, it should be fixed anyway. I don't think we should we restrict this to (plus (mult X Y) Z), since addresse

Re: [PATCH] Fortran : ICE on invalid code PR95398

2020-08-26 Thread Thomas Koenig via Gcc-patches
Hi Mark, Please find attach a fix for PR95398.  The original patch was  by Steve Kargl. OK to commit? OK. Thanks for taking this on! Regards Thomas

Re: [PATCH] Fortran : ICE for division by zero in declaration PR95882

2020-08-26 Thread Thomas Koenig via Gcc-patches
Hi Mark, OK to commit and backport? OK. Thanks for the patch! Best regards Thomas

RFQ: -R remark options

2020-08-26 Thread Nathan Sidwell
Hi, I had a need to add a new type of informative message on the modules branch, with an option to enable it. The message is not a warning or an error, but just 'hey, you asked if X happens. It happens just here'. This is emitted as a note. I chose -fnote-$NAME for the option, but that wasn

Re: RFQ: -R remark options

2020-08-26 Thread Richard Biener via Gcc-patches
On Wed, Aug 26, 2020 at 3:37 PM Nathan Sidwell wrote: > > Hi, > I had a need to add a new type of informative message on the modules > branch, with an option to enable it. The message is not a warning or an > error, but just 'hey, you asked if X happens. It happens just here'. > This is emitted

Re: [PATCH 1/2] IPA symver: allow multiple symvers for a definition

2020-08-26 Thread Martin Liška
Hi. There's one obvious fix that I've just noticed. I'm going to install it. Martin >From a5d075d595d35cd5d6607bbd9c8b2eb7707ca920 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed, 26 Aug 2020 13:18:14 +0200 Subject: [PATCH] symver: fix attribute matching. gcc/ChangeLog: * cgraphunit.c

Re: RFQ: -R remark options

2020-08-26 Thread David Malcolm via Gcc-patches
On Wed, 2020-08-26 at 09:37 -0400, Nathan Sidwell wrote: > Hi, > I had a need to add a new type of informative message on the modules > branch, with an option to enable it. The message is not a warning or > an > error, but just 'hey, you asked if X happens. It happens just > here'. > This is e

Re: RFQ: -R remark options

2020-08-26 Thread Rainer Orth
Hi Nathan, > Hi, > I had a need to add a new type of informative message on the modules > branch, with an option to enable it. The message is not a warning or an > error, but just 'hey, you asked if X happens. It happens just here'. This > is emitted as a note. I chose -fnote-$NAME for the opti

Re: [PATCH 1/3] vec: add exact argument for various grow functions.

2020-08-26 Thread Martin Liška
On 8/12/20 2:28 PM, Martin Liška wrote: I guess Richi can defend his strategy for this Richi? Martin

Re: RFQ: -R remark options

2020-08-26 Thread Nathan Sidwell
On 8/26/20 9:50 AM, Rainer Orth wrote: Hi Nathan, Hi, I had a need to add a new type of informative message on the modules branch, with an option to enable it. The message is not a warning or an error, but just 'hey, you asked if X happens. It happens just here'. This is emitted as a note. I

[PATCH] tree-optimization/96698 - fix ICE when vectorizing nested cycles

2020-08-26 Thread Richard Biener
This fixes vectorized PHI latch edge updating and delay it until all of the loop is code generated to deal with the case that the latch def is a PHI in the same block. Boostrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-08-26 Richard Biener PR tree-optimization/96698

Re: RFQ: -R remark options

2020-08-26 Thread Nathan Sidwell
On 8/26/20 9:40 AM, Richard Biener wrote: On Wed, Aug 26, 2020 at 3:37 PM Nathan Sidwell wrote: Hi, I had a need to add a new type of informative message on the modules branch, with an option to enable it. The message is not a warning or an error, but just 'hey, you asked if X happens. It ha

Re: PING: Fwd: [PATCH] Rewrite get_size_range for irange API.

2020-08-26 Thread Aldy Hernandez via Gcc-patches
PING * 2 On 8/11/20 1:56 PM, Aldy Hernandez wrote: -- Forwarded message - From: *Aldy Hernandez* mailto:al...@redhat.com>> Date: Thu, Aug 6, 2020, 16:54 Subject: [PATCH] Rewrite get_size_range for irange API. To: mailto:gcc-patches@gcc.gnu.org>> Cc: mailto:mse...@redhat.com>>, A

Re: PING: Fwd: [PATCH] Adjust tree-ssa-strlen.c for irange API.

2020-08-26 Thread Aldy Hernandez via Gcc-patches
PING * 2 On 8/11/20 1:55 PM, Aldy Hernandez wrote: -- Forwarded message - From: *Aldy Hernandez* mailto:al...@redhat.com>> Date: Tue, Aug 4, 2020, 13:34 Subject: [PATCH] Adjust tree-ssa-strlen.c for irange API. To: mailto:gcc-patches@gcc.gnu.org>> Cc: mailto:l...@redhat.com>>, <

Re: RFQ: -R remark options

2020-08-26 Thread Martin Sebor via Gcc-patches
On 8/26/20 7:37 AM, Nathan Sidwell wrote: Hi, I had a need to add a new type of informative message on the modules branch, with an option to enable it.  The message is not a warning or an error, but just 'hey, you asked if X happens.  It happens just here'. This is emitted as a note.  I chose

[PATCH] tree-optimization/96565 - improve DSE with paths ending in noreturn

2020-08-26 Thread Richard Biener
This improves DSEs stmt walking by not considering a DEF without uses for further processing (and thus giving up when there's two paths to follow). Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2020-08-26 Richard Biener PR tree-optimization/96565 * t

Re: [PATCH] lra: Canonicalize mult to shift in address reloads

2020-08-26 Thread Alex Coplan
Thanks for the review, both. On 26/08/2020 09:19, Vladimir Makarov wrote: > > On 2020-08-26 5:06 a.m., Richard Sandiford wrote: > > Alex Coplan writes: > > > > Minor nit, should be formatted as: > > > > static rtx > > canonicalize_reload_addr (rtx addr) > Sorry for missing this.  Alex, it shou

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 25/08/20 15:30 +0100, Jonathan Wakely wrote: On 17/08/20 19:13 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the new proposal.     As we can't remove template parameters I simply restore those that I tried to pass differently _H2 and _ExtractKey, so eventually I only r

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:30 +0100, Jonathan Wakely wrote: On 25/08/20 15:30 +0100, Jonathan Wakely wrote: On 17/08/20 19:13 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the new proposal.     As we can't remove template parameters I simply restore those that I tried to pass differe

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:55 +0100, Jonathan Wakely wrote: On 26/08/20 16:30 +0100, Jonathan Wakely wrote: I'm seeing new FAILures with this: FAIL: 20_util/function_objects/searchers.cc (test for excess errors) UNRESOLVED: 20_util/function_objects/searchers.cc compilation failed to produce executable FAI

Re: c++: template operator lookup caching

2020-08-26 Thread Jason Merrill via Gcc-patches
On 8/26/20 8:30 AM, Nathan Sidwell wrote: Jason's fix to retain operator lookups inside dependent lambda functions turns out to be needed on the modules branch for all template functions.  Because the context for that lookup no longer exists in imports.  There were also a couple of shortcomings,

Re: [PATCH] hppa: PR middle-end/87256: Improved hppa_rtx_costs avoids synth_mult madness.

2020-08-26 Thread Jeff Law via Gcc-patches
On Wed, 2020-08-26 at 12:19 +0100, Roger Sayle wrote: > Hi Dave, > > > This change is also fine. > > > > The gcc.target/hppa/shadd-2.c test now fails because there are two > additional sh1add instructions. > > However, the total number of instructions is the same as before. > > Just to be on the

[Patch] Fortran: Fix absent-optional handling for nondescriptor arrays (PR94672)

2020-08-26 Thread Tobias Burnus
This fixes an issue caused by the patch for PR 94672, which affects both GCC 10 and GCC 11. Only 'sVal' of 'subroutine foo' was affected, the rest is only a crosscheck that it worked for those code paths. (I did check against the dump – which looks fine. I could add dump tests as well. The 'foo'

[PATCH] libstdc++: Fix typo in chrono::year_month_weekday::operator==

2020-08-26 Thread Patrick Palka via Gcc-patches
Tested on x86_64-pc-linux-gnu, does this look OK to commit? libstdc++-v3/ChangeLog: * include/std/chrono (year_month_weekday::operator==): Compare weekday_indexed instead of weekday. * testsuite/std/time/year_month_weekday/1.cc: Augment testcase. --- libstdc++-v3/include/

Re: [PATCH] libstdc++: Fix typo in chrono::year_month_weekday::operator==

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 12:35 -0400, Patrick Palka via Libstdc++ wrote: Tested on x86_64-pc-linux-gnu, does this look OK to commit? OK, thanks. libstdc++-v3/ChangeLog: * include/std/chrono (year_month_weekday::operator==): Compare weekday_indexed instead of weekday. * testsuite/

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:58 +0100, Jonathan Wakely wrote: On 26/08/20 16:55 +0100, Jonathan Wakely wrote: On 26/08/20 16:30 +0100, Jonathan Wakely wrote: I'm seeing new FAILures with this: FAIL: 20_util/function_objects/searchers.cc (test for excess errors) UNRESOLVED: 20_util/function_objects/searchers

[PATCH] libstdc++: Add compile-time checks to__glibcxx_assert [PR 71960]

2020-08-26 Thread Jonathan Wakely via Gcc-patches
This change evaluates __glibcxx_assert checks unconditionally when a function is being constant evaluated (when std::is_constant_evaluated() is true). If the check fails, compilation will fail with an error. If the function isn't being constant evaluated, the normal runtime check will be done if e

Re: c++: template operator lookup caching

2020-08-26 Thread Nathan Sidwell
On 8/26/20 12:06 PM, Jason Merrill wrote: On 8/26/20 8:30 AM, Nathan Sidwell wrote: Jason's fix to retain operator lookups inside dependent lambda functions turns out to be needed on the modules branch for all template functions.  Because the context for that lookup no longer exists in imports.

Re: c++: template operator lookup caching

2020-08-26 Thread Jason Merrill via Gcc-patches
On 8/26/20 12:56 PM, Nathan Sidwell wrote: On 8/26/20 12:06 PM, Jason Merrill wrote: On 8/26/20 8:30 AM, Nathan Sidwell wrote: Jason's fix to retain operator lookups inside dependent lambda functions turns out to be needed on the modules branch for all template functions.  Because the context

Re: c++: template operator lookup caching

2020-08-26 Thread Nathan Sidwell
On 8/26/20 1:07 PM, Jason Merrill wrote: On 8/26/20 12:56 PM, Nathan Sidwell wrote: On 8/26/20 12:06 PM, Jason Merrill wrote: On 8/26/20 8:30 AM, Nathan Sidwell wrote: This still retains only recording on lambdas.  As the comment says, we could enable for all templates. If we're going to

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-08-26 Thread Qing Zhao via Gcc-patches
> On Aug 26, 2020, at 7:02 AM, Alexandre Oliva wrote: > > On Aug 25, 2020, Jeff Law mailto:l...@redhat.com>> wrote: > >> On Tue, 2020-08-25 at 02:16 -0300, Alexandre Oliva wrote: >>> On Aug 24, 2020, Richard Biener wrote: >>> since the option is quite elaborate on what (sub-)set of reg

RE: [Patch 3/5] rs6000, Add TI to TD (128-bit DFP) and TD to TI support

2020-08-26 Thread Carl Love via Gcc-patches
Segher: On Wed, 2020-08-19 at 20:29 -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Aug 11, 2020 at 12:22:59PM -0700, Carl Love wrote: > > +(define_insn "floattitd2" > > + [(set (match_operand:TD 0 "gpc_reg_operand" "=d") > > + (float:TD (match_operand:TI 1 "gpc_reg_operand" "v")))] > > +

[committed] libstdc++: Use correct argument type for __use_alloc [PR 96803]

2020-08-26 Thread Jonathan Wakely via Gcc-patches
The _Tuple_impl constructor for allocator-extended construction from a different tuple type uses the _Tuple_impl's own _Head type in the __use_alloc test. That is incorrect, because the argument tuple could have a different type. Using the wrong type might select the leading-allocator convention wh

[committed] libstdc++: Whitespace changes in

2020-08-26 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/std/tuple (_Tuple_impl): Whitespaces changes for consistent indentation. Also use __enable_if_t alias template. Tested powerpc64le-linux. Committed to trunk. commit af06acfc8de1ddcfd02a4de1200735b5479f086f Author: Jonathan Wakely Date: Wed Aug

Re: PING [Patch][Middle-end]Add -fzero-call-used-regs=[skip|used-gpr|all-gpr|used|all]

2020-08-26 Thread Jeff Law via Gcc-patches
On Wed, 2020-08-26 at 09:02 -0300, Alexandre Oliva wrote: > On Aug 25, 2020, Jeff Law wrote: > > > On Tue, 2020-08-25 at 02:16 -0300, Alexandre Oliva wrote: > > > On Aug 24, 2020, Richard Biener wrote: > > > > > > > since the option is quite elaborate on what (sub-)set of regs is > > > > suppos

[PATCH] x86: Reject target("no-general-regs-only")

2020-08-26 Thread H.J. Lu via Gcc-patches
Reject target("no-general-regs-only") pragma and attribute. gcc/ PR target/96802 * config/i386/i386-options.c (ix86_valid_target_attribute_inner_p): Reject target("no-general-regs-only"). gcc/testsuite/ PR target/96802 * gcc.target/i386/pr96802-1.c: New t

Re: [PATCH] x86: Reject target("no-general-regs-only")

2020-08-26 Thread Uros Bizjak via Gcc-patches
> Reject target("no-general-regs-only") pragma and attribute. > > gcc/ > > PR target/96802 > * config/i386/i386-options.c (ix86_valid_target_attribute_inner_p): > Reject target("no-general-regs-only"). > > gcc/testsuite/ > > PR target/96802 > * gcc.target/i386/pr96802-1.c: New test. > * gcc.target/

Re: [PATCH] hppa: Improve expansion of ashldi3 when !TARGET_64BIT

2020-08-26 Thread Jeff Law via Gcc-patches
On Sun, 2020-08-23 at 00:24 +0100, Roger Sayle wrote: > Hi Dave, > I actually think using plus_xor_ior operator is useful. It means that if > combine, > inlining or some other RTL simplification generates these variants, these > forms > will still be recognized by the backend. It's more typing,

RE: [Patch 4/5] rs6000, Test 128-bit shifts for just the int128 type.

2020-08-26 Thread Carl Love via Gcc-patches
Segher: On Thu, 2020-08-20 at 16:50 -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Aug 11, 2020 at 12:23:05PM -0700, Carl Love wrote: > > +;; 128-bit int modes > > +(define_mode_iterator VEC_I128 [V1TI TI]) > > We already have VSX_TI for this (in vsx.md). Rename that to > something > withou

Re: [PATCH] hppa: Improve expansion of ashldi3 when !TARGET_64BIT

2020-08-26 Thread John David Anglin
On 2020-08-26 4:08 p.m., Jeff Law wrote: > It 3-stages, but trips: > Tests that now fail, but worked before (5 tests): > > gcc.dg/tree-ssa/slsr-13.c scan-tree-dump-times optimized " \\* 4" 2 > gcc.dg/tree-ssa/slsr-13.c scan-tree-dump-times optimized " \\* 4" 2 > gcc.dg/tree-ssa/slsr-13.c scan-tree-

Re: [PATCH] separate reading past the end from -Wstringop-overflow

2020-08-26 Thread Jeff Law via Gcc-patches
On Tue, 2020-06-23 at 20:05 -0600, Martin Sebor wrote: > -Wstringop-overflow is issued for both writing and reading past > the end, even though the latter problem is often viewed as being > lower severity than the former, or at least sufficiently different > to triage separately. In CWE, for examp

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread François Dumont via Gcc-patches
Deeply sorry, I indeed didn't sent the patch I wanted to commit. It was in 3 commits on my side and it looks like I had miss the last one regarding the changes for _ExtractKey. But moreover I had change the ebo helper index wrongly, I missed the abi change here, thanks for fixing it. On 26/

[PATCH 1/3] libstdc++: Implement P1994R1 changes to ranges::elements_view

2020-08-26 Thread Patrick Palka via Gcc-patches
The example from the paper doesn't compile without the proposed resolution for LWG 3406, so we'll add a testcase for this once the proposed resolution is in. libstdc++-v3/ChangeLog: P1994R1: elements_view needs its own sentinel. * include/std/ranges (elements_view::end): Replace t

[PATCH 2/3] libstdc++: elements_view's sentinel and iterator not comparable [LWG 3406]

2020-08-26 Thread Patrick Palka via Gcc-patches
This implements the proposed resolution for LWG 3406 and adds a testcase for the example from P1994R1. libstdc++-v3/ChangeLog: LWG 3406 * include/std/ranges (elements_view::begin): Adjust constraints. (elements_view::end): Likewise. (elements_view::_Sentinel::opera

[PATCH 3/3] libstdc++: Implement remaining piece of LWG 3448

2020-08-26 Thread Patrick Palka via Gcc-patches
Almost all of the proposed resolution for LWG 3448 is already implemented; the only part left is to adjust the return type of transform_view::sentinel::operator-. libstdc++-v3/ChangeLog: LWG 3448 PR libstdc++/95322 * include/std/ranges (transform_view::__distance_from): Gi

Re: [PATCH] rs6000, restrict bfloat convert intrinsic to Power 10. Fix BU_P10V macro definitions.

2020-08-26 Thread Segher Boessenkool
Hi! (All that Will says included by reference ;-) ) On Mon, Aug 24, 2020 at 02:39:41PM -0700, Carl Love wrote: > I attempted to do the backport however the patch doesn't even come > close to applying. The names XVCVBF16SPN and XVCVSPBF16 are the only > two builtin names that exist in GCC 10. Th

Re: [PATCH 2/3] libstdc++: elements_view's sentinel and iterator not comparable [LWG 3406]

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:44 -0400, Patrick Palka via Libstdc++ wrote: This implements the proposed resolution for LWG 3406 and adds a testcase for the example from P1994R1. libstdc++-v3/ChangeLog: LWG 3406 * include/std/ranges (elements_view::begin): Adjust constraints. (elements_

Re: [PATCH 1/3] libstdc++: Implement P1994R1 changes to ranges::elements_view

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:44 -0400, Patrick Palka via Libstdc++ wrote: The example from the paper doesn't compile without the proposed resolution for LWG 3406, so we'll add a testcase for this once the proposed resolution is in. libstdc++-v3/ChangeLog: P1994R1: elements_view needs its own sentinel

Re: [PATCH 3/3] libstdc++: Implement remaining piece of LWG 3448

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:44 -0400, Patrick Palka via Libstdc++ wrote: Almost all of the proposed resolution for LWG 3448 is already implemented; the only part left is to adjust the return type of transform_view::sentinel::operator-. libstdc++-v3/ChangeLog: LWG 3448 PR libstdc++/95322

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-08-26 Thread Segher Boessenkool
On Tue, Aug 25, 2020 at 02:35:51PM -0600, Jeff Law wrote: > I've gone back and forth on pre allocation splitting as well as > post-allocating > splitting and re-allocation. I could argue either side of that discussion -- If you end up wanting something split it is best to do it early. But if y

Re: [PATCH 1/3] vec: add exact argument for various grow functions.

2020-08-26 Thread Jeff Law via Gcc-patches
On Tue, 2020-08-11 at 13:36 +0200, Martin Liška wrote: > Hello. > > All right, I did it in 3 steps: > 1) - new exact argument is added (no default value) - I tested the on > x86_64-linux-gnu > and I build all cross targets. > 2) set default value of exact = false > 3) change places which calculat

Re: [PATCH 2/3] vec: default exact = false in grow functions.

2020-08-26 Thread Jeff Law via Gcc-patches
On Tue, 2020-08-11 at 13:37 +0200, Martin Liška wrote: > From 292532ea9e3d42ca164b9951674c1eccc86a1f11 Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Mon, 10 Aug 2020 12:01:59 +0200 > Subject: [PATCH 2/3] vec: default exect = false in grow functions. > > gcc/ChangeLog: > > * vec.h (

Re: [PATCH 3/3] vec: use inexact growth where possible.

2020-08-26 Thread Jeff Law via Gcc-patches
On Tue, 2020-08-11 at 13:37 +0200, Martin Liška wrote: > From cc1d41a469d76f2f8e4f44bed788ace77a1c6d62 Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Mon, 10 Aug 2020 12:09:19 +0200 > Subject: [PATCH 3/3] vec: use inexact growth where possible. > > gcc/ChangeLog: > > * cfgrtl.c (rtl

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-08-26 Thread Jeff Law via Gcc-patches
On Wed, 2020-08-26 at 15:58 -0500, Segher Boessenkool wrote: > On Tue, Aug 25, 2020 at 02:35:51PM -0600, Jeff Law wrote: > > I've gone back and forth on pre allocation splitting as well as > > post-allocating > > splitting and re-allocation. I could argue either side of that discussion > > -- >

RE: [PATCH] hppa: Improve expansion of ashldi3 when !TARGET_64BIT

2020-08-26 Thread Roger Sayle
The failure of slsr-13.c is not caused by the patchh3.txt, but the previous patchh2.txt that's now on mainline and the gcc-10 branch. That change provided more accurate rtx_costs for hppa, and solved the performance problems with synth_mult. These more accurate target rtx_costs are used by th

Re: [PATCH] [AVX512] [PR87767] Optimize memory broadcast for constant vector under AVX512

2020-08-26 Thread Jeff Law via Gcc-patches
On Tue, 2020-08-04 at 14:05 +0800, Hongtao Liu via Gcc-patches wrote: > Update patch. > > There are a lot of avx512 define_insns which lack corresponding memory > broadcast version, i only add *avx512f_mul3_bcst and > *avx512dq_mul3_bcst in this patch. > > On Fri, Jul 24, 2020 at 10:37 AM Hongtao

Re: [PATCH] hppa: Improve expansion of ashldi3 when !TARGET_64BIT

2020-08-26 Thread Jeff Law via Gcc-patches
On Wed, 2020-08-26 at 22:23 +0100, Roger Sayle wrote: > The failure of slsr-13.c is not caused by the patchh3.txt, but the previous > patchh2.txt > that's now on mainline and the gcc-10 branch. That change provided more > accurate > rtx_costs for hppa, and solved the performance problems with sy

Duplicate .debug_lines (Was: [PATCH 5/5] Add --gdwarf-5 to ASM_SPEC)

2020-08-26 Thread Mark Wielaard
Hi gcc hackers, binutils hackers, Nick, Jakub and I were discussing the gcc patch below and all the ways it is wrong. Most things can be fixed in the spec. Like only passing -gdwarf if we are generating DWARF and passing the right DWARF version as -gdwarf-N for the version that gcc itself creates.

Re: [PATCH] gcov-profile: clarify profile-exclude-files documentation [PR96285]

2020-08-26 Thread Jeff Law via Gcc-patches
On Fri, 2020-07-24 at 15:42 +0200, Martin Liška wrote: > On 7/24/20 1:02 PM, Göran Uddeborg wrote: > > The wording of the description of -fprofile-exclude-files is easy to > > misunderstand. One can be led to believe a file is excluded only if > > it matches all of the patterns, not just one. Thi

Re: [PATCH] i386: Add c99 runtime requirement to math optimisation tests

2020-08-26 Thread Jeff Law via Gcc-patches
On Tue, 2020-08-18 at 18:18 -0400, Pat Bernardi wrote: > A number of i386 math optimisation tests are looking assembly instructions > that are only emitted when the compiler knows the target has a C99 libm > available. Since targets like *-elf may not have such a libm, a C99 runtime > requirement i

libgo patch committed: Add FAT library support for AIX static libraries

2020-08-26 Thread Ian Lance Taylor via Gcc-patches
This libgo patch by Clément Chigot adds FAT library support for static libraries on AIX. Like shared libraries, AIX static libraries must also have both 32 and 64 bit objects. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian a66f773796a78d61891f5e78d275aeb462

  1   2   >