Re: [PATCH][AArch64] PR92424: Fix -fpatchable-function-entry=N,M with BTI

2020-01-19 Thread Fāng-ruì Sòng via gcc-patches
On 2020-01-16, Richard Sandiford wrote: Szabolcs Nagy writes: this affects the linux kernel and technically a wrong code bug so this fix tries to be backportable (fixing all issues with -fpatchable-function-entry=N,M will likely require new option). Even for the backportable version, I think

[PATCH] Remove assertion in get_info_about_necessary_edges (PR ipa/93166)

2020-01-19 Thread Feng Xue OS
Bootstrapped/regtested on x86_64-linux and aarch64-linux. Feng --- 2020-01-19 Feng Xue PR ipa/93166 * ipa-cp.c (get_info_about_necessary_edges): Remove value check assertion.From 02e4bea314a0ca0a8befb85c64efcfe422d35cb8 Mon Sep 17 00:00:00 2001 From: Feng Xue Date: Sun

Fix two issues with multi-target speculative calls

2020-01-19 Thread Jan Hubicka
Hi, this fixes two issues with the new multi-target speculation code which reproduce on Firefox. I can now build firefox with FDO locally but on Mozilla build bots it still fails with ICE in speculative_call_info. One problem is that speuclative code compares call_stmt and lto_stmt_uid in a way t

[wwwdocs] Remove specifics shared by all of GCC from the main Fortran page.

2020-01-19 Thread Gerald Pfeifer
This was triggered by a reference to SVN and dates back to the very early days for GFortran when it was more of a separate projects. Pushed. Gerald --- htdocs/fortran/index.html | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/htdocs/fortran/index.html b/htdocs/fortran/

Re: [PATCH] Remove assertion in get_info_about_necessary_edges (PR ipa/93166)

2020-01-19 Thread Jan Hubicka
> Bootstrapped/regtested on x86_64-linux and aarch64-linux. > > Feng > --- > 2020-01-19 Feng Xue > > PR ipa/93166 > * ipa-cp.c (get_info_about_necessary_edges): Remove value > check assertion. OK. Please next time write short description on the problem in email so one

Re: Fix two issues with multi-target speculative calls

2020-01-19 Thread Jan Hubicka
> Hi, > this fixes two issues with the new multi-target speculation code which > reproduce > on Firefox. I can now build firefox with FDO locally but on Mozilla build > bots > it still fails with ICE in speculative_call_info. > > One problem is that speuclative code compares call_stmt and lto_s

[wwwdocs] Adjustments of "regression hunting" instructions to the post-SVN world.

2020-01-19 Thread Gerald Pfeifer
With Git a clone carries the whole repository, so remove instructions on obtaining a local copy of the repository and related instructions on SVN usage. On the way remove a web link for the contrib/reghunt scripts since those are in the repository anyway. Pushed. Gerald --- htdocs/bugs/reghunt

Re: [wwwdocs] Remove the last reference to svnwrite.html and retire it.

2020-01-19 Thread Gerald Pfeifer
On Fri, 17 Jan 2020, Gerald Pfeifer wrote: > One step^Wfile at a time; next in line: svn.html. Let's make sure old links to svnwrite.html (externally or from our own archives, say) redirect. Pushed. Gerald - Log - commit e48a9f9e

[PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread H.J. Lu
To add x32 support to -mtls-dialect=gnu2, we need to replace DI with P in GNU2 TLS patterns. Since thread pointer is in ptr_mode, PLUS in GNU2 TLS address computation must be done in ptr_mode to support -maddress-mode=long. Also drop the "q" suffix from lea to support both "lea foo@TLSDESC(%rip),

Re: [wwwdocs] Updates to contribute.html for git-friendly posting rules

2020-01-19 Thread Gerald Pfeifer
Hi Richard, On Thu, 9 Jan 2020, Richard Earnshaw (lists) wrote: > The thread on gcc@ is now so long and complicated that this proposal > back at the start has dropped off the radar. With the switch now > imminent I'd like to re-propose this change, this time more formally. I wasn't sure *who*

Re: Copy list of development branches from svn.html into git.html

2020-01-19 Thread Gerald Pfeifer
On Thu, 16 Jan 2020, Joseph Myers wrote: > This patch makes a start on making the branch information from > svn.html available in git.html. Thank you, Joseph. That allowed for https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01089.html which was, from what I can tell, the last reference to that

New repository location

2020-01-19 Thread Bill Schmidt
Question:  Is the new gcc git repository at gcc.gnu.org/git/gcc.git using the same location as the earlier git mirror did?  I'm curious whether our repository on pike is still syncing with the new master, or whether we need to make some adjustments before we next rebase pu against master.

Re: New repository location

2020-01-19 Thread H.J. Lu
On Sun, Jan 19, 2020 at 6:33 AM Bill Schmidt wrote: > > Question: Is the new gcc git repository at gcc.gnu.org/git/gcc.git > using the same location as the earlier git mirror did? I'm curious > whether our repository on pike is still syncing with the new master, or > whether we need to make some

Re: New repository location

2020-01-19 Thread Bill Schmidt
I apologize, I sent this to the wrong mailing list, this had meant to be internal.  But thank you very much for the information!  It appears we have some adjustments to make. Thanks! Bill On 1/19/20 8:46 AM, H.J. Lu wrote: On Sun, Jan 19, 2020 at 6:33 AM Bill Schmidt wrote: Question: Is th

Add speculative call edges verifier and fix one extra bug

2020-01-19 Thread Jan Hubicka
Hi, this patch implements verifier and fixes one bug where speculative calls produced by ipa-devirt ended up having num_speculative_call_targets = 0 instead of 1. lto-profilebootstrapped/regtested x86_64-linux, will commit it shortly. Honza PR lto/93318 * cgraph.c (cgraph_edge::ma

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread Uros Bizjak
On Sun, Jan 19, 2020 at 2:58 PM H.J. Lu wrote: > > To add x32 support to -mtls-dialect=gnu2, we need to replace DI with > P in GNU2 TLS patterns. Since thread pointer is in ptr_mode, PLUS in > GNU2 TLS address computation must be done in ptr_mode to support > -maddress-mode=long. Also drop the "

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread Uros Bizjak
On Sun, Jan 19, 2020 at 6:43 PM Uros Bizjak wrote: > > On Sun, Jan 19, 2020 at 2:58 PM H.J. Lu wrote: > > > > To add x32 support to -mtls-dialect=gnu2, we need to replace DI with > > P in GNU2 TLS patterns. Since thread pointer is in ptr_mode, PLUS in > > GNU2 TLS address computation must be don

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread H.J. Lu
On Sun, Jan 19, 2020 at 9:48 AM Uros Bizjak wrote: > > On Sun, Jan 19, 2020 at 6:43 PM Uros Bizjak wrote: > > > > On Sun, Jan 19, 2020 at 2:58 PM H.J. Lu wrote: > > > > > > To add x32 support to -mtls-dialect=gnu2, we need to replace DI with > > > P in GNU2 TLS patterns. Since thread pointer is

[patch, fortran] Fix PR 85781, ICE on valid

2020-01-19 Thread Thomas König
Hello world, the attached patch fixes an ICE which could occur for empty substrings (see test case). In the spirit of "A patch that works beats an elegant idea every time" I simply set a substring known to be empty to (1:0) so that problems further down the road could be avoided. Regression-tes

Re: [PATCH][AArch64] PR92424: Fix -fpatchable-function-entry=N,M with BTI

2020-01-19 Thread Fāng-ruì Sòng via gcc-patches
On 2020-01-19, Fāng-ruì Sòng wrote: On 2020-01-16, Richard Sandiford wrote: Szabolcs Nagy writes: this affects the linux kernel and technically a wrong code bug so this fix tries to be backportable (fixing all issues with -fpatchable-function-entry=N,M will likely require new option). Even f

[C++ PATCH] Simplify lambda parsing.

2020-01-19 Thread Jason Merrill
Since we removed the special parsing for C++11 lambdas, it's just been an open-coded copy of cp_parser_function_body. So let's call it instead. This avoids the need to change this code in my revised 33799 patch. Tested x86_64-pc-linux-gnu, applying to trunk. * parser.c (cp_parser_lambda

[C++ PATCH] PR c++/33799 - destroy return value, take 2.

2020-01-19 Thread Jason Merrill
This patch differs from the reverted patch for 33799 in that it adds the CLEANUP_STMT for the return value at the end of the function, and only if we've seen a cleanup that might throw, so it should not affect most C++11 code. Tested x86_64-pc-linux-gnu, applying to trunk. * cp-tree.h (cu

[committed] testsuite: Make use of effective-target march_option for cris

2020-01-19 Thread Hans-Peter Nilsson
With march_option in place, here's the rest. (And yes, that cris-linux line in the last context goes away in the patchset putting that target down.) gcc/testsuite: * gcc.dg/torture/pr26515.c (cris*-*-*): Conditionalize -march=v10 option on target ! march_option. * gcc.targ

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread Uros Bizjak
On Sun, Jan 19, 2020 at 7:07 PM H.J. Lu wrote: > > On Sun, Jan 19, 2020 at 9:48 AM Uros Bizjak wrote: > > > > On Sun, Jan 19, 2020 at 6:43 PM Uros Bizjak wrote: > > > > > > On Sun, Jan 19, 2020 at 2:58 PM H.J. Lu wrote: > > > > > > > > To add x32 support to -mtls-dialect=gnu2, we need to replac

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread H.J. Lu
On Sun, Jan 19, 2020 at 12:01 PM Uros Bizjak wrote: > > On Sun, Jan 19, 2020 at 7:07 PM H.J. Lu wrote: > > > > On Sun, Jan 19, 2020 at 9:48 AM Uros Bizjak wrote: > > > > > > On Sun, Jan 19, 2020 at 6:43 PM Uros Bizjak wrote: > > > > > > > > On Sun, Jan 19, 2020 at 2:58 PM H.J. Lu wrote: > > >

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread Uros Bizjak
On Sun, Jan 19, 2020 at 9:07 PM H.J. Lu wrote: > > On Sun, Jan 19, 2020 at 12:01 PM Uros Bizjak wrote: > > > > On Sun, Jan 19, 2020 at 7:07 PM H.J. Lu wrote: > > > > > > On Sun, Jan 19, 2020 at 9:48 AM Uros Bizjak wrote: > > > > > > > > On Sun, Jan 19, 2020 at 6:43 PM Uros Bizjak wrote: > > >

[C++ PATCH] PR c++/93324 - ICE with -Wall on constexpr if.

2020-01-19 Thread Marek Polacek
This is a crash with constexpr if, when trying to see if the call in the if-statement is std::is_constant_evaluated. cp_get_callee_fndecl_nofold can return NULL_TREE and fndecl_built_in_p doesn't expect to get a null tree, so check FNDECL first. Bootstrapped/regtested on x86_64-linux, ok for trun

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread H.J. Lu
On Sun, Jan 19, 2020 at 12:16 PM Uros Bizjak wrote: > > On Sun, Jan 19, 2020 at 9:07 PM H.J. Lu wrote: > > > > On Sun, Jan 19, 2020 at 12:01 PM Uros Bizjak wrote: > > > > > > On Sun, Jan 19, 2020 at 7:07 PM H.J. Lu wrote: > > > > > > > > On Sun, Jan 19, 2020 at 9:48 AM Uros Bizjak wrote: > > >

Re: [C++ PATCH] PR c++/93324 - ICE with -Wall on constexpr if.

2020-01-19 Thread Jakub Jelinek
On Sun, Jan 19, 2020 at 03:34:48PM -0500, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > * semantics.c (is_std_constant_evaluated_p): Check fndecl. > > * g++.dg/cpp1z/constexpr-if33.C: New test. > --- > gcc/cp/semantics.c |

Re: [C++ PATCH v2] PR c++/93324 - ICE with -Wall on constexpr if.

2020-01-19 Thread Marek Polacek
On Sun, Jan 19, 2020 at 10:00:42PM +0100, Jakub Jelinek wrote: > On Sun, Jan 19, 2020 at 03:34:48PM -0500, Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > > > * semantics.c (is_std_constant_evaluated_p): Check fndecl. > > > > * g++.dg/cpp1z/constexpr-if3

[PATCH] Manually handle recursiveness in prepare_block_for_update

2020-01-19 Thread apinski
From: Andrew Pinski Reported as PR 93321, prepare_block_for_update with some huge recusive inlining can go past the stack limit. The loop at the end, could be transformed such that the last iteration goes back to the begining of the function instead of the call. This reduces the stack usage and

Re: [PATCH] Clean up references to Subversion in documentation sources.

2020-01-19 Thread Sandra Loosemore
On 1/13/20 9:12 AM, Joseph Myers wrote: On Mon, 13 Jan 2020, Sandra Loosemore wrote: On 1/13/20 7:02 AM, Eric S. Raymond wrote: Clean up references to SVN in in the GCC docs, redirecting to Git documentation as appropriate. This is OK, although the set of changes for the libstdc++ manual lik

[PATCH Coroutines]Fix false warning message about missing return

2020-01-19 Thread bin.cheng
Hi, The patch sets current_function_returns_value flag in templates for all co_return/co_yield/co_await cases, as well as for ramp function. This fixes false warning message for case like the added, or various cases in cppcoro. Bootstrap and test on X86_64, is it OK? Thanks, bin gcc/cp 2020-01

Re: [OpenACC] libgomp.texi — document acc_*_async and acc_*_finalize(_async) functions

2020-01-19 Thread Sandra Loosemore
On 1/8/20 9:07 AM, Tobias Burnus wrote: When looking at libgomp.texi the other day, I saw that the acc_*_async variants and the acc_*_finalize functions of OpenACC 2.5 were not documented. Hence, this patch adds them. Those are part of OpenACC 2.5, hence, I updated the @ref (but referenced to

Re: [OpenACC] bump version for 2.6 plus libgomp.texi update — document acc_attach/acc_detach, acc_*_async, acc_*_finalize(_async) functions

2020-01-19 Thread Sandra Loosemore
On 1/10/20 9:34 AM, Tobias Burnus wrote: I believe except for bugs and known omissions (e.g. PR93225+93226), the GCC 10 trunk implementation is complete – and the version number can be bumped from 2.0 (alias 201306) to OpenACC 2.6 (alias 201711). That's what this patch does (i.e. applying the

[PATCH Coroutines] Add error messages for missing methods of awaitable class

2020-01-19 Thread JunMa
Hi This patch adds lookup_awaitable_member, it outputs error messages when any of the await_ready/suspend/resume functions are missing in awaitable class. This patch also add some error check on return value of build_co_await since we may failed to build co_await_expr. Bootstrap and test on

[PATCH Coroutines]Fix ICE when co_awaiting on void type

2020-01-19 Thread bin.cheng
Hi, This simple patch skips calling complete_type_or_else for void type, which fixes the corresponding ICE. Thanks, bin gcc/cp 2020-01-20 Bin Cheng * coroutines.cc (build_co_await): Skip getting complete type for void. gcc/testsuite 2020-01-20 Bin Cheng * g++.dg/corouti

[PATCH][amdgcn] Add runtime ISA check for amdgcn offloading

2020-01-19 Thread Harwath, Frederik
Hi, this patch implements a runtime ISA check for amdgcn offloading. The check verifies that the ISA of the GPU to which we try to offload matches the ISA for which the code to be offloaded has been compiled. If it detects a mismatch, it emits an error message which contains a hint at the correct

Re: [PATCH] PR target/93319: x32: Add x32 support to -mtls-dialect=gnu2

2020-01-19 Thread Uros Bizjak
On Sun, Jan 19, 2020 at 10:00 PM H.J. Lu wrote: > > On Sun, Jan 19, 2020 at 12:16 PM Uros Bizjak wrote: > > > > On Sun, Jan 19, 2020 at 9:07 PM H.J. Lu wrote: > > > > > > On Sun, Jan 19, 2020 at 12:01 PM Uros Bizjak wrote: > > > > > > > > On Sun, Jan 19, 2020 at 7:07 PM H.J. Lu wrote: > > > >