Re: [PATCH] PR fortran/81509 and fortran/45513

2018-12-28 Thread Sudakshina Das
Hi Steve On 27/12/18 8:58 PM, Steve Kargl wrote: > On Thu, Dec 27, 2018 at 11:24:07AM +, Sudakshina Das wrote: >> With the failure as: >> >> Excess errors: >> /build/src/gcc/libgomp/testsuite/libgomp.fortran/aligned1.f03:55:14: >> Error: Arguments of 'iand' have different kind type parameters

Re: GCC 8 backports

2018-12-28 Thread Sudakshina Das
Hi Martin On 27/12/18 12:32 PM, Martin Liška wrote: > On 11/20/18 11:58 AM, Martin Liška wrote: >> On 10/3/18 11:23 AM, Martin Liška wrote: >>> On 9/25/18 8:48 AM, Martin Liška wrote: Hi. One more tested patch. Martin >>> One more tested patch. >>> >>> Martin >>> >> H

Re: Fix devirtualiation in expanded thunks

2018-12-28 Thread Sudakshina Das
Hi Jan On 21/12/18 7:20 PM, Jan Hubicka wrote: > Hi, > this patch fixes polymorphic call analysis in thunks. Unlike normal > methods, thunks take THIS pointer offsetted by a known constant. This > needs t be compensated for when calculating address of outer type. > > Bootstrapped/regtested x86_64

Re: [PATCH] cleanup libgomp's coalesce chunk data structures

2018-12-28 Thread Thomas Schwinge
Hi! On Tue, 18 Dec 2018 11:07:07 +0100, Jakub Jelinek wrote: > On Tue, Dec 18, 2018 at 10:59:20AM +0100, Thomas Schwinge wrote: > > [...] > > Ok, thanks. Committed to trunk in r267446: commit 65c9e9f98bd9919ba1a93a87b7ebec4ab30283b2 Author: tschwinge Date: Fri Dec 28 11:33:54 2018 +

Re: For libgomp OpenACC entry points, redefine the "device" argument to "flags"

2018-12-28 Thread Thomas Schwinge
Hi! On Wed, 19 Dec 2018 22:56:05 +0100, I wrote: > On Wed, 19 Dec 2018 15:18:12 +0100, Jakub Jelinek wrote: > > On Wed, Dec 19, 2018 at 03:03:42PM +0100, Jakub Jelinek wrote: > > > On Wed, Dec 19, 2018 at 02:59:54PM +0100, Thomas Schwinge wrote: > > > > Right. For OpenACC, there's no "device" cl

Re: [040/nnn] poly_int: get_inner_reference & co.

2018-12-28 Thread Thomas Schwinge
Hi! On Fri, 21 Dec 2018 12:17:17 +0100, Jakub Jelinek wrote: > On Fri, Dec 21, 2018 at 12:10:26PM +0100, Thomas Schwinge wrote: > > [...] > > Ok, thanks. Committed to trunk in r267447: commit a91917652db3a84fc69baf05468ba6f1aad655b7 Author: tschwinge Date: Fri Dec 28 11:34:03 2018 +

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts (revised, v3)

2018-12-28 Thread Thomas Schwinge
Hi Chung-Lin! On Sat, 22 Dec 2018 00:04:56 +0800, Chung-Lin Tang wrote: > On 2018/12/19 5:03 AM, Thomas Schwinge wrote: > > On Tue, 18 Dec 2018 23:06:38 +0800, Chung-Lin Tang > > wrote: > >> this part includes some of the lookup_goacc_asyncqueue fixes we talked > >> about. > >> I am still thi

Re: [PATCH] PR fortran/81984 -- Placate the sanitizer

2018-12-28 Thread Dominique d'Humières
Hi Steve, The patch looks good to me (and works as expected). Thanks, Dominique

[PATCH] x86-64: Remove .file directive from snapshot source

2018-12-28 Thread H.J. Lu
Since snapshot() is implemented in assembly code, .file directive should be removed. Otherwise, debugger can't find the snapshot source. I am checking it in as an obvious fix. H.J. * gcc.target/x86_64/abi/asm-support-darwin.s: Remove .file directive. * gcc.target/x86

Re: [PATCH] Improve predictions for hot and cold labels ([[likely]], [[unlikely]]).

2018-12-28 Thread Martin Liška
On 12/6/18 9:23 AM, Bernhard Reutner-Fischer wrote: > On 30 November 2018 10:47:45 CET, "Martin Liška" wrote: >> Hi. >> >> This patch is a reaction to Jason's commit where he introduced new C++ >> attributes. >> First I would like to align cold/hot to __builtin_expect, so I adjusted >> probability

Re: [PATCH] x86-64: Remove .file directive from snapshot source

2018-12-28 Thread H.J. Lu
On Fri, Dec 28, 2018 at 06:34:51AM -0800, H.J. Lu wrote: > Since snapshot() is implemented in assembly code, .file directive should > be removed. Otherwise, debugger can't find the snapshot source. I am > checking it in as an obvious fix. > > H.J. > > * gcc.target/x86_64/abi/asm-suppo

Re: [patch] Fix PR rtl-optimization/87727

2018-12-28 Thread Peter Bergner
On 12/21/18 9:24 AM, Vladimir Makarov wrote: > Peter, also if you are interesting to do RA work, there is another problem > which is to implement sub-register level conflict calculations in LRA. > Currently, IRA has a simple subregister level conflict calculation (see > allocno objects) and in a ca

[patch, rfa] Fix PR other/16615, change "can not" to "cannot" throughout docs and code

2018-12-28 Thread Sandra Loosemore
I've split the fix for PR other/16615 into a series of 4 proposed commits. 3 of the 4 parts are mechanically generated, so I'm only posting the actual patch for the remaining piece (part 2). Part 1 is the result of applying find . -type f -print | xargs grep -i -l '\' | grep -v ChangeLog | f

Re: [REVISED PATCH 3/9]: C++ P0482R5 char8_t: New core language tests

2018-12-28 Thread Mike Stump
I'd like to punt to Jason for this patch. > On Dec 23, 2018, at 6:27 PM, Tom Honermann wrote: > > Attached is a revised patch that addresses changes in P0482R6 as well as > feedback provided by Jason for patch 2/9. Changes from the prior patch > include:

Re: [REVISED PATCH 4/9]: C++ P0482R5 char8_t: Updates to existing core language tests

2018-12-28 Thread Mike Stump
I'd like to punt to Jason for this patch. > On Dec 23, 2018, at 6:27 PM, Tom Honermann wrote: > > Attached is a revised patch that addresses changes in P0482R6 and adoption of > P0482R6 for C++20 in San Diego. Changes from the prior patch include: > - Updated a test to validate the value of th

Re: [PATCH] fortran/88342 -- interaction of -ffpe-trap and IEEE_VALUE

2018-12-28 Thread Steve Kargl
Ping. On Mon, Dec 24, 2018 at 11:59:50AM -0800, Steve Kargl wrote: > All, > > The IEEE modules and -ffpe-trap are to some extent orthogonal > features of gfortran. Unfortunately, some users have the > expectation of using -ffpe-trap for debugging while also using only > some of the mechanisms p

Re: [PATCH,fortran] Add pre-defined macros for different available types

2018-12-28 Thread Steve Kargl
Ping. On Tue, Dec 25, 2018 at 01:44:10PM -0800, Steve Kargl wrote: > Here's a Holiday present for Fortranners. > > 2018-12-25 Steven G. Kargl > > * cpp.c (gfc_cpp_init): Add pre-defined macros for INTEGER(1) > INTEGER(2), INTEGER(8) and INTEGER(16) if supported. Add pre-defined

Re: [PATCH,fortran] Add support for IEEE_SUBNORMAL

2018-12-28 Thread Steve Kargl
Ping. On Tue, Dec 25, 2018 at 02:36:40PM -0800, Steve Kargl wrote: > Fortran 2018 has added IEEE_SUBNORMAL, IEEE_POSITIVE_SUBNORMAL, and > IEEE_NEGATIVE_SUBNORMAL as counterparts the same features with the > DENORMAL name. The attached patch allows gfortran to recognize > and do the right thing w

[committed] Small warning bugfix

2018-12-28 Thread Jeff Law
This was extracted from Martin's work on the strlen range fixes. As the comment indicates, avoid warning for strncpy (a, b, N) where N == sizeof (a) and N == sizeof (b). I didn't immediately see a testcase in Martin's changes. I'm pretty sure I've seen a few Fedora rawhide packages failing build

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

2018-12-28 Thread Alexandre Oliva
On Dec 20, 2018, Jason Merrill wrote: > I think the bug is in calling instantiate_constexpr_fns in this case. > I think that should only happen when ctx->manifestly_const_eval. FTR, changing that breaks cpp2a/constexpr-init1.C (P0859), unfortunately. I don't see why the operand of decltype or o

[C++ PATCH] [PR86648] use auto identifier for class placeholder templates

2018-12-28 Thread Alexandre Oliva
dwarf2out recognizes unspecified auto types by the identifier. C++ template class placeholders are unspecified auto types that take the identifier of the class rather than those used by preexisting auto types, so dwarf2out ICEs when it finds one of those. Alas, they may be visible to dwarf2out,

Go patch committed: Remove escapes_ field from Variable/Result_variable

2018-12-28 Thread Ian Lance Taylor
This patch to the Go frontend removes the escapes_ field from Variable and Result_variable. The fields were set to true initially and never set to false. These were left over from an earlier attempt at escape analysis. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainli

[PATCH, i386]: Add some missing QImode register aliases to ADDITIONAL_REGISTER_NAMES

2018-12-28 Thread Uros Bizjak
2018-12-28 Uros Bizjak * config/i386/i386.h (ADDITIONAL_REGISTER_NAMES): Add sil, dil, bpl and spl aliases. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline SVN. Uros. Index: i386.h =

libgo patch committed: Prevent deadlock on SIGPROF during stack scan

2018-12-28 Thread Ian Lance Taylor
This libgo patch by Cherry Zhang prevents a deadlock when a profiling signal arrives during a stack scan. A precise stack scan needs to unwind the stack. When it is unwinding the stack, if a profiling signal arrives, which also does a traceback, it may deadlock in dl_iterate_phdr. Prevent this de

Re: [PATCH] fortran/88342 -- interaction of -ffpe-trap and IEEE_VALUE

2018-12-28 Thread Jerry DeLisle
On 12/28/18 10:43 AM, Steve Kargl wrote: Ping. On Mon, Dec 24, 2018 at 11:59:50AM -0800, Steve Kargl wrote: All, The IEEE modules and -ffpe-trap are to some extent orthogonal features of gfortran. Unfortunately, some users have the expectation of using -ffpe-trap for debugging while also usin

Re: [PATCH,fortran] Add pre-defined macros for different available types

2018-12-28 Thread Jerry DeLisle
OK Steve, Jerry On 12/28/18 10:43 AM, Steve Kargl wrote: Ping. On Tue, Dec 25, 2018 at 01:44:10PM -0800, Steve Kargl wrote: Here's a Holiday present for Fortranners. 2018-12-25 Steven G. Kargl * cpp.c (gfc_cpp_init): Add pre-defined macros for INTEGER(1) INTEGER(2), INTE

Re: [PATCH,fortran] Add support for IEEE_SUBNORMAL

2018-12-28 Thread Jerry DeLisle
On 12/28/18 10:44 AM, Steve Kargl wrote: Ping. OK, thanks. Jerry On Tue, Dec 25, 2018 at 02:36:40PM -0800, Steve Kargl wrote: Fortran 2018 has added IEEE_SUBNORMAL, IEEE_POSITIVE_SUBNORMAL, and IEEE_NEGATIVE_SUBNORMAL as counterparts the same features with the DENORMAL name. The attached p

Re: [Patch] Bug 88521 - gcc 9.0 from r266355 miscompile x265 for mingw-w64 target

2018-12-28 Thread JonY
On 12/26/18 1:10 PM, Lokesh Janghel wrote: > Hi, > > Here is the patch for the issue. > Please let me know your thoughts. > > On Fri, Dec 21, 2018 at 3:16 PM JonY <10wa...@gmail.com> wrote: >> >> On 12/21/18 9:08 AM, Uros Bizjak wrote: >>> On Thu, Dec 20, 2018 at 1:09 PM Jakub Jelinek wrote: >>>

Re: [PATCH v3] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-12-28 Thread Gerald Pfeifer
On Mon, 26 Nov 2018, Kyrill Tkachov wrote: > Hi Christoph, : > Can you please create a patch for the changes.html page > (https://gcc.gnu.org/gcc-9/changes.html) > mentioning the new CPU support? There are examples on that page of the kind of > appropriate wording. > You can find details of how to

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

2018-12-28 Thread Alexandre Oliva
On Dec 28, 2018, Alexandre Oliva wrote: > I guess I still need to > fill in other gaps to in my knowledge to try and make sense of it. Done. > diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c Here's a patch based on your suggestion. [PR88146] do not instantiate constexpr if not manifestl

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

2018-12-28 Thread Alexandre Oliva
On Dec 28, 2018, Alexandre Oliva wrote: > diff --git a/gcc/cp/cvt.c b/gcc/cp/cvt.c And here's a cleaned-up patch based on my initial approach. [PR88146] avoid diagnostics diffs if cdtor_returns_this Diagnostics for testsuite/g++.dg/cpp0x/inh-ctor32.C varied across platforms. Specifically, on

Re: [PR86153] simplify more overflow tests in VRP

2018-12-28 Thread Alexandre Oliva
On Dec 19, 2018, Alexandre Oliva wrote: > + op1 = x; > + code = (code == LT_EXPR || code == LE_EXPR) ? LE_EXPR : GT_EXPR; So... I've done some more testing, and this alone seems to overlap nicely with what's in the trunk ATM, with a few exceptions: - for some reason, LE/GT do not get

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-12-28 Thread Gerald Pfeifer
On Fri, 23 Nov 2018, Tom de Vries wrote: > When building libbacktrace, we typically use elf.c, and don't build > pecoff.c, xcoff.c or unknown.c > > Add testcases that use unused format to ensure that we also build and > test those on a typical development setup. This is a good idea! > Bootstrap