[Patch, fortran] PR77703 - [7/8/9 Regression] ICE on assignment to pointer function

2018-12-23 Thread Paul Richard Thomas
I will apply this as 'obvious' this evening, unless there are objections. The patch is entirely self-explanatory. Paul 2018-12-23 Paul Thomas PR fortran/77703 * resolve.c (get_temp_from_expr): Use the string length of constant character expressions. 2018-12-23 Paul Thomas

[PATCH, committed] Enable ident for X86 Darwin.

2018-12-23 Thread Iain Sandoe
Hi, The c-c++-common tests fail (or XPASS depending on which) on Darwin because it doesn't currently emit .ident marker. For X86 Darwin, this is a trivial oversight; the assembler supports the directive. We can therefore use the default target hook there. I applied the following as obvious, Ia

Re: [ping] Change static chain to r11 on aarch64

2018-12-23 Thread Olivier Hainque
Hi Wilco, > On 21 Dec 2018, at 19:02, Wilco Dijkstra wrote: > > Remember these are just temporaries for use in the prolog and epilog - > there is no need to save/restore the static base. Setting static chain > to x9 and the temporaries to x10/x11 is the simplest solution. We > can separately lo

[PATCH] Don't run ident tests on powerpc-darwin

2018-12-23 Thread Iain Sandoe
Hi The c-c++-common tests fail (or XPASS depending on which) on Darwin because it doesn't currently emit .ident marker. For powerpc darwin (and, I think, AIX - hence copying David), there’s no .ident support in the assembler, and we need to skip the tests. In this case, I suggest that it’s not

[PATCH] Fix Ada bootstrap for Darwin9 and earlier.

2018-12-23 Thread Iain Sandoe
Hi, This is a bootstrap regression on 7,8 and trunk for Ada on [X86 and PowerPC] Darwin9 (and earlier, although I don’t test much there). Changes were made to __gnat_lwp_self to use a facility that’s only available from Darwin10 onwards. The patch makes this conditional on the target Darwin ve

[PATCH, lto-wrapper] Don't pre-link the early-debug objects.

2018-12-23 Thread Iain Sandoe
Hi, As there was some discussion of this on IRC - I believe that Honza might want this patch sooner, rather than later I constructed it as part of the series to support LTO debug [PR 82005] on Darwin (it’s still needed there). The patch has been reg-strapped on x86_64-darwin, x86_64-linux, pow

[PATCH, Darwin, config] Check for DWARF debug line support with otool.

2018-12-23 Thread Iain Sandoe
Hi, This corrects a long-standing misconfiguration for Darwin. The assembler supports the “.file” and “.loc” directives, but the GCC configury was not detecting this because it was using objdump, which does not exist on most Darwin installations. We added support for “otool” to GCC and now we ca

Re: [PATCH, lto-wrapper] Don't pre-link the early-debug objects.

2018-12-23 Thread Richard Biener
On December 23, 2018 12:41:04 PM GMT+01:00, Iain Sandoe wrote: >Hi, > >As there was some discussion of this on IRC - I believe that Honza >might want this patch sooner, rather than later > >I constructed it as part of the series to support LTO debug [PR 82005] >on Darwin (it’s still needed there)

Re: [PATCH] Fix Ada bootstrap for Darwin9 and earlier.

2018-12-23 Thread Eric Botcazou
> * adaint.c (__gnat_lwp_self): Ensure that the system interface used > is available on the target. OK for all active branches, modulo the couple of following nits: The ChangeLog must make it clear that this is for Darwin only: * adaint.c [__APPLE__] (__gnat_lwp_self): Ensure

[PATCH, Darwin] Fix PR67974.

2018-12-23 Thread Iain Sandoe
Hi, The PR is about a set of tests that were not executed because of missing asm support. However, the assembler can handle the insns now, so the tests are attempted (but with a missing asm shim they fail). This adds the shim. In principle (bugs notwithstanding) Darwin’s x86_64 ABI is suppose

[committed] Cleanup structure initialization in preparation for fixing string length range computations

2018-12-23 Thread Jeff Law
So I'm working to break down and resubmit Martin's work to fix the over-aggressive string length range computations. There's a fair amount of cleanup and other non-behavorial changes in that work. There's two paths we could take. One would be to drop all the non-behavorial changes and reduce th

[committed] Cleanup variable names and comments in preparation for fixing string length computations

2018-12-23 Thread Jeff Law
In a variety of instances Martin changed some variable names to be more descriptive or avoid shadowing problems. I've pulled those changes into a distinct patch to cut down on the noise in the meat of the patch. Bootstrapped and regression tested on x86_64-linux-gnu. My tester will spin this on

[committed] Add new fields to c_strlen_data structure, rename field access

2018-12-23 Thread Jeff Law
This is probably a good place to stop for today and let the testers catch up. This patch introduces new fields into the c_strlen_data structure. They're mostly unused at this point. The data structure shouldn't change in subsequent patches. The old "len" field accesses are changed to "minlen" w

Re: [PATCH, Darwin] Fix PR67974.

2018-12-23 Thread Jeff Law
On 12/23/18 8:05 AM, Iain Sandoe wrote: > Hi, > > The PR is about a set of tests that were not executed because of > missing asm support. > > However, the assembler can handle the insns now, so the tests are > attempted (but with a missing asm shim they fail). > > This adds the shim. > > In p

Re: [PATCH, Darwin, config] Check for DWARF debug line support with otool.

2018-12-23 Thread Jeff Law
On 12/23/18 4:53 AM, Iain Sandoe wrote: > Hi, > > This corrects a long-standing misconfiguration for Darwin. > The assembler supports the “.file” and “.loc” directives, but > the GCC configury was not detecting this because it was > using objdump, which does not exist on most Darwin installations

Re: [PATCH] Don't run ident tests on powerpc-darwin

2018-12-23 Thread Jeff Law
On 12/23/18 4:16 AM, Iain Sandoe wrote: > Hi > > The c-c++-common tests fail (or XPASS depending on which) on Darwin > because it doesn't currently emit .ident marker. > > For powerpc darwin (and, I think, AIX - hence copying David), there’s no > .ident support in the assembler, and we need to s

Re: Fix hashtable node deallocation

2018-12-23 Thread François Dumont
On 12/21/18 9:29 PM, Jonathan Wakely wrote: On 16/12/18 14:16 +0100, François Dumont wrote: Gentle reminder, we still have this issue pending.     * include/bits/hashtable_policy.h (_Hashtable_alloc<>::_M_deallocate_node_ptr(__node_type*)): New. (_Hashtable_alloc<>::_M_deallocate_node(__node_ty

[PATCH] PR fortran/81509 and fortran/45513

2018-12-23 Thread Steve Kargl
This is a re-submission of a patch I submitted 15 months ago. See https://gcc.gnu.org/ml/fortran/2017-09/msg00124.html At that time one reviewer OK'd the patch for committing, and one reviewer raised objections to the patch as I chose to remove dubious extensions to the Fortran standard. I withdre

Re: libbacktrace integration for _GLIBCXX_DEBUG mode

2018-12-23 Thread François Dumont
On 12/21/18 10:03 PM, Jonathan Wakely wrote: On 21/12/18 22:47 +0200, Ville Voutilainen wrote: On Fri, 21 Dec 2018 at 22:35, Jonathan Wakely wrote: >    I also explcitely define BACKTRACE_SUPPORTED to 0 to make sure >libstdc++ has no libbacktrace dependency after usual build. I'm concerned

Re: [PATCH] PR fortran/81509 and fortran/45513

2018-12-23 Thread Dominique d'Humières
Hi Steve, The 'call abort’ in the test gfortran.dg/pr81509_1.f90 should be replaced with ‘stop n’. Thanks for the patch. Dominique

Fix summary update after profile merging

2018-12-23 Thread Jan Hubicka
Hi, while looking into Firefox inline dumps I noticed that my previous patch was not quite enough to get inline summaries right. The problem is that we may have speculative edges from profile feedback and also it does happen that profiles mismatch and we should handle it better. This patch fixes t

Re: [REVISED PATCH 1/9]: C++ P0482R5 char8_t: Documentation updates

2018-12-23 Thread Tom Honermann
Attached is a revised patch that addresses feedback provided by Jason and Sandra. Changes from the prior patch include: - Updates to the -fchar8_t option documentation as requested by Jason. - Corrections for indentation, spacing, hyphenation, and wrapping as requested by Sandra. Tested on x8

Re: [REVISED PATCH 2/9]: C++ P0482R5 char8_t: Core language support

2018-12-23 Thread Tom Honermann
Attached is a revised patch that addresses changes in P0482R6 as well as feedback provided by Jason. Changes from the prior patch include: - Updated the value of the __cpp_char8_t feature test macro to 201811 per P0482R6. - Enable char8_t support with -std=c++2a per adoption of P0482R6 in Sa

Re: [REVISED PATCH 3/9]: C++ P0482R5 char8_t: New core language tests

2018-12-23 Thread Tom Honermann
Attached is a revised patch that addresses changes in P0482R6 as well as feedback provided by Jason for patch 2/9. Changes from the prior patch include: - New tests to ensure -fchar8_t is implicitly enabled when targeting C++2a per adoption of P0482R6 in San Diego. - gcc/testsuite/g++.dg/cp

Re: [REVISED PATCH 4/9]: C++ P0482R5 char8_t: Updates to existing core language tests

2018-12-23 Thread Tom Honermann
Attached is a revised patch that addresses changes in P0482R6 and adoption of P0482R6 for C++20 in San Diego. Changes from the prior patch include: - Updated a test to validate the value of the __cpp_char8_t feature test macro when targeting C++2a. Tested on x86_64-linux. gcc/testsuite/Chan

Re: [REVISED PATCH 5/9]: C++ P0482R5 char8_t: Standard library support

2018-12-23 Thread Tom Honermann
Attached is a revised patch that addresses changes in P0482R6. Changes from the prior patch include: - Updated the value of the __cpp_char8_t feature test macro to 201811. Tested on x86_64-linux. gcc/cp/ChangeLog: 2018-11-04 Tom Honermann * name-lookup.c (get_std_name_hint): Added u8

Re: [PATCH 2/9]: C++ P0482R5 char8_t: Core language support

2018-12-23 Thread Tom Honermann
Thanks, Jason.  I just sent a revised set of patches addressing most of your feedback with exceptions as described inline below. On 12/17/18 4:47 PM, Tom Honermann wrote: On 12/17/18 4:02 PM, Jason Merrill wrote: On 12/5/18 11:16 AM, Jason Merrill wrote: On 12/5/18 2:09 AM, Tom Honermann wrot

Re: [REVISED PATCH 7/9]: C++ P0482R5 char8_t: New standard library tests

2018-12-23 Thread Tom Honermann
Attached is a revised patch that addresses changes in P0482R6. Changes from the prior patch include: - Updated the value of the __cpp_char8_t feature test macro to 201811. Tested on x86_64-linux. libstdc++-v3/ChangeLog: 2018-11-04 Tom Honermann * testsuite/18_support/numeric_limits/c

Re: [PATCH 1/9]: C++ P0482R5 char8_t: Documentation updates

2018-12-23 Thread Tom Honermann
Thank you, Sandra!  I just sent a revised patch to the list that I believe addresses all of your comments.  Thanks for the suggestion to generate and check the pdf, that was helpful to ensure the changes rendered correctly. Tom. On 12/11/18 6:35 PM, Sandra Loosemore wrote: On 11/5/18 12:39 P

Re: [PATCH] PR fortran/81509 and fortran/45513

2018-12-23 Thread Jerry DeLisle
On 12/23/18 10:49 AM, Steve Kargl wrote: This is a re-submission of a patch I submitted 15 months ago. See https://gcc.gnu.org/ml/fortran/2017-09/msg00124.html At that time one reviewer OK'd the patch for committing, and one reviewer raised objections to the patch as I chose to remove dubious ex