Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-11-04 Thread Stafford Horne
On Mon, Oct 29, 2018 at 02:28:11PM +, Szabolcs Nagy wrote: > On 27/10/18 05:37, Stafford Horne wrote: > > +++ b/gcc/config/or1k/linux.h > > @@ -0,0 +1,44 @@ > > +/* Linux Definitions for OpenRISC. > > + Copyright (C) 2018 Free Software Foundation, Inc. > > + Contributed by Stafford Horne. >

Re: [patch, libgfortran] PR78351 comma not terminating READ of formatted input field

2018-11-04 Thread Bernhard Reutner-Fischer
On Sat, 3 Nov 2018 15:33:07 -0700 Jerry DeLisle wrote: > diff --git a/libgfortran/io/transfer.c b/libgfortran/io/transfer.c > index 31198a3cc39..0d26101cef0 100644 > --- a/libgfortran/io/transfer.c > +++ b/libgfortran/io/transfer.c > @@ -260,22 +250,80 @@ read_sf_internal (st_parameter_dt *dtp,

RE: [patch][x86_64]: AMD znver2 enablement

2018-11-04 Thread Kumar, Venkataramanan
Hi Uros and Honza, I have committed the znver2 patch. Ref:https://gcc.gnu.org/viewcvs/gcc?limit_changes=0&view=revision&revision=265775 Thanks you. regards, Venkat. > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org > On Behalf Of Kumar, Venkataramanan > Sent: Sunday, November

Re: [patch, libgfortran] PR78351 comma not terminating READ of formatted input field

2018-11-04 Thread Jerry DeLisle
On 11/4/18 1:51 AM, Bernhard Reutner-Fischer wrote: On Sat, 3 Nov 2018 15:33:07 -0700 Jerry DeLisle wrote: diff --git a/libgfortran/io/transfer.c b/libgfortran/io/transfer.c index 31198a3cc39..0d26101cef0 100644 --- a/libgfortran/io/transfer.c +++ b/libgfortran/io/transfer.c @@ -260,22 +250

PING: V4 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-11-04 Thread H.J. Lu
On Tue, Sep 25, 2018 at 8:46 AM H.J. Lu wrote: > > On Fri, Aug 31, 2018 at 2:04 PM, Jason Merrill wrote: > > On 07/23/2018 05:24 PM, H.J. Lu wrote: > >> > >> On Mon, Jun 18, 2018 at 12:26 PM, Joseph Myers > >> wrote: > >>> > >>> On Mon, 18 Jun 2018, Jason Merrill wrote: > >>> > On Mon, Jun

PING: V2 [PATCH] i386: Add pass_remove_partial_avx_dependency

2018-11-04 Thread H.J. Lu
On Fri, Oct 19, 2018 at 1:44 AM H.J. Lu wrote: > > On 10/18/18, Jan Hubicka wrote: > >> we need to generate > >> > >> vxorp[ds] %xmmN, %xmmN, %xmmN > >> ... > >> vcvtss2sd f(%rip), %xmmN, %xmmX > >> ... > >> vcvtsi2ss i(%rip), %xmmN, %xmmY > >> > >> to a

PING: [PATCH] apply_subst_iterator: Handle define_split/define_insn_and_split

2018-11-04 Thread H.J. Lu
On Fri, Oct 26, 2018 at 12:44 AM H.J. Lu wrote: > > On 10/25/18, Uros Bizjak wrote: > > On Fri, Oct 26, 2018 at 8:48 AM H.J. Lu wrote: > >> > >> On 10/25/18, Uros Bizjak wrote: > >> > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote: > >> >> > >> >> * read-rtl.c (apply_subst_iterator): Ha

Re: [PATCH libquadmath/PR68686]

2018-11-04 Thread Ed Smith-Rowland
On 11/3/18 10:09 PM, Jeff Law wrote: On 10/23/18 7:45 PM, Ed Smith-Rowland wrote: Greetings, This is an almost trivial patch to get the correct sign for tgammaq. I don't have a testcase as I don't know where to put one. OK? Ed Smith-Rowland tgammaq.CL 2018-10-24 Edward Smith-Rowland <3

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread Uros Bizjak
On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with > subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is changed by > > avx2_test: > .cfi_startproc > - vmovaps x(%rip), %xmm1 > - vbroadcastss%xmm1, %ym

Re: Fix D compilation on Solaris

2018-11-04 Thread Rainer Orth
Hi Iain, > On Wed, 31 Oct 2018 at 10:40, Rainer Orth > wrote: >> >> Hi Iain, >> >> > My first suspect here would be 'struct UnionExp', see d/dmd/expression.h >> > >> > Upstream dmd use a poor man's alignment, from what I recall to be >> > compatible with the dmc compiler. >> > >> > // En

Re: Fix D compilation on Solaris

2018-11-04 Thread Rainer Orth
Hi Iain, > On Wed, 31 Oct 2018 at 10:43, Rainer Orth > wrote: >> >> Hi Iain, >> >> >> My first suspect here would be 'struct UnionExp', see d/dmd/expression.h >> >> >> >> Upstream dmd use a poor man's alignment, from what I recall to be >> >> compatible with the dmc compiler. >> >> >> >>

Re: Fix D compilation on Solaris

2018-11-04 Thread Rainer Orth
Hi Iain, > On Wed, 31 Oct 2018 at 10:40, Rainer Orth > wrote: >> >> Hi Iain, >> >> > My first suspect here would be 'struct UnionExp', see d/dmd/expression.h >> > >> > Upstream dmd use a poor man's alignment, from what I recall to be >> > compatible with the dmc compiler. >> > >> > // En

Re: Fix D compilation on Solaris

2018-11-04 Thread Rainer Orth
Hi Iain, > On Sat, 3 Nov 2018 at 23:23, Iain Buclaw wrote: >> >> On Wed, 31 Oct 2018 at 10:40, Rainer Orth >> wrote: >> > >> > Hi Iain, >> > >> > > My first suspect here would be 'struct UnionExp', see d/dmd/expression.h >> > > >> > > Upstream dmd use a poor man's alignment, from what I recall

Re: [PR87815]Don't generate shift sequence for load replacement in DSE when the mode size is not compile-time constant

2018-11-04 Thread Jeff Law
On 10/31/18 5:13 AM, Renlin Li wrote: > Hi all, > > The patch adds a check if the gap is compile-time constant. > > This happens when dse decides to replace the load with previous store > value. > The problem is that, shift sequence could not accept compile-time > non-constant > mode operand. >

Re: [PATCH v2, middle end]: Fix PR58372, internal compiler error: ix86_compute_frame_layout

2018-11-04 Thread Jeff Law
On 11/1/18 10:18 AM, Uros Bizjak wrote: > Hello! > > v2 of the patch hits the real problem: in pass_expand::execute > finish_eh_generation is called after expand_stack_alignment is called. > Construction of SjLj landing pads calls emit_library_call, which can > change crtl->preferred_stack_boundar

Re: [PATCH] Fix PR 86572

2018-11-04 Thread Jeff Law
On 10/22/18 9:08 AM, Bernd Edlinger wrote: > Hi! > > This makes c_strlen avoid an unsafe strlen folding of const arguments > with non-const offset. Currently a negative out of bounds offset > makes the strlen function return an extremely large number, and > at the same time, prevents the VRP mach

Re: [PATCH] Fix PR 87672

2018-11-04 Thread Jeff Law
On 10/22/18 8:59 AM, Bernd Edlinger wrote: > Hi! > > This fixes an ICE which was exposed by a previous patch of mine, > and a wrong transformation from strcat_chk => strcpy_chk, > which fails to adjust the object size, thus allowing too much > memory to be accessed. > > > Bootstrapped and reg-te

Re: gOlogy: fix debug binds in auto-inc-dec

2018-11-04 Thread Jeff Law
On 10/21/18 2:07 AM, Alexandre Oliva wrote: > As auto_inc_dec pass combines incs and mems from different insns, it > often causes regs to temporarily hold a value different from the one > it would before the transformation. Debug insns within that range > would therefore end up binding to the wron

Re: [PATCH libquadmath/PR68686]

2018-11-04 Thread Ed Smith-Rowland
On 11/3/18 10:09 PM, Jeff Law wrote: On 10/23/18 7:45 PM, Ed Smith-Rowland wrote: Greetings, This is an almost trivial patch to get the correct sign for tgammaq. I don't have a testcase as I don't know where to put one. OK? Ed Smith-Rowland tgammaq.CL 2018-10-24 Edward Smith-Rowland <3

Re: Fix D compilation on Solaris

2018-11-04 Thread Iain Buclaw
On Sun, 4 Nov 2018 at 17:50, Rainer Orth wrote: > > Hi Iain, > > > On Sat, 3 Nov 2018 at 23:23, Iain Buclaw wrote: > >> > >> On Wed, 31 Oct 2018 at 10:40, Rainer Orth > >> wrote: > >> > > >> > Hi Iain, > >> > > >> > > My first suspect here would be 'struct UnionExp', see > >> > > d/dmd/express

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread H.J. Lu
On Sun, Nov 4, 2018 at 8:41 AM Uros Bizjak wrote: > > On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with > > subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is changed by > > > > avx2_test: > > .cfi_startproc >

Re: [PATCH] Fix setting of hotness in non-LTO mode (PR gcov-profile/77698).

2018-11-04 Thread Jeff Law
On 10/9/18 6:37 AM, Martin Liška wrote: > Hi. > > In non-LTO mode, we should not set hotness according to computed histogram > in ipa-profile. Following patch does that and fixes the test-case isolated > from PR. > > Patch survives regression tests on x86_64-linux-gnu. > Ready for trunk? > Thanks

Re: [PATCH v2, middle end]: Fix PR58372, internal compiler error: ix86_compute_frame_layout

2018-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2018 at 6:59 PM Jeff Law wrote: > > On 11/1/18 10:18 AM, Uros Bizjak wrote: > > Hello! > > > > v2 of the patch hits the real problem: in pass_expand::execute > > finish_eh_generation is called after expand_stack_alignment is called. > > Construction of SjLj landing pads calls emit_l

Re: PR83750: CSE erf/erfc pair

2018-11-04 Thread Jeff Law
On 11/2/18 3:36 AM, Prathamesh Kulkarni wrote: > Hi, > This patch adds two transforms to match.pd to CSE erf/erfc pair. > erfc(x) is canonicalized to 1 - erf(x) and is then reversed to 1 - > erf(x) when canonicalization is disabled and result of erf(x) has > single use within 1 - erf(x). > > The p

Re: [PATCH, testsuite] add "inf" target attribute

2018-11-04 Thread Jeff Law
On 11/1/18 1:30 PM, Paul Koning wrote: > A number of test cases fail on pdp11 because they use the "inf" float value > which does not exist on that target (nor on VAX). Rainer Orth and Joseph > Myers suggested adding a new effective-target keyword to check for this, and > require it for tests t

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2018 at 8:17 PM H.J. Lu wrote: > > On Sun, Nov 4, 2018 at 8:41 AM Uros Bizjak wrote: > > > > On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > > > > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with > > > subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread H.J. Lu
On Sun, Nov 4, 2018 at 11:45 AM Uros Bizjak wrote: > > On Sun, Nov 4, 2018 at 8:17 PM H.J. Lu wrote: > > > > On Sun, Nov 4, 2018 at 8:41 AM Uros Bizjak wrote: > > > > > > On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > > > > > > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace the

[PATCH v3][C][ADA] use function descriptors instead of trampolines in C

2018-11-04 Thread Uecker, Martin
Hi Joseph, here is a new version of this patch which adds a warning for targets which do not support -fno-trampolines and only runs the test case on architectures where this is supported. It seems that documentation for this general feature has improved in the meantime so I only mention C as sup

[PATCH, d] Committed merge with upstream dmd

2018-11-04 Thread Iain Buclaw
Hi, I've merged into the D front-end patches sent to upstream dmd, most address problems found when building the compiler on OSX and Solaris. This introduces a new header that pulls in system includes for use only in the DMD front-end part of the compiler, fixing up uses of problematic functions

[PATCH 3/3] Allow changing the fentry section per file and per function

2018-11-04 Thread Andi Kleen
From: Andi Kleen When dynamically patching in/out instrumentation it can be useful to handle different classes of functions differently. Add support for changing the fentry section name on the command line or as a function attributes. This allows to mark functions differently, and handle them dif

[PATCH 1/3] Support instrumenting returns of instrumented functions

2018-11-04 Thread Andi Kleen
From: Andi Kleen When instrumenting programs using __fentry__ it is often useful to instrument the function return too. Traditionally this has been done by patching the return address on the stack frame on entry. However this is fairly complicated (trace function has to emulate a stack) and also

[PATCH 2/3] Support changing fentry name per function

2018-11-04 Thread Andi Kleen
From: Andi Kleen It can be useful to have some classes of functions that use a different __fentry__ instrumentation than others. Currently it is only possible to disable instrumentation on the command line or with no_instrument_function, but not to change the instrumentation function on a case b

Re: [PATCH] Fix PR 86572

2018-11-04 Thread H.J. Lu
On Sun, Nov 4, 2018 at 10:02 AM Jeff Law wrote: > > On 10/22/18 9:08 AM, Bernd Edlinger wrote: > > Hi! > > > > This makes c_strlen avoid an unsafe strlen folding of const arguments > > with non-const offset. Currently a negative out of bounds offset > > makes the strlen function return an extreme

Re: [PATCH, OpenACC] Update documentation to mention OpenACC 2.5

2018-11-04 Thread Sandra Loosemore
On 11/02/2018 04:38 AM, Chung-Lin Tang wrote: Hi Thomas, this patch (mostly by yourself:) ) are the changes to the documentation to now state OpenACC 2.5 support. I believe this is within your maintainership scope. I took a look at it with my doc maintainer hat on too, and the patch is fine

[PATCH][x86_64] Fix PR87853, _mm_cmpgt_epi8 broken with -funsigned-char

2018-11-04 Thread Terry Guo
Hi there, This patch intends to fix PR87853 by involving a new 'signed char' vector type to avoid the impact of option -funsigned-char. Tested with bootstrap and regression tests on x86_64. No regressions. Is it OK to trunk and release branch? BR, Terry diff --git a/gcc/ChangeLog b/gcc/ChangeLo

[C++ PATCH] PR c++/60503 - wrong lambda attribute syntax.

2018-11-04 Thread Jason Merrill
This patch fixes two issues with lambda attribute handling: First, it was in the wrong place in the grammar. Second, it was treating attributes as applying to the whole declaration rather than to the function type, as specified by the standard. Tested x86_64-pc-linux-gnu, applying to trunk.

[C++ PATCH 1/3] Fix various latent issues revealed by P0732 work.

2018-11-04 Thread Jason Merrill
The initialized_type hunk fixes handling of void AGGR_INIT_EXPRs that call a non-constructor; an AGGR_INIT_EXPR can have void type if its initialization semantics are more complicated than just expanding the call. The cxx_eval_vec_init_1 hunk corrects AGGR_INIT_EXPRs that were nonsensically built

[PATCH 3/3] Implement UDL changes from P0732R2.

2018-11-04 Thread Jason Merrill
Implementing the UDL changes was pretty straightforward; I simplified cp_parser_userdef_string_literal using the releasing_vec type from mangle.c. While looking at this, I realized that the string UDL template taking a character pack that we implemented for C++14 didn't actually make it into C++14

[PATCH 2/3] Implement P0732R2, class types in non-type template parameters.

2018-11-04 Thread Jason Merrill
There is one significant piece of this that is not implemented yet: the reliance on defaulted operator<=>, which someone else has been working on. So, for the moment those lines are commented out of the testcases. One tricky bit was treating template parameters of classtype as const lvalues withou

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-04 Thread Prathamesh Kulkarni
On Fri, 2 Nov 2018 at 19:08, Wilco Dijkstra wrote: > > Prathamesh Kulkarni wrote: > > > This is a rebased version of patch that adds a pattern to neon.md for > > implementing division with multiplication by reciprocal using > > vrecpe/vrecps with -funsafe-math-optimizations excluding -Os. > > The

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-04 Thread Wei Xiao
> Please also rename these: > > _mm512_mask_fixupimm_round_pd (__m512d __A, __mmask8 __U, __m512d __B, > __m512i __C, const int __imm, const int __R) > > _mm512_mask_fixupimm_round_ps (__m512 __A, __mmask16 __U, __m512 __B, > __m512i __C, const int __imm, c

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-04 Thread Uros Bizjak
On Mon, Nov 5, 2018 at 6:54 AM Wei Xiao wrote: > > > Please also rename these: > > > > _mm512_mask_fixupimm_round_pd (__m512d __A, __mmask8 __U, __m512d __B, > > __m512i __C, const int __imm, const int __R) > > > > _mm512_mask_fixupimm_round_ps (__m512 __A, __mmask16 __U, __m

Re: [PATCH][x86_64] Fix PR87853, _mm_cmpgt_epi8 broken with -funsigned-char

2018-11-04 Thread Uros Bizjak
On Mon, Nov 5, 2018 at 2:58 AM Terry Guo wrote: > > Hi there, > > This patch intends to fix PR87853 by involving a new 'signed char' > vector type to avoid the impact of option -funsigned-char. Tested with > bootstrap and regression tests on x86_64. No regressions. > > Is it OK to trunk and releas

Re: [PATCH, OpenACC] Update documentation to mention OpenACC 2.5

2018-11-04 Thread Thomas Schwinge
Hi! On Sun, 4 Nov 2018 18:13:09 -0700, Sandra Loosemore wrote: > On 11/02/2018 04:38 AM, Chung-Lin Tang wrote: > > Hi Thomas, > > this patch (mostly by yourself:) ) are the changes to the documentation > > to now state OpenACC 2.5 support. > > I believe this is within your maintainership scope.

Re: [PATCH 1/3][GCC] Add new target hook asm_post_cfi_startproc

2018-11-04 Thread Richard Biener
On Fri, 2 Nov 2018, Sam Tebbs wrote: > On 11/02/2018 05:28 PM, Sam Tebbs wrote: > > > Hi all, > > > > This patch adds a new target hook called "asm_post_cfi_startproc". This > > hook is > > intended to be used by the aarch64 backend to emit a directive that enables > > support for unwinding fram