Re: [PATCH] Strenghten assumption about gswitch statements.

On 08/27/2018 05:21 PM, Richard Biener wrote: > On Mon, Aug 27, 2018 at 4:05 PM Martin Liška wrote: >> >> Hi. >> >> Now we should not meet a degenerated gswitch statements. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > Hum. This rel

Re: [PATCH] Use more DECL_BUILT_IN_P macro.

On 08/27/2018 06:02 PM, Martin Sebor wrote: > On 08/27/2018 01:20 AM, Martin Liška wrote: >> +/* For a FUNCTION_DECL NODE, nonzero means a built in function of a >> + standard library or more generally a built in function that is >> + recognized by optimizers and expanders. Hi. Thanks for help wi

[PATCH] Fix some bugs in maybe_warn_nonstring_arg (PR middle-end/87099)

Hi! The following patch fixes some bugs in maybe_warn_nonstring_arg. The testcase ICEs, because lenrng[1] is a PLUS_EXPR, but the code assumes without checking that it must be INTEGER_CST and feeds it into tree_int_cst_lt. If the upper bound is NULL or is some expression other than INTEGER_CST, w

[PATCH][1/4] Fix PR87117

I believe Micha stumbled over this as well. For stores to string literals we miss VDEFs and loads from STRING_CSTs miss VUSEs. Bootstrap and regtest running on x86_64-unknown-linux-gnu. 2018-08-28 Richard Biener PR tree-optimization/87117 * tree-ssa-sccvn.c (fully_constant_

[PATCH][2/4] Fix PR87117

Err, see comment of [1/4] ;) Bootstrap and regtest running on x86_64-unknown-linux-gnu. 2018-08-28 Richard Biener PR tree-optimization/87117 * tree-ssa-operands.c (add_stmt_operand): STRING_CST may get virtual operands. (get_expr_operands): Handle STRING_CST

[PATCH][3/4] Fix PR87118

For now give up on predicated values when doing PRE (there's a similar hunk in PHI-translation already). I need to sit down and decide whether it's worth handling them or whether we'd better prune them from the hash tables when assigning value-ids. Bootstrap and regtest running on x86_64-unknow

[PATCH][4/4] Fix PR87117

Bootstrap and regtest running on x86_64-unknown-linux-gnu. 2018-08-28 Richard Biener PR tree-optimization/87117 * tree-ssa-sccvn.c (eliminate_dom_walker::eliminate_cleanup): Handle removed stmt without LHS (GIMPLE_NOP). Index: gcc/tree-ssa-sccvn.c ===

Re: [PATCH][AArch64] Implement new intrinsics vabsd_s64 and vnegd_s64

Gentle ping. On 08/08/18 17:38, Vlad Lazar wrote: On 01/08/18 18:35, James Greenhalgh wrote: On Wed, Aug 01, 2018 at 07:13:53AM -0500, Vlad Lazar wrote: On 31/07/18 22:48, James Greenhalgh wrote: On Fri, Jul 20, 2018 at 04:37:34AM -0500, Vlad Lazar wrote: Hi, The patch adds implementations

Re: [PATCH][AAarch64][v3] Add support for TARGET_COMPUTE_FRAME_LAYOUT

Gentle ping. On 06/08/18 17:14, Vlad Lazar wrote: Hi, The patch adds support for the TARGET_COMPUTE_FRAME_LAYOUT hook on AArch64 and removes unneeded frame layout recalculation. The removed aarch64_layout_frame calls are unnecessary because the functions in which they appear will be called du

[PATCH 1/4] qsort_chk: call from gcc_qsort instead of wrapping it

Hi, This is an independently useful patch that makes it easier to introduce gcc_stablesort. Swap responsibilities of gcc_qsort and qsort_chk: call the checking function from the sorting function instead of wrapping gcc_qsort with qsort_chk. * gcc/sort.cc (gcc_qsort) [CHECKING_P]: Call qs

Re: [PATCH 2/4] introduce gcc_stablesort

This adds a stable sort to sort.cc: mergesort implementation is stable, so we just need network sort limited to sizes 2-3 to get the complete sort stable. As I don't want to duplicate code for this, I've chosen to have gcc_qsort accept bit-inverted 'size' parameter to request stable sorting.

Re: [PATCH 3/4] tree-loop-distribution: convert to gcc_stablesort

This converts std::stable_sort use in tree-loop-distribution to gcc_stablesort. * gcc/tree-loop-distribution.c (offset_cmp): Convert to C-qsort-style tri-state comparator. (fuse_memset_builtins): Change std::stable_sort to gcc_stablesort . diff --git a/gcc/tree-loop-distr

Re: [PATCH 1/4] qsort_chk: call from gcc_qsort instead of wrapping it

On Tue, Aug 28, 2018 at 11:03 AM Alexander Monakov wrote: > > Hi, > > This is an independently useful patch that makes it easier to introduce > gcc_stablesort. > > Swap responsibilities of gcc_qsort and qsort_chk: call the checking function > from the sorting function instead of wrapping gcc_qsort

Re: [PATCH 4/4] bb-reorder: convert to gcc_stablesort

This converts the use in bb-reorder. I had to get a little bit creative with the comparator as profile_count::operator> does not implement a strict weak order. * gcc/bb-reorder.c (edge_order): Convert to C-qsort-style tri-state comparator. (reorder_basic_blocks_simple): Ch

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

On 08/28/18 04:55, Jeff Law wrote: > On 08/23/2018 08:48 AM, Bernd Edlinger wrote: >> On 08/23/18 16:24, Jeff Law wrote: Yes, and which one was the earlier, more controversial patch from me? >>> >>> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >>> >>> >>> Which is the issue I'

Re: VRP: abstract out wide int CONVERT_EXPR_P code

On Mon, Aug 27, 2018 at 2:24 PM Aldy Hernandez wrote: > > Howdy! > > Phew, I think this is the last abstraction. This handles the unary > CONVERT_EXPR_P code. > > It's the usual story-- normalize the symbolics to [-MIN,+MAX] and handle > everything generically. > > Normalizing the symbolics broug

Re: VRP: abstract out wide int CONVERT_EXPR_P code

On 08/28/2018 05:27 AM, Richard Biener wrote: On Mon, Aug 27, 2018 at 2:24 PM Aldy Hernandez wrote: Howdy! Phew, I think this is the last abstraction. This handles the unary CONVERT_EXPR_P code. It's the usual story-- normalize the symbolics to [-MIN,+MAX] and handle everything generical

Re: [committed] Fix minor bug in recently added sanity test in tree-ssa-dse.c

On Mon, Aug 27, 2018 at 10:31 PM Jeff Law wrote: > > > We recently changes tree-ssa-dse.c to not trim stores outside the bounds > of the referenced object. This is generally a good thing. > > However, there are cases where the object doesn't have a usable size. > We see this during kernel builds,

Re: [PATCH] Fix some bugs in maybe_warn_nonstring_arg (PR middle-end/87099)

On Tue, 28 Aug 2018, Jakub Jelinek wrote: > Hi! > > The following patch fixes some bugs in maybe_warn_nonstring_arg. > The testcase ICEs, because lenrng[1] is a PLUS_EXPR, but the code assumes > without checking that it must be INTEGER_CST and feeds it into > tree_int_cst_lt. If the upper bound

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

On Tue, Aug 28, 2018 at 4:37 AM Martin Sebor wrote: > > Richard, please let me know if the patch is acceptable as is > (with the RejectNegative property added). As I said, I realize > it's not ideal, but neither is any of the alternatives we have > discussed. They all involve trade- offs, and I

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

On Tue, Aug 28, 2018 at 6:27 AM Jeff Law wrote: > > On 08/27/2018 10:27 AM, Martin Sebor wrote: > > On 08/27/2018 02:29 AM, Richard Biener wrote: > >> On Sun, Aug 26, 2018 at 7:26 AM Jeff Law wrote: > >>> > >>> On 08/24/2018 09:58 AM, Martin Sebor wrote: > The warning suppression for -Wstrin

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

On Tue, Aug 28, 2018 at 11:55 AM Richard Biener wrote: > > On Tue, Aug 28, 2018 at 6:27 AM Jeff Law wrote: > > > > On 08/27/2018 10:27 AM, Martin Sebor wrote: > > > On 08/27/2018 02:29 AM, Richard Biener wrote: > > >> On Sun, Aug 26, 2018 at 7:26 AM Jeff Law wrote: > > >>> > > >>> On 08/24/2018

Re: [PATCH RFC] add generic expansion for MULT_HIGHPART_EXP

On Tue, Aug 28, 2018 at 7:59 AM Alexander Monakov wrote: > > > > > So - how difficult is it to fix BRIG to not use MULT_HIGHPART_EXPR if > > > > not supported? > > Richard, how should we proceed from here? Do you like the solution in the > initial mail, or would you prefer something else? FWIW I

Re: [PATCH] Strenghten assumption about gswitch statements.

On Tue, Aug 28, 2018 at 9:11 AM Martin Liška wrote: > > On 08/27/2018 05:21 PM, Richard Biener wrote: > > On Mon, Aug 27, 2018 at 4:05 PM Martin Liška wrote: > >> > >> Hi. > >> > >> Now we should not meet a degenerated gswitch statements. > >> > >> Patch can bootstrap on x86_64-linux-gnu and surv

Add target selectors to slp-37.c (PR87078)

This test was failing for Power 7 due to the lack of hw support for unaligned accesses. Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu. OK to install? Richard 2018-08-28 Richard Sandiford gcc/testsuite/ PR testsuite/87078 * gcc.dg/vect/slp-37.c: Rest

Fix unguarded use of tree_to_shwi in tree-ssa-sccvn.c

Fixes many testsuite failures for SVE. Tested on aarch64-linux-gnu (with and without SVE), aarch64_be-elf and x86_64-linux-gnu. OK to install? Richard 2018-08-28 Richard Sandiford gcc/ * tree-ssa-sccvn.c (fully_constant_vn_reference_p): Fix unguarded use of tree_to_shwi. R

Re: Fix unguarded use of tree_to_shwi in tree-ssa-sccvn.c

On Tue, Aug 28, 2018 at 12:39 PM Richard Sandiford wrote: > > Fixes many testsuite failures for SVE. > > Tested on aarch64-linux-gnu (with and without SVE), aarch64_be-elf > and x86_64-linux-gnu. OK to install? OK. Richard. > Richard > > > 2018-08-28 Richard Sandiford > > gcc/ > * t

Re: Add target selectors to slp-37.c (PR87078)

On Tue, Aug 28, 2018 at 12:31 PM Richard Sandiford wrote: > > This test was failing for Power 7 due to the lack of hw support > for unaligned accesses. > > Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu. > OK to install? OK. > Richard > > > 2018-08-28 Richard Sandiford

Re: [PATCH] Frame pointer for arm with THUMB2 mode

Hi, thanks for the answer. > Switching on the frame pointer typically costs 1-2% performance, so it's a bad > idea to use it. However changing the frame pointer like in the proposed patch > will have a much larger cost - both in performance and codesize. You'd be > lucky if it is less than 10%

[0/6] Make vector pattern statements less special

The goal of this series is to make vector pattern statements less special compared to normal bb statements, and thus make them easier to work with. It picks up the tail end of: https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01821.html Patch 08/11 from that series turned out to be wrong, for the

[1/6] Handle gphis in gimple_get_lhs

Several callers of gimple_get_lhs deal with statements that might be phis. This patch makes gimple_get_lhs handle that case too, so that the callers don't have to. 2018-08-28 Richard Sandiford gcc/ * gimple.c (gimple_get_lhs): Handle gphis. * tree-ssa-phionlycprop.c (get_lhs_

[2/6] Make vec_info::lookup_single_use take a stmt_vec_info

All callers to vec_info::lookup_single_use are asking about the lhs of a statement that they're already examining. It makes more sense to pass that statement instead of the SSA name, since it is then easier to handle statements that have been replaced by pattern statements. A later patch adds sup

[3/6] Add a vec_basic_block structure

This patch adds a vec_basic_block that records the scalar phis and scalar statements that we need to vectorise. This is a slight simplification in its own right, since it avoids unnecesary statement lookups and shaves >50 LOC. But the main reason for doing it is to allow the rest of the series to

[4/6] Make the vectoriser do its own DCE

The vectoriser normally leaves a later DCE pass to remove the scalar code, but we've accumulated various special cases for things that DCE can't handle, such as removing the scalar stores that have been replaced by vector stores, and the scalar calls to internal functions. (The latter must be remov

[5/6] Insert pattern statements into vec_basic_blocks

The point of this patch is to put pattern statements in the same vec_basic_block as the statements they replace, with the pattern statements for S coming between S and S's original predecessor. This removes the need to handle them specially in various places. 2018-08-28 Richard Sandiford gcc/

[6/6] Link imm uses for pattern stmts

One of the warts of the vectoriser IR is that it doesn't link SSA name uses for pattern statements, leading to complicated special cases in vect_mark_stmts_to_be_vectorized and (especially) vect_detect_hybrid_slp. It also makes it harder to check how an SSA name is used after pattern replacement (s

PR85787: Extend malloc_candidate_p to handle multiple phis.

H The attached patch extends malloc_candidate_p to handle multiple phis. There's a lot of noise in the patch because I moved most of malloc_candidate_p into new function malloc_candidate_p_1. The only real change is following hunk: + gimple *arg_def = SSA_NAME_DEF_STMT (arg); +

RE: [PATCH][GCC][AArch64] Cleanup the AArch64 testsuite when stack-clash is on [Patch (7/7)]

Hi All, Since this patch series now contains SVE support I am removing the changes to the SVE tests in this patch series. I assume the OK still stands as the only change here is undoing updates to three files. Thanks, Tamar gcc/testsuite/ 2018-08-28 Tamar Christina PR target/86486

RE: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/7)]

Hi All, As requested this patch series now contains basic SVE support, following that I am updating this patch to remove the error/warnings generated when SVE is used. The series now consists of 7 patches but I will only send updates for those that changed. Ok for trunk? Thanks, Tamar gcc/

[PATCH][GCC][AArch64] Add support for SVE stack clash probing [patch (2/7)]

Hi all, This patch adds basic support for SVE stack clash protection. It is a first implementation and will use a loop to do the probing and stack adjustments. An example sequence is: .cfi_startproc mov x15, sp cntbx16, all, mul #11 add x16, x16, 304

Re: [PATCH] Fix version check for ATTRIBUTE_GCC_DUMP_PRINTF

On Tue, Aug 28, 2018 at 08:43:59AM +0200, Jakub Jelinek wrote: > On Mon, Aug 27, 2018 at 08:32:11PM -0400, David Malcolm wrote: > > gcc/ChangeLog: > > * dumpfile.h (ATTRIBUTE_GCC_DUMP_PRINTF): Change version check on > > GCC_VERSION for usage of "__gcc_dump_printf__" format from > > >=

Re: [GCC][PATCH v2][Aarch64] Exploiting BFXIL when OR-ing two AND-operations with appropriate bitmasks

ping https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00108.html On 08/01/2018 04:07 PM, Sam Tebbs wrote: Hi all, This patch adds an optimisation that exploits the AArch64 BFXIL instruction when or-ing the result of two bitwise and operations with non-overlapping bitmasks (e.g. (a & 0x)

Re: [Patch, fortran] PRs 80477 and 86481 - memory leaks following function calls.

Committed as r263916. Thanks for taking a look over it, Thomas. Paul On Mon, 27 Aug 2018 at 20:26, Thomas Koenig wrote: > > Hi Paul, > > > Bootstrapped and regtested on FC28/x86_64 - OK for trunk? > > OK, and thanks for the patch! > > Regards > > Thomas -- "If you can't explain it s

[C++ Patch] PR 86546 (" ICE on invalid: tree_class_check_failed()")

Hi, this low priority ICE on invalid happens only in c++98 mode but I think we can as well avoid it and have consistent error recovery across std modes. Essentially, the VAR_DECL for 'b' with erroneous TREE_TYPE (the type is incomplete) reaches cxx_eval_constant_expression and we ICE when we

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

Hi Joseph, On Mon, Aug 27, 2018 at 05:24:51PM +, Joseph Myers wrote: > On Mon, 27 Aug 2018, Stafford Horne wrote: > > > gcc/config/or1k/elf.opt | 33 + > > > gcc/config/or1k/or1k.opt | 41 + > > Command-line options need documenting in invoke.texi. This patch i

Re: [PATCH 2/4] introduce gcc_stablesort

On Tue, Aug 28, 2018 at 11:14 AM Alexander Monakov wrote: > > This adds a stable sort to sort.cc: mergesort implementation is stable, so > we just need network sort limited to sizes 2-3 to get the complete sort > stable. > > As I don't want to duplicate code for this, I've chosen to have gcc_qsor

Re: [PATCH 3/4] tree-loop-distribution: convert to gcc_stablesort

On Tue, Aug 28, 2018 at 11:17 AM Alexander Monakov wrote: > > This converts std::stable_sort use in tree-loop-distribution to > gcc_stablesort. > > * gcc/tree-loop-distribution.c (offset_cmp): Convert to C-qsort-style > tri-state comparator. > (fuse_memset_builtins): Chang

Re: [C++ Patch] PR 86546 (" ICE on invalid: tree_class_check_failed()")

On 08/28/2018 08:43 AM, Paolo Carlini wrote: Hi, this low priority ICE on invalid happens only in c++98 mode but I think we can as well avoid it and have consistent error recovery across std modes. Essentially, the VAR_DECL for 'b' with erroneous TREE_TYPE (the type is incomplete) reaches cxx

Re: [PATCH 4/4] bb-reorder: convert to gcc_stablesort

On Tue, Aug 28, 2018 at 11:22 AM Alexander Monakov wrote: > > This converts the use in bb-reorder. I had to get a little bit creative with > the comparator as profile_count::operator> does not implement a strict weak > order. So the previously used comparator was invalid? I think your proposed

[PATCH] Fix PR87124

Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-08-28 Richard Biener PR tree-optimization/87124 * tree-ssa-sccvn.c (vn_lookup_simplify_result): Guard against constants before looking up avail. * g++.dg/torture/pr87124.C: New testc

[PATCH][5/4] Fix PR87117

Another one. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2018-08-28 Richard Biener PR tree-optimization/87117 * tree-ssa-sccvn.c (eliminate_dom_walker::eliminate_stmt): Only re-value-number released SSA VDEFs. * gfortran.dg/pr871

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

On 08/28/18 11:25, Bernd Edlinger wrote: > On 08/28/18 04:55, Jeff Law wrote: >> On 08/23/2018 08:48 AM, Bernd Edlinger wrote: >>> On 08/23/18 16:24, Jeff Law wrote: > > Yes, and which one was the earlier, more controversial patch from me? https://gcc.gnu.org/ml/gcc-patches/2018-0

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

On 08/26/2018 03:18 PM, Stafford Horne wrote: > -mm-dd Stafford Horne > Richard Henderson > > gcc/ChangeLog: > > * common/config/or1k/or1k-common.c: New file. > * config/or1k/*: New. > * config.gcc (or1k*-*-*): New. > * configure.ac (or1k*-*-*): New test

Re: [PATCH] Fix version check for ATTRIBUTE_GCC_DUMP_PRINTF

On Tue, 2018-08-28 at 14:26 +0200, Jakub Jelinek wrote: > On Tue, Aug 28, 2018 at 08:43:59AM +0200, Jakub Jelinek wrote: > > On Mon, Aug 27, 2018 at 08:32:11PM -0400, David Malcolm wrote: > > > gcc/ChangeLog: > > > * dumpfile.h (ATTRIBUTE_GCC_DUMP_PRINTF): Change version check > > > on > > > GC

[PATCH] doc: document -ftree-scev-cprop

Hi, PR 86726 is pointing out that -ftree-scev-cprop is not documented. Here's documentation for the final-value-replacement aspect of the option. It technically can also replace in-loop references by constants, but that doesn't seem very useful. I'm not aware of any required order for option pa

[PATCH] Fix PR87126

I am testing the following. Richard. 2018-08-28 Richard Biener PR tree-optimization/87126 * tree-ssa-sccvn.c (vn_reference_insert): Remove assert. * gcc.dg/tree-ssa/pr87126.c: New testcase. Index: gcc/tree-ssa-sccvn.c ===

[PATCH] PR libstdc++/87116 fix path::lexically_normal() handling of dot-dot

Previously the logic that turned "a/b/c/../.." into "a/" failed to preserve an empty path at the end of the iteration sequence, as required by the trailing slash. That meant the result didn't meet the class invariants, and that "a/b/c/d/../../.." would remove four components instead of the three t

Re: [PATCH] Optimize more boolean functions

Hi again, I guess I haven't been clear enough. I don't have push access, is it possible for you to push my patch to trunk? The same patch as: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01688.html but updated dates. 2018-08-28 MCC CS gcc/ PR tree-optimization/87009 *

Re: [PATCH 4/4] bb-reorder: convert to gcc_stablesort

On Tue, 28 Aug 2018, Richard Biener wrote: > On Tue, Aug 28, 2018 at 11:22 AM Alexander Monakov wrote: > > > > This converts the use in bb-reorder. I had to get a little bit creative > > with > > the comparator as profile_count::operator> does not implement a strict weak > > order. > > So the

Re: [ARM/FDPIC v2 00/21] FDPIC ABI for ARM

Ping? The original thread started at: https://gcc.gnu.org/ml/gcc-patches/2018-07/msg00707.html On Fri, 17 Aug 2018 at 00:19, Christophe Lyon wrote: > > Ping? > > Le mer. 1 août 2018 à 10:03, Christophe Lyon a écrit > : >> >> Ping? >> >> >> On 13/07/2018 18:10, christophe.l...@st.com wrote: >> >

[PATCH] i386: Add pass_remove_partial_avx_dependency

With -mavx, for [hjl@gnu-cfl-1 skx-2]$ cat foo.i extern float f; extern double d; extern int i; void foo (void) { d = f; f = i; } we need to generate vxorp[ds] %xmmN, %xmmN, %xmmN ... vcvtss2sd f(%rip), %xmmN, %xmmX ... vcvtsi2ss i(%

Re: [PATCH][GCC][AArch64] Cleanup the AArch64 testsuite when stack-clash is on [Patch (7/7)]

On 08/28/2018 06:18 AM, Tamar Christina wrote: > Hi All, > > Since this patch series now contains SVE support I am removing the changes > to the SVE tests in this patch series. I assume the OK still stands as the > only change here is undoing updates to three files. > > Thanks, > Tamar > > gcc/

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

On Fri, Aug 17, 2018 at 12:16:07AM -0700, Omar Sandoval wrote: > On Thu, Aug 16, 2018 at 11:54:53PM -0700, Omar Sandoval wrote: > > On Thu, Aug 16, 2018 at 10:27:48PM -0700, Andrew Pinski wrote: > > > On Thu, Aug 16, 2018 at 9:29 PM Omar Sandoval wrote: > > > > > > > > Hi, > > > > > > > > This fix

Re: [1/6] Handle gphis in gimple_get_lhs

On 08/28/2018 05:20 AM, Richard Sandiford wrote: > Several callers of gimple_get_lhs deal with statements that might > be phis. This patch makes gimple_get_lhs handle that case too, > so that the callers don't have to. > > > 2018-08-28 Richard Sandiford > > gcc/ > * gimple.c (gimple_ge

Re: [2/6] Make vec_info::lookup_single_use take a stmt_vec_info

On 08/28/2018 05:21 AM, Richard Sandiford wrote: > All callers to vec_info::lookup_single_use are asking about the lhs of a > statement that they're already examining. It makes more sense to pass > that statement instead of the SSA name, since it is then easier to > handle statements that have bee

Re: Keep std::deque algos specializations in Debug mode

On 25/08/18 22:44 +0200, François Dumont wrote: Note that I try to use typename deque<>::iterator or typename deque<>::const_iterator to define Debug algos but it didn't work, gcc was just not considering those overloads. I wonder why ? Because you can't deduce the template arguments from thos

Re: Keep std::deque algos specializations in Debug mode

On 25/08/18 22:44 +0200, François Dumont wrote: The last optimizations that get disabled when Debug mode is enable are the algo specializations for std::deque iterators. This patch move those algos in std namespace as they should even when Debug mode is enable so that they get considered even

Re: Make safe_iterator inline friends

On 23/08/18 22:59 +0200, François Dumont wrote: On 22/08/2018 23:45, Jonathan Wakely wrote: On 22/08/18 23:08 +0200, François Dumont wrote: Only operator== and != remains outside _Safe_iterator because all my attempts to make them inline friends failed. I understand that an inline friend withi

Re: [PATCH] Use more DECL_BUILT_IN_P macro.

> > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > Ready to be installed? This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87130 H.J.

[PATCH, OpenACC] (1/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

This patch implements support for array slices (with a non-zero base element) declared on OpenACC data constructs. Any lexically-enclosed parallel or kernels regions should "inherit" such mappings, e.g. if we have: #pragma acc data copy(arr[10:20]) { #pragma acc parallel loop for (...) { ...arr[

[PATCH, OpenACC] (2/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

This follow-up patch enables the "inheritance" of mappings for OpenACC data constructs to work also for Fortran assumed-size arrays. Otherwise, such arrays are (arguably, prematurely) bailed out on in the Fortran front-end. Tested alongside the previous patch with offloading to nvptx. OK to apply

Re: Make safe_iterator inline friends

On 28/08/2018 21:04, Jonathan Wakely wrote: On 23/08/18 22:59 +0200, François Dumont wrote: On 22/08/2018 23:45, Jonathan Wakely wrote: On 22/08/18 23:08 +0200, François Dumont wrote: Only operator== and != remains outside _Safe_iterator because all my attempts to make them inline friends fail

Re: [PATCH, OpenACC] (2/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

On 08/28/2018 12:19 PM, Julian Brown wrote: > diff --git a/gcc/fortran/trans-openmp.c b/gcc/fortran/trans-openmp.c > index f038f4c..86be407 100644 > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -1045,9 +1045,13 @@ gfc_omp_finish_clause (tree c, gimple_seq *pre_p) > >

Re: [PATCH 4/4] bb-reorder: convert to gcc_stablesort

Hi, On Tue, 28 Aug 2018, Alexander Monakov wrote: > > I think your proposed one > > warrants some comments. Maybe trade speed for some clearer code? > > I think it's not too complicated, but how about adding this comment: > > profile_count m = c1.max (c2); > /* Return 0 if counts are equal

Re: [PATCH] Optimize more boolean functions

On 08/28/2018 09:34 AM, MCC CS wrote: > Hi again, > > I guess I haven't been clear enough. I don't > have push access, is it possible for you to > push my patch to trunk? > > The same patch as: > https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01688.html > but updated dates. > > 2018-08-28 MCC CS

Re: [PATCH][GCC][AArch64] Add support for SVE stack clash probing [patch (2/7)]

I'll leave the AArch64 maintainers to review, but some comments. Tamar Christina writes: > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index > 06451f38b11822ea77323438fe8c7e373eb9e614..e7efde79bb111e820f4df44a276f6f73070ecd17 > 100644 > --- a/gcc/config/aarch64/aa

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

On 08/27/2018 10:27 PM, Jeff Law wrote: On 08/27/2018 10:27 AM, Martin Sebor wrote: On 08/27/2018 02:29 AM, Richard Biener wrote: On Sun, Aug 26, 2018 at 7:26 AM Jeff Law wrote: On 08/24/2018 09:58 AM, Martin Sebor wrote: The warning suppression for -Wstringop-truncation looks for the next

Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/7)]

Tamar Christina writes: > + HOST_WIDE_INT guard_used_by_caller = STACK_CLASH_CALLER_GUARD; > + /* When doing the final adjustment for the outgoing argument size we can't > + assume that LR was saved at position 0. So subtract it's offset from > the > + ABI safe buffer so that we don't

Re: [PATCH] doc: document -ftree-scev-cprop

Alexander Monakov writes: > @@ -9120,6 +9121,15 @@ determining number of iterations requires complicated > analysis. Later > optimizations then may determine the number easily. Useful especially > in connection with unrolling. > > +@item -ftree-scev-cprop > +@opindex ftree-scev-cprop > +Per

RFA: Avoid warning for write_predicate_subfunction generated function

In predicates.md, we have a predicate like this: (define_special_predicate "esirisc_simd_shift_reg_operand" (match_operand 0 "d_register_operand") { /* Earlier revs shifted both halves by the same amount, which is not usable. */ return esirisc_rev_option > 10; }) genpreds generates for

Re: [PATCH, OpenACC] (2/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

On Tue, 28 Aug 2018 12:23:22 -0700 Cesar Philippidis wrote: > On 08/28/2018 12:19 PM, Julian Brown wrote: > > > diff --git a/gcc/fortran/trans-openmp.c b/gcc/fortran/trans-openmp.c > > index f038f4c..86be407 100644 > > --- a/gcc/fortran/trans-openmp.c > > +++ b/gcc/fortran/trans-openmp.c > > @@

Re: RFA: Avoid warning for write_predicate_subfunction generated function

Joern Wolfgang Rennecke writes: > 2018-08-28 Joern Rennecke > > * genpreds.c (write_predicate_subfunction): Also add ATTRIBUTE_UNUSED > to OP parmeter of generated function. OK, thanks. Richard > Index: genpreds.c >

Re: [PATCH][AArch64] Implement new intrinsics vabsd_s64 and vnegd_s64

On Tue, Aug 28, 2018 at 03:59:25AM -0500, Vlad Lazar wrote: > Gentle ping. > > On 08/08/18 17:38, Vlad Lazar wrote: > > On 01/08/18 18:35, James Greenhalgh wrote: > >> On Wed, Aug 01, 2018 at 07:13:53AM -0500, Vlad Lazar wrote: > >>> On 31/07/18 22:48, James Greenhalgh wrote: > On Fri, Jul 20

Re: [PATCH] [AArch64, Falkor] Adjust Falkor's sign extend reg+reg address cost

On Mon, Aug 27, 2018 at 10:05:21AM -0500, Luis Machado wrote: > Hi, > > On 08/08/2018 04:46 AM, Siddhesh Poyarekar wrote: > > On 08/01/2018 04:24 AM, James Greenhalgh wrote: > >> OK if this is what is best for your subtarget. > >> > > > > I have pushed this on behalf of Luis since he is on holida

Re: [PATCH] [AArch64, Falkor] Switch to using Falkor-specific vector costs

On Mon, Aug 27, 2018 at 10:05:17AM -0500, Luis Machado wrote: > Hi, > > On 08/08/2018 04:54 AM, Siddhesh Poyarekar wrote: > > On 08/01/2018 04:23 AM, James Greenhalgh wrote: > >> On Wed, Jul 25, 2018 at 01:10:34PM -0500, Luis Machado wrote: > >>> The adjusted vector costs give Falkor a reasonable

Re: [PATCH, OpenACC] (2/2) Fix implicit mapping for array slices on lexically-enclosing data constructs (PR70828)

On 08/28/2018 02:32 PM, Julian Brown wrote: > On Tue, 28 Aug 2018 12:23:22 -0700 > Cesar Philippidis wrote: >> This is specific to OpenACC, and needs to be guarded as such. > > Are you sure that condition can be true for OpenMP? I'd assumed not... My bad, you're correct. OMP doesn't use those G

Re: [PATCH][GCC][AARCH64] Use stdint integers in vect_su_add_sub.c

On Fri, Aug 03, 2018 at 11:28:08AM -0500, Matthew Malcomson wrote: > On 02/08/18 20:18, James Greenhalgh wrote: > > On Tue, Jul 31, 2018 at 04:53:19AM -0500, Matthew Malcomson wrote: > >> Fixing the ilp32 issue that Christophe found. > >> > >> The existing testcase uses `long` to represent a 64 bit

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

On 08/28/2018 02:43 PM, Martin Sebor wrote: > On 08/27/2018 10:27 PM, Jeff Law wrote: >> On 08/27/2018 10:27 AM, Martin Sebor wrote: >>> On 08/27/2018 02:29 AM, Richard Biener wrote: On Sun, Aug 26, 2018 at 7:26 AM Jeff Law wrote: > > On 08/24/2018 09:58 AM, Martin Sebor wrote: >>

[C++ PATCH] Fix structured binding range for in generic lambda inside of template (PR c++/87122)

Hi! The following testcase ICEs in tsubst_decomp_names, because the earlier tsubst_expr still with processing_template_decl called just tsubst_decomp_names, but didn't arrange for DECL_VALUE_EXPR to be set on the decomp identifier decls (which cp_finish_decomp does). Fixed thusly, bootstrapped/re

Re: [3/6] Add a vec_basic_block structure

On 08/28/2018 05:22 AM, Richard Sandiford wrote: > This patch adds a vec_basic_block that records the scalar phis and > scalar statements that we need to vectorise. This is a slight > simplification in its own right, since it avoids unnecesary statement > lookups and shaves >50 LOC. But the main

[C++ PATCH] Fix -fsanitize=vptr -fno-sanitize-recover=vptr (PR c++/87095)

Hi! As mentioned in the PR, if some class has nearly empty virtual base as primary base, it shares the vptr with that primary base; in that case, we can't clear the vptr in the not in charge destructor of that class, as the dtor for the virtual base will be invoked later on and needs to have the v

Re: [GCC][PATCH v2][Aarch64] Exploiting BFXIL when OR-ing two AND-operations with appropriate bitmasks

On Wed, Aug 01, 2018 at 10:07:23AM -0500, Sam Tebbs wrote: > Hi all, > > This patch adds an optimisation that exploits the AArch64 BFXIL > instruction when or-ing the result of two bitwise and operations > with non-overlapping bitmasks > (e.g. (a & 0x) | (b & 0x)). > > Example: >

Re: [GCC][PATCH][Aarch64] Added pattern to match zero extended bfxil

On Tue, Jul 31, 2018 at 04:38:43AM -0500, Sam Tebbs wrote: > Hi all, > > This patch captures the case where an unnecessary uxtw instruction is > generated > after a bfxil instruction when in SI mode, and stops it from being > generated. > Note that this depends on my previous patch submission >

Re: [PATCH, rs6000] inline expansion of str[n]cmp using vec/vsx instructions

Hi Aaron, On Wed, Aug 22, 2018 at 12:31:51PM -0500, Aaron Sawdey wrote: > This patch teaches rs6000 inline expansion of strcmp/strncmp how to > generate vector/vsx code for power8/power9 processors. Compares 16 > bytes and longer are generated using the vector code, which is > considerably faster

Re: [4/6] Make the vectoriser do its own DCE

On 08/28/2018 05:23 AM, Richard Sandiford wrote: > The vectoriser normally leaves a later DCE pass to remove the scalar > code, but we've accumulated various special cases for things that > DCE can't handle, such as removing the scalar stores that have been > replaced by vector stores, and the scal

Re: [PATCH] convert MIN_EXPR operands to the same type (PR 87059)

On 08/27/2018 02:32 AM, Richard Biener wrote: > On Sat, Aug 25, 2018 at 9:14 PM Jeff Law wrote: >> >> On 08/24/2018 01:06 PM, Martin Sebor wrote: >>> PR 87059 points out an ICE in the recently enhanced VRP code >>> that was traced back to a MIN_EXPR built out of operands of >>> types with differen

Re: [5/6] Insert pattern statements into vec_basic_blocks

On 08/28/2018 05:24 AM, Richard Sandiford wrote: > The point of this patch is to put pattern statements in the same > vec_basic_block as the statements they replace, with the pattern > statements for S coming between S and S's original predecessor. > This removes the need to handle them specially i

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

Sadly, dstbase is the PARM_DECL for d. That's where things are going "wrong". Not sure why you're getting the PARM_DECL in that case. I'd debug get_addr_base_and_unit_offset to understand what's going on. Essentially you're getting different results of get_addr_base_and_unit_offset in a case wh

Go patch committed: Remove hmap field from map types

In https://golang.org/cl/91796 in the master Go repository the hmap field was removed from map types. While the Go frontend doesn't have to be compatible, it may as well be. This implements part of that change for the Go frontend, just the compiler change and the required libgo change. This is i

[PATCH] Rewrite pic.md to improve medany and pic code size.

The pic.md file has patterns used only for the medany code model and for pic code. They match an unsplit 2-instruction address load pattern followed by a load or store instruction, and emit an assembler macro that expands to two instructions. This replaces 3 instructions with 2. Unfortunately, t

  1   2   >