RE: [PATCH] arm: Generate correct const_ints (PR86640)

2018-08-15 Thread Tamar Christina
Hi All, I'd like to ask for permissions to backport of this patch to GCC 8? Thanks, Tamar > -Original Message- > From: Kyrill Tkachov > Sent: Tuesday, July 31, 2018 12:55 > To: Segher Boessenkool > Cc: gcc-patches@gcc.gnu.org; tnfch...@gcc.gnu.org > Subject: Re: [PATCH] arm: Generate c

Re: [PATCH] arm: Generate correct const_ints (PR86640)

2018-08-15 Thread Kyrill Tkachov
On 15/08/18 09:21, Tamar Christina wrote: Hi All, I'd like to ask for permissions to backport of this patch to GCC 8? Ok. Please bundle the testcase in the backport as well. Thanks, Kyrill Thanks, Tamar -Original Message- From: Kyrill Tkachov Sent: Tuesday, July 31, 2018 12:55

[Patch wwwdocs] Document arm-8-branch

2018-08-15 Thread Ramana Radhakrishnan
As $subject. Ok ? regards Ramana ? htdocs/svn.html.~1.223.~ Index: htdocs/svn.html === RCS file: /cvs/gcc/wwwdocs/htdocs/svn.html,v retrieving revision 1.223 diff -a -u -p -r1.223 svn.html --- htdocs/svn.html 18 Jul 2018 18:17:

Re: [PATCH] PR libstdc++/86846 Alternative to pointer-width atomics

2018-08-15 Thread Szabolcs Nagy
On 14/08/18 14:13, Jonathan Wakely wrote: Define a class using std::mutex for when std::atomic cannot be used to implement the default memory resource. When std::mutex constructor is not constexpr the constant_init trick won't work, so just define a global and use init_priority for it. The compi

Re: [PATCH] PR libstdc++/86846 Alternative to pointer-width atomics

2018-08-15 Thread Jonathan Wakely
On 15/08/18 10:40 +0100, Szabolcs Nagy wrote: On 14/08/18 14:13, Jonathan Wakely wrote: Define a class using std::mutex for when std::atomic cannot be used to implement the default memory resource. When std::mutex constructor is not constexpr the constant_init trick won't work, so just define a

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread James Greenhalgh
On Tue, Aug 14, 2018 at 09:34:08PM -0500, Martin Sebor wrote: > On 08/14/2018 09:24 AM, Martin Sebor wrote: > > On 08/14/2018 09:08 AM, Martin Sebor wrote: > >> On 08/14/2018 07:27 AM, James Greenhalgh wrote: > >>> On Wed, Aug 08, 2018 at 07:17:07PM -0500, Martin Sebor wrote: > On 08/08/2018 0

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-15 Thread Kai Tietz
Hello Kyrill, thanks for your comments. 2018-08-14 16:50 GMT+02:00 Kyrill Tkachov : > Hi Kai, > > > On 13/08/18 17:48, Kai Tietz wrote: >> >> I repost updated patch containing ChangeLog entry. >> >> Regards, >> Kai > > > I think I understand what this patch does, please correct me if I'm wrong.

[PATCH v2] S/390: Remove literal pool chunkification loop

2018-08-15 Thread Ilya Leoshkevich
Since there is no branch splitting anymore, the loop is no longer necessary: pool chunkification can be done in one step. gcc/ChangeLog: 2018-08-13 Ilya Leoshkevich * config/s390/s390.c (s390_reorg): remove loop --- gcc/config/s390/s390.c | 68 ++--

[PATCH] Set start_location to 0 if we ran out of line map space

2018-08-15 Thread H.J. Lu
With profiledbootstrap and --with-build-config=bootstrap-lto, linemap_add may create a macro map when we run out of line map space. This patch changes start_location to UNKNOWN_LOCATION (0) in this case. Tested with profiledbootstrap and --with-build-config=bootstrap-lto on Linux/x86-64.

Re: [PATCH] Merge Ignore and Deprecated in .opt files.

2018-08-15 Thread Martin Liška
On 07/26/2018 11:19 PM, Joseph Myers wrote: > On Thu, 19 Jul 2018, Martin Liška wrote: > >> I must admit that was my intention :) In my eyes it makes it more consistent >> and >> it gives consumers feedback about usage of an option that does nothing. >> For x86_64 there's list of options that are

Re: [PATCH v2] S/390: Remove literal pool chunkification loop

2018-08-15 Thread Andreas Krebbel
On 08/15/2018 12:50 PM, Ilya Leoshkevich wrote: > gcc/ChangeLog: > > 2018-08-13 Ilya Leoshkevich > > * config/s390/s390.c (s390_reorg): remove loop Applied. Thanks! Andreas

Re: [PATCH] Use more DECL_BUILT_IN_P macro.

2018-08-15 Thread Martin Liška
On 08/14/2018 06:02 PM, Martin Sebor wrote: > On 08/14/2018 03:06 AM, Martin Liška wrote: >> Hi. >> >> The patch adds more usages of the new macro. I hope it improves >> readability of code. > > I think it does :)  I see that most invocations of it in your > patch are with BUILT_IN_NORMAL as the s

Re: [PATCH][GCC][AArch64] Limit movmem copies to TImode copies.

2018-08-15 Thread Tamar Christina
Hi All, I'm updating the patch with the suggested changes and also fixing a bug with a boundary condition. On AArch64 we have integer modes larger than TImode, and while we can generate moves for these they're not as efficient. So instead make sure we limit the maximum we can copy to TImode. T

[PATCH][GCC][mid-end] Fix DSE big-endian subreg crash

2018-08-15 Thread Tamar Christina
Hi All, This patch fixes an ICE that would happen when extract_low_bits is called with modes for which you can't extract a valid subreg. e.g. taking a 32 bytes subreg from a 48 byte mode. The ICE happens because convert_modes which eventually calls simplify_gen_subreg does not expect the converti

[arm-8-branch] Backport spectre v1 patches

2018-08-15 Thread Ramana Radhakrishnan
Hi, Backport spectre mitigation patches into the arm-8-branch , these appeared to be clean backports back to the branch without any conflicts. Backported svn revisions 263169 263170 263171 263172 263173 263174 263175 263176 263180 263196 263197 263209 263253 263254 263255 263256 263258 263259 26

[PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Iain Sandoe
Hi, The fails on Darwin are because the section naming convention is different. The patch adds Darwin-specific section attributes and a corresponding target-specific scan-assembler clause. OK for trunk? affected branches (7, 8)? thanks Iain 2018-08-15 Iain Sandoe gcc/testsuite: PR

[RFC][debug] Add -greadable-dwarf

2018-08-15 Thread Tom de Vries
Hi, This patch adds option -greadable-dwarf. In absence of an DW_AT_comment attribute, it sets the DW_AT_name attribute of dies that otherwise do not get that attribute, to make it easier to figure out what the die is describing. The option exports the names of artificial variables: ... DIE

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Bernd Edlinger
On 08/15/18 07:12, Jeff Law wrote: > On 08/14/2018 08:08 AM, Martin Sebor wrote: >> On 08/14/2018 04:25 AM, Bernd Edlinger wrote: >>> Hi, >>> >>> this patch is a follow-up to my patch here: >>> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >> >> As I said multiple times, this patch is re

[PATCH, testsuite] Stringify __USER_LABEL_PREFIX__ for pr81923.c

2018-08-15 Thread Iain Sandoe
Hi, This test has always failed on Darwin (and presumably the other targets with user __USER_LABEL_PREFIX__ != “” ) since it needs to be stringified. OK for trunk? affected branches? thanks Iain 2018-08-15 Iain Sandoe gcc/testsuite: * gcc.dg/asan/pr81923.c: Stringify __USER_LABEL_

[PATCH,testsuite, Darwin] Skip tests with pthread_barrier.

2018-08-15 Thread Iain Sandoe
Hi, Darwin is stated to be SUSv6 compliant and, at that revision, pthread_barrier is optional. It is not implemented on any version at least up to Darwin18. This skips the tests currently attempted which use pthread_barrier. OK for trunk? thanks Iain gcc/testsuite/ * c-c++-common/asan

Re: [PATCH][GCC][Arm] Fix subreg crash in different way by enabling the FP16 pattern unconditionally.

2018-08-15 Thread Kyrill Tkachov
Hi Tamar, On 26/07/18 12:01, Tamar Christina wrote: Hi Thomas, > -Original Message- > From: Thomas Preudhomme > Sent: Thursday, July 26, 2018 09:29 > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Ramana Radhakrishnan > ; Richard Earnshaw > ; ni...@redhat.com; Kyrylo Tkachov

Re: [PATCH 0/6] improve handling of char arrays with missing nul (PR 86552, 86711, 86714)

2018-08-15 Thread Martin Sebor
On 08/15/2018 12:02 AM, Jeff Law wrote: On 08/13/2018 03:23 PM, Martin Sebor wrote: To make reviewing the changes easier I've split up the patch into a series: [ ... ] I'm about done for the night and thus won't get into the series (and as you know Bernd has a competing patch in this space). B

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread Richard Biener
On August 15, 2018 12:28:55 PM GMT+02:00, James Greenhalgh wrote: >On Tue, Aug 14, 2018 at 09:34:08PM -0500, Martin Sebor wrote: >> On 08/14/2018 09:24 AM, Martin Sebor wrote: >> > On 08/14/2018 09:08 AM, Martin Sebor wrote: >> >> On 08/14/2018 07:27 AM, James Greenhalgh wrote: >> >>> On Wed, Aug

Re: [PATCH, testsuite] Stringify __USER_LABEL_PREFIX__ for pr81923.c

2018-08-15 Thread Richard Biener
On August 15, 2018 4:15:42 PM GMT+02:00, Iain Sandoe wrote: >Hi, > >This test has always failed on Darwin (and presumably the other targets >with user __USER_LABEL_PREFIX__ != “” ) since it needs to be >stringified. > >OK for trunk? OK. >affected branches? Yes. If you tested on x86_64-linux f

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Jeff Law
On 08/15/2018 08:03 AM, Bernd Edlinger wrote: > > But must admit, that I have sometimes the impression of being ignored, > for instance what I wrote in response to Martin's patch here: > https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00184.html > ... and already earlier here: > https://gcc.gnu.org/

Stack alignment on Darwin (PR78444)

2018-08-15 Thread Iain Sandoe
Hi HJ, I am trying to track down a misalignment of the stack on Darwin (pr78444). In r163971 you applied this: --- gcc/config/i386/darwin.h(revision 163970) +++ gcc/config/i386/darwin.h(revision 163971) @@ -79,7 +79,9 @@ Failure to ensure this will lead to a crash in the system libra

Re: [PATCH 0/6] improve handling of char arrays with missing nul (PR 86552, 86711, 86714)

2018-08-15 Thread Jeff Law
On 08/15/2018 08:47 AM, Martin Sebor wrote: > On 08/15/2018 12:02 AM, Jeff Law wrote: >> On 08/13/2018 03:23 PM, Martin Sebor wrote: >>> To make reviewing the changes easier I've split up the patch >>> into a series: >> [ ... ] >> I'm about done for the night and thus won't get into the series (and

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread Martin Sebor
On 08/15/2018 04:28 AM, James Greenhalgh wrote: On Tue, Aug 14, 2018 at 09:34:08PM -0500, Martin Sebor wrote: On 08/14/2018 09:24 AM, Martin Sebor wrote: On 08/14/2018 09:08 AM, Martin Sebor wrote: On 08/14/2018 07:27 AM, James Greenhalgh wrote: On Wed, Aug 08, 2018 at 07:17:07PM -0500, Marti

Re: Stack alignment on Darwin (PR78444)

2018-08-15 Thread H.J. Lu
On Wed, Aug 15, 2018 at 8:41 AM, Iain Sandoe wrote: > Hi HJ, > > I am trying to track down a misalignment of the stack on Darwin (pr78444). > > In r163971 you applied this: > > --- gcc/config/i386/darwin.h(revision 163970) > +++ gcc/config/i386/darwin.h(revision 163971) > @@ -79,7 +79,9 @@

[PATCH, testsuite] Fix gcc.dg/memcmp-1.c for targets using __USER_LABEL_PREFIX__

2018-08-15 Thread Iain Sandoe
Hi, The test fails on Darwin (and presumably on other _U_L_P_ targets) because the asm-specified symbol isn’t found at link time. OK for trunk? thanks Iain gcc/testsuite: * gcc.dg/memcmp-1.c (lib_memcmp): Apply __USER_LABEL_PREFIX__. (lib_strncmp): Likewise. diff --git a/gcc/

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Jeff Law
On 08/14/2018 04:25 AM, Bernd Edlinger wrote: > Hi, > > this patch is a follow-up to my patch here: > https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html > > Since most calls of c_strlen and get_range_strlen expect > a string length in bytes of a zero-terminated string, there is > a need for

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-15 Thread Qing Zhao
> On Aug 14, 2018, at 11:25 PM, Jeff Law wrote: > > On 08/14/2018 08:57 AM, Qing Zhao wrote: >> Hi, >> >> PR 86519:New test case gcc.dg/strcmpopt_6.c fails with its introduction in >> r262636. >> >> gcc/ChangeLog: >> >> +2018-08-14 Qing Zhao >> + >> + PR testsuite/86519 >> +

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Martin Sebor
Standard procedure in this kind of situation where we have two patches that are handling the same issue is to bake them off and choose one based on the technical merits. To that end... It would be helpful if you could compare/contrast your patch to Bernd's. ie, are there cases that will be hand

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Bernd Edlinger
On 08/15/18 18:25, Jeff Law wrote: > On 08/14/2018 04:25 AM, Bernd Edlinger wrote: >> Hi, >> >> this patch is a follow-up to my patch here: >> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >> >> Since most calls of c_strlen and get_range_strlen expect >> a string length in bytes of a zer

Re: [PATCH] Merge Ignore and Deprecated in .opt files.

2018-08-15 Thread Joseph Myers
On Wed, 15 Aug 2018, Martin Liška wrote: > Ok, so you have very similar opinion as Jakub. Thus I'm sending new > version that preserves status quo, it only does: This is removing RejectNegative from some Deprecated options. Won't that result in the -fno-* variants of those options starting to

Re: [PATCH, testsuite] Fix gcc.dg/memcmp-1.c for targets using __USER_LABEL_PREFIX__

2018-08-15 Thread Jeff Law
On 08/15/2018 10:05 AM, Iain Sandoe wrote: > Hi, > > The test fails on Darwin (and presumably on other _U_L_P_ targets) because > the asm-specified symbol isn’t found at link time. > > OK for trunk? > > thanks > Iain > > gcc/testsuite: > > * gcc.dg/memcmp-1.c (lib_memcmp): Apply __USER_

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

2018-08-15 Thread Julian Brown
On Mon, 13 Aug 2018 12:06:21 -0700 Cesar Philippidis wrote: > So in other words, this is safe for fortran. It probably could use a > fortran test, because that functionality wasn't explicitly exercised > in og7/og8. Here's a new version of the patch with a Fortran test case. It's not too easy to

[PATCH][GCC][DOCS] Remove rtl.texi references to old RTX code class names

2018-08-15 Thread Matthew Malcomson
Remove rtl.texi references to old RTX code class names The old names were changed in svn revision svn+ssh://gcc.gnu.org/svn/gcc/trunk@78824 138bc75d-0d04-0410-961f-82ee72b054a4 but the documentation was not fully updated at the time. Documentation checked after full build (both .info and .pdf) Ok

[PATCH] CPP Macro predicates

2018-08-15 Thread Nathan Sidwell
I've been working on a cleanup of the preprocessor's macro machinery, this is the first patch of that series. 1) Introduce a set of inline predicates for detecting if an identifier is a macro of some kind. The implementation of those predicates will change, but the users will not need further

Re: Warning about -Wmain for local variables

2018-08-15 Thread Prathamesh Kulkarni
On 28 June 2018 at 08:46, Jeff Law wrote: > On 05/30/2018 09:51 AM, Prathamesh Kulkarni wrote: >> On 30 May 2018 at 18:12, Jonathan Wakely wrote: >>> On 30 May 2018 at 11:40, Prathamesh Kulkarni wrote: gcc with -Wmain warns for local variables named main. int foo() { in

lightweight class to wide int ranges in VRP and friends

2018-08-15 Thread Aldy Hernandez
I kept seeing the same patterns over and over in all this re-factoring: 1. extract value_range constants into pairs of wide ints 2. mimic symbolics as [-MIN, +MAX] (most of the time :)) 3. perform some wide int operation on the wide int range 4. convert back to a value range So I've decided t

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-15 Thread Steve Ellcey
On Wed, 2018-08-15 at 12:45 +0200, Kai Tietz wrote: >  > > I believe the scheduler provides hooks specifically for storing > > backend-specific scheduling state so we should > > avoid creating such static variables in aarch64.c. Can you use the > > TARGET_SCHED_*_SCHED_CONTEXT family of hooks here?

[committed] diagnostics: add labeling of source ranges

2018-08-15 Thread David Malcolm
This patch adds the ability to label source ranges within a rich_location, to be printed by diagnostic_show_locus. For example: pr69554-1.c:11:18: error: invalid operands to binary + (have 'const char *' and 'const char *') 11 | return (p + 1) + (q + 1); | ~~~ ^ ~~~ |

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Jeff Law
On 08/15/2018 10:38 AM, Bernd Edlinger wrote: > On 08/15/18 18:25, Jeff Law wrote: >> On 08/14/2018 04:25 AM, Bernd Edlinger wrote: >>> Hi, >>> >>> this patch is a follow-up to my patch here: >>> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >>> >>> Since most calls of c_strlen and get_r

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Martin Sebor
On 08/15/2018 10:25 AM, Jeff Law wrote: On 08/14/2018 04:25 AM, Bernd Edlinger wrote: Hi, this patch is a follow-up to my patch here: https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html Since most calls of c_strlen and get_range_strlen expect a string length in bytes of a zero-terminated

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Bernd Edlinger
On 08/15/18 20:13, Jeff Law wrote: > On 08/15/2018 10:38 AM, Bernd Edlinger wrote: >> On 08/15/18 18:25, Jeff Law wrote: >>> On 08/14/2018 04:25 AM, Bernd Edlinger wrote: Hi, this patch is a follow-up to my patch here: https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >>>

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Jeff Law
Ignore this prior message from me I'm off-base here... On 08/15/2018 12:13 PM, Jeff Law wrote: > On 08/15/2018 10:38 AM, Bernd Edlinger wrote: >> On 08/15/18 18:25, Jeff Law wrote: >>> On 08/14/2018 04:25 AM, Bernd Edlinger wrote: Hi, this patch is a follow-up to my patch here

Re: [PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Mike Stump
On Aug 15, 2018, at 6:20 AM, Iain Sandoe wrote: > > The fails on Darwin are because the section naming convention is different. > > The patch adds Darwin-specific section attributes and a corresponding > target-specific scan-assembler clause. > > OK for trunk? > affected branches (7, 8)? Ok.

Re: [PATCH,testsuite, Darwin] Skip tests with pthread_barrier.

2018-08-15 Thread Mike Stump
On Aug 15, 2018, at 7:22 AM, Iain Sandoe wrote: > Darwin is stated to be SUSv6 compliant and, at that revision, pthread_barrier > is optional. > It is not implemented on any version at least up to Darwin18. > > This skips the tests currently attempted which use pthread_barrier. > > OK for trunk

C++ PATCH for c++/67012, diagnose decltype(auto) f() -> int;

2018-08-15 Thread Marek Polacek
I think that [dcl.fct] says that a function with trailing-return-type should have plain auto as the return type, so this test should not compile. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2018-08-15 Marek Polacek PR c++/67012 * decl.c (grokdeclarator): Disallow fun

Re: [PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Iain Sandoe
> On 15 Aug 2018, at 19:39, Mike Stump wrote: > > On Aug 15, 2018, at 6:20 AM, Iain Sandoe wrote: >> >> The fails on Darwin are because the section naming convention is different. >> >> The patch adds Darwin-specific section attributes and a corresponding >> target-specific scan-assembler c

[PATCH, Darwin] Move fixed _Unwind_find_Enclosing_func to a crt.

2018-08-15 Thread Iain Sandoe
Hi, This is a pre-cursor to other tidy-ups aimed at being able to dispense with the “ext” library that we introduced (a lng time ago) to deal with the differences between Darwin’s installed libgcc_s and the current compiler. Since the installed version of _Unwind_find_Enclosing_func was bro

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-15 Thread Bernd Edlinger
On 08/15/18 20:18, Martin Sebor wrote: > On 08/15/2018 10:25 AM, Jeff Law wrote: >> On 08/14/2018 04:25 AM, Bernd Edlinger wrote: >>> Hi, >>> >>> this patch is a follow-up to my patch here: >>> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >>> >>> Since most calls of c_strlen and get_ran

Re: [PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Joseph Myers
On Wed, 15 Aug 2018, Iain Sandoe wrote: > One of my Grand Ideas (i.e. things that might never happen because of > time) would be to split out the Well Known Sections used by GCC into > file/files with .defs for the different flavours. This would mean one > place to add a new GCC named section -

Re: [PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Iain Sandoe
> On 15 Aug 2018, at 20:07, Joseph Myers wrote: > > On Wed, 15 Aug 2018, Iain Sandoe wrote: > >> One of my Grand Ideas (i.e. things that might never happen because of >> time) would be to split out the Well Known Sections used by GCC into >> file/files with .defs for the different flavours.

[PATCH] Refactor uses-allocator construction

2018-08-15 Thread Jonathan Wakely
Remove duplicated logic in experimental::pmr::polymorphic_allocator by calling the __uses_allocator_construct helper. Fix bugs in std::pmr::polymorphic_allocator with incorrect SFINAE constraint and incorrect argument order. * include/bits/uses_allocator.h (__uses_allocator_construct): Q

Re: [PATCH][GCC][DOCS] Remove rtl.texi references to old RTX code class names

2018-08-15 Thread Sandra Loosemore
On 08/15/2018 11:17 AM, Matthew Malcomson wrote: Remove rtl.texi references to old RTX code class names The old names were changed in svn revision svn+ssh://gcc.gnu.org/svn/gcc/trunk@78824 138bc75d-0d04-0410-961f-82ee72b054a4 but the documentation was not fully updated at the time. Documentatio

Re: [PATCH][x86] Match movss and movsd "blend" instructions

2018-08-15 Thread Uros Bizjak
On Wed, Aug 15, 2018 at 6:33 AM, Jeff Law wrote: > On 08/11/2018 03:54 AM, Allan Sandfeld Jensen wrote: >> On Samstag, 11. August 2018 11:18:39 CEST Jakub Jelinek wrote: >>> On Sat, Aug 11, 2018 at 10:59:26AM +0200, Allan Sandfeld Jensen wrote: +/* A subroutine of ix86_expand_vec_perm_builtin

[PATCH] Fix experimental::pmr typedefs and add tests

2018-08-15 Thread Jonathan Wakely
The typedefs in and don't need to be in the __cxx11 namespace, because they are only aliases and so will have the same mangled name as the underlying types. * include/experimental/regex: Remove begin/end macros for namespace. * include/experimental/string: Likewise. * te

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

2018-08-15 Thread Bernhard Reutner-Fischer
On 15 August 2018 18:46:37 CEST, Julian Brown wrote: >On Mon, 13 Aug 2018 12:06:21 -0700 >Cesar Philippidis wrote: atttribute has more t than strictly necessary. Don't like signed integer levels where they should be some unsigned. Also don't like single switch cases instead of if. And omitting

Re: C++ PATCH for c++/67012, diagnose decltype(auto) f() -> int;

2018-08-15 Thread Marek Polacek
On Wed, Aug 15, 2018 at 02:45:02PM -0400, Marek Polacek wrote: > I think that [dcl.fct] says that a function with trailing-return-type should > have plain auto as the return type, so this test should not compile. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? Looking at 86942, I think

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread Martin Sebor
On 08/15/2018 06:07 AM, Joseph Myers wrote: On Tue, 14 Aug 2018, Martin Sebor wrote: This is with Bison 3.0.4, should the version used to produce intl/plural.c prove relevant. Can you send me the translation unit and the options it was compiled with that triggered the errors? I've attached

Re: [RFC PATCH, i386]: Deprecate -mmitigate-rop

2018-08-15 Thread Uros Bizjak
On Wed, Aug 15, 2018 at 5:56 AM, Jeff Law wrote: > On 08/10/2018 05:42 AM, Uros Bizjak wrote: >> This option is fairly ineffective, and in the light of CET, nobody >> seems interested to improve it. Deprecate the option, so it won't lure >> developers to the land of false security. >> >> 2018-08-1

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread Jeff Law
On 08/15/2018 03:02 PM, Martin Sebor wrote: > On 08/15/2018 06:07 AM, Joseph Myers wrote: >> On Tue, 14 Aug 2018, Martin Sebor wrote: >> This is with Bison 3.0.4, should the version used to produce intl/plural.c prove relevant. >>> >>> Can you send me the translation unit and the opt

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread Jeff Law
On 08/15/2018 03:02 PM, Martin Sebor wrote: > On 08/15/2018 06:07 AM, Joseph Myers wrote: >> On Tue, 14 Aug 2018, Martin Sebor wrote: >> This is with Bison 3.0.4, should the version used to produce intl/plural.c prove relevant. >>> >>> Can you send me the translation unit and the opt

Re: [committed] diagnostics: add labeling of source ranges

2018-08-15 Thread Eric Gallager
On 8/15/18, David Malcolm wrote: > This patch adds the ability to label source ranges within a rich_location, > to be printed by diagnostic_show_locus. > > For example: > > pr69554-1.c:11:18: error: invalid operands to binary + (have 'const char *' > and 'const char *') > 11 | return (p + 1) + (

Re: [PATCH] [C] Warn when calculating abs(unsigned_value)

2018-08-15 Thread Eric Gallager
On 8/14/18, Joseph Myers wrote: > On Tue, 14 Aug 2018, Martin Jambor wrote: > >> when you try compiling a call to function abs and provide an unsigned >> int in the argument in C++, you will get an error about ambiguous >> overload. In C however, it will pass without silently. The following >> p

Re: [PATCH] [C] Warn when calculating abs(unsigned_value)

2018-08-15 Thread Martin Sebor
On 08/14/2018 05:53 AM, Martin Jambor wrote: Hi, when you try compiling a call to function abs and provide an unsigned int in the argument in C++, you will get an error about ambiguous overload. In C however, it will pass without silently. The following patch adds a warning for these cases, be

[PATCH v3 00/10] New backend for the TI PRU processor

2018-08-15 Thread Dimitar Dimitrov
This patch series adds support for the TI PRU I/O processor to GCC. All comments from v1 [1] and v2 [2] should be addressed in this third patch revision. Test results can be downloaded from here: http://dinux.eu/gnupru/testresults/20180816-b7bb5264/ Changes since patch series v2 [2]: - Minor

[PATCH v3 04/10] testsuite: Add check for overflowed IMEM region to testsuite

2018-08-15 Thread Dimitar Dimitrov
PRU architecture supports maximum 256k program memory (IMEM). Some GCC test cases manage to produce executables bigger than that. gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * lib/gcc-dg.exp: Bail on region overflow for tiny targets. * lib/target-utils.exp: Ditto.

[PATCH v3 02/10] Initial TI PRU libgcc port

2018-08-15 Thread Dimitar Dimitrov
The floating point support has been borrowed from C6X libgcc port to help with TI PRU toolchain ABI compatibility. libgcc/ChangeLog: 2018-07-27 Dimitar Dimitrov * config.host: Add PRU target. * config/pru/asri.c: New file. * config/pru/eqd.c: New file. * config

[PATCH v3 08/10] testsuite: Mark that PRU has one-cycle jumps

2018-08-15 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * gcc.dg/tree-ssa/20040204-1.c: XFAIL on pru. * gcc.dg/tree-ssa/reassoc-33.c: Ditto. * gcc.dg/tree-ssa/reassoc-34.c: Ditto. * gcc.dg/tree-ssa/reassoc-35.c: Ditto. * gcc.dg/tree-ssa/reassoc-36.c: Ditto.

[PATCH v3 07/10] testsuite: Define PRU stack usage

2018-08-15 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * gcc.dg/stack-usage-1.c: Define PRU stack usage. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.dg/stack-usage-1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/testsuite/gcc.dg/stack-usage-1.c b/gcc/testsuite

[PATCH v3 09/10] testsuite: Mark that PRU uses all function pointer bits

2018-08-15 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * g++.old-deja/g++.abi/ptrmem.C: Add PRU to list. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/g++.old-deja/g++.abi/ptrmem.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.old-deja/g++.a

[PATCH v3 03/10] testsuite: Add PRU tests

2018-08-15 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * gcc.target/pru/abi-arg-struct.c: New test. * gcc.target/pru/ashiftrt.c: New test. * gcc.target/pru/builtins-1.c: New test. * gcc.target/pru/builtins-error.c: New test. * gcc.target/pru/clearbit.c: Ne

[PATCH v3 10/10] testsuite: Mark testsuite that PRU has different calling convention

2018-08-15 Thread Dimitar Dimitrov
For variadic functions, the last named and all anonymous arguments are passed on stack. Regular functions pass arguments in registers. gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * gcc.dg/builtin-apply2.c: Skip for PRU. * gcc.dg/torture/stackalign/builtin-apply-2.c: D

[PATCH v3 06/10] testsuite: Remove PRU from test cases requiring hosted environment

2018-08-15 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * gcc.c-torture/execute/20101011-1.c: Define DO_TEST to 0 for PRU. * gcc.dg/20020312-2.c: No PIC register for PRU. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.c-torture/execute/20101011-1.c | 3 +++ gcc/testsuite

[PATCH v3 05/10] testsuite: Add check for unsupported TI ABI PRU features to testsuite

2018-08-15 Thread Dimitar Dimitrov
Not all C language features are supported when -mabi=ti option is used for PRU target. gcc/testsuite/ChangeLog: 2018-07-27 Dimitar Dimitrov * lib/gcc-dg.exp: Filter unsupported features in PRU's TI ABI mode. * lib/target-utils.exp: Ditto. * lib/target-supports.exp (che

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-15 Thread Bernd Edlinger
Jeff Law wrote: > I wonder if the change to how we set up the initializers is ultimately > changing the section those go into and ultimately causing an overflow of > the .sdata section. Yes, that is definitely the case. Due to the -fmerge-all-constants option used named arrays with brace initiali