Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Christophe Lyon
On 27 August 2015 at 17:43, Alan Lawrence wrote: > Martin Jambor wrote: >> >> First, I would be much >> happier if you added a proper comment to scalarize_elem function which >> you forgot completely. The name is not very descriptive and it has >> quite few parameters too. >> >> Second, this patc

Re: C++ delayed folding branch review

2015-08-28 Thread Kai Tietz
2015-08-28 4:11 GMT+02:00 Jason Merrill : > On 08/27/2015 02:12 PM, Kai Tietz wrote: >> >> + else if (TREE_CODE (type) == VECTOR_TYPE) >> +{ >> + if (TREE_CODE (arg1) == VECTOR_CST >> + && code == NOP_EXPR >> + && TYPE_VECTOR_SUBPARTS (type) == VECTOR_CST_NELTS (arg1)) >>

Re: [PATCH] Guard early debug generation with !seen_errors ()

2015-08-28 Thread Richard Biener
On Thu, 27 Aug 2015, Richard Biener wrote: > > This is already done for the TYPE_DECL case, the following avoids > trying to generate any debug after we've seen errors for the > calls to early_global_decl. > > Bootstrapped on x86_64-unknown-linux-gnu, testing and gdb testing in > progress. The

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Richard Biener
On Fri, 28 Aug 2015, Christophe Lyon wrote: > On 27 August 2015 at 17:43, Alan Lawrence wrote: > > Martin Jambor wrote: > >> > >> First, I would be much > >> happier if you added a proper comment to scalarize_elem function which > >> you forgot completely. The name is not very descriptive and it

Re: [ARC] Cleanup A5 references

2015-08-28 Thread Claudiu Zissulescu
Ping Original submission: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01199.html Thanks, Claudiu On Thu, Aug 20, 2015 at 1:42 PM, Claudiu Zissulescu wrote: > This patch cleans up the references to obsolete A5 processor. > > Can this be committed? > > Thanks, > Claudiu > > > 2015-08-20 Claudi

Re: [patch,libgfortran] Fix configure test for weakref support

2015-08-28 Thread FX
ping**2 Given that it’s a configury-patch, I think what it needs is real exposure on unusual targets more than formal review, so I intend to commit it in 48 hours unless someone objects in the meantime. Then I’ll be around to fix things if some fall apart… FX > Le 14 août 2015 à 17:06, FX

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Christophe Lyon
On 28 August 2015 at 09:48, Richard Biener wrote: > On Fri, 28 Aug 2015, Christophe Lyon wrote: > >> On 27 August 2015 at 17:43, Alan Lawrence wrote: >> > Martin Jambor wrote: >> >> >> >> First, I would be much >> >> happier if you added a proper comment to scalarize_elem function which >> >> you

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Richard Biener
On Fri, 28 Aug 2015, Christophe Lyon wrote: > On 28 August 2015 at 09:48, Richard Biener wrote: > > On Fri, 28 Aug 2015, Christophe Lyon wrote: > > > >> On 27 August 2015 at 17:43, Alan Lawrence wrote: > >> > Martin Jambor wrote: > >> >> > >> >> First, I would be much > >> >> happier if you adde

[PATCH] Fix LTO early-debug ICE wrt abstract origin node streaming

2015-08-28 Thread Richard Biener
The following fixes Program received signal SIGSEGV, Segmentation fault. 0x00af8edd in lto_get_decl_name_mapping (decl_data=0x0, name=0x768dcbd0 "bar") at /space/rguenther/src/svn/trunk/gcc/lto-section-in.c:349 349 htab_t renaming_hash_table = decl_data->renaming_hash_t

[COMMITTED][AArch64] Rename SYMBOL_SMALL_GOTTPREL to SYMBOL_SMALL_TLSIE

2015-08-28 Thread Jiong Wang
SYMBOL_SMALL_GOTTPREL is for TLS IE model, while it is the only symbol name which is not following the name convention SYMBOL_[code model]_TLS[tls model]. This patch fix this. Committed as obivious. 2015-08-28 Jiong Wang gcc/ * config/aarch64/aarch64-protos.h (aarch64_symbol_context): Ren

Re: [PATCH] Fix LTO early-debug ICE wrt abstract origin node streaming

2015-08-28 Thread Richard Biener
On Fri, 28 Aug 2015, Richard Biener wrote: > > The following fixes > > Program received signal SIGSEGV, Segmentation fault. > 0x00af8edd in lto_get_decl_name_mapping (decl_data=0x0, > name=0x768dcbd0 "bar") > at /space/rguenther/src/svn/trunk/gcc/lto-section-in.c:349 > 349

Re: [Patch] Add to the libgfortran/newlib bodge to "detect" ftruncate support in ARM/AArch64/SH

2015-08-28 Thread James Greenhalgh
On Tue, Aug 25, 2015 at 03:44:05PM +0100, FX wrote: > > 2015-08-25 James Greenhalgh > > > > * configure.ac: Auto-detect newlib function support unless we > > know there are issues when configuring for a host. > > * configure: Regenerate. > > Thanks for CC’ing the fortran list. > >

Remove redundant use of REG_CLASS_NAMES maros

2015-08-28 Thread Anatoliy Sokolov
Hi. This patch remove static reg_class_names array from print_translated_classes and print_unform_and_important_classes functions. Global reg_class_names array is used instead. Bootstrapped and reg-tested on x86_64-unknown-linux-gnu and powerpc64le-unknown-linux-gnu. OK for trunk? 2015-08-

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Alan Lawrence
Christophe Lyon wrote: I asked because I assumed that Alan saw it pass in his configuration. Bah. No - I now discover a problem in my C++ testsuite setup that was causing a large number of tests to not be executed. I see the problem too now, investigating --Alan

Remove redundant test for global_regs

2015-08-28 Thread Anatoliy Sokolov
Hi. The fixed_reg_set contain all fixed and global registers. This patch change code "fixed_regs[r] || global_regs[r]" with "TEST_HARD_REG_BIT (fixed_reg_set, r)". Bootstrapped and reg-tested on x86_64-unknown-linux-gnu and powerpc64le-unknown-linux-gnu. OK for trunk? 2015-08-24 Anatoly Sok

[PATCH COMMITTED] MAINTAINERS (Write After Approval): Add myself.

2015-08-28 Thread David Sherwood
FYI. ChangeLog: 2015-08-28 David Sherwood * MAINTAINERS: Add myself.

Re: C++ delayed folding branch review

2015-08-28 Thread Kai Tietz
2015-08-28 9:19 GMT+02:00 Kai Tietz : > 2015-08-28 4:11 GMT+02:00 Jason Merrill : >> On 08/27/2015 02:12 PM, Kai Tietz wrote: >>> >>> + else if (TREE_CODE (type) == VECTOR_TYPE) >>> +{ >>> + if (TREE_CODE (arg1) == VECTOR_CST >>> + && code == NOP_EXPR >>> + && TYPE_VECTOR_

Re: Move remaining flag_unsafe_math_optimizations using simplify and match

2015-08-28 Thread Richard Biener
On Fri, Aug 28, 2015 at 7:33 AM, Marc Glisse wrote: > On Thu, 27 Aug 2015, Andreas Schwab wrote: > >> "Hurugalawadi, Naveen" writes: >> >>> * fold-const.c (fold_binary_loc) : Move Optimize >>> root(x)*root(y) as root(x*y) to match.pd. >>> Move Optimize expN(x)*expN(y) as e

[PATCH] Fix c++/67371 (issues with throw in constexpr)

2015-08-28 Thread Markus Trippelsdorf
As PR67371 shows gcc currently rejects all throw statements in constant-expressions, even when they are never executed. Fix by simply allowing THROW_EXPR in potential_constant_expression_1. One drawback is that we now accept some ill formed cases, but they fall under the "no diagnostic required"

Re: Remove redundant use of REG_CLASS_NAMES maros

2015-08-28 Thread Vladimir Makarov
On 08/28/2015 06:07 AM, Anatoliy Sokolov wrote: Hi. This patch remove static reg_class_names array from print_translated_classes and print_unform_and_important_classes functions. Global reg_class_names array is used instead. Bootstrapped and reg-tested on x86_64-unknown-linux-gnu and powerpc

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Richard Biener
executed. I see the problem too now, > investigating Btw, your patch broke Ada: +===GNAT BUG DETECTED==+ | 6.0.0 20150828 (experimental) (x86_64-pc-linux-gnu) GCC error: | | in completely_scalarize, at tree-sra.c:996

RE: [PATCH] MIPS: Add the lo register to the clobber list in the madd-8.c and msub-8.c testcases

2015-08-28 Thread Andrew Bennett
> Yes, this looks OK. Committed as SVN 227299. Regards, Andrew

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Alan Lawrence
problem too now, investigating Btw, your patch broke Ada: +===GNAT BUG DETECTED==+ | 6.0.0 20150828 (experimental) (x86_64-pc-linux-gnu) GCC error: | | in completely_scalarize, at tree-sra.c:996

[PATCH] Tidy tree-ssa-dom.c: Use dom_valueize more.

2015-08-28 Thread Alan Lawrence
The code in the dom_valueize function is duplicated a number of times; so, call the function. Also remove a comment in lookup_avail_expr re const_and_copies, describing one of said duplicates, that looks like it was superceded in r87787. Bootstrapped + check-gcc on x86-none-linux-gnu. gcc/Change

[gomp4.1] document more structures in libgomp.h

2015-08-28 Thread Aldy Hernandez
More boring patches in an effort to make sense of it all. Does this match your understanding? If it does, OK for branch? commit 3b7ffc815a8e163391c913196160354348348945 Author: Aldy Hernandez Date: Fri Aug 28 07:19:51 2015 -0700 * libgomp.h: Document gomp_task_depend_entry, gomp_tas

Re: [gomp4.1] document more structures in libgomp.h

2015-08-28 Thread Jakub Jelinek
On Fri, Aug 28, 2015 at 07:21:46AM -0700, Aldy Hernandez wrote: > * libgomp.h: Document gomp_task_depend_entry, gomp_task, > gomp_taskgroup. > *task.c (gomp_task_run_pre): Add comments. Missing space before task.c. > --- a/libgomp/libgomp.h > +++ b/libgomp/libgomp.h > @@ -279,9

[HSA] Add support for unordered comparions codes

2015-08-28 Thread Martin Jambor
Hi, I've committed the following simple patch to the branch to add missing support for unordered compariosn codes. Martin 2015-08-28 Martin Jambor * hsa-gen.c (gen_hsa_cmp_insn_from_gimple): Add unordered comparison codes. (gen_hsa_insns_for_operation_assignment): Li

[hsa] Create a special omp statement for gpu kernels

2015-08-28 Thread Martin Jambor
Hi, the patch I below that I have committed to the branch adds a special gimple statement code in which GPU statements can survive between lowering and expansion and which makes sure that even statements which pertain to the kernel loop but lowering puts them in front of the loop are picked up by

[PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-08-28 Thread Charles Baylis
Hi This patch is an attempt to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67280. I have written up an analysis of the bug there. When cgraph_node::create_wrapper() updates the callgraph for the new function, it sets the can_throw_external flag to false, even when wrapping a function which c

Re: [PATCH 2/5] completely_scalarize arrays as well as records

2015-08-28 Thread Alan Lawrence
Alan Lawrence wrote: Right. I think VLA's are the problem with pr64312.C also. I'm testing a fix (that declares arrays with any of these properties as unscalarizable). Monday is a bank holiday in UK and so I expect to get back to you on Tuesday. --Alan In the meantime I've reverted the pat

Re: [Patch] Add to the libgfortran/newlib bodge to "detect" ftruncate support in ARM/AArch64/SH

2015-08-28 Thread James Greenhalgh
On Fri, Aug 28, 2015 at 10:40:31AM +0100, James Greenhalgh wrote: > On Tue, Aug 25, 2015 at 03:44:05PM +0100, FX wrote: > > > 2015-08-25 James Greenhalgh > > > > > > * configure.ac: Auto-detect newlib function support unless we > > > know there are issues when configuring for a host. > > >

Re: [patch] fix bootstrap if no ISL is available.

2015-08-28 Thread Sebastian Pop
On Thu, Aug 27, 2015 at 3:19 PM, Andreas Tobler wrote: > Hi all, > > I think this is obvious? Yes. Sorry for missing testing without ISL. I have committed a similar patch just after I got pinged that my patch broke builds without ISL. Sebastian > > Thanks, > Andreas > > 2015-08-27 Andreas Tobl

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

2015-08-28 Thread Andrew Bennett
> I had some comments on this that I hadn't got round to posting. The fix in > this patch is not general enough as the missing header problem comes in > two (related) forms: > > 1) Using the new MTI and IMG sysroot layout we can end up with GCC looking >for headers in a sysroot that simply doe

[PATCH] PR bootstrap/67385: READELF_FOR_TARGET isn't used in gcc configure

2015-08-28 Thread H.J. Lu
Similar to as, ld, nm and objdump, gcc configure should check $READELF_FOR_TARGET for readelf. OK for trunk? H.J. --- PR bootstrap/67385 * configure.ac (gcc_cv_readelf): Check $READELF_FOR_TARGET. * configure: Regenerated. --- gcc/configure| 6 -- gcc/configure.ac

Re: [gomp4.1] document more structures in libgomp.h

2015-08-28 Thread Aldy Hernandez
On 08/28/2015 07:31 AM, Jakub Jelinek wrote: On Fri, Aug 28, 2015 at 07:21:46AM -0700, Aldy Hernandez wrote: * libgomp.h: Document gomp_task_depend_entry, gomp_task, gomp_taskgroup. *task.c (gomp_task_run_pre): Add comments. Missing space before task.c. --- a/libgomp/

[gomp4] check for compatible parallelism with acc routines

2015-08-28 Thread Cesar Philippidis
This patch teaches omplower to report any incompatible parallelism when using routines. I also fixed a minor bug involving reductions inside routines and removed a dead variable inside execute_oacc_transform which caused a build warning. There are two scenarios involving acc routines that need che

Re: [gomp4.1] document more structures in libgomp.h

2015-08-28 Thread Jakub Jelinek
On Fri, Aug 28, 2015 at 08:53:44AM -0700, Aldy Hernandez wrote: > @@ -311,22 +313,35 @@ struct gomp_taskwait > > struct gomp_task > { > + /* Parent circular list. See children description below. */ >struct gomp_task *parent; > + /* Circular list representing the children of this task. >

Re: [Patch, libstdc++] Add specific error message into exceptions

2015-08-28 Thread Jonathan Wakely
On 27/08/15 22:18 -0700, Tim Shen wrote: Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit 53c1caff442e97a18652ec8b1d984341168fd98d Author: Tim Shen Date: Thu Aug 27 21:42:40 2015 -0700 PR libstdc++/67361 * include/bits/regex_error.h: Add __throw_regex_error t

[PATCH][lto/66752] Fix missed FSM jump thread

2015-08-28 Thread Jeff Law
It's taken a month to get back to this, but it's time to re-install this patch onto the trunk with a minor update. This patch gives the FSM jump threading code the opportunity to find known values when we have a condition like (x != 0). Previously it just allowed a naked SSA_NAME (which is

[PATCH, libbacktrace] SPU does not support fcntl

2015-08-28 Thread Ulrich Weigand
Hello, one more compatibility problem showed up with libbacktrace on SPU: we do not have the fcntl routine. This does not cause any failure on building the library, but when linking the final executable. Fixed by disabling have_fcntl for SPU (just as is already done for mingw). Tested on x86_64

[PATCH, libbacktrace] SPU does not support __sync or __atomic

2015-08-28 Thread Ulrich Weigand
Hello, this is the (hopefully) last compatibility problem with libbacktrace on SPU: we do not have either the __sync or the __atomic routines (since the SPU is a fundamentally single-threaded target). There are configure.ac checks for both of these functions, but for cross-compilation, the code a

[PATCH][GCC] Algorithmic optimization in match and simplify

2015-08-28 Thread Andre Vieira
Two new algorithmic optimisations: 1.((X op0 C0) op1 C1) op2 C2) with op0 = {&, >>, <<}, op1 = {|,^}, op2 = {|,^} and op1 != op2 zero_mask has 1's for all bits that are sure to be 0 in (X op0 C0) and 0's otherwise. if (op1 == '^') C1 &= ~C2 (Only changed if actually emitted)

Re: Openacc launch API

2015-08-28 Thread Nathan Sidwell
On 08/25/15 09:29, Nathan Sidwell wrote: I did rename the GOACC_parallel entry point to GOACC_parallel_keyed and provide a forwarding function. However, as the mkoffload data is incompatible, this is probably overkill. I've had to increment the (just committed) version number to detect the cha

Re: [gomp4] check for compatible parallelism with acc routines

2015-08-28 Thread Nathan Sidwell
On 08/28/15 11:56, Cesar Philippidis wrote: Right now, gcc is permitting both of these loops. I.e., only the seq loop itself is executing in a non-partitioned mode. Julian inquired about this in the openacc technical list a while ago, but I don't think he got a response. This patch has been app

Re: Openacc launch API

2015-08-28 Thread Jakub Jelinek
On Fri, Aug 28, 2015 at 01:29:51PM -0400, Nathan Sidwell wrote: > On 08/25/15 09:29, Nathan Sidwell wrote: > > >I did rename the GOACC_parallel entry point to GOACC_parallel_keyed and > >provide > >a forwarding function. However, as the mkoffload data is incompatible, this > >is > >probably ove

Re: [PATCH][GCC] Algorithmic optimization in match and simplify

2015-08-28 Thread Marc Glisse
(not a review, I haven't even read the whole patch) On Fri, 28 Aug 2015, Andre Vieira wrote: 2015-08-03 Andre Vieira * match.pd: Added new patterns: ((X {&,<<,>>} C0) {|,^} C1) {^,|} C2) (X {|,^,&} C0) {<<,>>} C1 -> (X {<<,>>} C1) {|,^,&} (C0 {<<,>>} C1) +(for op0 (rshift rshift ls

[gomp4.1] WIP: Structure element mapping support

2015-08-28 Thread Jakub Jelinek
Hi! Here is my current WIP on further structure element mapping support (so, structure element {pointer,reference to pointer,reference to array} based array sections, start of C++ support (still need to add tests for template instantiation and verify it works properly)). I have still pending quest

Re: [Patch, libstdc++] Add specific error message into exceptions

2015-08-28 Thread Tim Shen
On Fri, Aug 28, 2015 at 8:59 AM, Jonathan Wakely wrote: > There seems to be no need to construct a std::string here, just pass a > const char* (see below). To be honest, I wasn't considering performance for a bit, since exceptions are already considered slow by me :P. But yes, we can do less allo

Re: Openacc launch API

2015-08-28 Thread Nathan Sidwell
On 08/28/15 13:36, Jakub Jelinek wrote: On Fri, Aug 28, 2015 at 01:29:51PM -0400, Nathan Sidwell wrote: On 08/25/15 09:29, Nathan Sidwell wrote: I did rename the GOACC_parallel entry point to GOACC_parallel_keyed and provide a forwarding function. However, as the mkoffload data is incompatibl

[wwwdocs] Adjust three links to gccupc.org

2015-08-28 Thread Gerald Pfeifer
...which got broken over time. Applied. Gerald Index: projects/gupc.html === RCS file: /cvs/gcc/wwwdocs/htdocs/projects/gupc.html,v retrieving revision 1.8 diff -u -r1.8 gupc.html --- projects/gupc.html 29 Jun 2014 11:31:33 -

jit bit missing?

2015-08-28 Thread Mike Stump
These seem to be missing? I stenciled this up by copy and pasting… I did try and run the test suite, but you didn’t add a -L$(objdir) to the flags to pick up the library that was built. You incorrectly test the installed library, which has no relation to the library that should be tested. I’v

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

2015-08-28 Thread Martin Sebor
The second question is about your suggestion to consolidate the code into mark_rvalue_use. The problem I'm running into there is that mark_rvalue_use is called for calls to builtins as well as for other uses and doesn't have enough context to tell one from the other. Ah, true. But special-casin

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

2015-08-28 Thread Joseph Myers
On Fri, 28 Aug 2015, Martin Sebor wrote: > I ran into one regression in the gcc.dg/lto/pr54702_1.c test. > The file takes the address of malloc without declaring it, and > after calling it first. The code is invalid but GCC compiles it > due to a bug. I raised it in c/67386 -- missing diagnostic o

[fortran,committed] Emit direct calls to malloc() and free()

2015-08-28 Thread FX
For the MALLOC and FREE Cray pointer-related intrinsics, we used to emit calls to _gfortran_malloc and _gfortran_free, which would in turn call the libc routines. The attached patch makes us directly emit the calls to the BUILT_IN_MALLOC and BUILT_IN_FREE. Committed as revision 227311 after reg

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

2015-08-28 Thread Martin Sebor
On 08/28/2015 02:09 PM, Joseph Myers wrote: On Fri, 28 Aug 2015, Martin Sebor wrote: I ran into one regression in the gcc.dg/lto/pr54702_1.c test. The file takes the address of malloc without declaring it, and after calling it first. The code is invalid but GCC compiles it due to a bug. I raise

Re: [PATCH, libbacktrace] SPU does not support __sync or __atomic

2015-08-28 Thread Ian Lance Taylor
On Fri, Aug 28, 2015 at 9:54 AM, Ulrich Weigand wrote: > > this is the (hopefully) last compatibility problem with libbacktrace on SPU: > we do not have either the __sync or the __atomic routines (since the SPU > is a fundamentally single-threaded target). I guess I don't understand. These are G

Re: [PATCH, libbacktrace] SPU does not support fcntl

2015-08-28 Thread Ian Lance Taylor
On Fri, Aug 28, 2015 at 9:53 AM, Ulrich Weigand wrote: > > * configure.ac: For spu-*-* targets, set have_fcntl to no. > * configure: Regenerate. This is OK. Thanks. Ian

Re: [PATCH] Fix c++/67371 (issues with throw in constexpr)

2015-08-28 Thread Jason Merrill
On 08/28/2015 08:00 AM, Markus Trippelsdorf wrote: As PR67371 shows gcc currently rejects all throw statements in constant-expressions, even when they are never executed. Fix by simply allowing THROW_EXPR in potential_constant_expression_1. One drawback is that we now accept some ill formed cas

Re: [Patch, libstdc++] Add specific error message into exceptions

2015-08-28 Thread Tim Shen
On Fri, Aug 28, 2015 at 11:23 AM, Tim Shen wrote: > So is it good to have an owned raw pointer stored in runtime_error, > pointing to a heap allocated char chunk, which will be deallocated in > regex_error's dtor? I just put a string member into regex_error, completely ignoring the storage in std

Re: [c++-delayed-folding] fold_simple

2015-08-28 Thread Jason Merrill
On 08/27/2015 05:21 AM, Kai Tietz wrote: 2015-08-27 4:57 GMT+02:00 Jason Merrill : Why does fold_simple fold so many patterns? I thought we wanted something that would just fold conversions and negations of constant values. Yes, initial variant was handling much less patterns. But actually w

[patch, libgfortran] PR67367 Program crashes on READ

2015-08-28 Thread Jerry DeLisle
I found that in read_buf where raw_read is called, no checks for errors were being made, raw_read returns the number of bytes read or an error code. In the test case, an error occurs and we proceeded to use the resulting error code as if it were the number of bytes read. The attached patch fixes