Re: [PATCH][RFC] Move IVOPTs closer to RTL expansion

2013-09-12 Thread Richard Biener
On Wed, 11 Sep 2013, Pat Haugen wrote: > On 09/04/2013 04:20 AM, Richard Biener wrote: > > Any help with benchmarking this on targets other than x86_64 > > is appreciated (I'll re-do x86_64). > > > I ran CPU2000 and CPU2006 on PowerPC comparing the patch. CPU2000 had 3 > benchmarks degrade in the

Re: [patch 1/2] tree-flow.h restructuring

2013-09-12 Thread Richard Biener
On Wed, Sep 11, 2013 at 8:10 PM, Andrew MacLeod wrote: > OK, here's the patch... virtually the same except I moved > useless_type_conversion_p() and types_compatible_p() to gimple.[ch] instead > of tree.[ch]. > > Upon closer examination, the comments for those functions are fine, they > say that

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-12 Thread Richard Biener
On Wed, Sep 11, 2013 at 8:39 PM, Richard Sandiford wrote: > Graham Stott writes: >> Hi Richard, >> >> There is some minor testsuite fallout with these patches on MIPS a >> couple of tests (see below)ICE ingen_int_mode () in both these ICE the >> mode is CCmode. > > Hmm, interesting. I suppose ge

Re: [PATCH] [vectorizer] Fixing a bug in tree-vect-patterns.c in GCC vectorizer.

2013-09-12 Thread Richard Biener
On Thu, Sep 12, 2013 at 3:16 AM, Cong Hou wrote: > Hi > > There is a bug in the function vect_recog_dot_prod_pattern() in > tree-vect-patterns.c. This function checks if a loop is of dot > production pattern. Specifically, according to the comment of this > function: > > /* > Try to find the foll

Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)

2013-09-12 Thread Andrew Haley
On 09/12/2013 03:11 AM, Alan Modra wrote: > We have precedent for compiling libffi based on gcc preprocessor > defines, eg. __NO_FPRS__, so here's a way of making upstream libffi > compatible with the various versions of gcc out there. I've taken the > condition under which we align aggregates fro

[PATCH] Further cleanup loop-distribution

2013-09-12 Thread Richard Biener
The following patch makes us rely on a correct RDG for the partition creation, removing all code that adds further dependencies. Most of it was necessary because we threw in a cost model via 'remaining_stmts' early, limiting the DFS walks on the RDG that look up dependencies. The patch also beef

Re: [PATCH] [x86] Incorrect naming of FMA Builtins in documentation.

2013-09-12 Thread Uros Bizjak
On Wed, Sep 11, 2013 at 11:48 PM, Cameron McInally wrote: > Hey guys, > > It appears that there are errors in the x86 FMA Builtins > documentation. The FMA instruction names should be prefixed with a > 'v'. Also the FMA instructions operate on XMM/YMM registers, not MMX > registers. > > Please fin

back to the Ada target vs target_alias issue wrt target pairs

2013-09-12 Thread Olivier Hainque
Hello, This is a followup on Thomas' proposal at http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01617.html re the use of $target_alias vs $target derivatives in the GNAT Makefiles to select target specific pairs for runtime and tools. As part of this dicsussion, we: - agreed that moving back t

Add implicit C linkage for win32-specific entry points

2013-09-12 Thread Jacek Caban
Hi, This is a resend after I'm done with assignment paper work. gcc/c-family/ChangeLog: c-target.def: New hook gcc/ChangeLog: config/config.gcc: Use new winnt-c.c target hooks config/t-winnt: New file config/winnt-c.c: New file doc/tm.texi.in: Docu

RE: [PING][PATCH ARM]Extend thumb1_reorg to save more comparison instructions

2013-09-12 Thread bin.cheng
Ping ^ 3 -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of bin.cheng Sent: Friday, August 23, 2013 3:23 PM To: gcc-patches@gcc.gnu.org Cc: Richard Earnshaw Subject: RE: [PING][PATCH ARM]Extend thumb1_reorg to save more comparison in

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-12 Thread Alexander Monakov
On Wed, 11 Sep 2013, Wei Mi wrote: > I agree with you that explicit handling in sched-deps.c for this > feature looks not good. So I move it to sched_init (Instead of > ix86_sched_init_global because ix86_sched_init_global is used to > install scheduling hooks), and then it is possible for other

Re: [gomp4] C++ OpenMP user defined reductions (take 2)

2013-09-12 Thread Jakub Jelinek
On Thu, Sep 12, 2013 at 10:55:44AM +0200, Jakub Jelinek wrote: > What is still missing is accessibility checking, in the attached udr5.C > I'd assume we should error on the dg-error marked lines (because one of the > UDRs is protected and another one is private). Not sure what I'm doing > wrong th

Re: Add implicit C linkage for win32-specific entry points

2013-09-12 Thread Kai Tietz
Hi Jacek, 2013/9/12 Jacek Caban : > Hi, > > This is a resend after I'm done with assignment paper work. > > gcc/c-family/ChangeLog: > c-target.def: New hook > > gcc/ChangeLog: > config/config.gcc: Use new winnt-c.c target hooks > config/t-winnt: New file > c

Re: Add implicit C linkage for win32-specific entry points

2013-09-12 Thread Jacek Caban
On 09/12/13 12:20, Kai Tietz wrote: > Hi Jacek, > > 2013/9/12 Jacek Caban : >> Hi, >> >> This is a resend after I'm done with assignment paper work. >> >> gcc/c-family/ChangeLog: >> c-target.def: New hook >> >> gcc/ChangeLog: >> config/config.gcc: Use new winnt-c.c target ho

[PATCH] Fix PR58396

2013-09-12 Thread Richard Biener
This fixes PR58396 and also fixes some memleaks. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-09-12 Richard Biener PR tree-optimization/58396 * tree-loop-distribution.c (create_rdg_edges): Free unused DDRs. (build_rdg): Take a loop-nest

Re: [x86,PATCH] Simple performance tuning for SLM.

2013-09-12 Thread Kirill Yukhin
Hello, On 10 Sep 19:32, Uros Bizjak wrote: > On Tue, Sep 10, 2013 at 4:56 PM, Yuri Rumyantsev wrote: > > Is it OK for trunk? > OK. Checked into main trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00383.html -- Thanks, K

[libvtv] Remove Android from supported targets

2013-09-12 Thread Alexander Ivchenko
Hi, We currently have build problem in Android ndk for trunk: toolchain/gcc/gcc-4.9/libvtv/vtv_rts.cc:124:22: fatal error: execinfo.h: No such file or directory #include ^ compilation terminated. toolchain/gcc/gcc-4.9/libvtv/vtv_utils.cc:36:22: fatal error: execinfo.h: No

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-12 Thread Graham Stott
Hi Richard, After applying just the cse.c part of the patch the two testcases no longer ICE and pass with regressions in C or C++ testsuites. Not sure if we really need the other part of the patch to gen_int_mode (). Graham - Original Message - From: Richard Sandiford To: Graham St

[PATCH, PR 58389] Do not attempt to use reference descriptions associated with removed edges

2013-09-12 Thread Martin Jambor
Hi, PR 58389 is another case where the reference removal code, which is now also called from the edge removal hook, ICEs when inlined edges are not removed in topological order, which ins not the case when we are removing unreachable nodes. I'd like to fix it by the patch below. When removing an

Re: [C++ Patch] Improve finish_pseudo_destructor_expr location

2013-09-12 Thread Jason Merrill
OK. Jason

[PING][PATCH] ICE with combination of -fopenmp and -femit-struct-debug-reduced/baseonly‏

2013-09-12 Thread Evgeny Gavrin
I’ve attached fix for this issue: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57737 There are fix, two tests and change log message. Is it ok? Cary, can you commit it for me? Ping this patch, http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00053.html - Thanks,  Evgeny. ice-omp-fesdr.patch Desc

[PATCH][ubsan] Add VLA bound instrumentation

2013-09-12 Thread Marek Polacek
This patch adds the instrumentation of VLA bounds. Basically, it just checks that the size of a VLA is positive. I.e., We also issue an error if the size of the VLA is 0. It catches e.g. int i = 1; int a[i][i - 2]; It is pretty straightforward, but I had issues in the C++ FE, mainly choosing

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-09-12 Thread Marek Polacek
On Thu, Sep 12, 2013 at 02:26:55PM +0200, Marek Polacek wrote: > the size of a VLA is positive. I.e., We also issue an error if the size of > the s/We also/we/

Re: [PATCH, PR 58389] Do not attempt to use reference descriptions associated with removed edges

2013-09-12 Thread Jan Hubicka
> Hi, > > PR 58389 is another case where the reference removal code, which is > now also called from the edge removal hook, ICEs when inlined edges > are not removed in topological order, which ins not the case when we > are removing unreachable nodes. > > I'd like to fix it by the patch below.

Re: Add implicit C linkage for win32-specific entry points

2013-09-12 Thread Jason Merrill
On 09/12/2013 06:26 AM, Jacek Caban wrote: +@deftypefn {C Target Hook} bool TARGET_CXX_IMPLICIT_EXTERN_C (const char*@var{}) +Define this hook to add target-specific C++ implicit extern C functions. An example of such function is WinMain on Win32 targets. +@end deftypefn Let's clarify this a

Re: Add implicit C linkage for win32-specific entry points

2013-09-12 Thread Jacek Caban
On 09/12/13 14:38, Jason Merrill wrote: > On 09/12/2013 06:26 AM, Jacek Caban wrote: >> +@deftypefn {C Target Hook} bool TARGET_CXX_IMPLICIT_EXTERN_C (const >> char*@var{}) >> +Define this hook to add target-specific C++ implicit extern C >> functions. An example of such function is WinMain on Win3

Ask for approval to backport a trunk LTO fix to 4.7 branch

2013-09-12 Thread Terry Guo
Hi there, The FSF 4.7 branch still has bug http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54598. May I backport trunk fix to 4.7 branch? Thanks and best regards, Terry

Re: [PATCH 6/6] Andes nds32: wwwdoc for nds32 target.

2013-09-12 Thread Chung-Ju Wu
2013/9/10 Gerald Pfeifer : > On Mon, 9 Sep 2013, Chung-Ju Wu wrote: >> Is it OK to apply on the cvs wwwdoc trunk? :) > > I would perhaps say: > > "A new nds32 port supports the 32-bit architecture from Andes > Technology Corporation" > > or similar. > > If you prefer the current wording, that n

Re: Ask for approval to backport a trunk LTO fix to 4.7 branch

2013-09-12 Thread Richard Biener
On Thu, 12 Sep 2013, Terry Guo wrote: > Hi there, > > The FSF 4.7 branch still has bug > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54598. May I backport trunk fix > to 4.7 branch? Sure. Richard.

[PATCH] Fix PR58402

2013-09-12 Thread Richard Biener
I see no compelling reason to not run pass_late_warn_uninitialized really late. Thus, bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-09-12 Richard Biener PR tree-optimization/58402 * passes.def: Move pass_late_warn_uninitialized later. Index: gc

[PATCH] Fix PR58404

2013-09-12 Thread Richard Biener
Jakub noticed that we don't forward &a[i] into a dereference of said pointer when the resulting struct is partially accessed. I suppose I just didn't implement that initially because I was lazy. It turns out to be comparatively easy to do though. Bootstrapped and tested on x86_64-unknown-linux-

[PATCH, SH4] Fix PR58314 (unsatisfied constraints)

2013-09-12 Thread Christian Bruel
The attached patch fixes an ice while building the linux kernel. Reduced in the included testcase. The problem is that we are generating a movhi_reg_reg insn that accepts only registers as operands. Spilling a pseudo on the stack results in an invalid memory load/store constraints. The attached p

[patch] Cleanup tree-ssa-uninit.c exports

2013-09-12 Thread Andrew MacLeod
It turns out that ssa_undefined_value_p() is also used in tree-complex.c and tree-ssa-pre.c. doh. That routine is *almost* pass independent... only the last line uses 'possibly_undefined_names'. Since the late warning pass initializes and then clears that pointer_set when done, those other

Re: [Patch] Support assertions and greedy/ungreedy matching in regex

2013-09-12 Thread Paolo Carlini
Hi, On 09/12/2013 03:25 PM, Tim Shen wrote: This patch implement the (expecting) last two features in regex. Work is easier after this ;) Great. A quick-quick comment: if these are the last two features, why we can't un-xfail the testcase which we added latety? Also, a grep revealed a couple m

Re: [PATCH 6/6] Andes nds32: wwwdoc for nds32 target.

2013-09-12 Thread Gerald Pfeifer
On Thu, 12 Sep 2013, Chung-Ju Wu wrote: > I'd happy to propose a new item at "News" block > on gcc main page as follows: This looks fine, thanks! > Once nds32 port implementation is approved and committed, > I will fill up the date in 2013-MM-DD and formally post a > patch mail on mailing list.

Re: [patch] Cleanup tree-ssa-uninit.c exports

2013-09-12 Thread Richard Biener
On Thu, Sep 12, 2013 at 3:53 PM, Andrew MacLeod wrote: > It turns out that ssa_undefined_value_p() is also used in tree-complex.c and > tree-ssa-pre.c. doh. > > That routine is *almost* pass independent... only the last line uses > 'possibly_undefined_names'. Since the late warning pass initial

Re: [C++ Patch] Improve finish_pseudo_destructor_expr location

2013-09-12 Thread Richard Biener
On Wed, Sep 11, 2013 at 9:28 PM, Paolo Carlini wrote: > Hi, > > when yesterday I analyzed a bit c++/58363 and eventually I committed a > pretty printing fix I noticed that the column was wrong for the pseudo > destructor expression m.~f, pointing at the end. A fix turns out to be > rather simple,

[gomp4, trunk] Fix up simd loop handling (PR tree-optimization/58392)

2013-09-12 Thread Jakub Jelinek
Hi! This patch fixes PR58392 and some related issues I've discovered. move_sese_region_to_fn wasn't remapping loop->simduid VAR_DECL, and wasn't setting dest_cfun->has_{simduid,force_vect}_loops when needed, the inliner wasn't copying/remapping simduid nor force_vect (just conservatively setting c

Re: [C++ Patch] Improve finish_pseudo_destructor_expr location

2013-09-12 Thread Paolo Carlini
On 09/12/2013 04:12 PM, Richard Biener wrote: On Wed, Sep 11, 2013 at 9:28 PM, Paolo Carlini wrote: Hi, when yesterday I analyzed a bit c++/58363 and eventually I committed a pretty printing fix I noticed that the column was wrong for the pseudo destructor expression m.~f, pointing at the end.

[RFC] Unifying logic of interprocedural/intraprocedural and ipa-devirt type handling

2013-09-12 Thread Jan Hubicka
Hi, this is a streghtening of current ipa-devirt type walking I was working on in past weeks. My initial implementation of inheritance tree analysis simply take OTR_TYPE that is the type of class of the polymorphic call and OTR_TOKEN that is an index of virtual method in the vtable. It always wal

Re: [Patch] Support assertions and greedy/ungreedy matching in regex

2013-09-12 Thread Paolo Carlini
Hi, On 09/12/2013 04:51 PM, Tim Shen wrote: On Thu, Sep 12, 2013 at 9:57 AM, Paolo Carlini wrote: Great. A quick-quick comment: if these are the last two features, why we can't un-xfail the testcase which we added latety? Also, a grep revealed a couple more xfails. Can you clarify? I say `fea

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-12 Thread Joseph S. Myers
On Wed, 11 Sep 2013, Brooks Moses wrote: > Ping^3? > > Joseph, I'd been cc'ing you on this because it's driver-related and I > didn't find a more-obvious reviewer. Is there someone else I should > be asking to review it? Alternately, is this a change that should be > discussed on gcc@ before ha

Re: [Patch] Support assertions and greedy/ungreedy matching in regex

2013-09-12 Thread Paolo Carlini
.. please fix the overlong lines, I spotted quite a few. Paolo.

[v3] libstdc++/58403

2013-09-12 Thread Paolo Carlini
Hi, see the audit trail for details. Tested x86_64-linux, committed to mainline. Thanks, Paolo. 2013-09-12 Paolo Carlini PR libstdc++/58403 * include/bits/stl_iterator.h (__normal_iterator<>::operator[], operator+=, operator+, operator-=, ope

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-09-12 Thread Marek Polacek
On Thu, Sep 12, 2013 at 04:05:48PM +, Joseph S. Myers wrote: > On Thu, 12 Sep 2013, Joseph S. Myers wrote: > > > (Actually, I believe sizes (in bytes) greater than target PTRDIFF_MAX, not > > just SIZE_MAX, should be caught, because pointer subtraction cannot work > > reliably with larger ob

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-09-12 Thread Marek Polacek
On Thu, Sep 12, 2013 at 03:52:18PM +, Joseph S. Myers wrote: > On Thu, 12 Sep 2013, Marek Polacek wrote: > > > This patch adds the instrumentation of VLA bounds. Basically, it just > > checks that the size of a VLA is positive. I.e., We also issue an error > > if the size of the VLA is 0.

Re: [PATCH] PR tree-optimization/58380

2013-09-12 Thread Jeff Law
On 09/12/2013 09:48 AM, Paolo Carlini wrote: On 09/11/2013 09:31 PM, Jeff Law wrote: -w is the right thing to do, warnings or the lack thereof aren't important for what that test is detecting. I'll fix it up momentarily. I went ahead and added the "-w" myself. I hope you don't mind, otherwise,

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-12 Thread Richard Sandiford
Richard Biener writes: > On Wed, Sep 11, 2013 at 8:39 PM, Richard Sandiford > wrote: >> Graham Stott writes: >>> Hi Richard, >>> >>> There is some minor testsuite fallout with these patches on MIPS a >>> couple of tests (see below)ICE ingen_int_mode () in both these ICE the >>> mode is CCmode. >

Re: cfgexpand.c patch for msp430-elf

2013-09-12 Thread DJ Delorie
I finally got around to checking this in, with your suggested change. Thanks!

Re: [PATCH] PR tree-optimization/58380

2013-09-12 Thread Paolo Carlini
On 09/11/2013 09:31 PM, Jeff Law wrote: -w is the right thing to do, warnings or the lack thereof aren't important for what that test is detecting. I'll fix it up momentarily. I went ahead and added the "-w" myself. I hope you don't mind, otherwise, just let me know and I will revert/commit som

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-12 Thread Wei Mi
> Your new implementation is not efficient: when looping over BBs, you need to > look only at the last insn of each basic block. > Thanks, fixed. New patch attached. patch Description: Binary data

patch to fix PR58335

2013-09-12 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58335 It required to implement a new approach for elimination updates for insn frame_pointer = hard_frame_pointer + offset. The previous implementation used parsing insns generated for offset elimination for given insn. I

Re: [PATCH V4 2/2] Support using 'auto' in a function parameter list to introduce an implicit template parameter.

2013-09-12 Thread Adam Butcher
On 11.09.2013 17:02, Jason Merrill wrote: On 09/09/2013 10:19 PM, Adam Butcher wrote: + if (current_class_type && LAMBDA_TYPE_P (current_class_type)) + { + if (cxx_dialect < cxx1y) + pedwarn (location_of (type), 0, +"use of % in

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-12 Thread DJ Delorie
The patch is OK with me from a build machinery point of view.

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv

2013-09-12 Thread Caroline Tice
On Wed, Sep 11, 2013 at 12:35 PM, H.J. Lu wrote: > On Wed, Sep 11, 2013 at 12:27 PM, Caroline Tice wrote: >> >>> 2. Why does libvtv/configure.ac have >>> >>> echo 'MULTISUBDIR =' >> $ac_file >>> ml_norecursion=yes >>> . ${multi_basedir}/config-ml.in >>> >>> when AM_ENABLE_MULTILIB is

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Xinliang David Li
On Thu, Sep 12, 2013 at 1:06 PM, Teresa Johnson wrote: > After porting r198033 from google/4_7 to google/4_8 a test case failed > with an assert when trying to take the strlen of profile_data_prefix. > > In most cases this is either set from the directory specified to > -fprofile-generate=, or to

RE: [PATCH, PR 57748] Check for out of bounds access

2013-09-12 Thread Bernd Edlinger
On Wed, 11 Sep 2013 15:43:53, Richard Biener wrote: > On Wed, Sep 11, 2013 at 3:41 PM, Bernd Edlinger > wrote: >> On Tue, 10 Sep 2013 21:32:29, Martin Jambor wrote: >>> The misalignp path was added by you during the 4.7 development to fix >>> PR 50444 which was indeed about expansion of a SRA gene

New GCC options for loop vectorization

2013-09-12 Thread Xinliang David Li
Currently -ftree-vectorize turns on both loop and slp vectorizations, but there is no simple way to turn on loop vectorization alone. The logic for default O3 setting is also complicated. In this patch, two new options are introduced: 1) -ftree-loop-vectorize This option is used to turn on loop

[Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Teresa Johnson
After porting r198033 from google/4_7 to google/4_8 a test case failed with an assert when trying to take the strlen of profile_data_prefix. In most cases this is either set from the directory specified to -fprofile-generate=, or to getpwd when a directory is not specified. However, the exception

[PATCH, committed] Support decl instantiation in function-local templates.

2013-09-12 Thread Adam Butcher
From: abutcher * pt.c (instantiate_decl): Save/restore cp_unevaluated_operand and c_inhibit_evaluation_warnings. Reset if instantiating within a function-local template. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@202538 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc

Re: [libvtv] Remove Android from supported targets

2013-09-12 Thread Caroline Tice
Yes, that patch is ok. -- Caroline Tice cmt...@google.com On Thu, Sep 12, 2013 at 3:56 AM, Alexander Ivchenko wrote: > Hi, > > We currently have build problem in Android ndk for trunk: > > toolchain/gcc/gcc-4.9/libvtv/vtv_rts.cc:124:22: fatal error: > execinfo.h: No such file or directory > #in

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Xinliang David Li
When absolute path is specified for the object file, no prefix will be prepended to the gcda path. If you record the cwd as in the _gcov_profile_prefix variable, at profile dump time, the prefix will be wrong -- as it is never used. David On Thu, Sep 12, 2013 at 2:07 PM, Teresa Johnson wrote: >

[PATCH, committed] Support using 'auto' in a function parameter list to introduce an implicit template parameter.

2013-09-12 Thread Adam Butcher
From: abutcher * cp-tree.h (type_uses_auto_or_concept): Declare. (is_auto_or_concept): Declare. * decl.c (grokdeclarator): Allow 'auto' parameters in lambdas with -std=gnu++1y or -std=c++1y or, as a GNU extension, in plain functions. * type-utils.h: New hea

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Teresa Johnson
On Thu, Sep 12, 2013 at 1:20 PM, Xinliang David Li wrote: > On Thu, Sep 12, 2013 at 1:06 PM, Teresa Johnson wrote: >> After porting r198033 from google/4_7 to google/4_8 a test case failed >> with an assert when trying to take the strlen of profile_data_prefix. >> >> In most cases this is either

[patch] Cleanup tree-ssa-ter.c exports

2013-09-12 Thread Andrew MacLeod
There are 2 parts of tre-ssa-ter.c to address. is_replaceable_p() is also used in expr.c, It has a flag to indicate where its being called from, and we do different checks for each one. There is a wrapper function stmt_is_replaceable_p() in tree-ssa-ter.c which hides the setting of the flag t

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-09-12 Thread Joseph S. Myers
On Thu, 12 Sep 2013, Joseph S. Myers wrote: > (Actually, I believe sizes (in bytes) greater than target PTRDIFF_MAX, not > just SIZE_MAX, should be caught, because pointer subtraction cannot work > reliably with larger objects. So it's not just when the size or > multiplication overflow size_t

[PATCH, committed] Support lambda templates.

2013-09-12 Thread Adam Butcher
From: abutcher * parser.c (cp_parser_lambda_declarator_opt): Accept template parameter list with std=c++1y or std=gnu++1y. (cp_parser_lambda_body): Don't call 'expand_or_defer_fn' for lambda call operator template to avoid adding template result to symbol table.

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-09-12 Thread Joseph S. Myers
On Thu, 12 Sep 2013, Marek Polacek wrote: > This patch adds the instrumentation of VLA bounds. Basically, it just > checks that the size of a VLA is positive. I.e., We also issue an error > if the size of the VLA is 0. It catches e.g. This is not an objection to this patch, but there are a f

Re: [PATCH V4 2/2] Support using 'auto' in a function parameter list to introduce an implicit template parameter.

2013-09-12 Thread Jason Merrill
Just the pedwarn, I think. Jason

Re: [PATCH ARM]Extend thumb1_reorg to save more comparison instructions

2013-09-12 Thread Richard Earnshaw
On 18/04/13 06:34, Bin Cheng wrote: > Hi, > Before thumb1_reorg, ARM backend uses peephole to save comparison > instructions when a flag setting move is found before branch instruction. > Since we are using thumb1_reog now, it can be extended to catch more > opportunities by searching flag setting

Re: [PATCH, SH4] Fix PR58314 (unsatisfied constraints)

2013-09-12 Thread Oleg Endo
On Thu, 2013-09-12 at 15:37 +0200, Christian Bruel wrote: > The attached patch fixes an ice while building the linux kernel. Reduced > in the included testcase. > > The problem is that we are generating a movhi_reg_reg insn that accepts > only registers as operands. Spilling a pseudo on the stack

Re: [PATCH, committed] Support lambda templates.

2013-09-12 Thread Dominique Dhumieres
> Adam Butcher wrote: > From: abutcher > * lambda.c (lambda_function): Return template result if call operator is > a template. > > I believe that that patch causes the following build failure of cp/lambda.c: > ... > PS: I am not positive since I use a patched tree and I haven't bisec

Re: [PATCH, committed] Support lambda templates.

2013-09-12 Thread Andrew MacLeod
On 09/12/2013 05:55 PM, Tobias Burnus wrote: Adam Butcher wrote: From: abutcher * lambda.c (lambda_function): Return template result if call operator is a template. I believe that that patch causes the following build failure of cp/lambda.c: In file included from ../../gcc/tree-c

[rl78] use ax to copy fp to sp

2013-09-12 Thread DJ Delorie
Devirtualizer used to do this for us. Committed. * config/rl78/rl78.c (rl78_expand_prologue): Use AX to copy between SP and FP. (rl78_expand_epilogue): Likewise. Index: config/rl78/rl78.c === --- config/rl78

Re: [PATCH, committed] Support lambda templates.

2013-09-12 Thread Andrew MacLeod
On 09/12/2013 06:41 PM, Andrew MacLeod wrote: On 09/12/2013 05:55 PM, Tobias Burnus wrote: Adam Butcher wrote: From: abutcher * lambda.c (lambda_function): Return template result if call operator is a template. I believe that that patch causes the following build failure of cp/lam

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-12 Thread Brooks Moses
On Thu, Sep 12, 2013 at 8:42 AM, Joseph S. Myers wrote: > On Wed, 11 Sep 2013, Brooks Moses wrote: >> Joseph, I'd been cc'ing you on this because it's driver-related and I >> didn't find a more-obvious reviewer. Is there someone else I should >> be asking to review it? Alternately, is this a cha

Re: [PATCH, committed] Support lambda templates.

2013-09-12 Thread Tobias Burnus
Adam Butcher wrote: From: abutcher * lambda.c (lambda_function): Return template result if call operator is a template. I believe that that patch causes the following build failure of cp/lambda.c: In file included from ../../gcc/tree-core.h:27:0, from ../../gc

Re: [Patch] Support assertions and greedy/ungreedy matching in regex

2013-09-12 Thread Tim Shen
On Thu, Sep 12, 2013 at 11:37 AM, Paolo Carlini wrote: > .. please fix the overlong lines, I spotted quite a few. Quite a few? I see only one line by casting: egrep '^\+.{80}' a.patch Even it's not 81. That'll be fixed before committing. Seriously, I think we need an AST-based formatter? Clang

Re: [PATCH, SH4] Fix PR58314 (unsatisfied constraints)

2013-09-12 Thread Kaz Kojima
Christian Bruel wrote: > The attached patch fixes an ice while building the linux kernel. Reduced > in the included testcase. > > The problem is that we are generating a movhi_reg_reg insn that accepts > only registers as operands. Spilling a pseudo on the stack results in an > invalid memory loa

[rl78] pass -mrelax to gas/ld

2013-09-12 Thread DJ Delorie
Committed. * config/rl78/rl78.opt (mrelax): New. * config/rl78/rl78.h (ASM_SPEC): New, pass on -mrelax to gas. * config/rl78/rl78.h (LINK_SPEC): New, pass on -mrelax to ld. Index: config/rl78/rl78.h === --- c

[rl78] stop using asm line separators

2013-09-12 Thread DJ Delorie
The line separator char for gas changed from | to @, so don't use line separators at all to be most compatible. Committed. * config/rl78/rl78-virt.md: Change from | to \; for asm line separators. Index: config/rl78/rl78-virt.md ===

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-12 Thread Brooks Moses
On Thu, Sep 12, 2013 at 11:19 AM, DJ Delorie wrote: > The patch is OK with me from a build machinery point of view. Thanks, DJ. Based on that and Joseph's comments elsewhere that removing these binaries is the right thing to do, I've committed the patch. At Ian Taylor's suggestion, I also confi

Re: [Patch] Support assertions and greedy/ungreedy matching in regex

2013-09-12 Thread Tim Shen
On Thu, Sep 12, 2013 at 9:57 AM, Paolo Carlini wrote: > Great. A quick-quick comment: if these are the last two features, why we > can't un-xfail the testcase which we added latety? Also, a grep revealed a > couple more xfails. Can you clarify? I say `feature` when I think that, what these xfails

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-12 Thread Paul Pluzhnikov
On Wed, Sep 4, 2013 at 9:55 PM, Daniel Krügler wrote: >> Did you mean "pessimises code size", or something else? > > Yes. Daniel's idea proved a good one, and I now have a patch that I am happy with, and that will be easy to extend to string::at(), and other __throw_... functions. I've added th

Re: [Patch] Support assertions and greedy/ungreedy matching in regex

2013-09-12 Thread Jakub Jelinek
On Thu, Sep 12, 2013 at 11:51:57AM -0400, Tim Shen wrote: > On Thu, Sep 12, 2013 at 11:37 AM, Paolo Carlini > wrote: > > .. please fix the overlong lines, I spotted quite a few. > > Quite a few? I see only one line by casting: > egrep '^\+.{80}' a.patch > > Even it's not 81. That is not the rig

Re: expand_expr tweaks to fix PR57134

2013-09-12 Thread Alan Modra
This is a followup to http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00837.html which is still lacking an OK. Apologies for dropping this patch on the floor. PR middle-end/57586 * stmt.c (expand_asm_operands): Call expand_expr with EXPAND_MEMORY for output operands that disa

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-12 Thread Kugan
Here is the modified patch that addresses the comments form Richard and Jakub. This also includes: 1. Added TDF_RANGE to dump range_info 2. Moved enum value_range_type to tree.h (Is this the right place?) Bootstrapped and regtested for x86_64-unknown-linux-gnu and arm-none linux-gnueabi. I

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Teresa Johnson
On Thu, Sep 12, 2013 at 2:32 PM, Xinliang David Li wrote: > When absolute path is specified for the object file, no prefix will be > prepended to the gcda path. If you record the cwd as in the > _gcov_profile_prefix variable, at profile dump time, the prefix will > be wrong -- as it is never used.

[arm-embedded] merged with FSF 4.7 branch until revision 202551

2013-09-12 Thread Terry Guo
Hello, The arm/embedded-4_7-branch is just synced with FSF 4.7 branch. Lots of bug fixes are included now. BR, Terry

Re: [PATCH, committed] Support lambda templates.

2013-09-12 Thread Adam Butcher
On 12.09.2013 23:44, Andrew MacLeod wrote: On 09/12/2013 06:41 PM, Andrew MacLeod wrote: On 09/12/2013 05:55 PM, Tobias Burnus wrote: Adam Butcher wrote: From: abutcher * lambda.c (lambda_function): Return template result if call operator is a template. I believe that that patch c

[PATCH, committed] Fix uninitialized variables causing breakage with -Werror.

2013-09-12 Thread Adam Butcher
From: abutcher * lambda.c (maybe_add_lambda_conv_op): Initialize direct_argvec and call to nullptr to avoid breakage with -Werror. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@202554 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/cp/ChangeLog | 5 + gcc/cp/lambda.c | 4 ++

Re: [PATCH, committed] Support lambda templates.

2013-09-12 Thread Adam Butcher
On 13.09.2013 07:17, Adam Butcher wrote: On 12.09.2013 23:44, Andrew MacLeod wrote: On 09/12/2013 06:41 PM, Andrew MacLeod wrote: On 09/12/2013 05:55 PM, Tobias Burnus wrote: Adam Butcher wrote: From: abutcher * lambda.c (lambda_function): Return template result if call operator is

[patch libstdc++]: Enable use of 'long long' for mingw targets

2013-09-12 Thread Kai Tietz
Hello, this patch enables the 'long long' use in libstdc++ for Windows native targets. ChangeLog 2013-09-13 Kai Tietz * config/os/mingw32/os_defines.h (_GLIBCXX_USE_LONG_LONG): Enable feature. * config/os/mingw-w64/os_defines.h (_GLIBCXX_USE_LONG_LONG): Likewise. Tested for

Re: [PING] Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-09-12 Thread Nathan Sidwell
On 09/02/13 13:23, Sebastian Huber wrote: what is the blocking point for GCC integration? It was accepted by the SC and all issues of the last review have been addressed (at least this is my impression). Is it that none of the persons with global write permission seems to be responsible? Tha