Re: [patch][i386] Remove some dead code (TARGET_BRANCH_PREDICTION_HINTS)

2012-07-10 Thread Steven Bosscher
On Tue, Jul 10, 2012 at 8:56 AM, Uros Bizjak wrote: > Hello! > >> TARGET_BRANCH_PREDICTION_HINTS isn't used at all. This patch removes it. >> Bootstrapped&tested (incl. -m32) on x86_64-unknown-linux-gnu. OK for trunk? > > This infrastructure can be used for future targets, so let's leave it as is.

Re: [patch] Add a lexical block only when the callsite has source location info

2012-07-10 Thread Dehao Chen
On Tue, Jul 10, 2012 at 1:57 PM, Xinliang David Li wrote: > Is this related to the problem described in > http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01511.html ? This does not sounds related to me. This patch only fix the block info for phi_arg_t. The following patch is related to function spl

[SH] PR 53911 - Remove SImode displacement addressing related splits

2012-07-10 Thread Oleg Endo
Hello, The attached patch removes two splits that undo displacement address re-basing. I've noticed that removing the two splits seems to result in overall slightly smaller code according to the CSiBE set (compared with -m4-single -ml -O2 -mpretend-cmove, -1048 bytes in total), despite some code

[PATCH 0/7] Clean up widen mult even/odd

2012-07-10 Thread Richard Henderson
I find it instructive that 4 of the 5 isas that actually implement widening integer multiplication do have mult-widen-even as the isa primitive (even if the -odd variant is missing). The fact that this operation is implemented as a set of builtins and target hooks has lead to disturbingly cookie-c

[PATCH 2/7] i386: Rename patterns for vec_widen_mult_even/odd_

2012-07-10 Thread Richard Henderson
* config/i386/sse.md (vec_widen_umult_even_v8si): Rename from avx2_umulv4siv4di3. (vec_widen_umult_even_v4si): Rename from sse2_umulv2siv2di3. (vec_widen_smult_even_v8si): Rename from avx2_mulv4siv4di3. (mulv4si3): Remove XOP test shadowed by SSE4 test.

[PATCH 1/7] Add VEC_WIDEN_MULT_EVEN/ODD_EXPR

2012-07-10 Thread Richard Henderson
* tree.def (VEC_WIDEN_MULT_EVEN_EXPR, VEC_WIDEN_MULT_ODD_EXPR): New. * cfgexpand.c (expand_debug_expr): Handle them. * expr.c (expand_expr_real_2): Likewise. * fold-const.c (fold_binary_loc): Likewise. * gimple-pretty-print.c (dump_binary_rhs): Likewise.

[PATCH 3/7] rs6000: Rename patterns for vec_widen_mult_even/odd_

2012-07-10 Thread Richard Henderson
* config/rs6000/altivec.md (vec_widen_umult_even_v16qi): Rename from altivec_vmuleub. (vec_widen_smult_even_v16qi): Rename from altivec_vmulesb. (vec_widen_umult_even_v8hi): Rename from altivec_vmuleuh. (vec_widen_smult_even_v8hi): Rename from altivec_vmulesh

[PATCH 4/7] spu: Rename patterns for vec_widen_mult_even/odd_

2012-07-10 Thread Richard Henderson
* config/spu/spu-builtins.md (spu_mpy): Move to spu.md. (spu_mpyu, spu_mpyhhu, spu_mpyhh): Likewise. * config/spu/spu.md (vec_widen_smult_odd_v8hi): Rename from spu_mpy. (vec_widen_umult_odd_v8hi): Rename from spu_mpyu. (vec_widen_smult_even_v8hi): Rename fro

[PATCH 6/7] Use VEC_WIDEN_MULT_EVEN/ODD_EXPR in supportable_widening_operation

2012-07-10 Thread Richard Henderson
* tree-vect-stmts.c (supportable_widening_operation): Expand WIDEN_MULT_EXPR via VEC_WIDEN_MULT_EVEN/ODD_EXPR if possible. --- gcc/ChangeLog |3 ++ gcc/tree-vect-stmts.c | 96 + 2 files changed, 53 insertions(+), 46 dele

[PATCH 7/7] Zap now unused builtin_mul_widen_even/odd target hooks

2012-07-10 Thread Richard Henderson
* target.def (builtin_mul_widen_even, builtin_mul_widen_odd): Remove. * system.h (TARGET_VECTORIZE_BUILTIN_MUL_WIDEN_EVEN): Poison. (TARGET_VECTORIZE_BUILTIN_MUL_WIDEN_ODD): Poison. * config/i386/i386.c (IX86_BUILTIN_VEC_WIDEN_SMUL_ODD_V4SI): Remove. (IX86_BU

[PATCH 5/7] Move vector highpart emulation to the optabs layer

2012-07-10 Thread Richard Henderson
* expmed.c (expmed_mult_highpart): Rename from expand_mult_highpart. (expmed_mult_highpart_optab): Rename from expand_mult_highpart_optab. * optabs.c (can_mult_highpart_p): New. (expand_mult_highpart): New. * expr.c (expand_expr_real_2) [MULT_HIGHPART_EXPR):

Re: [patch][i386] Remove some dead code (TARGET_BRANCH_PREDICTION_HINTS)

2012-07-10 Thread Uros Bizjak
On Tue, Jul 10, 2012 at 9:04 AM, Steven Bosscher wrote: >>> TARGET_BRANCH_PREDICTION_HINTS isn't used at all. This patch removes it. >>> Bootstrapped&tested (incl. -m32) on x86_64-unknown-linux-gnu. OK for trunk? >> >> This infrastructure can be used for future targets, so let's leave it as is. >

Re: [PATCH 0/7] Clean up widen mult even/odd

2012-07-10 Thread Richard Guenther
On Tue, Jul 10, 2012 at 10:22 AM, Richard Henderson wrote: > I find it instructive that 4 of the 5 isas that actually implement > widening integer multiplication do have mult-widen-even as the isa > primitive (even if the -odd variant is missing). The fact that this > operation is implemented as

Re: [PATCH 0/7] Clean up widen mult even/odd

2012-07-10 Thread Jakub Jelinek
On Tue, Jul 10, 2012 at 10:22:44AM +0200, Richard Henderson wrote: > I've not touched the interface to supportable_widening_operation, > which is still prepared to return a CALL_EXPR and some decls. After > this patch set it will never do so. I'm undecided as to whether we > ought to be prepared

Re: [patch][i386] Remove some dead code (TARGET_BRANCH_PREDICTION_HINTS)

2012-07-10 Thread H.J. Lu
On Tue, Jul 10, 2012 at 1:57 AM, Uros Bizjak wrote: > On Tue, Jul 10, 2012 at 9:04 AM, Steven Bosscher > wrote: TARGET_BRANCH_PREDICTION_HINTS isn't used at all. This patch removes it. Bootstrapped&tested (incl. -m32) on x86_64-unknown-linux-gnu. OK for trunk? >>> >>> This infrastructu

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-07-10 Thread Jason Merrill
On 07/09/2012 11:27 PM, Xinliang David Li wrote: Ok. Do you have specific comments on the patch? My comment is "Perhaps we want to implement this using a more generic mechanism." I was thinking to defer a detailed code review until that question is settled. Jason

PR bootstrap/53913

2012-07-10 Thread Andreas Schwab
To avoid having to include tree.h in resource.c move the body of EPILOGUE_USES to m68k.c. Tested on m68k-linux. Andreas. PR bootstrap/53913 * config/m68k/m68k.c (m68k_epilogue_uses): New. * config/m68k/m68k.h (EPILOGUE_USES): Use it. * config/m68k/m68k-protos.h (m

Re: [wwwdocs] Update coding conventions for C++

2012-07-10 Thread Jason Merrill
On 07/09/2012 06:00 PM, Lawrence Crowl wrote: Done. New patch attached, but note that the tags have been stripped from the patch to avoid mailer problems. Thanks. If nobody else has any comments, I think this is good to go. Jason

[Patch, ARM] Fix PR53859: ICE on armv7e-m

2012-07-10 Thread Greta Yorsh
New RTL patterns generated for epilogues with RETURN (trunk r188742) are not recognized by the pattern matching code in arm_early_load_addr_dep, which is used for insn latency calculation when tuning for cortex-m4. It causes an ICE when tuning for armv7e-m or cortex-m4: http://gcc.gnu.org/bugzilla/

[patch] fixes for power4 scheduler description

2012-07-10 Thread Steven Bosscher
Hello, These look like typos: * "power4-store-update" wants "iuX,iuY" for X=1|2 and Y=1|2. The "iu2,iu1" case appeared twice. * "power4-three" wants "iuX,iuX,iuY|iuX,iuY,iuY" for X=1|2 and Y=1|2. The "iu1,iu1,iu2" case appeared twice. Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for tr

Re: [wwwdocs] Update coding conventions for C++

2012-07-10 Thread Gabriel Dos Reis
Jason Merrill writes: | On 07/09/2012 06:00 PM, Lawrence Crowl wrote: | > Done. New patch attached, but note that the tags have been | > stripped from the patch to avoid mailer problems. | | Thanks. If nobody else has any comments, I think this is good to go. Great! -- Gaby

Re: [C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-07-10 Thread Dominique Dhumieres
Hi Sterling, On x86_64-apple-darwin10 the test fails with FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler .section\t.debug_pubnames FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler "_GLOBAL__sub_I__ZN3one3c1vE0"+[ \t]+[#;]+[ \t]+external name FAIL: g++.dg/debug/dwarf2/pubnames-2.C

[PATCH] [LM32] Fix lm32-elf-gcc build error by remove unnecessary constant legitimate check.

2012-07-10 Thread Jia Liu
Hi all, When I build lm32-elf-gcc, it failed at libgcc configure due to lm32-elf-cc1 segment fault when compile conftest.c: void bar (); void clean (int *); void foo () { int i __attribute__ ((cleanup (clean))); bar(); } Then I find lm32_legitimate_constant_p return false too much times, it

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-07-10 Thread Xinliang David Li
On Tue, Jul 10, 2012 at 2:46 AM, Jason Merrill wrote: > On 07/09/2012 11:27 PM, Xinliang David Li wrote: >> >> Ok. Do you have specific comments on the patch? > > > My comment is "Perhaps we want to implement this using a more generic > mechanism." I was thinking to defer a detailed code review

Re: [C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-07-10 Thread Sterling Augustine
On Tue, Jul 10, 2012 at 6:51 AM, Dominique Dhumieres wrote: > Hi Sterling, > > On x86_64-apple-darwin10 the test fails with > > FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler > .section\t.debug_pubnames > FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler > "_GLOBAL__sub_I__ZN3one3c1vE

Re: G++ namespace association extension

2012-07-10 Thread Jonathan Wakely
On 9 July 2012 14:18, Jason Merrill wrote: > On 07/09/2012 01:26 PM, Jonathan Wakely wrote: >> >> http://gcc.gnu.org/onlinedocs/gcc/Namespace-Association.html says: >> >> "Caution: The semantics of this extension are not fully defined. Users >> should refrain from using this extension as its semant

Re: [SH] PR 53911 - Remove SImode displacement addressing related splits

2012-07-10 Thread Kaz Kojima
Oleg Endo wrote: > The attached patch removes two splits that undo displacement address > re-basing. I've noticed that removing the two splits seems to result in > overall slightly smaller code according to the CSiBE set (compared with > -m4-single -ml -O2 -mpretend-cmove, -1048 bytes in total),

Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin

2012-07-10 Thread Iain Sandoe
Hi Steven, On 9 Jul 2012, at 09:21, Iain Sandoe wrote: > On 9 Jul 2012, at 09:11, Iain Sandoe wrote: >>> crt3.o: $(srcdir)/config/darwin-crt3.c > >> regstrapped (all+ada+objc++) on i686-darwin9 with no regressions. > > .. but, now I re-check, crt3 is only used on Darwin 8 and earlier; > That wi

Re: G++ namespace association extension

2012-07-10 Thread Jason Merrill
OK. Jason

[gimplefe] Construction of individual gimple statements for gimple_cond and gimple_label

2012-07-10 Thread Sandeep Soni
The patch adds support for creating individual gimple statements for the gimple_cond and gimple_label statements. Diego, I need your help in generalizing to include all possible cases of these statements. Here is the ChangeLog 2012-07-10 Sandeep Soni * parser.c (gp_parse_expect_op1):

Re: [gimplefe] Fixing the bug for gimple_assign statement with ternary operands

2012-07-10 Thread Sandeep Soni
On Fri, Jul 6, 2012 at 7:26 PM, Diego Novillo wrote: > On 12-07-06 00:38 , Sandeep Soni wrote: > >> I am halfway through the patch for building gimple_cond statements. I >> will be able to complete the patch over the weekend. I am also working >> towards a patch that generalizes the assignment sta

[PATCH] Fix breakage for m68k-linux introduced by 4a020a8 / r189359

2012-07-10 Thread Jan-Benedict Glaw
Hi! Git revision 4a020a8 [aka. SVN 189359], the large header reordering patch, broke m68k-linux (.../configure --target=m68k-linux --prefix=... --enable-languages=c --disable-threads) for me: [...] gcc -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -W -Wall -Wno-narrowing -Wwrite-strings -Wca

Re: [PATCH] Fix breakage for m68k-linux introduced by 4a020a8 / r189359

2012-07-10 Thread Steven Bosscher
On Wed, Jul 11, 2012 at 7:49 AM, Jan-Benedict Glaw wrote: > Hi! > > Git revision 4a020a8 [aka. SVN 189359], the large header reordering patch, > broke m68k-linux (.../configure --target=m68k-linux --prefix=... > --enable-languages=c --disable-threads) for me: > > [...] > gcc -c -g -O2 -DIN_GCC -