Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-07 Thread Simon Baldwin
On 4 March 2011 22:50, Diego Novillo wrote: > ... > I forgot to add.  Simon, this still shows up some failures in > google/integration, but these failures are the same we have in trunk. > > For our builds, we have been XFAILing these failures, right?  Do you > want me to mark them XFAIL to avoid p

[libgo] Use _nuname on 32-bit Solaris 2/x86

2011-03-07 Thread Rainer Orth
The libgo os test used to fail on 32-bit Solaris 2/x86 only: --- FAIL: os_test.TestHostname Hostname() = "", want "fuego" Running the test under gdb, I find that syscall.Uname is entered with errno = 4 and left the same, even if I reset errno = ENONE on entry. Further investigation led to

[libgo] Omit /bin in os_test.go

2011-03-07 Thread Rainer Orth
/bin is a directory on Solaris 2, which causes the libgo os test to fail: FAIL: os --- FAIL: os_test.TestChdirAndGetwd Getwd returned "/usr/bin" want "/bin" This patch fixes this by simply removing /bin. One could probably replace it by /sbin instead, which is a directory on every Unix I

[libgo] Don't check gopher, http ports

2011-03-07 Thread Rainer Orth
The gopher (sort of understandable) and http (unexpected and strange) ports are missing form Solaris 2 /etc/services as far back as Solaris 8, which causes the libgo net test to fail: --- FAIL: net.TestLookupPort LookupPort("tcp", "gopher") = 0, unknown port tcp/gopher; want 70 Loo

[MELT] Fixing compilation issues

2011-03-07 Thread Alexandre Lissy
Hello, Sorry for the delay, but I had no time to perform this small change while attending ROADEF 2011 :). So, here we go, same patches again, with ChangeLog.MELT updated.

[PATCH 1/4] Fix RPM compilation

2011-03-07 Thread Alexandre Lissy
The GCC's options -pipe and -Wp,-D_FORTIFY_SOURCE=2 are passed by default by Mandriva's GCC RPM spec file, and end up in some parts of MELT CFLAGS. But they should not end up there. --- gcc/Makefile.in |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gcc/Makefile.in b/

[PATCH 4/4] Updating MELT ChangeLog

2011-03-07 Thread Alexandre Lissy
--- ChangeLog.MELT |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ChangeLog.MELT b/ChangeLog.MELT index b18e8ff..0e52116 100644 --- a/ChangeLog.MELT +++ b/ChangeLog.MELT @@ -1,3 +1,7 @@ +2011-03-07 Alexandre Lissy + + * Fixing issues in compilation process for R

[PATCH 2/4] Fix double '/' in MELT build process

2011-03-07 Thread Alexandre Lissy
Double slashes while building are a problem for RPM's debugedit tool, which seems to be 'well-known', while never fixed. The only solution is to fix the build process. Also, remove any trailing slash from MELTMODULE_SRCDIR variable, since slashes are added when used. --- gcc/melt-build.tpl |8

[PATCH 3/4] Regenerating melt-build.mk

2011-03-07 Thread Alexandre Lissy
--- gcc/melt-build.mk | 128 ++-- 1 files changed, 64 insertions(+), 64 deletions(-) diff --git a/gcc/melt-build.mk b/gcc/melt-build.mk index f00e43b..e75229e 100644 --- a/gcc/melt-build.mk +++ b/gcc/melt-build.mk @@ -164,7 +164,7 @@ melt-stage0-st

[STORMY16] Hookize PRINT_OPERAND and TARGET_PRINT_OPERAND_ADDRESS

2011-03-07 Thread Anatoly Sokolov
Hi. This patch removes obsolete PRINT_OPERAND and PRINT_OPERAND_ADDRESS macros from the STORMY16 back end in the GCC and introduces equivalent TARGET_PRINT_OPERAND and TARGET_PRINT_OPERAND_ADDRESS target hooks. Regression tested on xstormy16-unknown-elf. OK to install? * config/

Ping Re: [PATCH, ARM] Fix PR 43872, incorrectly aligned VLAs

2011-03-07 Thread Chung-Lin Tang
Ping. On 2011/2/17 06:01 PM, Chung-Lin Tang wrote: > Hi, > this PR is a case where we have a leaf function with a zero-size frame, > that calls alloca() (here through a C99 VLA). > > The ARM backend recognizes the leaf-and-no-frame opportunity to save an > unneeded stack alignment. But when calli

Ping Re: [patch, ARM] ICE in get_arm_condition_code()

2011-03-07 Thread Chung-Lin Tang
Ping. On 2011/1/26 11:09 AM, Chung-Lin Tang wrote: > Ping. > (I'll fix the minor nits before actually committing, thanks Ramana :) > > On 2011/1/13 08:24, Chung-Lin Tang wrote: >> Hi, >> there's an ICE in arm.c:get_arm_condition_code(), from here: >> https://bugs.launchpad.net/gcc-linaro/+bug/689

Ping Re: [PATCH, ARM] Fix PR44557, Thumb-1 ICE

2011-03-07 Thread Chung-Lin Tang
Ping. On 2011/1/26 11:07 AM, Chung-Lin Tang wrote: > On 2011/1/1 19:21, Chung-Lin Tang wrote: >> On 2010/12/21 02:03, Richard Earnshaw wrote: >>> >>> On Thu, 2010-12-09 at 14:08 +0800, Chung-Lin Tang wrote: Hi, this patch fixes the ICE in PR44557. It now occurs on trunk only under

[MIPS] Hookize PREFERRED_RELOAD_CLASS

2011-03-07 Thread Anatoly Sokolov
Hi. This patch removes obsolete PREFERRED_RELOAD_CLASS macro from the MIPS back end in the GCC and introduces equivalent TARGET_PREFERRED_RELOAD_CLASS target hook. Bootstrapped and regression tested on mips64el-unknown-linux-gnu. * config/mips/mips.h (PREFERRED_RELOAD_CLASS): Rem

Re: [PATCH] PR45413 - require nonpic target

2011-03-07 Thread Dominique Dhumieres
Would it be possible to have this patch commited before 4.6 is released? TIA Dominique

Re: [PATCH 4/4] Updating MELT ChangeLog

2011-03-07 Thread Basile Starynkevitch
On Mon, 7 Mar 2011 12:35:24 +0100 Alexandre Lissy wrote: > --- > ChangeLog.MELT |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/ChangeLog.MELT b/ChangeLog.MELT > index b18e8ff..0e52116 100644 > --- a/ChangeLog.MELT > +++ b/ChangeLog.MELT > @@ -1,3 +1,7 @@ > +20

Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-07 Thread Diego Novillo
On Fri, Mar 4, 2011 at 20:07, Mike Stump wrote: >> -     @echo "set GCC_UNDER_TEST \"$(GCC_FOR_TARGET)\"" >> ./tmp0 > > ?  What's this?  GCC_UNDER_TEST is kinda important to testing.  I feel like > I'm missing something trivial. This is an artifact of the branch. We used to force GCC_UNDER_TES

Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-07 Thread Diego Novillo
On Mon, Mar 7, 2011 at 05:44, Simon Baldwin wrote: > On 4 March 2011 22:50, Diego Novillo wrote: >> ... >> I forgot to add.  Simon, this still shows up some failures in >> google/integration, but these failures are the same we have in trunk. >> >> For our builds, we have been XFAILing these failu

[gomp3.1] Handle list form of OMP_NUM_THREADS

2011-03-07 Thread Jakub Jelinek
Hi! While the standard talks about list form of nthreads-var everywhere, given that omp_set_num_threads only affects the first element of the list, only the first element is also used everywhere but during parallel creation of new implicit tasks, I think this patch is equivalent to it. Regtested

Re: [PATCH] fix PR 47786, DECL_CHAIN fallout with -flto

2011-03-07 Thread Nathan Froyd
On Wed, Feb 23, 2011 at 11:14:08AM -0800, Nathan Froyd wrote: > The patch below fixes PR 47786, a bit of DECL_CHAIN fallout. The patch > is trivial, even obvious, since it replaces the custom loop with > list_length. > > The only problem is adding a testcase. I can't add the existing > testcase

Re: [PATCH] PR 47862: Fix caller-save vector spill on PowerPC

2011-03-07 Thread David Edelsohn
On Fri, Mar 4, 2011 at 1:06 PM, Pat Haugen wrote: > Fix subject PR by defining HARD_REGNO_CALLER_SAVE_MODE to return V2DFmode > for vectors in FP regs. > > Bootstrap/regtest on powerpc with no new failures. Ok for trunk and 4.5 > (after successful 4.5 bootstrap/regtest)? > > -Pat > > > 2011-03-04

[committed] Fix profiledbootstrap on x86_64-linux (PR bootstrap/48000)

2011-03-07 Thread Jakub Jelinek
Hi! I've bootstrapped/regtested and profiledbootstrapped/regtested the following patch from Zdenek on x86_64-linux and i686-linux and with richi's approval from IRC committed to trunk. 2011-03-07 Zdenek Dvorak PR bootstrap/48000 * cfgloopmanip.c (fix_bb_placements): Return imm

[GOMP 3.1] Update gcc/fortran/{gfortran,intrinsic}.texi for OpenMP 3.1

2011-03-07 Thread Tobias Burnus
The attached patch removes the deleted constants omp_integer_kind and omp_logical_kind from the manual and updates the references to the OpenMP 3.1 spec. Committed to the gomp-3_1-branch as Rev. 170742. Tobias 2011-03-07 Tobias Burnus * gfortran.texi (OpenMP): Update ref to OpenMP 3.1. *

Re: [STORMY16] Hookize PRINT_OPERAND and TARGET_PRINT_OPERAND_ADDRESS

2011-03-07 Thread Nick Clifton
Hi Anatoly, * config/stormy16/stormy16.h (PRINT_OPERAND, PRINT_OPERAND_ADDRESS): Remove. * config/stormy16/stormy16-protos.h (xstormy16_print_operand, xstormy16_print_operand_address): Remove. * config/stormy16/stormy16.c (xstormy16_print_operand,

Re: [PATCH] Teach var-tracking about some targets setmem/movmem patterns (PR debug/47991)

2011-03-07 Thread Alexandre Oliva
On Mar 4, 2011, Jakub Jelinek wrote: > PR debug/47991 > * var-tracking.c (find_use_val): Return NULL for > cui-> sets && cui->store_p BLKmode MEMs. > * gcc.dg/pr47991.c: New test. This looks good to me, but I can't approve it. -- Alexandre Oliva, freedom fighterht

Re: [PATCH] PR45413 - require nonpic target

2011-03-07 Thread Mike Stump
On Mar 7, 2011, at 6:41 AM, Dominique Dhumieres wrote: > Would it be possible to have this patch commited before 4.6 is > released? I checked it in. Give it a try, and if it doesn't work as expected ,let me know asap. :-)

RE: [PING^2] [PR46003, C++] Fix the assertion failure in build_target_expr

2011-03-07 Thread Yufeng Zhang
> On 03/03/2011 11:39 PM, Jason Merrill wrote: > I think rather that the problem is in build_conditional_expr; it > should have a template case that just determines the appropriate > type and then builds up a COND_EXPR with that type from the > unconverted operands, like we do for calls in finish_

[PATCH] Don't warn with -Wstrict-overflow about X + C1 == C2 transformations (PR tree-optimization/48022)

2011-03-07 Thread Jakub Jelinek
Hi! EQ/NE comparisons don't really assume that overflow doesn't happen unlike >/>=/etc., so it is strange that we warn about it. As the warning happens on simple strcmp uses when using glibc string.h, it is extra annoying. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok fo

Re: [patch testsuite g++.dg]: Adjust tree-ssa/pr21082 testcase for LLP64

2011-03-07 Thread Kai Tietz
PING 2011/2/23 Kai Tietz : > Hi, > > ChangeLog > > 2011-02-23  Kai Tietz > >        * g++.dg/tree-ssa/pr21082.C: Use __INTPTR_TYPE__ instead of 'long' > type. > > Ok for apply? > > Regards, > Kai > -- |  (\_/) This is Bunny. Copy and paste | (='.'=) Bunny into your signature to help | (")_(")

Re: avoid useless if-before-free tests

2011-03-07 Thread Dr Andrew John Hughes
On 19:16 Sat 05 Mar , Joseph S. Myers wrote: > On Sat, 5 Mar 2011, Jim Meyering wrote: > > > diff --git a/gcc/config/i386/gmm_malloc.h b/gcc/config/i386/gmm_malloc.h > > index 7a7e840..8993fc7 100644 > > --- a/gcc/config/i386/gmm_malloc.h > > +++ b/gcc/config/i386/gmm_malloc.h > > @@ -67,8 +67

Re: PR 47793 - Support relative paths using -fprofile-generate

2011-03-07 Thread Diego Novillo
On Tue, Mar 1, 2011 at 17:07, Martin Thuresson wrote: > Ping. > > On Wed, Feb 23, 2011 at 3:37 PM, Martin Thuresson wrote: >> On Wed, Feb 23, 2011 at 10:21 AM, Martin Thuresson >> wrote: >>> Change 165596 and 168475 updated the code for handling gcda-paths. As >>> part of this change, relative

C++ PATCH for c++/48008 (mangling clash with -fabi-version=5)

2011-03-07 Thread Jason Merrill
My patch from last July to avoid mangling attribute const/volatile as qualifiers on the type had the unfortunate effect of also omitting const/volatile function-cv-quals on plain function types, which can occur as template arguments. This patch fixes that by stripping the attribute-derived qua

[PATCH] PR c++/47957

2011-03-07 Thread Dodji Seketeli
Hello, In the example of the patch below, the lookup of symbol 'T' yields the template parameter instead of the typedef Base::T. That's because outer_binding considers the template-parameters-scope bindings from Derived::foo even though that template doesn't have it's own template header. outer_

Go patch committed: Handle predeclared names as field names in literals

2011-03-07 Thread Ian Lance Taylor
This patch to the Go frontend fixes the case where a struct composite literal uses a field name which happens to be a predeclared name. The problem was that predeclared names aren't packed as hidden names, because the package name is not known when they are declared. The field names in structs ar

Go patch committed: Fix import _ used twice in one package

2011-03-07 Thread Ian Lance Taylor
This patch to the Go frontend fixes the case where a package is imported twice, by two different source files, and the second import uses _ as the local name. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r f3dfe292768b go/gogo.cc --- a/go/gogo.

Go patch committed: Support multiple init functions in a single file

2011-03-07 Thread Ian Lance Taylor
This patch to the Go frontend fixes the case of having multiple init functions in a single file. The earlier code, removed in this patch, handled multiple init functions in a single package, but not in a single file. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to main

libgcc patch committed: Accounts for all regs in __splitstack_find

2011-03-07 Thread Ian Lance Taylor
The function __splitstack_find is used by the Go garbage collector to find all stacks used by all threads. The goal was to find all pointers on the stack. Unfortunately, it turned out to miss some saved registers in some cases, because they were saved on the split stack below the location where t

Go patch committed: Avoid race condition shutting down thread

2011-03-07 Thread Ian Lance Taylor
I spotted a theoretical race condition when shutting down a thread. If a garbage collection occurs at the very end of existing the thread, the garbage collector and the thread could collide on manipulating the heap. This patch fixes the problem by moving the thread exiting manipulations within the

Re: [PATCH] Teach var-tracking about some targets setmem/movmem patterns (PR debug/47991)

2011-03-07 Thread Richard Henderson
On 03/05/2011 07:56 AM, Jakub Jelinek wrote: > PR debug/47991 > * var-tracking.c (find_use_val): Return NULL for > cui->sets && cui->store_p BLKmode MEMs. > > * gcc.dg/pr47991.c: New test. Ok. > + /* Some targets represent memset and memcpy patterns > + by

libgo patch committed: Permit GC on any compiler generated allocation

2011-03-07 Thread Ian Lance Taylor
Due to an oversight, libgo did not permit garbage collection to occur on any compiler generated memory allocation. It would only occur on memory allocation in the runtime library, or when allocating memory which was known to not hold pointers. This libgo patch fixes that oversight. Bootstrapped

Re: [libgo] Use _nuname on 32-bit Solaris 2/x86

2011-03-07 Thread Ian Lance Taylor
Rainer Orth writes: > The libgo os test used to fail on 32-bit Solaris 2/x86 only: > > --- FAIL: os_test.TestHostname >Hostname() = "", want "fuego" > > Running the test under gdb, I find that syscall.Uname is entered with > errno = 4 and left the same, even if I reset errno = ENONE on en

Re: avoid useless if-before-free tests

2011-03-07 Thread Joseph S. Myers
On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: > > http://gcc.gnu.org/codingconventions.html says Classpath changes should go > > via Classpath upstream, not directly into GCC. I don't know if that's > > still accurate. > > > > That's still true. This seems to be the first message I've rec

Re: avoid useless if-before-free tests

2011-03-07 Thread Paolo Carlini
On 03/05/2011 03:05 PM, Jim Meyering wrote: > diff --git a/libstdc++-v3/libsupc++/del_opnt.cc > b/libstdc++-v3/libsupc++/del_opnt.cc > index 75051d5..29eab10 100644 > --- a/libstdc++-v3/libsupc++/del_opnt.cc > +++ b/libstdc++-v3/libsupc++/del_opnt.cc > @@ -31,6 +31,5 @@ extern "C" void free (void

Re: [libgo] Omit /bin in os_test.go

2011-03-07 Thread Ian Lance Taylor
Rainer Orth writes: > /bin is a directory on Solaris 2, which causes the libgo os test to > fail: > > FAIL: os > --- FAIL: os_test.TestChdirAndGetwd > Getwd returned "/usr/bin" want "/bin" > > This patch fixes this by simply removing /bin. One could probably > replace it by /sbin instead,

Re: [libgo] Don't check gopher, http ports

2011-03-07 Thread Ian Lance Taylor
Rainer Orth writes: > The gopher (sort of understandable) and http (unexpected and strange) > ports are missing form Solaris 2 /etc/services as far back as Solaris 8, > which causes the libgo net test to fail: > > --- FAIL: net.TestLookupPort > LookupPort("tcp", "gopher") = 0, unknown port

[v3] libstdc++/47145

2011-03-07 Thread Benjamin Kosnik
Conditionally set XSL_STYLE_DIR at configure time for either debian or fedora/RHEL based systems. As discussed in bugzilla. For convenience, this patch steps around the STYLESHEET_FLAG question by just punting to the net for validation only. STYLESHEET_FLAG is only used in the validation makefil

[trans-mem] PR 47952 Re: weak aliases, .tm_clone_table, and binutils confusion

2011-03-07 Thread Richard Henderson
On 03/06/2011 10:54 PM, Patrick Marlier wrote: > >> On 03/04/11 13:07, Patrick Marlier wrote: >>> I think this line: >>> >>> .section >>> .text._ZGTtNSt14_List_iteratorIN4Game12BuildProjectEEC2EPSt15_List_node_base,"axG",@progbits,_ZNSt14_List_iteratorIN4Game12BuildProjectE >>> >>> EC5EPSt15_List_

Using sysroot in testsuite. Trunk version. (issue4248059)

2011-03-07 Thread Diego Novillo
This is the patch I had in mind for trunk. I made it a little more generic by changing the name of the variable to TEST_ALWAYS_FLAGS and setting it by default to use the value from SYSROOT_CFLAGS_FOR_TARGET. I also added the setting of SYSROOT_CFLAGS_FOR_TARGET to use the value from --with-build

Re: Using sysroot in testsuite. Trunk version. (issue4248059)

2011-03-07 Thread Mike Stump
On Mar 7, 2011, at 5:30 PM, Diego Novillo wrote: > This is the patch I had in mind for trunk. > OK for 4.7? Ok. I'll just note here, that this is necessary for canadian, but not always sufficient. It is monotonically better however. I looked at the Make/configure issues, and they look fine t

[4.7] Avoid global state in v850_handle_option

2011-03-07 Thread Joseph S. Myers
This patch, for 4.7 and relative to a tree with applied, stops the V850 handle_option hook from using global state. The main changes here relate to the small memory options. These were previously handled as options -msda, -mtda, -mzda with

C++ PATCH for c++/48003 (allow integer overflow in template args with -fpermissive)

2011-03-07 Thread Jason Merrill
This patch changes convert_nontype_argument to defer to cxx_constant_value on whether or not to go ahead with a semi-constant template argument, and whether or not to give a diagnostic. Making this change revealed a bug in potential_constant_expression_1, which was failing to check for overflo

Re: PR 47793 - Support relative paths using -fprofile-generate

2011-03-07 Thread Martin Thuresson
On Mon, Mar 7, 2011 at 11:53 AM, Diego Novillo wrote: > On Tue, Mar 1, 2011 at 17:07, Martin Thuresson wrote: >> Ping. >> >> On Wed, Feb 23, 2011 at 3:37 PM, Martin Thuresson wrote: >>> On Wed, Feb 23, 2011 at 10:21 AM, Martin Thuresson >>> wrote: Change 165596 and 168475 updated the code

C++ PATCH for c++/48015 (C++0x ICE with non-constant initializer for const int var in template)

2011-03-07 Thread Jason Merrill
constant_value_1 has been trying to pull out DECL_INITIAL for any variable with the proper type. This can be problematic in templates, where DECL_INITIAL hasn't always been properly folded yet. But since we try to reduce initializers to a constant when we process the declaration, we can just

[PATCH, SMS] Support closing_branch_deps

2011-03-07 Thread Revital1 Eres
Hello, The attached patch includes enhancements for SMS to support targets that their doloop part is not decoupled from the rest of the loop's instructions, as SMS currently requires. (ARM is an example for such target, where the loop's instructions might use CC which is used in the doloop part)