On 09 Feb 2017 21:13, Mark Wielaard wrote:
> +# See if we can add -D_FORTIFY_SOURCE=2. Don't do it if it is already
> +# (differently) defined or if it generates warnings/errors because we
> +# don't use the right optimisation level (string.h will warn about that).
> +AC_MSG_CHECKING([whether to ad
On 22 Feb 2017 13:50, Ulf Hermann wrote:
> Add replacements to libeu.a if they don't exist. Include system.h
> and link against libeu.a where they are used.
these portability replacements are starting to get out of hand
-mike
signature.asc
Description: Digital signature
On 22 Feb 2017 17:01, Ulf Hermann wrote:
> > these portability replacements are starting to get out of hand
>
> To what extent should elfutils be portable to non-GNU systems? My goal here
> is to port it to windows while minimizing the amount of external dependencies
> I have to add. The functio
On 22 Feb 2017 17:45, Ulf Hermann wrote:
> > imo, elfutils shouldn't be growing these fallback implementations itself.
> > if you want to do this stuff, use gnulib instead.
> >
> > then there is no ifdef hell in the source files, and you don't have to
> > worry about testing whether the ifdef's ar
On 22 Feb 2017 18:43, Ulf Hermann wrote:
> > sorry, but i don't know what you're talking about. you don't read the
> > gnulib code/modules directly, you just run gnulib-tool and tell it which
> > modules to import. it does all the rest for you.
> >
> > you want asprintf ? then add it to the lis
On 23 Feb 2017 10:39, Ulf Hermann wrote:
> > basename() is in the dirname module
>
> That's the POSIX variant. We're using the GNU variant everywhere
looking closer, it's not either. POSIX doesn't guarantee that the input
is not modified, while GNU guarantees that it is left alone. the gnulib
o
On 24 Feb 2017 10:42, Ulf Hermann wrote:
> >> and the GNU variant is a whopping two lines of code:
> >>
> >> char *base = strrchr(path, '/');
> >> return base ? base + 1 : (char *)path;
> >
> > and we get straight to an example of why your solutions don't scale.
> > your replacement is wrong. and
